Skip to contentSkip to conversation

Bluetooth: btusb: Fix fall-through warnings

PATCH In review [email protected] 2 participants 2 messages Aug 5, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth: btusb: Fix fall-through warnings

From: "mark-yw.chen" <[email protected]>

Fix fall-through warnings:
drivers/bluetooth/btusb.c: In function ‘btusb_recv_acl_mtk’:
drivers/bluetooth/btusb.c:4033:3: warning:
this statement may fall through [-Wimplicit-fallthrough=]

 4033 |   usb_disable_autosuspend(data->udev);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btusb.c:4034:2: note: here
 4034 |  case 0x05ff:  /* Firmware debug logging 1 */
      |  ^~~~
---
 drivers/bluetooth/btusb.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/bluetooth/btusb.c +2 -0
index a4cee8327295..89ff9182b7e2 100644
@@ -4027,7 +4027,9 @@ static int btusb_recv_acl_mtk(struct hci_dev *hdev, struct sk_buff *skb)
 		 * suspend and thus disable auto-suspend.
 		 */
 		usb_disable_autosuspend(data->udev);
+		fallthrough;
 	case 0x05ff:		/* Firmware debug logging 1 */
+		fallthrough;
 	case 0x05fe:		/* Firmware debug logging 2 */
 		return hci_recv_diag(hdev, skb);
 	}
Signature · 5 lines
2.18.0
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
maintainer
#1 lore raw

Hi Mark,

Quoted 20 lines

Fix fall-through warnings:
drivers/bluetooth/btusb.c: In function ‘btusb_recv_acl_mtk’:
drivers/bluetooth/btusb.c:4033:3: warning:
this statement may fall through [-Wimplicit-fallthrough=]

4033 |   usb_disable_autosuspend(data->udev);
     |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btusb.c:4034:2: note: here
4034 |  case 0x05ff:  /* Firmware debug logging 1 */
     |  ^~~~

---
drivers/bluetooth/btusb.c | 2 ++

1 file changed, 2 insertions(+)
drivers/bluetooth/btusb.c +0 -0
index a4cee8327295..89ff9182b7e2 100644

drivers/bluetooth/btusb.c static int btusb_recv_acl_mtk(struct hci_dev *hdev, struct sk_buff *skb) · line 4032

Quoted 6 lines
drivers/bluetooth/btusb.c +2 -0
@@ -4027,7 +4027,9 @@ static int btusb_recv_acl_mtk(struct hci_dev *hdev, struct sk_buff *skb)
 		 * suspend and thus disable auto-suspend.
 		 */
 		usb_disable_autosuspend(data->udev);
+		fallthrough;
 	case 0x05ff:		/* Firmware debug logging 1 */
+		fallthrough;

this one is not needed.

drivers/bluetooth/btusb.c static int btusb_recv_acl_mtk(struct hci_dev *hdev, struct sk_buff *skb) · line 4035

Quoted 3 lines
drivers/bluetooth/btusb.c +0 -0
 	case 0x05fe:		/* Firmware debug logging 2 */
 		return hci_recv_diag(hdev, skb);
 	}

Regards

Marcel