Skip to contentSkip to conversation

libsepol/cil: remove obsolete comment

PATCH In review Ondrej Mosnacek 2 participants 3 messages Aug 5, 2021 – Aug 10, 2021 SELinux security module

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libsepol/cil: remove obsolete comment

Commit a60343cabfc2 ("libsepol/cil: remove unnecessary hash tables") removed FILENAME_TRANS_TABLE_SIZE macro that this comment was referring to. Remove the comment as well to avoid confusion.

---
 libsepol/cil/src/cil_binary.c | 3 ---
 1 file changed, 3 deletions(-)
libsepol/cil/src/cil_binary.c +0 -3
index 41105c12..2b65c622 100644
@@ -55,9 +55,6 @@
 #include "cil_find.h"
 #include "cil_build_ast.h"
 
-/* There are 44000 filename_trans in current fedora policy. 1.33 times this is the recommended
- * size of a hashtable. The next power of 2 of this is 2 ** 16.
- */
 #define ROLE_TRANS_TABLE_SIZE (1 << 10)
 #define AVRULEX_TABLE_SIZE (1 <<  10)
 #define PERMS_PER_CLASS 32
Signature · 1 line
2.31.1
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Ondrej Mosnacek

Commit a60343cabfc2 ("libsepol/cil: remove unnecessary hash tables") removed FILENAME_TRANS_TABLE_SIZE macro that this comment was referring to. Remove the comment as well to avoid confusion.

Quoted 21 lines
---
 libsepol/cil/src/cil_binary.c | 3 ---
 1 file changed, 3 deletions(-)
libsepol/cil/src/cil_binary.c +0 -4
index 41105c12..2b65c622 100644
@@ -55,9 +55,6 @@
 #include "cil_find.h"
 #include "cil_build_ast.h"
 
-/* There are 44000 filename_trans in current fedora policy. 1.33 times this is the recommended
- * size of a hashtable. The next power of 2 of this is 2 ** 16.
- */
 #define ROLE_TRANS_TABLE_SIZE (1 << 10)
 #define AVRULEX_TABLE_SIZE (1 <<  10)
 #define PERMS_PER_CLASS 32
--

2.31.1

#2 lore raw
Quoted 11 lines · James Carter
Quoted 6 lines · Ondrej Mosnacek

Commit a60343cabfc2 ("libsepol/cil: remove unnecessary hash tables") removed FILENAME_TRANS_TABLE_SIZE macro that this comment was referring to. Remove the comment as well to avoid confusion.

Merged.
Thanks,
Jim

Quoted 21 lines
Quoted 21 lines
---
 libsepol/cil/src/cil_binary.c | 3 ---
 1 file changed, 3 deletions(-)
libsepol/cil/src/cil_binary.c +0 -4
index 41105c12..2b65c622 100644
@@ -55,9 +55,6 @@
 #include "cil_find.h"
 #include "cil_build_ast.h"
 
-/* There are 44000 filename_trans in current fedora policy. 1.33 times this is the recommended
- * size of a hashtable. The next power of 2 of this is 2 ** 16.
- */
 #define ROLE_TRANS_TABLE_SIZE (1 << 10)
 #define AVRULEX_TABLE_SIZE (1 <<  10)
 #define PERMS_PER_CLASS 32
--

2.31.1