stmmac: recycle SKB
Subsystems (4)
cover stmmac: recycle SKB
From: Matteo Croce <[email protected]>
I have two patches to enable SKB recycling in stmmac. Unfortunately the only stmmac hardware I have behave very bad, so I can't do decent performance tests.
Can I get some feedback for this series?
Matteo Croce (2):
stmmac: use build_skb()
stmmac: skb recycling
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
Signature · 1 line
2.31.1
PATCH 1/2 stmmac: use build_skb()
From: Matteo Croce <[email protected]>
Signed-off-by Matteo Croce <[email protected]>
--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +3 -4
@@ -5208,7 +5208,7 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)/* XDP program may expand or reduce tail */ buf1_len = xdp.data_end - xdp.data; - skb =napi_alloc_skb (&ch->rx_napi, buf1_len); + skb =build_skb (xdp.data_hard_start,PAGE_SIZE );if (!skb) { priv->dev->stats.rx_dropped++; count++;
@@ -5216,11 +5216,10 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue) }/* XDP program may adjust header */ -skb_copy_to_linear_data (skb, xdp.data, buf1_len); +skb_reserve (skb, buf->page_offset);skb_put (skb, buf1_len); -/* Data payload copied into SKB, page ready for recycle */ -page_pool_recycle_direct (rx_q->page_pool, buf->page); +page_pool_release_page (rx_q->page_pool, buf->page); buf->page =NULL ; }else if (buf1_len) { dma_sync_single_for_cpu(priv->device, buf->addr,
Signature · 1 line
2.31.1
PATCH 2/2 stmmac: skb recycling
In reply to Matteo CroceFrom: Matteo Croce <[email protected]>
Signed-off-by Matteo Croce <[email protected]>
--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +3 -3
@@ -5219,7 +5219,7 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)skb_reserve (skb, buf->page_offset);skb_put (skb, buf1_len); -page_pool_release_page (rx_q->page_pool, buf->page); +skb_mark_for_recycle (skb, buf->page, rx_q->page_pool); buf->page =NULL ; }else if (buf1_len) { dma_sync_single_for_cpu(priv->device, buf->addr,
@@ -5229,7 +5229,7 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue) priv->dma_buf_sz);/* Data payload appended into SKB */ -page_pool_release_page (rx_q->page_pool, buf->page); +page_pool_store_mem_info (buf->page, rx_q->page_pool); buf->page =NULL ; }
@@ -5241,7 +5241,7 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue) priv->dma_buf_sz);/* Data payload appended into SKB */ -page_pool_release_page (rx_q->page_pool, buf->sec_page); +page_pool_store_mem_info (buf->sec_page, rx_q->page_pool); buf->sec_page =NULL ; }
Signature · 1 line
2.31.1