intersil: remove obsolete prism54 wireless driver
Subsystems (3)
PATCH 1/1 intersil: remove obsolete prism54 wireless driver
Commit 1d89cae1b47d ("MAINTAINERS: mark prism54 obsolete") indicated the prism54 driver as obsolete in July 2010.
Now, after being exposed for ten years to refactoring, general tree-wide changes and various janitor clean-up, it is really time to delete the driver for good.
This was discovered as part of a checkpatch evaluation, investigating all reports of checkpatch's WARNING:OBSOLETE check.
---
Kalle, please pick this non-urgent driver clean-up patch.
MAINTAINERS | 7 - drivers/net/wireless/intersil/Kconfig | 20 - drivers/net/wireless/intersil/Makefile | 1 - .../net/wireless/intersil/prism54/Makefile | 9 - .../net/wireless/intersil/prism54/isl_38xx.c | 245 -- .../net/wireless/intersil/prism54/isl_38xx.h | 158 - .../net/wireless/intersil/prism54/isl_ioctl.c | 2909 ----------------- .../net/wireless/intersil/prism54/isl_ioctl.h | 35 - .../net/wireless/intersil/prism54/isl_oid.h | 492 --- .../wireless/intersil/prism54/islpci_dev.c | 951 ------ .../wireless/intersil/prism54/islpci_dev.h | 204 -- .../wireless/intersil/prism54/islpci_eth.c | 489 --- .../wireless/intersil/prism54/islpci_eth.h | 59 - .../intersil/prism54/islpci_hotplug.c | 316 -- .../wireless/intersil/prism54/islpci_mgt.c | 491 --- .../wireless/intersil/prism54/islpci_mgt.h | 126 - .../net/wireless/intersil/prism54/oid_mgt.c | 889 ----- .../net/wireless/intersil/prism54/oid_mgt.h | 46 - .../wireless/intersil/prism54/prismcompat.h | 30 - 19 files changed, 7477 deletions(-) delete mode 100644 drivers/net/wireless/intersil/prism54/Makefile delete mode 100644 drivers/net/wireless/intersil/prism54/isl_38xx.c delete mode 100644 drivers/net/wireless/intersil/prism54/isl_38xx.h delete mode 100644 drivers/net/wireless/intersil/prism54/isl_ioctl.c delete mode 100644 drivers/net/wireless/intersil/prism54/isl_ioctl.h delete mode 100644 drivers/net/wireless/intersil/prism54/isl_oid.h delete mode 100644 drivers/net/wireless/intersil/prism54/islpci_dev.c delete mode 100644 drivers/net/wireless/intersil/prism54/islpci_dev.h delete mode 100644 drivers/net/wireless/intersil/prism54/islpci_eth.c delete mode 100644 drivers/net/wireless/intersil/prism54/islpci_eth.h delete mode 100644 drivers/net/wireless/intersil/prism54/islpci_hotplug.c delete mode 100644 drivers/net/wireless/intersil/prism54/islpci_mgt.c delete mode 100644 drivers/net/wireless/intersil/prism54/islpci_mgt.h delete mode 100644 drivers/net/wireless/intersil/prism54/oid_mgt.c delete mode 100644 drivers/net/wireless/intersil/prism54/oid_mgt.h delete mode 100644 drivers/net/wireless/intersil/prism54/prismcompat.h
MAINTAINERS +0 -7
@@ -14940,13 +14940,6 @@ S: Maintained F: include/linux/printk.h F: kernel/printk/ -PRISM54 WIRELESS DRIVER -M: Luis Chamberlain <[email protected]> -L: [email protected] -S: Obsolete -W: https://wireless.wiki.kernel.org/en/users/Drivers/p54 -F: drivers/net/wireless/intersil/prism54/ - PROC FILESYSTEM L: [email protected] L: [email protected]
drivers/net/wireless/intersil/Kconfig +0 -20
@@ -16,24 +16,4 @@ source "drivers/net/wireless/intersil/hostap/Kconfig" source "drivers/net/wireless/intersil/orinoco/Kconfig" source "drivers/net/wireless/intersil/p54/Kconfig" -config PRISM54 - tristate 'Intersil Prism GT/Duette/Indigo PCI/Cardbus (DEPRECATED)' - depends on PCI - select WIRELESS_EXT - select WEXT_SPY - select WEXT_PRIV - select FW_LOADER - help - This enables support for FullMAC PCI/Cardbus prism54 devices. This - driver is now deprecated in favor for the SoftMAC driver, p54pci. - p54pci supports FullMAC PCI/Cardbus devices as well. - - For more information refer to the p54 wiki: - - http://wireless.wiki.kernel.org/en/users/Drivers/p54 - - Note: You need a motherboard with DMA support to use any of these cards - - When built as module you get the module prism54 - endif # WLAN_VENDOR_INTERSIL
drivers/net/wireless/intersil/Makefile +0 -1
@@ -2,4 +2,3 @@ obj-$(CONFIG_HOSTAP) += hostap/ obj-$(CONFIG_HERMES) += orinoco/ obj-$(CONFIG_P54_COMMON) += p54/ -obj-$(CONFIG_PRISM54) += prism54/
drivers/net/wireless/intersil/prism54/Makefile deleted +0 -9
@@ -1,9 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0-only -# $Id: Makefile.k26,v 1.7 2004/01/30 16:24:00 ajfa Exp $ - -prism54-objs := islpci_eth.o islpci_mgt.o \ - isl_38xx.o isl_ioctl.o islpci_dev.o \ - islpci_hotplug.o oid_mgt.o - -obj-$(CONFIG_PRISM54) += prism54.o -
drivers/net/wireless/intersil/prism54/isl_38xx.c deleted +0 -245
245 lines not on this page · raw message
drivers/net/wireless/intersil/prism54/isl_38xx.h deleted +0 -158
158 lines not on this page · raw message
drivers/net/wireless/intersil/prism54/isl_ioctl.c deleted +0 -2909
2,547 lines not on this page · raw message
drivers/net/wireless/intersil/prism54/isl_ioctl.h deleted +0 -35
Lines of this file are not shown. View the raw message.
drivers/net/wireless/intersil/prism54/isl_oid.h deleted +0 -492
492 lines not on this page · raw message
drivers/net/wireless/intersil/prism54/islpci_dev.c deleted +0 -951
951 lines not on this page · raw message
drivers/net/wireless/intersil/prism54/islpci_dev.h deleted +0 -204
204 lines not on this page · raw message
drivers/net/wireless/intersil/prism54/islpci_eth.c deleted +0 -489
489 lines not on this page · raw message
drivers/net/wireless/intersil/prism54/islpci_eth.h deleted +0 -59
59 lines not on this page · raw message
drivers/net/wireless/intersil/prism54/islpci_hotplug.c deleted +0 -316
316 lines not on this page · raw message
drivers/net/wireless/intersil/prism54/islpci_mgt.c deleted +0 -491
491 lines not on this page · raw message
drivers/net/wireless/intersil/prism54/islpci_mgt.h deleted +0 -126
126 lines not on this page · raw message
drivers/net/wireless/intersil/prism54/oid_mgt.c deleted +0 -889
889 lines not on this page · raw message
drivers/net/wireless/intersil/prism54/oid_mgt.h deleted +0 -46
46 lines not on this page · raw message
drivers/net/wireless/intersil/prism54/prismcompat.h deleted +0 -30
Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.17.1
Part of the diff is not shown here. View the raw message.
Quoted 7 lines · Lukas Bulwahn
Commit
1d89cae1b47d("MAINTAINERS: mark prism54 obsolete") indicated the prism54 driver as obsolete in July 2010.Now, after being exposed for ten years to refactoring, general tree-wide changes and various janitor clean-up, it is really time to delete the driver for good.
Quoted 5 lines
This was discovered as part of a checkpatch evaluation, investigating all reports of checkpatch's WARNING:OBSOLETE check.
Signed-off-by Lukas Bulwahn <[email protected]>---
Luis
Quoted 8 lines · Luis Chamberlain
Quoted 7 lines · Lukas Bulwahn
Commit
1d89cae1b47d("MAINTAINERS: mark prism54 obsolete") indicated the prism54 driver as obsolete in July 2010.Now, after being exposed for ten years to refactoring, general tree-wide changes and various janitor clean-up, it is really time to delete the driver for good.
Quoted 5 lines
Quoted 5 lines
This was discovered as part of a checkpatch evaluation, investigating all reports of checkpatch's WARNING:OBSOLETE check.
Signed-off-by Lukas Bulwahn <[email protected]>---
noted. Farewell.
Cheers
Christian
Quoted 9 lines · Christian Lamparter
Quoted 8 lines · Luis Chamberlain
Quoted 7 lines · Lukas Bulwahn
Commit
1d89cae1b47d("MAINTAINERS: mark prism54 obsolete") indicated the prism54 driver as obsolete in July 2010.Now, after being exposed for ten years to refactoring, general tree-wide changes and various janitor clean-up, it is really time to delete the driver for good.
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
This was discovered as part of a checkpatch evaluation, investigating all reports of checkpatch's WARNING:OBSOLETE check.
Signed-off-by Lukas Bulwahn <[email protected]>---
noted. Farewell.
How do we know that there are no users left? It's surprising how ancient hardware some people use. Is the driver broken or what?
(Reads commit 1d89cae1b47d)
Ah, p54 is supposed to replace prism54. Does that include all the hardware supported by prism54? If yes, that should be clearly documented in the commit log and I can add that.
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 19 lines · Kalle Valo
Quoted 9 lines · Christian Lamparter
Quoted 8 lines · Luis Chamberlain
Quoted 7 lines · Lukas Bulwahn
Commit
1d89cae1b47d("MAINTAINERS: mark prism54 obsolete") indicated the prism54 driver as obsolete in July 2010.Now, after being exposed for ten years to refactoring, general tree-wide changes and various janitor clean-up, it is really time to delete the driver for good.
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
This was discovered as part of a checkpatch evaluation, investigating all reports of checkpatch's WARNING:OBSOLETE check.
Signed-off-by Lukas Bulwahn <[email protected]>---
noted. Farewell.
Quoted 7 lines
How do we know that there are no users left? It's surprising how ancient hardware some people use. Is the driver broken or what?
(Reads commit
1d89cae1b47d)Ah, p54 is supposed to replace prism54. Does that include all the hardware supported by prism54?
There was a one off chipset someone told me about long ago that p54 didn't work for. But that persond disappeared from the face of the earth. Additionally, distributions have been blacklisting prism54 for years now.
Quoted 2 lines
If yes, that should be clearly documented
in the commit log and I can add that.
Agreed. Feel free to quote the above.
Luis
Quoted 33 lines · Luis Chamberlain
Quoted 19 lines · Kalle Valo
Quoted 9 lines · Christian Lamparter
Quoted 8 lines · Luis Chamberlain
Quoted 7 lines · Lukas Bulwahn
Commit
1d89cae1b47d("MAINTAINERS: mark prism54 obsolete") indicated the prism54 driver as obsolete in July 2010.Now, after being exposed for ten years to refactoring, general tree-wide changes and various janitor clean-up, it is really time to delete the driver for good.
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
This was discovered as part of a checkpatch evaluation, investigating all reports of checkpatch's WARNING:OBSOLETE check.
Signed-off-by Lukas Bulwahn <[email protected]>---
noted. Farewell.
Quoted 7 lines
How do we know that there are no users left? It's surprising how ancient hardware some people use. Is the driver broken or what?
(Reads commit
1d89cae1b47d)Ah, p54 is supposed to replace prism54. Does that include all the hardware supported by prism54?
There was a one off chipset someone told me about long ago that p54 didn't work for. But that persond disappeared from the face of the earth. Additionally, distributions have been blacklisting prism54 for years now.
Quoted 4 lines
Quoted 2 lines
If yes, that should be clearly documented
in the commit log and I can add that.Agreed. Feel free to quote the above.
Thanks, will do.
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 10 lines · Lukas Bulwahn
Commit
1d89cae1b47d("MAINTAINERS: mark prism54 obsolete") indicated the prism54 driver as obsolete in July 2010.Now, after being exposed for ten years to refactoring, general tree-wide changes and various janitor clean-up, it is really time to delete the driver for good.
This was discovered as part of a checkpatch evaluation, investigating all reports of checkpatch's WARNING:OBSOLETE check.
Quoted 7 lines
p54 replaces prism54 so users should be unaffected. There was a one off chipset someone long ago reported that p54 didn't work with but the reporter never followed up on that. Additionally, distributions have been blacklisting prism54 for years now.
Signed-off-by Lukas Bulwahn <[email protected]>Acked-by Luis Chamberlain <[email protected]>
Patch applied to wireless-drivers-next.git, thanks.
d249ff28b1d8 intersil: remove obsolete prism54 wireless driver
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches