Skip to contentSkip to conversation

ARM: dts: am335x-sancloud-bbe: Fix missing pinctrl refs

PATCH In review Paul Barker 2 participants 3 messages Aug 6, 2021 – Aug 10, 2021 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: dts: am335x-sancloud-bbe: Fix missing pinctrl refs

pinctrl settings for the USB hub, barometer & accelerometer need to be referenced from the relevant nodes to work.

---
 arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi | 2 ++
 arch/arm/boot/dts/am335x-sancloud-bbe.dts         | 4 ++++
 2 files changed, 6 insertions(+)
arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi +2 -0
index 627c18d23f94..55952fe8687c 100644
@@ -58,6 +58,8 @@ &cpsw_port1 {
 
 &i2c0 {
 	usb2512b: usb-hub@2c {
+		pinctrl-names = "default";
+		pinctrl-0 = <&usb_hub_ctrl>;
 		compatible = "microchip,usb2512b";
 		reg = <0x2c>;
 		reset-gpios = <&gpio0 29 GPIO_ACTIVE_LOW>;
arch/arm/boot/dts/am335x-sancloud-bbe.dts +4 -0
index 2a0ac9f5dda7..efbe93135dbe 100644
@@ -32,6 +32,8 @@ AM33XX_PADCONF(AM335X_PIN_GPMC_A10, PIN_INPUT, MUX_MODE7)     /* gpmc_a10.gpio1_
 
 &i2c0 {
 	lps331ap: barometer@5c {
+		pinctrl-names = "default";
+		pinctrl-0 = <&lps3331ap_pins>;
 		compatible = "st,lps331ap-press";
 		st,drdy-int-pin = <1>;
 		reg = <0x5c>;
@@ -40,6 +42,8 @@ lps331ap: barometer@5c {
 	};
 
 	mpu6050: accelerometer@68 {
+		pinctrl-names = "default";
+		pinctrl-0 = <&mpu6050_pins>;
 		compatible = "invensense,mpu6050";
 		reg = <0x68>;
 		interrupt-parent = <&gpio0>;
Signature · 1 line
2.31.1
#1 lore raw

PATCH 2/2 ARM: dts: am335x-sancloud-bbe: Drop usb wifi comment

The wifi chip on USB port 4 may not be present on all BBE variants.

---
 arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/am335x-sancloud-bbe-common.dtsi +0 -1
index 55952fe8687c..f9b7e774ac48 100644
@@ -63,6 +63,5 @@ usb2512b: usb-hub@2c {
 		compatible = "microchip,usb2512b";
 		reg = <0x2c>;
 		reset-gpios = <&gpio0 29 GPIO_ACTIVE_LOW>;
-		/* wifi on port 4 */
 	};
 };
Signature · 1 line
2.31.1
#2 lore raw
In reply to Paul Barker
Quoted 2 lines · Paul Barker

pinctrl settings for the USB hub, barometer & accelerometer need to be referenced from the relevant nodes to work.

Thanks applying both into omap-for-v5.15/dt.

Tony