drm/amdgpu: check for allocation failure in amdgpu_vkms_sw_init()
Subsystems (3)
PATCH 1/1 drm/amdgpu: check for allocation failure in amdgpu_vkms_sw_init()
Check whether the kcalloc() fails and return -ENOMEM if it does.
Fixes eeba0b9046fc ("drm/amdgpu: create amdgpu_vkms (v4)")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c +2 -0
@@ -482,6 +482,8 @@ static int amdgpu_vkms_sw_init(void *handle)return r; adev->amdgpu_vkms_output =kcalloc (adev->mode_info.num_crtc,sizeof (struct amdgpu_vkms_output ),GFP_KERNEL ); +if (!adev->amdgpu_vkms_output) +return -ENOMEM ;/* allocate crtcs, encoders, connectors */ for (i =0 ; i < adev->mode_info.num_crtc; i++) {
Signature · 1 line
2.20.1
Am 06.08.21 um 17:05 schrieb Dan Carpenter:
Quoted 4 lines
Check whether the
kcalloc()fails and return-ENOMEMif it does.Fixes eeba0b9046fc ("drm/amdgpu: create amdgpu_vkms (v4)")Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Christian König <[email protected]>
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c static int amdgpu_vkms_sw_init(void *handle) · line 484
Quoted 12 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c +0
-0@@ -482,6 +482,8 @@ static int amdgpu_vkms_sw_init(void *handle)return r; adev->amdgpu_vkms_output =kcalloc (adev->mode_info.num_crtc,sizeof (struct amdgpu_vkms_output ),GFP_KERNEL );
Is the line above not a bit long?
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c +2
-0+if (!adev->amdgpu_vkms_output) +return -ENOMEM ;/* allocate crtcs, encoders, connectors */ for (i =0 ; i < adev->mode_info.num_crtc; i++) {
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 30 lines · Christian König
Am 06.08.21 um 17:05 schrieb Dan Carpenter:
Quoted 4 lines
Check whether the
kcalloc()fails and return-ENOMEMif it does.Fixes eeba0b9046fc ("drm/amdgpu: create amdgpu_vkms (v4)")Signed-off-by Dan Carpenter <[email protected]>Reviewed-by Christian König <[email protected]>drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c static int amdgpu_vkms_sw_init(void *handle) · line 484
Quoted 12 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c +0
-0@@ -482,6 +482,8 @@ static int amdgpu_vkms_sw_init(void *handle)return r; adev->amdgpu_vkms_output =kcalloc (adev->mode_info.num_crtc,sizeof (struct amdgpu_vkms_output ),GFP_KERNEL );Is the line above not a bit long?
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c +2
-0+if (!adev->amdgpu_vkms_output) +return -ENOMEM ;/* allocate crtcs, encoders, connectors */ for (i =0 ; i < adev->mode_info.num_crtc; i++) {