Skip to contentSkip to conversation

platform/x86/intel: int3472: Use y instead of objs in Makefile

PATCH In review Andy Shevchenko 4 participants 5 messages Aug 6, 2021 – Aug 9, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86/intel: int3472: Use y instead of objs in Makefile

The 'objs' is for user space tools, for the kernel modules we should use 'y'.

---
 drivers/platform/x86/intel/int3472/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel/int3472/Makefile +1 -1
index 48bd97f0a04e..2362e04db18d 100644
@@ -1,5 +1,5 @@
 obj-$(CONFIG_INTEL_SKL_INT3472)		+= intel_skl_int3472.o
-intel_skl_int3472-objs			:= intel_skl_int3472_common.o \
+intel_skl_int3472-y			:= intel_skl_int3472_common.o \
 					   intel_skl_int3472_discrete.o \
 					   intel_skl_int3472_tps68470.o \
 					   intel_skl_int3472_clk_and_regulator.o
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw

Hi Andy

Quoted 2 lines · Andy Shevchenko

The 'objs' is for user space tools, for the kernel modules we should use 'y'.

Oops, now you mention it I remember you saying that for the cio2-bridge code too - thanks.

Quoted 1 line
Quoted 15 lines
---
 drivers/platform/x86/intel/int3472/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel/int3472/Makefile +1 -1
index 48bd97f0a04e..2362e04db18d 100644
@@ -1,5 +1,5 @@
 obj-$(CONFIG_INTEL_SKL_INT3472)		+= intel_skl_int3472.o
-intel_skl_int3472-objs			:= intel_skl_int3472_common.o \
+intel_skl_int3472-y			:= intel_skl_int3472_common.o \
 					   intel_skl_int3472_discrete.o \
 					   intel_skl_int3472_tps68470.o \
 					   intel_skl_int3472_clk_and_regulator.o
#2 lore raw
Quoted 6 lines · Daniel Scally
Quoted 2 lines · Andy Shevchenko

The 'objs' is for user space tools, for the kernel modules we should use 'y'.

Oops, now you mention it I remember you saying that for the cio2-bridge code too - thanks.

Just for the sake of reference (I spent some time to realize from where I have got this):
https://www.kernel.org/doc/html/latest/kbuild/makefiles.html#composite-userspace-programs
(Note, that there is the first section with the first "objs" mention)

...

Quoted 1 line

Thanks!

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Daniel Scally
Quoted 2 lines · Andy Shevchenko

The 'objs' is for user space tools, for the kernel modules we should use 'y'.

Quoted 7 lines
Quoted 2 lines

Oops, now you mention it I remember you saying that for the cio2-bridge code too - thanks.

Just for the sake of reference (I spent some time to realize from where I have got this):
https://www.kernel.org/doc/html/latest/kbuild/makefiles.html#composite-userspace-programs
(Note, that there is the first section with the first "objs" mention)

Actually this one
https://www.kernel.org/doc/html/latest/kbuild/makefiles.html#composite-host-programs
But it doesn't change the point.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
In reply to Andy Shevchenko

Hi,

Quoted 4 lines · Andy Shevchenko

The 'objs' is for user space tools, for the kernel modules we should use 'y'.

Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.

Regards,

Hans

Quoted 16 lines
---
 drivers/platform/x86/intel/int3472/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel/int3472/Makefile +1 -1
index 48bd97f0a04e..2362e04db18d 100644
@@ -1,5 +1,5 @@
 obj-$(CONFIG_INTEL_SKL_INT3472)		+= intel_skl_int3472.o
-intel_skl_int3472-objs			:= intel_skl_int3472_common.o \
+intel_skl_int3472-y			:= intel_skl_int3472_common.o \
 					   intel_skl_int3472_discrete.o \
 					   intel_skl_int3472_tps68470.o \
 					   intel_skl_int3472_clk_and_regulator.o