Skip to contentSkip to conversation

atm: horizon: Fix spelling mistakes in TX comment

PATCH Superseded Jun Miao 2 participants 3 messages Aug 7, 2021

Subsystems (3)
lore
Share & tools
lore

Jun Miao

author
#0 lore raw

PATCH v2 1/1 atm: horizon: Fix spelling mistakes in TX comment

It's "must not", not "musn't", meaning "shall not". Let's fix that.

---
 drivers/atm/horizon.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/atm/horizon.c +3 -3
index 4f2951cbe69c..9ee494bc5c51 100644
@@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc)
   
   // Part of the job is done by atm_pcr_goal which gives us a PCR
   // specification which says: EITHER grab the maximum available PCR
-  // (and perhaps a lower bound which we musn't pass), OR grab this
+  // (and perhaps a lower bound which we mustn't pass), OR grab this
   // amount, rounding down if you have to (and perhaps a lower bound
-  // which we musn't pass) OR grab this amount, rounding up if you
-  // have to (and perhaps an upper bound which we musn't pass). If any
+  // which we mustn't pass) OR grab this amount, rounding up if you
+  // have to (and perhaps an upper bound which we mustn't pass). If any
   // bounds ARE passed we fail. Note that rounding is only rounding to
   // match device limitations, we do not round down to satisfy
   // bandwidth availability even if this would not violate any given
Signature · 1 line
2.32.0
#1 lore raw
Quoted 18 lines · Jun Miao

It's "must not", not "musn't", meaning "shall not". Let's fix that.

---
 drivers/atm/horizon.c | 6 +++---

 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/atm/horizon.c +0 -0
index 4f2951cbe69c..9ee494bc5c51 100644
@@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc)

   // Part of the job is done by atm_pcr_goal which gives us a PCR // specification which says: EITHER grab the maximum available PCR

drivers/atm/horizon.c static int hrz_open (struct atm_vcc *atm_vcc) · line 2170

Quoted 2 lines
drivers/atm/horizon.c +1 -1
-  // (and perhaps a lower bound which we musn't pass), OR grab this
+  // (and perhaps a lower bound which we mustn't pass), OR grab this

I meant to suggest you change the patch to use "must not" not the commit message.

Quoted 8 lines

   // amount, rounding down if you have to (and perhaps a lower bound

drivers/atm/horizon.c +2 -2
-  // which we musn't pass) OR grab this amount, rounding up if you
-  // have to (and perhaps an upper bound which we musn't pass). If any
+  // which we mustn't pass) OR grab this amount, rounding up if you
+  // have to (and perhaps an upper bound which we mustn't pass). If any

   // bounds ARE passed we fail. Note that rounding is only rounding to // match device limitations, we do not round down to satisfy // bandwidth availability even if this would not violate any given

author
#2 lore raw
Quoted 19 lines · Joe Perches

[Please note: This e-mail is from an EXTERNAL e-mail address]

Quoted 16 lines · Jun Miao

It's "must not", not "musn't", meaning "shall not". Let's fix that.

---
  drivers/atm/horizon.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/atm/horizon.c +0 -0
index 4f2951cbe69c..9ee494bc5c51 100644
@@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc)
 
 
Quoted 6 lines

drivers/atm/horizon.c static int hrz_open (struct atm_vcc *atm_vcc) · line 2170

Quoted 4 lines
drivers/atm/horizon.c +1 -1
    // Part of the job is done by atm_pcr_goal which gives us a PCR
    // specification which says: EITHER grab the maximum available PCR
-  // (and perhaps a lower bound which we musn't pass), OR grab this
+  // (and perhaps a lower bound which we mustn't pass), OR grab this

I meant to suggest you change the patch to use "must not" not the commit message.

Please ignore this e-mail. Sorry, confuse the mailing list.

I am so careless to forget change there. After this 2 minutest, i send new  same V2(in fact should v3 but forgive for a freshman)

Quoted 9 lines
Quoted 8 lines
drivers/atm/horizon.c +2 -2
    // amount, rounding down if you have to (and perhaps a lower bound
-  // which we musn't pass) OR grab this amount, rounding up if you
-  // have to (and perhaps an upper bound which we musn't pass). If any
+  // which we mustn't pass) OR grab this amount, rounding up if you
+  // have to (and perhaps an upper bound which we mustn't pass). If any
    // bounds ARE passed we fail. Note that rounding is only rounding to
    // match device limitations, we do not round down to satisfy
    // bandwidth availability even if this would not violate any given