Skip to contentSkip to conversation

dt-bindings: net: Add the properties for ipq4019 MDIO

PATCH In review Luo Jie 2 participants 3 messages Aug 8, 2021 – Aug 9, 2021

Subsystems (4)
lore
Share & tools
lore

Luo Jie

author
#0 lore raw

PATCH 1/1 dt-bindings: net: Add the properties for ipq4019 MDIO

The new added properties resource "reg" is for configuring ethernet LDO in the IPQ5018 chipset, the property "clocks" is for configuring the MDIO clock source frequency.

This patch depends on the following patch:
Commit 2b8951cb4670 ("net: mdio: Add the reset function for IPQ MDIO driver")

---
 .../devicetree/bindings/net/qcom,ipq4019-mdio.yaml | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml +12 -2
index 0c973310ada0..8f53fa2a00f8 100644
@@ -14,7 +14,9 @@ allOf:
 
 properties:
   compatible:
-    const: qcom,ipq4019-mdio
+    enum:
+      - qcom,ipq4019-mdio
+      - qcom,ipq5018-mdio
 
   "#address-cells":
     const: 1
@@ -23,7 +25,15 @@ properties:
     const: 0
 
   reg:
-    maxItems: 1
+    minItems: 1
+    maxItems: 2
+    description:
+      the first Address and length of the register set for the MDIO controller.
+      the optional second Address and length of the register for ethernet LDO.
+
+  clocks:
+    items:
+      - description: MDIO clock
 
 required:
   - compatible
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#1 lore raw
Quoted 7 lines · Luo Jie

The new added properties resource "reg" is for configuring ethernet LDO in the IPQ5018 chipset, the property "clocks" is for configuring the MDIO clock source frequency.

This patch depends on the following patch:
Commit 2b8951cb4670 ("net: mdio: Add the reset function for IPQ MDIO driver")

Please always make binding patches part of the series containing the driver code. We sometimes need to see both to do a proper review.

Add a comment about when the second address range and clock is required. Does qcom,ipq5018-mdio require them?

Andrew

author
#2 lore raw
Quoted 8 lines · Andrew Lunn
Quoted 7 lines · Luo Jie

The new added properties resource "reg" is for configuring ethernet LDO in the IPQ5018 chipset, the property "clocks" is for configuring the MDIO clock source frequency.

This patch depends on the following patch:
Commit 2b8951cb4670 ("net: mdio: Add the reset function for IPQ MDIO driver")

Quoted 7 lines

Please always make binding patches part of the series containing the driver code. We sometimes need to see both to do a proper review.

Add a comment about when the second address range and clock is required. Does qcom,ipq5018-mdio require them?

Andrew

Hi Andrew,

yes, the second address range is only required for qcom,ipq5018-mdio currently,

will document it in next patch set, and send it with the drive code patch, thanks

for the comments and review.