Simple question for newbie developer about qgroup
I read btrfs kernel source code about qgroup. I want to know about how works adding or deleting qgroups. and I read the function __del_qgroup_relation() in qgroup.c.
This function checks whether dst is parent for src and store the result in variable named found. I think if the checks failed, the function needs to be failed or print warning message at least. Am I right? Or do you have other intentions?
Quoted 9 lines · Sidong Yang
I read btrfs kernel source code about qgroup. I want to know about how works adding or deleting qgroups. and I read the function
__del_qgroup_relation()inqgroup.c.This function checks whether dst is parent for src and store the result in variable named found. I think if the checks failed, the function needs to be failed or print warning message at least. Am I right? Or do you have other intentions?
User can specify a non-exist parent/child pair, in that case we don't need to print error message, as -ENOENT is enough to inform the user.
Thanks,
Qu
Quoted 7 lines · Qu Wenruo
Quoted 4 lines · Sidong Yang
I read btrfs kernel source code about qgroup. I want to know about how works adding or deleting qgroups. and I read the function
__del_qgroup_relation()inqgroup.c.
Quoted 8 lines
Quoted 5 lines
This function checks whether dst is parent for src and store the result in variable named found. I think if the checks failed, the function needs to be failed or print warning message at least. Am I right? Or do you have other intentions?
User can specify a non-exist parent/child pair, in that case we don't need to print error message, as
-ENOENTis enough to inform the user.
Hi, Qu.
Thanks for informing me. Now I continue to read the code.
Thanks,
Sidong
Quoted 3 lines
Thanks,
Qu