hw/nvme: fix missing variable initializers
PATCH 1/1 hw/nvme: fix missing variable initializers
From: Klaus Jensen <[email protected]>
Coverity found that 'uuid', 'csi' and 'eui64' are uninitialized. While we set most of the fields, we do not explicitly set the rsvd2 field in the NvmeIdNsDescr header.
Fix this by explicitly zero-initializing the variables.
--- hw/nvme/ctrl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
hw/nvme/ctrl.c +3 -3
@@ -4663,15 +4663,15 @@ static uint16_t nvme_identify_ns_descr_list(NvmeCtrl *n, NvmeRequest *req)struct {NvmeIdNsDescr hdr;uint8_t v[NVME_NIDL_UUID ]; - } QEMU_PACKED uuid; + } QEMU_PACKED uuid = {};struct {NvmeIdNsDescr hdr;uint64_t v; - } QEMU_PACKED eui64; + } QEMU_PACKED eui64 = {};struct {NvmeIdNsDescr hdr;uint8_t v; - } QEMU_PACKED csi; + } QEMU_PACKED csi = {};trace_pci_nvme_identify_ns_descr_list (nsid);
Signature · 1 line
2.32.0
Quoted 8 lines · Klaus Jensen
From: Klaus Jensen <[email protected]>
Coverity found that 'uuid', 'csi' and 'eui64' are uninitialized. While we set most of the fields, we do not explicitly set the rsvd2 field in the NvmeIdNsDescr header.
Fix this by explicitly zero-initializing the variables.
Quoted 7 lines
Reported-by Coverity (CID 1458835, 1459295 and 1459580)Fixes 6870cfb8140d ("hw/nvme: namespace parameter for EUI-64")Suggested-by Peter Maydell <[email protected]>Signed-off-by Klaus Jensen <[email protected]>--- hw/nvme/ctrl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 17 lines · Philippe Mathieu-Daudé
Quoted 8 lines · Klaus Jensen
From: Klaus Jensen <[email protected]>
Coverity found that 'uuid', 'csi' and 'eui64' are uninitialized. While we set most of the fields, we do not explicitly set the rsvd2 field in the NvmeIdNsDescr header.
Fix this by explicitly zero-initializing the variables.
Quoted 7 lines
Reported-by Coverity (CID 1458835, 1459295 and 1459580)Fixes 6870cfb8140d ("hw/nvme: namespace parameter for EUI-64")Suggested-by Peter Maydell <[email protected]>Signed-off-by Klaus Jensen <[email protected]>--- hw/nvme/ctrl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 2 lines
Reviewed-by Philippe Mathieu-Daudé <[email protected]>
Swift as always Philippe, thanks!
Yes, I'll PR this for -rc3 immediately.