Skip to contentSkip to conversation

arm64: dts: meson: add spdif out to khadas-vim

PATCH In review Artem Lapkin 2 participants 4 messages Aug 10, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 arm64: dts: meson: add spdif out to khadas-vim

Add spdif output audio support to khadas-vim

---
 .../dts/amlogic/meson-gxl-s905x-khadas-vim.dts  | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts +17 -0
index 60feac0179c0..01f13822a616 100644
@@ -64,6 +64,13 @@ hdmi_connector_in: endpoint {
 		};
 	};
 
+	spdif_dit: audio-codec-0 {
+		#sound-dai-cells = <0>;
+		compatible = "linux,spdif-dit";
+		status = "okay";
+		sound-name-prefix = "DIT";
+	};
+
 	sound {
 		compatible = "amlogic,gx-sound-card";
 		model = "KHADAS-VIM";
@@ -97,11 +104,21 @@ codec-0 {
 				sound-dai = <&hdmi_tx>;
 			};
 		};
+
+		dai-link-3 {
+			sound-dai = <&aiu AIU_CPU CPU_SPDIF_ENCODER>;
+
+			codec-0 {
+				sound-dai = <&spdif_dit>;
+			};
+		};
 	};
 };
 
 &aiu {
 	status = "okay";
+	pinctrl-0 = <&spdif_out_h_pins>;
+	pinctrl-names = "default";
 };
 
 &cec_AO {
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/2 arm64: dts: meson: add spdif out to khadas-vim2

Add spdif output audio support to khadas-vim2

---
 .../boot/dts/amlogic/meson-gxm-khadas-vim2.dts  | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts +17 -0
index 18a4b7a6c5df..a129a827f6ee 100644
@@ -146,6 +146,13 @@ wifi32k: wifi32k {
 		pwms = <&pwm_ef 0 30518 0>; /* PWM_E at 32.768KHz */
 	};
 
+	spdif_dit: audio-codec-0 {
+		#sound-dai-cells = <0>;
+		compatible = "linux,spdif-dit";
+		status = "okay";
+		sound-name-prefix = "DIT";
+	};
+
 	sound {
 		compatible = "amlogic,gx-sound-card";
 		model = "KHADAS-VIM2";
@@ -179,11 +186,21 @@ codec-0 {
 				sound-dai = <&hdmi_tx>;
 			};
 		};
+
+		dai-link-3 {
+			sound-dai = <&aiu AIU_CPU CPU_SPDIF_ENCODER>;
+
+			codec-0 {
+			sound-dai = <&spdif_dit>;
+			};
+		};
 	};
 };
 
 &aiu {
 	status = "okay";
+	pinctrl-0 = <&spdif_out_h_pins>;
+	pinctrl-names = "default";
 };
 
 &cec_AO {
Signature · 1 line
2.25.1
#2 lore raw
In reply to Artem Lapkin

Hi,

Quoted 38 lines · Artem Lapkin

Add spdif output audio support to khadas-vim

---
 .../dts/amlogic/meson-gxl-s905x-khadas-vim.dts  | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts +15 -0
index 60feac0179c0..01f13822a616 100644
@@ -64,6 +64,13 @@ hdmi_connector_in: endpoint {
 		};
 	};
 
+	spdif_dit: audio-codec-0 {
+		#sound-dai-cells = <0>;
+		compatible = "linux,spdif-dit";
+		status = "okay";
+		sound-name-prefix = "DIT";
+	};
+
 	sound {
 		compatible = "amlogic,gx-sound-card";
 		model = "KHADAS-VIM";
@@ -97,11 +104,21 @@ codec-0 {
 				sound-dai = <&hdmi_tx>;
 			};
 		};
+
+		dai-link-3 {
+			sound-dai = <&aiu AIU_CPU CPU_SPDIF_ENCODER>;
+
+			codec-0 {
+				sound-dai = <&spdif_dit>;
+			};
+		};

arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts codec-0 { · line 124

Quoted 10 lines
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts +2 -0
 	};
 };
 
 &aiu {
 	status = "okay";
+	pinctrl-0 = <&spdif_out_h_pins>;
+	pinctrl-names = "default";
 };
 
 &cec_AO {

AFAIK the board doesn't have a physical SPDIF output, but one of the 40pin header can output SPDIF, right ?

In this case, following the other boards mainline definitions, we do not enable any function by default for pins on the 40pin (or other programmable) headers.

There is still ongoing discussions on how to handle that on a more generic level, but you should write a bunch of DT overlays for the VIM boards to enable optional functions like SPDIF and store then in a public git tree for everybody to use (like armbian or LibreELEC for example) from the U-Boot stage.

Neil

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

author
#3 lore raw
Quoted 1 line

AFAIK the board doesn't have a physical SPDIF output, but one of the 40pin header can output SPDIF, right ?

Yes it's right

Quoted 1 line

In this case, following the other boards mainline definitions, we do not enable any function by default

For pins on the 40pin (or other programmable) headers.

ok ! now i'm understand reason

But maybe it is possible to add this area as commented /* */ and users will have possibilities to uncomment it.

Quoted 1 line

DT overlays

Yes but I still don't understand how-to apply dt overlays for EFI+grub may be somebody can clarify this problem?

Quoted 63 lines · Neil Armstrong

Hi,

Quoted 38 lines · Artem Lapkin

Add spdif output audio support to khadas-vim

---
 .../dts/amlogic/meson-gxl-s905x-khadas-vim.dts  | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts +15 -0
index 60feac0179c0..01f13822a616 100644
@@ -64,6 +64,13 @@ hdmi_connector_in: endpoint {
              };
      };
 
+     spdif_dit: audio-codec-0 {
+             #sound-dai-cells = <0>;
+             compatible = "linux,spdif-dit";
+             status = "okay";
+             sound-name-prefix = "DIT";
+     };
+
      sound {
              compatible = "amlogic,gx-sound-card";
              model = "KHADAS-VIM";
@@ -97,11 +104,21 @@ codec-0 {
                              sound-dai = <&hdmi_tx>;
                      };
              };
+
+             dai-link-3 {
+                     sound-dai = <&aiu AIU_CPU CPU_SPDIF_ENCODER>;
+
+                     codec-0 {
+                             sound-dai = <&spdif_dit>;
+                     };
+             };

arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts codec-0 { · line 124

Quoted 10 lines
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts +2 -0
      };
 };
 
 &aiu {
      status = "okay";
+     pinctrl-0 = <&spdif_out_h_pins>;
+     pinctrl-names = "default";
 };
 
 &cec_AO {

AFAIK the board doesn't have a physical SPDIF output, but one of the 40pin header can output SPDIF, right ?

In this case, following the other boards mainline definitions, we do not enable any function by default for pins on the 40pin (or other programmable) headers.

There is still ongoing discussions on how to handle that on a more generic level, but you should write a bunch of DT overlays for the VIM boards to enable optional functions like SPDIF and store then in a public git tree for everybody to use (like armbian or LibreELEC for example) from the U-Boot stage.

Neil