Move Intel platform drivers to intel directory to improve readability.
Subsystems (5)
cover Move Intel platform drivers to intel directory to improve readability.
All the intel platform specific drivers are moved to intel/. It makes more clear file structure to improve the readability.
Kate Hsuan (20):
Move Intel hid of pdx86 to intel directory to improve readability. Move Intel WMI driver of pdx86 to intel/ directory to improve
readability.
Move Intel bxtwc driver of pdx86 to intel/ directory to improve
readability.
Move Intel chtdc_ti driver of pdx86 to improve readability. Move MRFLD power button driver of pdx86 to intel directory to improve
readability.
Move Intel PMC core of pdx86 to intel/ directory to improve
readability.
Move Intel PMT driver of pdx86 to intel/ to improve readability. Move Intel P-Unit of pdx86 to intel/ directory to improve readability. Move Intel SCU IPC of pdx86 to intel directory to increase
readability.
Move Intel SoC telemetry driver to intel directory to improve
readability.
Move Intel IPS driver of pdx86 to improve readability. Move Intel RST driver of pdx86 to intel directory to improve
readability.
Move Intel smartconnect driver of pdx86 to intel/ directory to improve
readability.
Move Intel SST driver to intel/ directory to improve readability. Move Intel turbo max 3 driver to intel/ directory to improve
readability.
Move Intel uncore freq driver to intel/ directory to improve
readability.
Move Intel int0002 vgpio driver to intel/ directory to inprove
readability.
Move Intel thermal driver for menlow platform driver to intel/
directory to improve readability.
Move OakTrail driver to the intel/ directory to improve readability. Move Intel virtual botton driver to intel/ directory to improve
readability.
drivers/platform/x86/Kconfig | 297 ------------------
drivers/platform/x86/Makefile | 34 +-
drivers/platform/x86/intel/Kconfig | 21 ++
drivers/platform/x86/intel/Makefile | 31 ++
drivers/platform/x86/intel/bxtwc/Kconfig | 15 +
drivers/platform/x86/intel/bxtwc/Makefile | 6 +
.../x86/{ => intel/bxtwc}/intel_bxtwc_tmu.c | 0
drivers/platform/x86/intel/chtdc_ti/Kconfig | 16 +
drivers/platform/x86/intel/chtdc_ti/Makefile | 7 +
.../chtdc_ti}/intel_chtdc_ti_pwrbtn.c | 0
drivers/platform/x86/intel/hid/Kconfig | 17 +
drivers/platform/x86/intel/hid/Makefile | 7 +
.../platform/x86/{ => intel/hid}/intel-hid.c | 0
drivers/platform/x86/intel/int0002/Kconfig | 23 ++
drivers/platform/x86/intel/int0002/Makefile | 6 +
.../{ => intel/int0002}/intel_int0002_vgpio.c | 0
.../{ => intel}/intel_speed_select_if/Kconfig | 0
.../intel_speed_select_if/Makefile | 0
.../intel_speed_select_if/isst_if_common.c | 0
.../intel_speed_select_if/isst_if_common.h | 0
.../intel_speed_select_if/isst_if_mbox_msr.c | 0
.../intel_speed_select_if/isst_if_mbox_pci.c | 0
.../intel_speed_select_if/isst_if_mmio.c | 0
drivers/platform/x86/intel/ips/Kconfig | 14 +
drivers/platform/x86/intel/ips/Makefile | 6 +
.../platform/x86/{ => intel/ips}/intel_ips.c | 0
.../platform/x86/{ => intel/ips}/intel_ips.h | 0
drivers/platform/x86/intel/menlow/Kconfig | 14 +
drivers/platform/x86/intel/menlow/Makefile | 6 +
.../x86/{ => intel/menlow}/intel_menlow.c | 0
drivers/platform/x86/intel/mrfld/Kconfig | 17 +
drivers/platform/x86/intel/mrfld/Makefile | 6 +
.../{ => intel/mrfld}/intel_mrfld_pwrbtn.c | 0
drivers/platform/x86/intel/oaktrail/Kconfig | 15 +
drivers/platform/x86/intel/oaktrail/Makefile | 6 +
.../x86/{ => intel/oaktrail}/intel_oaktrail.c | 0
drivers/platform/x86/intel/pmc_core/Kconfig | 26 ++
drivers/platform/x86/intel/pmc_core/Makefile | 6 +
.../x86/{ => intel/pmc_core}/intel_pmc_core.c | 0
.../x86/{ => intel/pmc_core}/intel_pmc_core.h | 0
.../pmc_core}/intel_pmc_core_pltdrv.c | 0
drivers/platform/x86/intel/pmt/Kconfig | 41 +++
drivers/platform/x86/intel/pmt/Makefile | 9 +
.../x86/{ => intel/pmt}/intel_pmt_class.c | 0
.../x86/{ => intel/pmt}/intel_pmt_class.h | 0
.../x86/{ => intel/pmt}/intel_pmt_crashlog.c | 0
.../x86/{ => intel/pmt}/intel_pmt_telemetry.c | 0
drivers/platform/x86/intel/punit/Kconfig | 10 +
drivers/platform/x86/intel/punit/Makefile | 6 +
.../x86/{ => intel/punit}/intel_punit_ipc.c | 0
drivers/platform/x86/intel/rst/Kconfig | 16 +
drivers/platform/x86/intel/rst/Makefile | 6 +
.../platform/x86/{ => intel/rst}/intel-rst.c | 0
drivers/platform/x86/intel/scu/Kconfig | 52 +++
drivers/platform/x86/intel/scu/Makefile | 11 +
.../x86/{ => intel/scu}/intel_scu_ipc.c | 0
.../x86/{ => intel/scu}/intel_scu_ipcutil.c | 0
.../x86/{ => intel/scu}/intel_scu_pcidrv.c | 0
.../x86/{ => intel/scu}/intel_scu_pltdrv.c | 0
.../x86/{ => intel/scu}/intel_scu_wdt.c | 0
.../platform/x86/intel/smartconnect/Kconfig | 18 ++
.../platform/x86/intel/smartconnect/Makefile | 6 +
.../smartconnect}/intel-smartconnect.c | 0
drivers/platform/x86/intel/telemetry/Kconfig | 16 +
drivers/platform/x86/intel/telemetry/Makefile | 9 +
.../telemetry}/intel_telemetry_core.c | 0
.../telemetry}/intel_telemetry_debugfs.c | 0
.../telemetry}/intel_telemetry_pltdrv.c | 0
.../platform/x86/intel/turbo_max_3/Kconfig | 14 +
.../platform/x86/intel/turbo_max_3/Makefile | 6 +
.../turbo_max_3}/intel_turbo_max_3.c | 0
.../platform/x86/intel/uncore_freq/Kconfig | 15 +
.../platform/x86/intel/uncore_freq/Makefile | 6 +
.../uncore_freq}/intel-uncore-frequency.c | 0
drivers/platform/x86/intel/vbtn/Kconfig | 16 +
drivers/platform/x86/intel/vbtn/Makefile | 6 +
.../x86/{ => intel/vbtn}/intel-vbtn.c | 0
drivers/platform/x86/intel/wmi/Kconfig | 26 ++
drivers/platform/x86/intel/wmi/Makefile | 7 +
.../{ => intel/wmi}/intel-wmi-sbl-fw-update.c | 0
.../{ => intel/wmi}/intel-wmi-thunderbolt.c | 0
81 files changed, 562 insertions(+), 330 deletions(-)
create mode 100644 drivers/platform/x86/intel/bxtwc/Kconfig
create mode 100644 drivers/platform/x86/intel/bxtwc/Makefile
rename drivers/platform/x86/{ => intel/bxtwc}/intel_bxtwc_tmu.c (100%)
create mode 100644 drivers/platform/x86/intel/chtdc_ti/Kconfig
create mode 100644 drivers/platform/x86/intel/chtdc_ti/Makefile
rename drivers/platform/x86/{ => intel/chtdc_ti}/intel_chtdc_ti_pwrbtn.c (100%)
create mode 100644 drivers/platform/x86/intel/hid/Kconfig
create mode 100644 drivers/platform/x86/intel/hid/Makefile
rename drivers/platform/x86/{ => intel/hid}/intel-hid.c (100%)
create mode 100644 drivers/platform/x86/intel/int0002/Kconfig
create mode 100644 drivers/platform/x86/intel/int0002/Makefile
rename drivers/platform/x86/{ => intel/int0002}/intel_int0002_vgpio.c (100%)
rename drivers/platform/x86/{ => intel}/intel_speed_select_if/Kconfig (100%)
rename drivers/platform/x86/{ => intel}/intel_speed_select_if/Makefile (100%)
rename drivers/platform/x86/{ => intel}/intel_speed_select_if/isst_if_common.c (100%)
rename drivers/platform/x86/{ => intel}/intel_speed_select_if/isst_if_common.h (100%)
rename drivers/platform/x86/{ => intel}/intel_speed_select_if/isst_if_mbox_msr.c (100%)
rename drivers/platform/x86/{ => intel}/intel_speed_select_if/isst_if_mbox_pci.c (100%)
rename drivers/platform/x86/{ => intel}/intel_speed_select_if/isst_if_mmio.c (100%)
create mode 100644 drivers/platform/x86/intel/ips/Kconfig
create mode 100644 drivers/platform/x86/intel/ips/Makefile
rename drivers/platform/x86/{ => intel/ips}/intel_ips.c (100%)
rename drivers/platform/x86/{ => intel/ips}/intel_ips.h (100%)
create mode 100644 drivers/platform/x86/intel/menlow/Kconfig
create mode 100644 drivers/platform/x86/intel/menlow/Makefile
rename drivers/platform/x86/{ => intel/menlow}/intel_menlow.c (100%)
create mode 100644 drivers/platform/x86/intel/mrfld/Kconfig
create mode 100644 drivers/platform/x86/intel/mrfld/Makefile
rename drivers/platform/x86/{ => intel/mrfld}/intel_mrfld_pwrbtn.c (100%)
create mode 100644 drivers/platform/x86/intel/oaktrail/Kconfig
create mode 100644 drivers/platform/x86/intel/oaktrail/Makefile
rename drivers/platform/x86/{ => intel/oaktrail}/intel_oaktrail.c (100%)
create mode 100644 drivers/platform/x86/intel/pmc_core/Kconfig
create mode 100644 drivers/platform/x86/intel/pmc_core/Makefile
rename drivers/platform/x86/{ => intel/pmc_core}/intel_pmc_core.c (100%)
rename drivers/platform/x86/{ => intel/pmc_core}/intel_pmc_core.h (100%)
rename drivers/platform/x86/{ => intel/pmc_core}/intel_pmc_core_pltdrv.c (100%)
create mode 100644 drivers/platform/x86/intel/pmt/Kconfig
create mode 100644 drivers/platform/x86/intel/pmt/Makefile
rename drivers/platform/x86/{ => intel/pmt}/intel_pmt_class.c (100%)
rename drivers/platform/x86/{ => intel/pmt}/intel_pmt_class.h (100%)
rename drivers/platform/x86/{ => intel/pmt}/intel_pmt_crashlog.c (100%)
rename drivers/platform/x86/{ => intel/pmt}/intel_pmt_telemetry.c (100%)
create mode 100644 drivers/platform/x86/intel/punit/Kconfig
create mode 100644 drivers/platform/x86/intel/punit/Makefile
rename drivers/platform/x86/{ => intel/punit}/intel_punit_ipc.c (100%)
create mode 100644 drivers/platform/x86/intel/rst/Kconfig
create mode 100644 drivers/platform/x86/intel/rst/Makefile
rename drivers/platform/x86/{ => intel/rst}/intel-rst.c (100%)
create mode 100644 drivers/platform/x86/intel/scu/Kconfig
create mode 100644 drivers/platform/x86/intel/scu/Makefile
rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipc.c (100%)
rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipcutil.c (100%)
rename drivers/platform/x86/{ => intel/scu}/intel_scu_pcidrv.c (100%)
rename drivers/platform/x86/{ => intel/scu}/intel_scu_pltdrv.c (100%)
rename drivers/platform/x86/{ => intel/scu}/intel_scu_wdt.c (100%)
create mode 100644 drivers/platform/x86/intel/smartconnect/Kconfig
create mode 100644 drivers/platform/x86/intel/smartconnect/Makefile
rename drivers/platform/x86/{ => intel/smartconnect}/intel-smartconnect.c (100%)
create mode 100644 drivers/platform/x86/intel/telemetry/Kconfig
create mode 100644 drivers/platform/x86/intel/telemetry/Makefile
rename drivers/platform/x86/{ => intel/telemetry}/intel_telemetry_core.c (100%)
rename drivers/platform/x86/{ => intel/telemetry}/intel_telemetry_debugfs.c (100%)
rename drivers/platform/x86/{ => intel/telemetry}/intel_telemetry_pltdrv.c (100%)
create mode 100644 drivers/platform/x86/intel/turbo_max_3/Kconfig
create mode 100644 drivers/platform/x86/intel/turbo_max_3/Makefile
rename drivers/platform/x86/{ => intel/turbo_max_3}/intel_turbo_max_3.c (100%)
create mode 100644 drivers/platform/x86/intel/uncore_freq/Kconfig
create mode 100644 drivers/platform/x86/intel/uncore_freq/Makefile
rename drivers/platform/x86/{ => intel/uncore_freq}/intel-uncore-frequency.c (100%)
create mode 100644 drivers/platform/x86/intel/vbtn/Kconfig
create mode 100644 drivers/platform/x86/intel/vbtn/Makefile
rename drivers/platform/x86/{ => intel/vbtn}/intel-vbtn.c (100%)
create mode 100644 drivers/platform/x86/intel/wmi/Kconfig
create mode 100644 drivers/platform/x86/intel/wmi/Makefile
rename drivers/platform/x86/{ => intel/wmi}/intel-wmi-sbl-fw-update.c (100%)
rename drivers/platform/x86/{ => intel/wmi}/intel-wmi-thunderbolt.c (100%)Signature · 1 line
2.31.1
PATCH 1/20 Move Intel hid of pdx86 to intel directory to improve readability.
---
drivers/platform/x86/Kconfig | 12 ------------
drivers/platform/x86/Makefile | 2 +-
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 2 ++
drivers/platform/x86/intel/hid/Kconfig | 17 +++++++++++++++++
drivers/platform/x86/intel/hid/Makefile | 7 +++++++
.../platform/x86/{ => intel/hid}/intel-hid.c | 0
7 files changed, 28 insertions(+), 13 deletions(-)
create mode 100644 drivers/platform/x86/intel/hid/Kconfig
create mode 100644 drivers/platform/x86/intel/hid/Makefile
rename drivers/platform/x86/{ => intel/hid}/intel-hid.c (100%)drivers/platform/x86/Kconfig +0 -12
@@ -653,18 +653,6 @@ config THINKPAD_LMI source "drivers/platform/x86/intel/Kconfig" -config INTEL_HID_EVENT - tristate "INTEL HID Event" - depends on ACPI - depends on INPUT - select INPUT_SPARSEKMAP - help - This driver provides support for the Intel HID Event hotkey interface. - Some laptops require this driver for hotkey support. - - To compile this driver as a module, choose M here: the module will - be called intel_hid. - config INTEL_INT0002_VGPIO tristate "Intel ACPI INT0002 Virtual GPIO driver" depends on GPIOLIB && ACPI && PM_SLEEP
drivers/platform/x86/Makefile +1 -1
@@ -68,7 +68,7 @@ obj-$(CONFIG_THINKPAD_LMI) += think-lmi.o # Intel obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/ -obj-$(CONFIG_INTEL_HID_EVENT) += intel-hid.o + obj-$(CONFIG_INTEL_INT0002_VGPIO) += intel_int0002_vgpio.o obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.o obj-$(CONFIG_INTEL_OAKTRAIL) += intel_oaktrail.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -19,5 +19,6 @@ if X86_PLATFORM_DRIVERS_INTEL source "drivers/platform/x86/intel/int33fe/Kconfig" source "drivers/platform/x86/intel/int3472/Kconfig" source "drivers/platform/x86/intel/atomisp2/Kconfig" +source "drivers/platform/x86/intel/hid/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +2 -0
@@ -8,3 +8,5 @@ obj-$(CONFIG_INTEL_CHT_INT33FE) += int33fe/ obj-$(CONFIG_INTEL_SKL_INT3472) += int3472/ obj-$(CONFIG_INTEL_ATOMISP2_LED) += atomisp2/ obj-$(CONFIG_INTEL_ATOMISP2_PM) += atomisp2/ +obj-$(CONFIG_INTEL_HID_EVENT) += hid/ +
drivers/platform/x86/intel/hid/Kconfig new file +17 -0
@@ -0,0 +1,17 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Makefile for drivers/platform/x86/intel +# Intel x86 Platform-Specific Drivers +# + +config INTEL_HID_EVENT + tristate "INTEL HID Event" + depends on ACPI + depends on INPUT + select INPUT_SPARSEKMAP + help + This driver provides support for the Intel HID Event hotkey interface. + Some laptops require this driver for hotkey support. + + To compile this driver as a module, choose M here: the module will + be called intel_hid.
drivers/platform/x86/intel/hid/Makefile new file +7 -0
@@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Makefile for drivers/platform/x86/intel +# Intel x86 Platform-Specific Drivers +# + +obj-$(CONFIG_INTEL_HID_EVENT) += intel-hid.o
drivers/platform/x86/intel/hid/intel-hid.c renamed from drivers/platform/x86/intel-hid.c +0 -0
Signature · 1 line
2.31.1
PATCH 2/20 Move Intel WMI driver of pdx86 to intel/ directory to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 21 ---------------
drivers/platform/x86/Makefile | 2 --
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 3 ++-
drivers/platform/x86/intel/wmi/Kconfig | 26 +++++++++++++++++++
drivers/platform/x86/intel/wmi/Makefile | 7 +++++
.../{ => intel/wmi}/intel-wmi-sbl-fw-update.c | 0
.../{ => intel/wmi}/intel-wmi-thunderbolt.c | 0
8 files changed, 36 insertions(+), 24 deletions(-)
create mode 100644 drivers/platform/x86/intel/wmi/Kconfig
create mode 100644 drivers/platform/x86/intel/wmi/Makefile
rename drivers/platform/x86/{ => intel/wmi}/intel-wmi-sbl-fw-update.c (100%)
rename drivers/platform/x86/{ => intel/wmi}/intel-wmi-thunderbolt.c (100%)drivers/platform/x86/Kconfig +0 -21
@@ -77,27 +77,6 @@ config UV_SYSFS To compile this driver as a module, choose M here: the module will be called uv_sysfs. -config INTEL_WMI_SBL_FW_UPDATE - tristate "Intel WMI Slim Bootloader firmware update signaling driver" - depends on ACPI_WMI - help - Say Y here if you want to be able to use the WMI interface to signal - Slim Bootloader to trigger update on next reboot. - - To compile this driver as a module, choose M here: the module will - be called intel-wmi-sbl-fw-update. - -config INTEL_WMI_THUNDERBOLT - tristate "Intel WMI thunderbolt force power driver" - depends on ACPI_WMI - help - Say Y here if you want to be able to use the WMI interface on select - systems to force the power control of Intel Thunderbolt controllers. - This is useful for updating the firmware when devices are not plugged - into the controller. - - To compile this driver as a module, choose M here: the module will - be called intel-wmi-thunderbolt. config MXM_WMI tristate "WMI support for MXM Laptop Graphics"
drivers/platform/x86/Makefile +0 -2
@@ -10,8 +10,6 @@ obj-$(CONFIG_WMI_BMOF) += wmi-bmof.o # WMI drivers obj-$(CONFIG_HUAWEI_WMI) += huawei-wmi.o -obj-$(CONFIG_INTEL_WMI_SBL_FW_UPDATE) += intel-wmi-sbl-fw-update.o -obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += intel-wmi-thunderbolt.o obj-$(CONFIG_MXM_WMI) += mxm-wmi.o obj-$(CONFIG_PEAQ_WMI) += peaq-wmi.o obj-$(CONFIG_XIAOMI_WMI) += xiaomi-wmi.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -20,5 +20,6 @@ source "drivers/platform/x86/intel/int33fe/Kconfig" source "drivers/platform/x86/intel/int3472/Kconfig" source "drivers/platform/x86/intel/atomisp2/Kconfig" source "drivers/platform/x86/intel/hid/Kconfig" +source "drivers/platform/x86/intel/wmi/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +2 -1
@@ -9,4 +9,5 @@ obj-$(CONFIG_INTEL_SKL_INT3472) += int3472/ obj-$(CONFIG_INTEL_ATOMISP2_LED) += atomisp2/ obj-$(CONFIG_INTEL_ATOMISP2_PM) += atomisp2/ obj-$(CONFIG_INTEL_HID_EVENT) += hid/ - +obj-$(CONFIG_INTEL_WMI_SBL_FW_UPDATE) += wmi/ +obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += wmi/
drivers/platform/x86/intel/wmi/Kconfig new file +26 -0
@@ -0,0 +1,26 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_WMI_THUNDERBOLT + tristate "Intel WMI thunderbolt force power driver" + depends on ACPI_WMI + help + Say Y here if you want to be able to use the WMI interface on select + systems to force the power control of Intel Thunderbolt controllers. + This is useful for updating the firmware when devices are not plugged + into the controller. + + To compile this driver as a module, choose M here: the module will + be called intel-wmi-thunderbolt. + +config INTEL_WMI_SBL_FW_UPDATE + tristate "Intel WMI Slim Bootloader firmware update signaling driver" + depends on ACPI_WMI + help + Say Y here if you want to be able to use the WMI interface to signal + Slim Bootloader to trigger update on next reboot. + + To compile this driver as a module, choose M here: the module will + be called intel-wmi-sbl-fw-update.
drivers/platform/x86/intel/wmi/Makefile new file +7 -0
@@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_WMI_SBL_FW_UPDATE) += intel-wmi-sbl-fw-update.o +obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += intel-wmi-thunderbolt.o
drivers/platform/x86/intel/wmi/intel-wmi-sbl-fw-update.c renamed from drivers/platform/x86/intel-wmi-sbl-fw-update.c +0 -0
drivers/platform/x86/intel/wmi/intel-wmi-thunderbolt.c renamed from drivers/platform/x86/intel-wmi-thunderbolt.c +0 -0
Signature · 1 line
2.31.1
PATCH 3/20 Move Intel bxtwc driver of pdx86 to intel/ directory to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 9 ---------
drivers/platform/x86/Makefile | 2 +-
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 4 ++++
drivers/platform/x86/intel/bxtwc/Kconfig | 15 +++++++++++++++
drivers/platform/x86/intel/bxtwc/Makefile | 6 ++++++
.../x86/{ => intel/bxtwc}/intel_bxtwc_tmu.c | 0
7 files changed, 27 insertions(+), 10 deletions(-)
create mode 100644 drivers/platform/x86/intel/bxtwc/Kconfig
create mode 100644 drivers/platform/x86/intel/bxtwc/Makefile
rename drivers/platform/x86/{ => intel/bxtwc}/intel_bxtwc_tmu.c (100%)drivers/platform/x86/Kconfig +0 -9
@@ -1085,15 +1085,6 @@ config INTEL_UNCORE_FREQ_CONTROL To compile this driver as a module, choose M here: the module will be called intel-uncore-frequency. -config INTEL_BXTWC_PMIC_TMU - tristate "Intel BXT Whiskey Cove TMU Driver" - depends on REGMAP - depends on MFD_INTEL_PMC_BXT - depends on INTEL_SOC_PMIC_BXTWC - help - Select this driver to use Intel BXT Whiskey Cove PMIC TMU feature. - This driver enables the alarm wakeup functionality in the TMU unit - of Whiskey Cove PMIC. config INTEL_CHTDC_TI_PWRBTN tristate "Intel Cherry Trail Dollar Cove TI power button driver"
drivers/platform/x86/Makefile +1 -1
@@ -121,7 +121,7 @@ obj-$(CONFIG_INTEL_TURBO_MAX_3) += intel_turbo_max_3.o obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore-frequency.o # Intel PMIC / PMC / P-Unit devices -obj-$(CONFIG_INTEL_BXTWC_PMIC_TMU) += intel_bxtwc_tmu.o + obj-$(CONFIG_INTEL_CHTDC_TI_PWRBTN) += intel_chtdc_ti_pwrbtn.o obj-$(CONFIG_INTEL_MRFLD_PWRBTN) += intel_mrfld_pwrbtn.o obj-$(CONFIG_INTEL_PMC_CORE) += intel_pmc_core.o intel_pmc_core_pltdrv.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -21,5 +21,6 @@ source "drivers/platform/x86/intel/int3472/Kconfig" source "drivers/platform/x86/intel/atomisp2/Kconfig" source "drivers/platform/x86/intel/hid/Kconfig" source "drivers/platform/x86/intel/wmi/Kconfig" +source "drivers/platform/x86/intel/bxtwc/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +4 -0
@@ -11,3 +11,7 @@ obj-$(CONFIG_INTEL_ATOMISP2_PM) += atomisp2/ obj-$(CONFIG_INTEL_HID_EVENT) += hid/ obj-$(CONFIG_INTEL_WMI_SBL_FW_UPDATE) += wmi/ obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += wmi/ + + +# Intel PMIC / PMC / P-Unit devices +obj-$(CONFIG_INTEL_BXTWC_PMIC_TMU) += bxtwc/
drivers/platform/x86/intel/bxtwc/Kconfig new file +15 -0
@@ -0,0 +1,15 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + + +config INTEL_BXTWC_PMIC_TMU + tristate "Intel BXT Whiskey Cove TMU Driver" + depends on REGMAP + depends on MFD_INTEL_PMC_BXT + depends on INTEL_SOC_PMIC_BXTWC + help + Select this driver to use Intel BXT Whiskey Cove PMIC TMU feature. + This driver enables the alarm wakeup functionality in the TMU unit + of Whiskey Cove PMIC.
drivers/platform/x86/intel/bxtwc/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_BXTWC_PMIC_TMU) += intel_bxtwc_tmu.o
drivers/platform/x86/intel/bxtwc/intel_bxtwc_tmu.c renamed from drivers/platform/x86/intel_bxtwc_tmu.c +0 -0
Signature · 1 line
2.31.1
PATCH 4/20 Move Intel chtdc_ti driver of pdx86 to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 11 -----------
drivers/platform/x86/Makefile | 2 +-
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 3 ++-
drivers/platform/x86/intel/chtdc_ti/Kconfig | 16 ++++++++++++++++
drivers/platform/x86/intel/chtdc_ti/Makefile | 7 +++++++
.../{ => intel/chtdc_ti}/intel_chtdc_ti_pwrbtn.c | 0
7 files changed, 27 insertions(+), 13 deletions(-)
create mode 100644 drivers/platform/x86/intel/chtdc_ti/Kconfig
create mode 100644 drivers/platform/x86/intel/chtdc_ti/Makefile
rename drivers/platform/x86/{ => intel/chtdc_ti}/intel_chtdc_ti_pwrbtn.c (100%)drivers/platform/x86/Kconfig +0 -11
@@ -1086,17 +1086,6 @@ config INTEL_UNCORE_FREQ_CONTROL will be called intel-uncore-frequency. -config INTEL_CHTDC_TI_PWRBTN - tristate "Intel Cherry Trail Dollar Cove TI power button driver" - depends on INTEL_SOC_PMIC_CHTDC_TI - depends on INPUT - help - This option adds a power button driver driver for Dollar Cove TI - PMIC on Intel Cherry Trail devices. - - To compile this driver as a module, choose M here: the module - will be called intel_chtdc_ti_pwrbtn. - config INTEL_MRFLD_PWRBTN tristate "Intel Merrifield Basin Cove power button driver" depends on INTEL_SOC_PMIC_MRFLD
drivers/platform/x86/Makefile +1 -1
@@ -122,7 +122,7 @@ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore-frequency.o # Intel PMIC / PMC / P-Unit devices -obj-$(CONFIG_INTEL_CHTDC_TI_PWRBTN) += intel_chtdc_ti_pwrbtn.o + obj-$(CONFIG_INTEL_MRFLD_PWRBTN) += intel_mrfld_pwrbtn.o obj-$(CONFIG_INTEL_PMC_CORE) += intel_pmc_core.o intel_pmc_core_pltdrv.o obj-$(CONFIG_INTEL_PMT_CLASS) += intel_pmt_class.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -22,5 +22,6 @@ source "drivers/platform/x86/intel/atomisp2/Kconfig" source "drivers/platform/x86/intel/hid/Kconfig" source "drivers/platform/x86/intel/wmi/Kconfig" source "drivers/platform/x86/intel/bxtwc/Kconfig" +source "drivers/platform/x86/intel/chtdc_ti/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +2 -1
@@ -14,4 +14,5 @@ obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += wmi/ # Intel PMIC / PMC / P-Unit devices -obj-$(CONFIG_INTEL_BXTWC_PMIC_TMU) += bxtwc/ +obj-$(CONFIG_INTEL_BXTWC_PMIC_TMU) += bxtwc/ +obj-$(CONFIG_INTEL_CHTDC_TI_PWRBTN) += chtdc_ti/
drivers/platform/x86/intel/chtdc_ti/Kconfig new file +16 -0
@@ -0,0 +1,16 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + + +config INTEL_CHTDC_TI_PWRBTN + tristate "Intel Cherry Trail Dollar Cove TI power button driver" + depends on INTEL_SOC_PMIC_CHTDC_TI + depends on INPUT + help + This option adds a power button driver driver for Dollar Cove TI + PMIC on Intel Cherry Trail devices. + + To compile this driver as a module, choose M here: the module + will be called intel_chtdc_ti_pwrbtn.
drivers/platform/x86/intel/chtdc_ti/Makefile new file +7 -0
@@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + + +obj-$(CONFIG_INTEL_CHTDC_TI_PWRBTN) += intel_chtdc_ti_pwrbtn.o
drivers/platform/x86/intel/chtdc_ti/intel_chtdc_ti_pwrbtn.c renamed from drivers/platform/x86/intel_chtdc_ti_pwrbtn.c +0 -0
Signature · 1 line
2.31.1
PATCH 5/20 Move MRFLD power button driver of pdx86 to intel directory to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 11 -----------
drivers/platform/x86/Makefile | 2 +-
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 3 ++-
drivers/platform/x86/intel/mrfld/Kconfig | 17 +++++++++++++++++
drivers/platform/x86/intel/mrfld/Makefile | 6 ++++++
.../x86/{ => intel/mrfld}/intel_mrfld_pwrbtn.c | 0
7 files changed, 27 insertions(+), 13 deletions(-)
create mode 100644 drivers/platform/x86/intel/mrfld/Kconfig
create mode 100644 drivers/platform/x86/intel/mrfld/Makefile
rename drivers/platform/x86/{ => intel/mrfld}/intel_mrfld_pwrbtn.c (100%)drivers/platform/x86/Kconfig +0 -11
@@ -1086,17 +1086,6 @@ config INTEL_UNCORE_FREQ_CONTROL will be called intel-uncore-frequency. -config INTEL_MRFLD_PWRBTN - tristate "Intel Merrifield Basin Cove power button driver" - depends on INTEL_SOC_PMIC_MRFLD - depends on INPUT - help - This option adds a power button driver for Basin Cove PMIC - on Intel Merrifield devices. - - To compile this driver as a module, choose M here: the module - will be called intel_mrfld_pwrbtn. - config INTEL_PMC_CORE tristate "Intel PMC Core driver" depends on PCI
drivers/platform/x86/Makefile +1 -1
@@ -123,7 +123,7 @@ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore-frequency.o # Intel PMIC / PMC / P-Unit devices -obj-$(CONFIG_INTEL_MRFLD_PWRBTN) += intel_mrfld_pwrbtn.o + obj-$(CONFIG_INTEL_PMC_CORE) += intel_pmc_core.o intel_pmc_core_pltdrv.o obj-$(CONFIG_INTEL_PMT_CLASS) += intel_pmt_class.o obj-$(CONFIG_INTEL_PMT_TELEMETRY) += intel_pmt_telemetry.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -23,5 +23,6 @@ source "drivers/platform/x86/intel/hid/Kconfig" source "drivers/platform/x86/intel/wmi/Kconfig" source "drivers/platform/x86/intel/bxtwc/Kconfig" source "drivers/platform/x86/intel/chtdc_ti/Kconfig" +source "drivers/platform/x86/intel/mrfld/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +2 -1
@@ -15,4 +15,5 @@ obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += wmi/ # Intel PMIC / PMC / P-Unit devices obj-$(CONFIG_INTEL_BXTWC_PMIC_TMU) += bxtwc/ -obj-$(CONFIG_INTEL_CHTDC_TI_PWRBTN) += chtdc_ti/ +obj-$(CONFIG_INTEL_CHTDC_TI_PWRBTN) += chtdc_ti/ +obj-$(CONFIG_INTEL_MRFLD_PWRBTN) += mrfld/
drivers/platform/x86/intel/mrfld/Kconfig new file +17 -0
@@ -0,0 +1,17 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + + + +config INTEL_MRFLD_PWRBTN + tristate "Intel Merrifield Basin Cove power button driver" + depends on INTEL_SOC_PMIC_MRFLD + depends on INPUT + help + This option adds a power button driver for Basin Cove PMIC + on Intel Merrifield devices. + + To compile this driver as a module, choose M here: the module + will be called intel_mrfld_pwrbtn.
drivers/platform/x86/intel/mrfld/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_MRFLD_PWRBTN) += intel_mrfld_pwrbtn.o
drivers/platform/x86/intel/mrfld/intel_mrfld_pwrbtn.c renamed from drivers/platform/x86/intel_mrfld_pwrbtn.c +0 -0
Signature · 1 line
2.31.1
PATCH 6/20 Move Intel PMC core of pdx86 to intel/ directory to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 20 --------------
drivers/platform/x86/Makefile | 2 --
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 3 ++-
drivers/platform/x86/intel/pmc_core/Kconfig | 26 +++++++++++++++++++
drivers/platform/x86/intel/pmc_core/Makefile | 6 +++++
.../x86/{ => intel/pmc_core}/intel_pmc_core.c | 0
.../x86/{ => intel/pmc_core}/intel_pmc_core.h | 0
.../pmc_core}/intel_pmc_core_pltdrv.c | 0
9 files changed, 35 insertions(+), 23 deletions(-)
create mode 100644 drivers/platform/x86/intel/pmc_core/Kconfig
create mode 100644 drivers/platform/x86/intel/pmc_core/Makefile
rename drivers/platform/x86/{ => intel/pmc_core}/intel_pmc_core.c (100%)
rename drivers/platform/x86/{ => intel/pmc_core}/intel_pmc_core.h (100%)
rename drivers/platform/x86/{ => intel/pmc_core}/intel_pmc_core_pltdrv.c (100%)drivers/platform/x86/Kconfig +0 -20
@@ -1086,26 +1086,6 @@ config INTEL_UNCORE_FREQ_CONTROL will be called intel-uncore-frequency. -config INTEL_PMC_CORE - tristate "Intel PMC Core driver" - depends on PCI - depends on ACPI - help - The Intel Platform Controller Hub for Intel Core SoCs provides access - to Power Management Controller registers via various interfaces. This - driver can utilize debugging capabilities and supported features as - exposed by the Power Management Controller. It also may perform some - tasks in the PMC in order to enable transition into the SLPS0 state. - It should be selected on all Intel platforms supported by the driver. - - Supported features: - - SLP_S0_RESIDENCY counter - - PCH IP Power Gating status - - LTR Ignore / LTR Show - - MPHY/PLL gating status (Sunrisepoint PCH only) - - SLPS0 Debug registers (Cannonlake/Icelake PCH) - - Low Power Mode registers (Tigerlake and beyond) - - PMC quirks as needed to enable SLPS0/S0ix config INTEL_PMT_CLASS tristate
drivers/platform/x86/Makefile +0 -2
@@ -123,8 +123,6 @@ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore-frequency.o # Intel PMIC / PMC / P-Unit devices - -obj-$(CONFIG_INTEL_PMC_CORE) += intel_pmc_core.o intel_pmc_core_pltdrv.o obj-$(CONFIG_INTEL_PMT_CLASS) += intel_pmt_class.o obj-$(CONFIG_INTEL_PMT_TELEMETRY) += intel_pmt_telemetry.o obj-$(CONFIG_INTEL_PMT_CRASHLOG) += intel_pmt_crashlog.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -24,5 +24,6 @@ source "drivers/platform/x86/intel/wmi/Kconfig" source "drivers/platform/x86/intel/bxtwc/Kconfig" source "drivers/platform/x86/intel/chtdc_ti/Kconfig" source "drivers/platform/x86/intel/mrfld/Kconfig" +source "drivers/platform/x86/intel/pmc_core/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +2 -1
@@ -16,4 +16,5 @@ obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += wmi/ # Intel PMIC / PMC / P-Unit devices obj-$(CONFIG_INTEL_BXTWC_PMIC_TMU) += bxtwc/ obj-$(CONFIG_INTEL_CHTDC_TI_PWRBTN) += chtdc_ti/ -obj-$(CONFIG_INTEL_MRFLD_PWRBTN) += mrfld/ +obj-$(CONFIG_INTEL_MRFLD_PWRBTN) += mrfld/ +obj-$(CONFIG_INTEL_PMC_CORE) += pmc_core/
drivers/platform/x86/intel/pmc_core/Kconfig new file +26 -0
@@ -0,0 +1,26 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + + +config INTEL_PMC_CORE + tristate "Intel PMC Core driver" + depends on PCI + depends on ACPI + help + The Intel Platform Controller Hub for Intel Core SoCs provides access + to Power Management Controller registers via various interfaces. This + driver can utilize debugging capabilities and supported features as + exposed by the Power Management Controller. It also may perform some + tasks in the PMC in order to enable transition into the SLPS0 state. + It should be selected on all Intel platforms supported by the driver. + + Supported features: + - SLP_S0_RESIDENCY counter + - PCH IP Power Gating status + - LTR Ignore / LTR Show + - MPHY/PLL gating status (Sunrisepoint PCH only) + - SLPS0 Debug registers (Cannonlake/Icelake PCH) + - Low Power Mode registers (Tigerlake and beyond) + - PMC quirks as needed to enable SLPS0/S0ix
drivers/platform/x86/intel/pmc_core/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_PMC_CORE) += intel_pmc_core.o intel_pmc_core_pltdrv.o
drivers/platform/x86/intel/pmc_core/intel_pmc_core.c renamed from drivers/platform/x86/intel_pmc_core.c +0 -0
drivers/platform/x86/intel/pmc_core/intel_pmc_core.h renamed from drivers/platform/x86/intel_pmc_core.h +0 -0
drivers/platform/x86/intel/pmc_core/intel_pmc_core_pltdrv.c renamed from drivers/platform/x86/intel_pmc_core_pltdrv.c +0 -0
Signature · 1 line
2.31.1
PATCH 7/20 Move Intel PMT driver of pdx86 to intel/ to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Makefile | 4 +-
drivers/platform/x86/intel/Kconfig | 2 +
drivers/platform/x86/intel/Makefile | 3 ++
drivers/platform/x86/intel/pmt/Kconfig | 41 +++++++++++++++++++
drivers/platform/x86/intel/pmt/Makefile | 9 ++++
.../x86/{ => intel/pmt}/intel_pmt_class.c | 0
.../x86/{ => intel/pmt}/intel_pmt_class.h | 0
.../x86/{ => intel/pmt}/intel_pmt_crashlog.c | 0
.../x86/{ => intel/pmt}/intel_pmt_telemetry.c | 0
9 files changed, 56 insertions(+), 3 deletions(-)
create mode 100644 drivers/platform/x86/intel/pmt/Kconfig
create mode 100644 drivers/platform/x86/intel/pmt/Makefile
rename drivers/platform/x86/{ => intel/pmt}/intel_pmt_class.c (100%)
rename drivers/platform/x86/{ => intel/pmt}/intel_pmt_class.h (100%)
rename drivers/platform/x86/{ => intel/pmt}/intel_pmt_crashlog.c (100%)
rename drivers/platform/x86/{ => intel/pmt}/intel_pmt_telemetry.c (100%)drivers/platform/x86/Makefile +1 -3
@@ -123,9 +123,7 @@ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore-frequency.o # Intel PMIC / PMC / P-Unit devices -obj-$(CONFIG_INTEL_PMT_CLASS) += intel_pmt_class.o -obj-$(CONFIG_INTEL_PMT_TELEMETRY) += intel_pmt_telemetry.o -obj-$(CONFIG_INTEL_PMT_CRASHLOG) += intel_pmt_crashlog.o + obj-$(CONFIG_INTEL_PUNIT_IPC) += intel_punit_ipc.o obj-$(CONFIG_INTEL_SCU_IPC) += intel_scu_ipc.o obj-$(CONFIG_INTEL_SCU_PCI) += intel_scu_pcidrv.o
drivers/platform/x86/intel/Kconfig +2 -0
@@ -25,5 +25,7 @@ source "drivers/platform/x86/intel/bxtwc/Kconfig" source "drivers/platform/x86/intel/chtdc_ti/Kconfig" source "drivers/platform/x86/intel/mrfld/Kconfig" source "drivers/platform/x86/intel/pmc_core/Kconfig" +source "drivers/platform/x86/intel/pmt/Kconfig" + endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +3 -0
@@ -18,3 +18,6 @@ obj-$(CONFIG_INTEL_BXTWC_PMIC_TMU) += bxtwc/ obj-$(CONFIG_INTEL_CHTDC_TI_PWRBTN) += chtdc_ti/ obj-$(CONFIG_INTEL_MRFLD_PWRBTN) += mrfld/ obj-$(CONFIG_INTEL_PMC_CORE) += pmc_core/ +obj-$(CONFIG_INTEL_PMT_CLASS) += pmt/ +obj-$(CONFIG_INTEL_PMT_TELEMETRY) += pmt/ +obj-$(CONFIG_INTEL_PMT_CRASHLOG) += pmt/
drivers/platform/x86/intel/pmt/Kconfig new file +41 -0
41 lines not on this page · raw message
drivers/platform/x86/intel/pmt/Makefile new file +9 -0
@@ -0,0 +1,9 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + + +obj-$(CONFIG_INTEL_PMT_CLASS) += intel_pmt_class.o +obj-$(CONFIG_INTEL_PMT_TELEMETRY) += intel_pmt_telemetry.o +obj-$(CONFIG_INTEL_PMT_CRASHLOG) += intel_pmt_crashlog.o
drivers/platform/x86/intel/pmt/intel_pmt_class.c renamed from drivers/platform/x86/intel_pmt_class.c +0 -0
drivers/platform/x86/intel/pmt/intel_pmt_class.h renamed from drivers/platform/x86/intel_pmt_class.h +0 -0
drivers/platform/x86/intel/pmt/intel_pmt_crashlog.c renamed from drivers/platform/x86/intel_pmt_crashlog.c +0 -0
drivers/platform/x86/intel/pmt/intel_pmt_telemetry.c renamed from drivers/platform/x86/intel_pmt_telemetry.c +0 -0
Signature · 1 line
2.31.1
David E. Box
maintainerRe: [PATCH 07/20] Move Intel PMT driver of pdx86 to intel/ to improve readability.
Quoted 1 line · Kate Hsuan
Signed-off-by Kate Hsuan <[email protected]>
Already done for these drivers in pdx86 for-next. Thanks.
Quoted 159 lines
---
drivers/platform/x86/Makefile | 4 +- drivers/platform/x86/intel/Kconfig | 2 + drivers/platform/x86/intel/Makefile | 3 ++ drivers/platform/x86/intel/pmt/Kconfig | 41
+++++++++++++++++++
drivers/platform/x86/intel/pmt/Makefile | 9 ++++ .../x86/{ => intel/pmt}/intel_pmt_class.c | 0 .../x86/{ => intel/pmt}/intel_pmt_class.h | 0 .../x86/{ => intel/pmt}/intel_pmt_crashlog.c | 0 .../x86/{ =>intel/pmt}/intel_pmt_telemetry.c| 09 files changed, 56 insertions(+), 3 deletions(-)create mode 100644
drivers/platform/x86/intel/pmt/Kconfigcreate mode 100644drivers/platform/x86/intel/pmt/Makefilerenamedrivers/platform/x86/{=>intel/pmt}/intel_pmt_class.c(100%) renamedrivers/platform/x86/{=>intel/pmt}/intel_pmt_class.h(100%) renamedrivers/platform/x86/{=>intel/pmt}/intel_pmt_crashlog.c(100%)
renamedrivers/platform/x86/{=>intel/pmt}/intel_pmt_telemetry.c(100%)drivers/platform/x86/Makefile +0
-0@@ -123,9 +123,7 @@ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore- frequency.o
# Intel PMIC / PMC / P-Unit devicesdrivers/platform/x86/Makefile +1
-3-obj-$(CONFIG_INTEL_PMT_CLASS) += intel_pmt_class.o -obj-$(CONFIG_INTEL_PMT_TELEMETRY) += intel_pmt_telemetry.o -obj-$(CONFIG_INTEL_PMT_CRASHLOG) += intel_pmt_crashlog.o +obj-$(CONFIG_INTEL_PUNIT_IPC) += intel_punit_ipc.o obj-$(CONFIG_INTEL_SCU_IPC) += intel_scu_ipc.o obj-$(CONFIG_INTEL_SCU_PCI) += intel_scu_pcidrv.o
drivers/platform/x86/intel/Kconfig +0
-0@@ -25,5 +25,7 @@ source "drivers/platform/x86/intel/bxtwc/Kconfig"source "
drivers/platform/x86/intel/chtdc_ti/Kconfig" source "drivers/platform/x86/intel/mrfld/Kconfig" source "drivers/platform/x86/intel/pmc_core/Kconfig"drivers/platform/x86/intel/Kconfig +2
-0+source "drivers/platform/x86/intel/pmt/Kconfig" +
endif #X86_PLATFORM_DRIVERS_INTELdrivers/platform/x86/intel/Makefile +0
-0@@ -18,3 +18,6 @@ obj-$(CONFIG_INTEL_BXTWC_PMIC_TMU) += bxtwc/obj-$(CONFIG_INTEL_CHTDC_TI_PWRBTN) += chtdc_ti/ obj-$(CONFIG_INTEL_MRFLD_PWRBTN) += mrfld/ obj-$(CONFIG_INTEL_PMC_CORE) += pmc_core/
drivers/platform/x86/intel/Makefile +3
-0+obj-$(CONFIG_INTEL_PMT_CLASS) += pmt/ +obj-$(CONFIG_INTEL_PMT_TELEMETRY) += pmt/ +obj-$(CONFIG_INTEL_PMT_CRASHLOG) += pmt/drivers/platform/x86/intel/pmt/Kconfig new file +9
-0@@ -0,0 +1,41 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_PMT_CLASS + tristate + help + The Intel Platform Monitoring Technology (PMT) class driverprovides
+ the basic sysfs interface and file hierarchy used by PMT devices.drivers/platform/x86/intel/pmt/Kconfig new file +5
-0+ + For more information, see: + <file:Documentation/ABI/testing/sysfs-class-intel_pmt> + + To compile this driver as a module, choose M here: themodule
+ will be calledintel_pmt_class.drivers/platform/x86/intel/pmt/Kconfig new file +3
-0+ +config INTEL_PMT_TELEMETRY + tristate "Intel Platform Monitoring Technology (PMT)Telemetry driver"
+ depends onMFD_INTEL_PMT
+ selectINTEL_PMT_CLASS
+ help
+ The Intel Platform Monitory Technology (PMT) Telemetry driver provides
+ access to hardware telemetry metrics on devices that support the
+ feature.
+
+ To compile this driver as a module, choose M here: the module
+ will be calledintel_pmt_telemetry.drivers/platform/x86/intel/pmt/Kconfig new file +3
-0+ +config INTEL_PMT_CRASHLOG + tristate "Intel Platform Monitoring Technology (PMT) Crashlogdriver"
+ depends onMFD_INTEL_PMT
+ selectINTEL_PMT_CLASS
+ help
+ The Intel Platform Monitoring Technology (PMT) crashlog driver provides
+ access to hardware crashlog capabilities on devices that support the
+ feature.
+
+ To compile this driver as a module, choose M here: the module
+ will be calledintel_pmt_crashlog.drivers/platform/x86/intel/pmt/Kconfig new file +1
-0+drivers/platform/x86/intel/pmt/Makefile new file +9
-0@@ -0,0 +1,9 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + + +obj-$(CONFIG_INTEL_PMT_CLASS) += intel_pmt_class.o +obj-$(CONFIG_INTEL_PMT_TELEMETRY) += intel_pmt_telemetry.o +obj-$(CONFIG_INTEL_PMT_CRASHLOG) += intel_pmt_crashlog.odrivers/platform/x86/intel/pmt/intel_pmt_class.c renamed from drivers/platform/x86/intel_pmt_class.c +0
-0drivers/platform/x86/intel/pmt/intel_pmt_class.h renamed from drivers/platform/x86/intel_pmt_class.h +0
-0drivers/platform/x86/intel/pmt/intel_pmt_crashlog.c renamed from drivers/platform/x86/intel_pmt_crashlog.c +0
-0drivers/platform/x86/intel/pmt/intel_pmt_telemetry.c renamed from drivers/platform/x86/intel_pmt_telemetry.c +0
-0
PATCH 8/20 Move Intel P-Unit of pdx86 to intel/ directory to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 43 -------------------
drivers/platform/x86/Makefile | 2 +-
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 1 +
drivers/platform/x86/intel/punit/Kconfig | 10 +++++
drivers/platform/x86/intel/punit/Makefile | 6 +++
.../x86/{ => intel/punit}/intel_punit_ipc.c | 0
7 files changed, 19 insertions(+), 44 deletions(-)
create mode 100644 drivers/platform/x86/intel/punit/Kconfig
create mode 100644 drivers/platform/x86/intel/punit/Makefile
rename drivers/platform/x86/{ => intel/punit}/intel_punit_ipc.c (100%)drivers/platform/x86/Kconfig +0 -43
@@ -1086,49 +1086,6 @@ config INTEL_UNCORE_FREQ_CONTROL will be called intel-uncore-frequency. - -config INTEL_PMT_CLASS - tristate - help - The Intel Platform Monitoring Technology (PMT) class driver provides - the basic sysfs interface and file hierarchy used by PMT devices. - - For more information, see: - <file:Documentation/ABI/testing/sysfs-class-intel_pmt> - - To compile this driver as a module, choose M here: the module - will be called intel_pmt_class. - -config INTEL_PMT_TELEMETRY - tristate "Intel Platform Monitoring Technology (PMT) Telemetry driver" - depends on MFD_INTEL_PMT - select INTEL_PMT_CLASS - help - The Intel Platform Monitory Technology (PMT) Telemetry driver provides - access to hardware telemetry metrics on devices that support the - feature. - - To compile this driver as a module, choose M here: the module - will be called intel_pmt_telemetry. - -config INTEL_PMT_CRASHLOG - tristate "Intel Platform Monitoring Technology (PMT) Crashlog driver" - depends on MFD_INTEL_PMT - select INTEL_PMT_CLASS - help - The Intel Platform Monitoring Technology (PMT) crashlog driver provides - access to hardware crashlog capabilities on devices that support the - feature. - - To compile this driver as a module, choose M here: the module - will be called intel_pmt_crashlog. - -config INTEL_PUNIT_IPC - tristate "Intel P-Unit IPC Driver" - help - This driver provides support for Intel P-Unit Mailbox IPC mechanism, - which is used to bridge the communications between kernel and P-Unit. - config INTEL_SCU_IPC bool
drivers/platform/x86/Makefile +1 -1
@@ -124,7 +124,7 @@ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore-frequency.o -obj-$(CONFIG_INTEL_PUNIT_IPC) += intel_punit_ipc.o + obj-$(CONFIG_INTEL_SCU_IPC) += intel_scu_ipc.o obj-$(CONFIG_INTEL_SCU_PCI) += intel_scu_pcidrv.o obj-$(CONFIG_INTEL_SCU_PLATFORM) += intel_scu_pltdrv.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -26,6 +26,7 @@ source "drivers/platform/x86/intel/chtdc_ti/Kconfig" source "drivers/platform/x86/intel/mrfld/Kconfig" source "drivers/platform/x86/intel/pmc_core/Kconfig" source "drivers/platform/x86/intel/pmt/Kconfig" +source "drivers/platform/x86/intel/punit/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +1 -0
@@ -21,3 +21,4 @@ obj-$(CONFIG_INTEL_PMC_CORE) += pmc_core/ obj-$(CONFIG_INTEL_PMT_CLASS) += pmt/ obj-$(CONFIG_INTEL_PMT_TELEMETRY) += pmt/ obj-$(CONFIG_INTEL_PMT_CRASHLOG) += pmt/ +obj-$(CONFIG_INTEL_PUNIT_IPC) += punit/
drivers/platform/x86/intel/punit/Kconfig new file +10 -0
@@ -0,0 +1,10 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# X86 Platform Specific Drivers +# + +config INTEL_PUNIT_IPC + tristate "Intel P-Unit IPC Driver" + help + This driver provides support for Intel P-Unit Mailbox IPC mechanism, + which is used to bridge the communications between kernel and P-Unit.
drivers/platform/x86/intel/punit/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# X86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_PUNIT_IPC) += intel_punit_ipc.o
drivers/platform/x86/intel/punit/intel_punit_ipc.c renamed from drivers/platform/x86/intel_punit_ipc.c +0 -0
Signature · 1 line
2.31.1
David E. Box
maintainerRe: [PATCH 08/20] Move Intel P-Unit of pdx86 to intel/ directory to improve readability.
Hi,
Quoted 65 lines · Kate Hsuan
Signed-off-by Kate Hsuan <[email protected]>---
drivers/platform/x86/Kconfig | 43 ----------------- --
drivers/platform/x86/Makefile | 2 +- drivers/platform/x86/intel/Kconfig | 1 + drivers/platform/x86/intel/Makefile | 1 + drivers/platform/x86/intel/punit/Kconfig | 10 +++++ drivers/platform/x86/intel/punit/Makefile | 6 +++ .../x86/{ => intel/punit}/intel_punit_ipc.c | 07 files changed, 19 insertions(+), 44 deletions(-)create mode 100644
drivers/platform/x86/intel/punit/Kconfigcreate mode 100644drivers/platform/x86/intel/punit/Makefilerenamedrivers/platform/x86/{=>intel/punit}/intel_punit_ipc.c(100%)drivers/platform/x86/Kconfig +0
-0@@ -1086,49 +1086,6 @@ config INTEL_UNCORE_FREQ_CONTROLwill be called intel-uncore-frequency.
drivers/platform/x86/Kconfig +0
-5- -config INTEL_PMT_CLASS - tristate - help - The Intel Platform Monitoring Technology (PMT) class driverprovides
- the basic sysfs interface and file hierarchy used by PMT devices.drivers/platform/x86/Kconfig +0
-5- - For more information, see: - <file:Documentation/ABI/testing/sysfs-class-intel_pmt> - - To compile this driver as a module, choose M here: themodule
- will be calledintel_pmt_class.drivers/platform/x86/Kconfig +0
-3- -config INTEL_PMT_TELEMETRY - tristate "Intel Platform Monitoring Technology (PMT)Telemetry driver"
- depends onMFD_INTEL_PMT
- selectINTEL_PMT_CLASS
- help
- The Intel Platform Monitory Technology (PMT) Telemetry driver provides
- access to hardware telemetry metrics on devices that support the
- feature.
-
- To compile this driver as a module, choose M here: the module
- will be calledintel_pmt_telemetry.drivers/platform/x86/Kconfig +0
-3- -config INTEL_PMT_CRASHLOG - tristate "Intel Platform Monitoring Technology (PMT) Crashlogdriver"
- depends onMFD_INTEL_PMT
- selectINTEL_PMT_CLASS
- help
- The Intel Platform Monitoring Technology (PMT) crashlog driver provides
Quoted 8 lines
- access to hardware crashlog capabilities on devices that support the
- feature.
-
- To compile this driver as a module, choose M here: the module
- will be calledintel_pmt_crashlog.
-
Accidentally caught the above configs not part of P-Unit IPC driver.
Quoted 89 lines
-config
INTEL_PUNIT_IPC
- tristate "Intel P-Unit IPC Driver"
- help
- This driver provides support for Intel P-Unit Mailbox IPC mechanism,
- which is used to bridge the communications between kernel and P-Unit.
-
configINTEL_SCU_IPC
booldrivers/platform/x86/Makefile +0
-0@@ -124,7 +124,7 @@ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore- frequency.o
drivers/platform/x86/Makefile +1
-1-obj-$(CONFIG_INTEL_PUNIT_IPC) += intel_punit_ipc.o +obj-$(CONFIG_INTEL_SCU_IPC) += intel_scu_ipc.o obj-$(CONFIG_INTEL_SCU_PCI) += intel_scu_pcidrv.o obj-$(CONFIG_INTEL_SCU_PLATFORM) += intel_scu_pltdrv.o
drivers/platform/x86/intel/Kconfig +0
-0@@ -26,6 +26,7 @@ source"
drivers/platform/x86/intel/chtdc_ti/Kconfig" source "drivers/platform/x86/intel/mrfld/Kconfig" source "drivers/platform/x86/intel/pmc_core/Kconfig" source "drivers/platform/x86/intel/pmt/Kconfig" +source "drivers/platform/x86/intel/punit/Kconfig"
endif #X86_PLATFORM_DRIVERS_INTELdrivers/platform/x86/intel/Makefile +0
-0@@ -21,3 +21,4 @@ obj-$(CONFIG_INTEL_PMC_CORE) += pmc_core/obj-$(CONFIG_INTEL_PMT_CLASS) += pmt/
obj-$(CONFIG_INTEL_PMT_TELEMETRY) += pmt/
obj-$(CONFIG_INTEL_PMT_CRASHLOG) += pmt/drivers/platform/x86/intel/Makefile +1
-0+obj-$(CONFIG_INTEL_PUNIT_IPC) += punit/drivers/platform/x86/intel/punit/Kconfig new file +9
-0@@ -0,0 +1,10 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# X86 Platform Specific Drivers +# + +config INTEL_PUNIT_IPC + tristate "Intel P-Unit IPC Driver" + help + This driver provides support for Intel P-Unit Mailbox IPCmechanism,
+ which is used to bridge the communications between kernel and P-Unit.drivers/platform/x86/intel/punit/Makefile new file +6
-0@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# X86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_PUNIT_IPC) += intel_punit_ipc.odrivers/platform/x86/intel/punit/intel_punit_ipc.c renamed from drivers/platform/x86/intel_punit_ipc.c +0
-0
Re: [PATCH 08/20] Move Intel P-Unit of pdx86 to intel/ directory to improve readability.
Some commit mistakes. I'll correct this.
Thank you. :)
Quoted 171 lines · David E. Box
Hi,
Quoted 71 lines · Kate Hsuan
Signed-off-by Kate Hsuan <[email protected]>--- drivers/platform/x86/Kconfig | 43 ----------------- -- drivers/platform/x86/Makefile | 2 +- drivers/platform/x86/intel/Kconfig | 1 + drivers/platform/x86/intel/Makefile | 1 + drivers/platform/x86/intel/punit/Kconfig | 10 +++++ drivers/platform/x86/intel/punit/Makefile | 6 +++ .../x86/{ => intel/punit}/intel_punit_ipc.c | 0 7 files changed, 19 insertions(+), 44 deletions(-) create mode 100644 drivers/platform/x86/intel/punit/Kconfig create mode 100644 drivers/platform/x86/intel/punit/Makefile rename drivers/platform/x86/{ => intel/punit}/intel_punit_ipc.c(100%)
drivers/platform/x86/Kconfig +0
-5@@ -1086,49 +1086,6 @@ config INTEL_UNCORE_FREQ_CONTROL will be called intel-uncore-frequency. - -config INTEL_PMT_CLASS - tristate - help - The Intel Platform Monitoring Technology (PMT) class driverprovides
- the basic sysfs interface and file hierarchy used by PMT
devices.drivers/platform/x86/Kconfig +0
-5- - For more information, see: - <file:Documentation/ABI/testing/sysfs-class-intel_pmt> - - To compile this driver as a module, choose M here: themodule
drivers/platform/x86/Kconfig +0
-4- will be called intel_pmt_class. - -config INTEL_PMT_TELEMETRY - tristate "Intel Platform Monitoring Technology (PMT)Telemetry driver"
drivers/platform/x86/Kconfig +0
-4- depends on MFD_INTEL_PMT - select INTEL_PMT_CLASS - help - The Intel Platform Monitory Technology (PMT) Telemetrydriver provides
- access to hardware telemetry metrics on devices that
support thedrivers/platform/x86/Kconfig +0
-3- feature. - - To compile this driver as a module, choose M here: themodule
drivers/platform/x86/Kconfig +0
-4- will be called intel_pmt_telemetry. - -config INTEL_PMT_CRASHLOG - tristate "Intel Platform Monitoring Technology (PMT) Crashlogdriver"
drivers/platform/x86/Kconfig +0
-4- depends on MFD_INTEL_PMT - select INTEL_PMT_CLASS - help - The Intel Platform Monitoring Technology (PMT) crashlogdriver provides
- access to hardware crashlog capabilities on devices that
support thedrivers/platform/x86/Kconfig +0
-3- feature. - - To compile this driver as a module, choose M here: themodule
drivers/platform/x86/Kconfig
Quoted 2 lines
drivers/platform/x86/Kconfig +0
-2- will be called intel_pmt_crashlog. -Accidentally caught the above configs not part of P-Unit IPC driver.
Quoted 89 lines
drivers/platform/x86/Kconfig +0
-4-config INTEL_PUNIT_IPC - tristate "Intel P-Unit IPC Driver" - help - This driver provides support for Intel P-Unit Mailbox IPCmechanism,
- which is used to bridge the communications between kernel
and P-Unit.drivers/platform/x86/Kconfig +0
-1- config INTEL_SCU_IPC booldrivers/platform/x86/Makefile +0
-0@@ -124,7 +124,7 @@ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore-
frequency.odrivers/platform/x86/Makefile +1
-1-obj-$(CONFIG_INTEL_PUNIT_IPC) += intel_punit_ipc.o + obj-$(CONFIG_INTEL_SCU_IPC) += intel_scu_ipc.o obj-$(CONFIG_INTEL_SCU_PCI) += intel_scu_pcidrv.o obj-$(CONFIG_INTEL_SCU_PLATFORM) += intel_scu_pltdrv.odrivers/platform/x86/intel/Kconfig +0
-0@@ -26,6 +26,7 @@ source"
drivers/platform/x86/intel/chtdc_ti/Kconfig"
source "drivers/platform/x86/intel/mrfld/Kconfig" source "drivers/platform/x86/intel/pmc_core/Kconfig" source "drivers/platform/x86/intel/pmt/Kconfig"drivers/platform/x86/intel/Kconfig +1
-0+source "drivers/platform/x86/intel/punit/Kconfig" endif # X86_PLATFORM_DRIVERS_INTELdrivers/platform/x86/intel/Makefile +1
-0@@ -21,3 +21,4 @@ obj-$(CONFIG_INTEL_PMC_CORE) += pmc_core/ obj-$(CONFIG_INTEL_PMT_CLASS) += pmt/ obj-$(CONFIG_INTEL_PMT_TELEMETRY) += pmt/ obj-$(CONFIG_INTEL_PMT_CRASHLOG) += pmt/ +obj-$(CONFIG_INTEL_PUNIT_IPC) += punit/drivers/platform/x86/intel/punit/Kconfig new file +9
-0@@ -0,0 +1,10 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# X86 Platform Specific Drivers +# + +config INTEL_PUNIT_IPC + tristate "Intel P-Unit IPC Driver" + help + This driver provides support for Intel P-Unit Mailbox IPCmechanism,
+ which is used to bridge the communications between kernel
and P-Unit.drivers/platform/x86/intel/punit/Makefile new file +6
-0@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# X86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_PUNIT_IPC) += intel_punit_ipc.odrivers/platform/x86/intel/punit/intel_punit_ipc.c renamed from drivers/platform/x86/intel_punit_ipc.c +0
-0
PATCH 9/20 Move Intel SCU IPC of pdx86 to intel directory to increase readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 47 -----------------
drivers/platform/x86/Makefile | 6 +--
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 5 ++
drivers/platform/x86/intel/scu/Kconfig | 52 +++++++++++++++++++
drivers/platform/x86/intel/scu/Makefile | 11 ++++
.../x86/{ => intel/scu}/intel_scu_ipc.c | 0
.../x86/{ => intel/scu}/intel_scu_ipcutil.c | 0
.../x86/{ => intel/scu}/intel_scu_pcidrv.c | 0
.../x86/{ => intel/scu}/intel_scu_pltdrv.c | 0
.../x86/{ => intel/scu}/intel_scu_wdt.c | 0
11 files changed, 70 insertions(+), 52 deletions(-)
create mode 100644 drivers/platform/x86/intel/scu/Kconfig
create mode 100644 drivers/platform/x86/intel/scu/Makefile
rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipc.c (100%)
rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipcutil.c (100%)
rename drivers/platform/x86/{ => intel/scu}/intel_scu_pcidrv.c (100%)
rename drivers/platform/x86/{ => intel/scu}/intel_scu_pltdrv.c (100%)
rename drivers/platform/x86/{ => intel/scu}/intel_scu_wdt.c (100%)drivers/platform/x86/Kconfig +0 -47
@@ -1086,53 +1086,6 @@ config INTEL_UNCORE_FREQ_CONTROL will be called intel-uncore-frequency. -config INTEL_SCU_IPC - bool - -config INTEL_SCU - bool - select INTEL_SCU_IPC - -config INTEL_SCU_PCI - bool "Intel SCU PCI driver" - depends on PCI - select INTEL_SCU - help - This driver is used to bridge the communications between kernel - and SCU on some embedded Intel x86 platforms. It also creates - devices that are connected to the SoC through the SCU. - Platforms supported: - Medfield - Clovertrail - Merrifield - Broxton - Apollo Lake - -config INTEL_SCU_PLATFORM - tristate "Intel SCU platform driver" - depends on ACPI - select INTEL_SCU - help - This driver is used to bridge the communications between kernel - and SCU (sometimes called PMC as well). The driver currently - supports Intel Elkhart Lake and compatible platforms. - -config INTEL_SCU_WDT - bool - default INTEL_SCU_PCI - depends on INTEL_MID_WATCHDOG - help - This is a specific platform code to instantiate watchdog device - on ACPI-based Intel MID platforms. - -config INTEL_SCU_IPC_UTIL - tristate "Intel SCU IPC utility driver" - depends on INTEL_SCU - help - The IPC Util driver provides an interface with the SCU enabling - low level access for debug work and updating the firmware. Say - N unless you will be doing this on an Intel MID platform. - config INTEL_TELEMETRY tristate "Intel SoC Telemetry Driver" depends on X86_64
drivers/platform/x86/Makefile +1 -5
@@ -125,11 +125,7 @@ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore-frequency.o -obj-$(CONFIG_INTEL_SCU_IPC) += intel_scu_ipc.o -obj-$(CONFIG_INTEL_SCU_PCI) += intel_scu_pcidrv.o -obj-$(CONFIG_INTEL_SCU_PLATFORM) += intel_scu_pltdrv.o -obj-$(CONFIG_INTEL_SCU_WDT) += intel_scu_wdt.o -obj-$(CONFIG_INTEL_SCU_IPC_UTIL) += intel_scu_ipcutil.o + obj-$(CONFIG_INTEL_TELEMETRY) += intel_telemetry_core.o \ intel_telemetry_pltdrv.o \ intel_telemetry_debugfs.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -27,6 +27,7 @@ source "drivers/platform/x86/intel/mrfld/Kconfig" source "drivers/platform/x86/intel/pmc_core/Kconfig" source "drivers/platform/x86/intel/pmt/Kconfig" source "drivers/platform/x86/intel/punit/Kconfig" +source "drivers/platform/x86/intel/scu/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +5 -0
@@ -22,3 +22,8 @@ obj-$(CONFIG_INTEL_PMT_CLASS) += pmt/ obj-$(CONFIG_INTEL_PMT_TELEMETRY) += pmt/ obj-$(CONFIG_INTEL_PMT_CRASHLOG) += pmt/ obj-$(CONFIG_INTEL_PUNIT_IPC) += punit/ +obj-$(CONFIG_INTEL_SCU_IPC) += scu/ +obj-$(CONFIG_INTEL_SCU_PCI) += scu/ +obj-$(CONFIG_INTEL_SCU_PLATFORM) += scu/ +obj-$(CONFIG_INTEL_SCU_WDT) += scu/ +obj-$(CONFIG_INTEL_SCU_IPC_UTIL) += scu/
drivers/platform/x86/intel/scu/Kconfig new file +52 -0
52 lines not on this page · raw message
drivers/platform/x86/intel/scu/Makefile new file +11 -0
@@ -0,0 +1,11 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_SCU_IPC) += intel_scu_ipc.o +obj-$(CONFIG_INTEL_SCU_PCI) += intel_scu_pcidrv.o +obj-$(CONFIG_INTEL_SCU_PLATFORM) += intel_scu_pltdrv.o +obj-$(CONFIG_INTEL_SCU_WDT) += intel_scu_wdt.o +obj-$(CONFIG_INTEL_SCU_IPC_UTIL) += intel_scu_ipcutil.o +
drivers/platform/x86/intel/scu/intel_scu_ipc.c renamed from drivers/platform/x86/intel_scu_ipc.c +0 -0
drivers/platform/x86/intel/scu/intel_scu_ipcutil.c renamed from drivers/platform/x86/intel_scu_ipcutil.c +0 -0
drivers/platform/x86/intel/scu/intel_scu_pcidrv.c renamed from drivers/platform/x86/intel_scu_pcidrv.c +0 -0
drivers/platform/x86/intel/scu/intel_scu_pltdrv.c renamed from drivers/platform/x86/intel_scu_pltdrv.c +0 -0
drivers/platform/x86/intel/scu/intel_scu_wdt.c renamed from drivers/platform/x86/intel_scu_wdt.c +0 -0
Signature · 1 line
2.31.1
Mika Westerberg
maintainerRe: [PATCH 09/20] Move Intel SCU IPC of pdx86 to intel directory to increase readability.
Hi,
No objections, I think this is good idea but..
On Tue, Aug 10, 2021 at 05:58:21PM +0800, Kate Hsuan wrote:
.. I suggest to add proper commit message here. Many maintainers ignore patches that don't have one.
Quoted 21 lines
Signed-off-by Kate Hsuan <[email protected]>--- drivers/platform/x86/Kconfig | 47 ----------------- drivers/platform/x86/Makefile | 6 +-- drivers/platform/x86/intel/Kconfig | 1 + drivers/platform/x86/intel/Makefile | 5 ++ drivers/platform/x86/intel/scu/Kconfig | 52 +++++++++++++++++++ drivers/platform/x86/intel/scu/Makefile | 11 ++++ .../x86/{ => intel/scu}/intel_scu_ipc.c | 0 .../x86/{ => intel/scu}/intel_scu_ipcutil.c | 0 .../x86/{ => intel/scu}/intel_scu_pcidrv.c | 0 .../x86/{ => intel/scu}/intel_scu_pltdrv.c | 0 .../x86/{ => intel/scu}/intel_scu_wdt.c | 0 11 files changed, 70 insertions(+), 52 deletions(-) create mode 100644 drivers/platform/x86/intel/scu/Kconfig create mode 100644 drivers/platform/x86/intel/scu/Makefile rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipc.c (100%) rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipcutil.c (100%) rename drivers/platform/x86/{ => intel/scu}/intel_scu_pcidrv.c (100%) rename drivers/platform/x86/{ => intel/scu}/intel_scu_pltdrv.c (100%) rename drivers/platform/x86/{ => intel/scu}/intel_scu_wdt.c (100%)
Re: [PATCH 09/20] Move Intel SCU IPC of pdx86 to intel directory to increase readability.
Hi Mika,
Thanks for your suggestion.
I'll add them to the patches and resend them again.
Thank you.
BR,
Kate
Kate Hsuan
PhD
Senior Software Engineer
Red Hat APAC
Rm. 2708, 27F., No.9, Songgao Rd., Xinyi Dist., Taipei City 110
[email protected]
M: +886-919560388
Quoted 32 lines · Mika Westerberg
Hi,
No objections, I think this is good idea but..
On Tue, Aug 10, 2021 at 05:58:21PM +0800, Kate Hsuan wrote:
.. I suggest to add proper commit message here. Many maintainers ignore patches that don't have one.
Quoted 21 lines
Signed-off-by Kate Hsuan <[email protected]>--- drivers/platform/x86/Kconfig | 47 ----------------- drivers/platform/x86/Makefile | 6 +-- drivers/platform/x86/intel/Kconfig | 1 + drivers/platform/x86/intel/Makefile | 5 ++ drivers/platform/x86/intel/scu/Kconfig | 52 +++++++++++++++++++ drivers/platform/x86/intel/scu/Makefile | 11 ++++ .../x86/{ => intel/scu}/intel_scu_ipc.c | 0 .../x86/{ => intel/scu}/intel_scu_ipcutil.c | 0 .../x86/{ => intel/scu}/intel_scu_pcidrv.c | 0 .../x86/{ => intel/scu}/intel_scu_pltdrv.c | 0 .../x86/{ => intel/scu}/intel_scu_wdt.c | 0 11 files changed, 70 insertions(+), 52 deletions(-) create mode 100644 drivers/platform/x86/intel/scu/Kconfig create mode 100644 drivers/platform/x86/intel/scu/Makefile rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipc.c (100%) rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipcutil.c (100%) rename drivers/platform/x86/{ => intel/scu}/intel_scu_pcidrv.c (100%) rename drivers/platform/x86/{ => intel/scu}/intel_scu_pltdrv.c (100%) rename drivers/platform/x86/{ => intel/scu}/intel_scu_wdt.c (100%)
Re: [PATCH 09/20] Move Intel SCU IPC of pdx86 to intel directory to increase readability.
Quoted 6 lines · Kate Hsuan
Hi Mika,
Thanks for your suggestion.
I'll add them to the patches and resend them again.Thank you.
Please, do not top post!
Quoted 9 lines
Quoted 7 lines · Mika Westerberg
Hi,
No objections, I think this is good idea but..
On Tue, Aug 10, 2021 at 05:58:21PM +0800, Kate Hsuan wrote:
Quoted 8 lines
Quoted 8 lines
.. I suggest to add proper commit message here. Many maintainers ignore patches that don't have one.
Quoted 5 lines
rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipc.c (100%) rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipcutil.c (100%) rename drivers/platform/x86/{ => intel/scu}/intel_scu_pcidrv.c (100%) rename drivers/platform/x86/{ => intel/scu}/intel_scu_pltdrv.c (100%) rename drivers/platform/x86/{ => intel/scu}/intel_scu_wdt.c (100%)
Besides what Mika said this should follow the example of pmt, like dropping the intel_scu prefix from the files, but leave it for the module (see Makefile tricks for the details how to achieve this).
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH 10/20 Move Intel SoC telemetry driver to intel directory to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 13 -------------
drivers/platform/x86/Makefile | 3 ---
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 1 +
drivers/platform/x86/intel/telemetry/Kconfig | 16 ++++++++++++++++
drivers/platform/x86/intel/telemetry/Makefile | 9 +++++++++
.../{ => intel/telemetry}/intel_telemetry_core.c | 0
.../telemetry}/intel_telemetry_debugfs.c | 0
.../telemetry}/intel_telemetry_pltdrv.c | 0
9 files changed, 27 insertions(+), 16 deletions(-)
create mode 100644 drivers/platform/x86/intel/telemetry/Kconfig
create mode 100644 drivers/platform/x86/intel/telemetry/Makefile
rename drivers/platform/x86/{ => intel/telemetry}/intel_telemetry_core.c (100%)
rename drivers/platform/x86/{ => intel/telemetry}/intel_telemetry_debugfs.c (100%)
rename drivers/platform/x86/{ => intel/telemetry}/intel_telemetry_pltdrv.c (100%)drivers/platform/x86/Kconfig +0 -13
@@ -1085,19 +1085,6 @@ config INTEL_UNCORE_FREQ_CONTROL To compile this driver as a module, choose M here: the module will be called intel-uncore-frequency. - -config INTEL_TELEMETRY - tristate "Intel SoC Telemetry Driver" - depends on X86_64 - depends on MFD_INTEL_PMC_BXT - depends on INTEL_PUNIT_IPC - help - This driver provides interfaces to configure and use - telemetry for INTEL SoC from APL onwards. It is also - used to get various SoC events and parameters - directly via debugfs files. Various tools may use - this interface for SoC state monitoring. - endif # X86_PLATFORM_DEVICES config PMC_ATOM
drivers/platform/x86/Makefile +0 -3
@@ -126,7 +126,4 @@ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore-frequency.o -obj-$(CONFIG_INTEL_TELEMETRY) += intel_telemetry_core.o \ - intel_telemetry_pltdrv.o \ - intel_telemetry_debugfs.o obj-$(CONFIG_PMC_ATOM) += pmc_atom.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -28,6 +28,7 @@ source "drivers/platform/x86/intel/pmc_core/Kconfig" source "drivers/platform/x86/intel/pmt/Kconfig" source "drivers/platform/x86/intel/punit/Kconfig" source "drivers/platform/x86/intel/scu/Kconfig" +source "drivers/platform/x86/intel/telemetry/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +1 -0
@@ -27,3 +27,4 @@ obj-$(CONFIG_INTEL_SCU_PCI) += scu/ obj-$(CONFIG_INTEL_SCU_PLATFORM) += scu/ obj-$(CONFIG_INTEL_SCU_WDT) += scu/ obj-$(CONFIG_INTEL_SCU_IPC_UTIL) += scu/ +obj-$(CONFIG_INTEL_TELEMETRY) += telemetry/
drivers/platform/x86/intel/telemetry/Kconfig new file +16 -0
@@ -0,0 +1,16 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_TELEMETRY + tristate "Intel SoC Telemetry Driver" + depends on X86_64 + depends on MFD_INTEL_PMC_BXT + depends on INTEL_PUNIT_IPC + help + This driver provides interfaces to configure and use + telemetry for INTEL SoC from APL onwards. It is also + used to get various SoC events and parameters + directly via debugfs files. Various tools may use + this interface for SoC state monitoring.
drivers/platform/x86/intel/telemetry/Makefile new file +9 -0
@@ -0,0 +1,9 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + + +obj-$(CONFIG_INTEL_TELEMETRY) += intel_telemetry_core.o \ + intel_telemetry_pltdrv.o \ + intel_telemetry_debugfs.o
drivers/platform/x86/intel/telemetry/intel_telemetry_core.c renamed from drivers/platform/x86/intel_telemetry_core.c +0 -0
drivers/platform/x86/intel/telemetry/intel_telemetry_debugfs.c renamed from drivers/platform/x86/intel_telemetry_debugfs.c +0 -0
drivers/platform/x86/intel/telemetry/intel_telemetry_pltdrv.c renamed from drivers/platform/x86/intel_telemetry_pltdrv.c +0 -0
Signature · 1 line
2.31.1
PATCH 11/20 Move Intel IPS driver of pdx86 to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Makefile | 7 +------
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 3 +++
drivers/platform/x86/intel/ips/Kconfig | 14 ++++++++++++++
drivers/platform/x86/intel/ips/Makefile | 6 ++++++
drivers/platform/x86/{ => intel/ips}/intel_ips.c | 0
drivers/platform/x86/{ => intel/ips}/intel_ips.h | 0
7 files changed, 25 insertions(+), 6 deletions(-)
create mode 100644 drivers/platform/x86/intel/ips/Kconfig
create mode 100644 drivers/platform/x86/intel/ips/Makefile
rename drivers/platform/x86/{ => intel/ips}/intel_ips.c (100%)
rename drivers/platform/x86/{ => intel/ips}/intel_ips.h (100%)drivers/platform/x86/Makefile +1 -6
@@ -113,17 +113,12 @@ obj-$(CONFIG_TOUCHSCREEN_DMI) += touchscreen_dmi.o obj-$(CONFIG_WIRELESS_HOTKEY) += wireless-hotkey.o # Intel uncore drivers -obj-$(CONFIG_INTEL_IPS) += intel_ips.o + obj-$(CONFIG_INTEL_RST) += intel-rst.o obj-$(CONFIG_INTEL_SMARTCONNECT) += intel-smartconnect.o obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) += intel_speed_select_if/ obj-$(CONFIG_INTEL_TURBO_MAX_3) += intel_turbo_max_3.o obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore-frequency.o -# Intel PMIC / PMC / P-Unit devices - - - - obj-$(CONFIG_PMC_ATOM) += pmc_atom.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -29,6 +29,7 @@ source "drivers/platform/x86/intel/pmt/Kconfig" source "drivers/platform/x86/intel/punit/Kconfig" source "drivers/platform/x86/intel/scu/Kconfig" source "drivers/platform/x86/intel/telemetry/Kconfig" +source "drivers/platform/x86/intel/ips/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +3 -0
@@ -28,3 +28,6 @@ obj-$(CONFIG_INTEL_SCU_PLATFORM) += scu/ obj-$(CONFIG_INTEL_SCU_WDT) += scu/ obj-$(CONFIG_INTEL_SCU_IPC_UTIL) += scu/ obj-$(CONFIG_INTEL_TELEMETRY) += telemetry/ + +# Intel uncore drivers +obj-$(CONFIG_INTEL_IPS) += ips/
drivers/platform/x86/intel/ips/Kconfig new file +14 -0
@@ -0,0 +1,14 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_IPS + tristate "Intel Intelligent Power Sharing" + depends on ACPI && PCI + help + Intel Calpella platforms support dynamic power sharing between the + CPU and GPU, maximizing performance in a given TDP. This driver, + along with the CPU frequency and i915 drivers, provides that + functionality. If in doubt, say Y here; it will only load on + supported platforms.
drivers/platform/x86/intel/ips/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_IPS) += intel_ips.o
drivers/platform/x86/intel/ips/intel_ips.c renamed from drivers/platform/x86/intel_ips.c +0 -0
drivers/platform/x86/intel/ips/intel_ips.h renamed from drivers/platform/x86/intel_ips.h +0 -0
Signature · 1 line
2.31.1
PATCH 12/20 Move Intel RST driver of pdx86 to intel directory to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 21 -------------------
drivers/platform/x86/Makefile | 2 --
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 1 +
drivers/platform/x86/intel/rst/Kconfig | 16 ++++++++++++++
drivers/platform/x86/intel/rst/Makefile | 6 ++++++
.../platform/x86/{ => intel/rst}/intel-rst.c | 0
7 files changed, 24 insertions(+), 23 deletions(-)
create mode 100644 drivers/platform/x86/intel/rst/Kconfig
create mode 100644 drivers/platform/x86/intel/rst/Makefile
rename drivers/platform/x86/{ => intel/rst}/intel-rst.c (100%)drivers/platform/x86/Kconfig +0 -21
@@ -1026,27 +1026,6 @@ config INTEL_IMR If you are running on a Galileo/Quark say Y here. -config INTEL_IPS - tristate "Intel Intelligent Power Sharing" - depends on ACPI && PCI - help - Intel Calpella platforms support dynamic power sharing between the - CPU and GPU, maximizing performance in a given TDP. This driver, - along with the CPU frequency and i915 drivers, provides that - functionality. If in doubt, say Y here; it will only load on - supported platforms. - -config INTEL_RST - tristate "Intel Rapid Start Technology Driver" - depends on ACPI - help - This driver provides support for modifying parameters on systems - equipped with Intel's Rapid Start Technology. When put in an ACPI - sleep state, these devices will wake after either a configured - timeout or when the system battery reaches a critical state, - automatically copying memory contents to disk. On resume, the - firmware will copy the memory contents back to RAM and resume the OS - as usual. config INTEL_SMARTCONNECT tristate "Intel Smart Connect disabling driver"
drivers/platform/x86/Makefile +0 -2
@@ -113,8 +113,6 @@ obj-$(CONFIG_TOUCHSCREEN_DMI) += touchscreen_dmi.o obj-$(CONFIG_WIRELESS_HOTKEY) += wireless-hotkey.o # Intel uncore drivers - -obj-$(CONFIG_INTEL_RST) += intel-rst.o obj-$(CONFIG_INTEL_SMARTCONNECT) += intel-smartconnect.o obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) += intel_speed_select_if/ obj-$(CONFIG_INTEL_TURBO_MAX_3) += intel_turbo_max_3.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -30,6 +30,7 @@ source "drivers/platform/x86/intel/punit/Kconfig" source "drivers/platform/x86/intel/scu/Kconfig" source "drivers/platform/x86/intel/telemetry/Kconfig" source "drivers/platform/x86/intel/ips/Kconfig" +source "drivers/platform/x86/intel/rst/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +1 -0
@@ -31,3 +31,4 @@ obj-$(CONFIG_INTEL_TELEMETRY) += telemetry/ # Intel uncore drivers obj-$(CONFIG_INTEL_IPS) += ips/ +obj-$(CONFIG_INTEL_RST) += rst/
drivers/platform/x86/intel/rst/Kconfig new file +16 -0
@@ -0,0 +1,16 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_RST + tristate "Intel Rapid Start Technology Driver" + depends on ACPI + help + This driver provides support for modifying parameters on systems + equipped with Intel's Rapid Start Technology. When put in an ACPI + sleep state, these devices will wake after either a configured + timeout or when the system battery reaches a critical state, + automatically copying memory contents to disk. On resume, the + firmware will copy the memory contents back to RAM and resume the OS + as usual.
drivers/platform/x86/intel/rst/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_RST) += intel-rst.o
drivers/platform/x86/intel/rst/intel-rst.c renamed from drivers/platform/x86/intel-rst.c +0 -0
Signature · 1 line
2.31.1
PATCH 13/20 Move Intel smartconnect driver of pdx86 to intel/ directory to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 13 -------------
drivers/platform/x86/Makefile | 2 +-
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 1 +
.../platform/x86/intel/smartconnect/Kconfig | 18 ++++++++++++++++++
.../platform/x86/intel/smartconnect/Makefile | 6 ++++++
.../smartconnect}/intel-smartconnect.c | 0
7 files changed, 27 insertions(+), 14 deletions(-)
create mode 100644 drivers/platform/x86/intel/smartconnect/Kconfig
create mode 100644 drivers/platform/x86/intel/smartconnect/Makefile
rename drivers/platform/x86/{ => intel/smartconnect}/intel-smartconnect.c (100%)drivers/platform/x86/Kconfig +0 -13
@@ -1027,19 +1027,6 @@ config INTEL_IMR If you are running on a Galileo/Quark say Y here. -config INTEL_SMARTCONNECT - tristate "Intel Smart Connect disabling driver" - depends on ACPI - help - Intel Smart Connect is a technology intended to permit devices to - update state by resuming for a short period of time at regular - intervals. If a user enables this functionality under Windows and - then reboots into Linux, the system may remain configured to resume - on suspend. In the absence of any userspace to support it, the system - will then remain awake until something triggers another suspend. - - This driver checks to determine whether the device has Intel Smart - Connect enabled, and if so disables it. source "drivers/platform/x86/intel_speed_select_if/Kconfig"
drivers/platform/x86/Makefile +1 -1
@@ -113,7 +113,7 @@ obj-$(CONFIG_TOUCHSCREEN_DMI) += touchscreen_dmi.o obj-$(CONFIG_WIRELESS_HOTKEY) += wireless-hotkey.o # Intel uncore drivers -obj-$(CONFIG_INTEL_SMARTCONNECT) += intel-smartconnect.o + obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) += intel_speed_select_if/ obj-$(CONFIG_INTEL_TURBO_MAX_3) += intel_turbo_max_3.o obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore-frequency.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -31,6 +31,7 @@ source "drivers/platform/x86/intel/scu/Kconfig" source "drivers/platform/x86/intel/telemetry/Kconfig" source "drivers/platform/x86/intel/ips/Kconfig" source "drivers/platform/x86/intel/rst/Kconfig" +source "drivers/platform/x86/intel/smartconnect/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +1 -0
@@ -32,3 +32,4 @@ obj-$(CONFIG_INTEL_TELEMETRY) += telemetry/ # Intel uncore drivers obj-$(CONFIG_INTEL_IPS) += ips/ obj-$(CONFIG_INTEL_RST) += rst/ +obj-$(CONFIG_INTEL_SMARTCONNECT) += smartconnect/
drivers/platform/x86/intel/smartconnect/Kconfig new file +18 -0
@@ -0,0 +1,18 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_SMARTCONNECT + tristate "Intel Smart Connect disabling driver" + depends on ACPI + help + Intel Smart Connect is a technology intended to permit devices to + update state by resuming for a short period of time at regular + intervals. If a user enables this functionality under Windows and + then reboots into Linux, the system may remain configured to resume + on suspend. In the absence of any userspace to support it, the system + will then remain awake until something triggers another suspend. + + This driver checks to determine whether the device has Intel Smart + Connect enabled, and if so disables it.
drivers/platform/x86/intel/smartconnect/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_SMARTCONNECT) += intel-smartconnect.o
drivers/platform/x86/intel/smartconnect/intel-smartconnect.c renamed from drivers/platform/x86/intel-smartconnect.c +0 -0
Signature · 1 line
2.31.1
PATCH 14/20 Move Intel SST driver to intel/ directory to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 2 --
drivers/platform/x86/Makefile | 2 +-
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 1 +
drivers/platform/x86/{ => intel}/intel_speed_select_if/Kconfig | 0
drivers/platform/x86/{ => intel}/intel_speed_select_if/Makefile | 0
.../x86/{ => intel}/intel_speed_select_if/isst_if_common.c | 0
.../x86/{ => intel}/intel_speed_select_if/isst_if_common.h | 0
.../x86/{ => intel}/intel_speed_select_if/isst_if_mbox_msr.c | 0
.../x86/{ => intel}/intel_speed_select_if/isst_if_mbox_pci.c | 0
.../x86/{ => intel}/intel_speed_select_if/isst_if_mmio.c | 0
11 files changed, 3 insertions(+), 3 deletions(-)
rename drivers/platform/x86/{ => intel}/intel_speed_select_if/Kconfig (100%)
rename drivers/platform/x86/{ => intel}/intel_speed_select_if/Makefile (100%)
rename drivers/platform/x86/{ => intel}/intel_speed_select_if/isst_if_common.c (100%)
rename drivers/platform/x86/{ => intel}/intel_speed_select_if/isst_if_common.h (100%)
rename drivers/platform/x86/{ => intel}/intel_speed_select_if/isst_if_mbox_msr.c (100%)
rename drivers/platform/x86/{ => intel}/intel_speed_select_if/isst_if_mbox_pci.c (100%)
rename drivers/platform/x86/{ => intel}/intel_speed_select_if/isst_if_mmio.c (100%)drivers/platform/x86/Kconfig +0 -2
@@ -1028,8 +1028,6 @@ config INTEL_IMR -source "drivers/platform/x86/intel_speed_select_if/Kconfig" - config INTEL_TURBO_MAX_3 bool "Intel Turbo Boost Max Technology 3.0 enumeration driver" depends on X86_64 && SCHED_MC_PRIO
drivers/platform/x86/Makefile +1 -1
@@ -114,7 +114,7 @@ obj-$(CONFIG_WIRELESS_HOTKEY) += wireless-hotkey.o # Intel uncore drivers -obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) += intel_speed_select_if/ + obj-$(CONFIG_INTEL_TURBO_MAX_3) += intel_turbo_max_3.o obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore-frequency.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -32,6 +32,7 @@ source "drivers/platform/x86/intel/telemetry/Kconfig" source "drivers/platform/x86/intel/ips/Kconfig" source "drivers/platform/x86/intel/rst/Kconfig" source "drivers/platform/x86/intel/smartconnect/Kconfig" +source "drivers/platform/x86/intel/intel_speed_select_if/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +1 -0
@@ -33,3 +33,4 @@ obj-$(CONFIG_INTEL_TELEMETRY) += telemetry/ obj-$(CONFIG_INTEL_IPS) += ips/ obj-$(CONFIG_INTEL_RST) += rst/ obj-$(CONFIG_INTEL_SMARTCONNECT) += smartconnect/ +obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) += intel_speed_select_if/
drivers/platform/x86/intel/intel_speed_select_if/Kconfig renamed from drivers/platform/x86/intel_speed_select_if/Kconfig +0 -0
drivers/platform/x86/intel/intel_speed_select_if/Makefile renamed from drivers/platform/x86/intel_speed_select_if/Makefile +0 -0
drivers/platform/x86/intel/intel_speed_select_if/isst_if_common.c renamed from drivers/platform/x86/intel_speed_select_if/isst_if_common.c +0 -0
drivers/platform/x86/intel/intel_speed_select_if/isst_if_common.h renamed from drivers/platform/x86/intel_speed_select_if/isst_if_common.h +0 -0
drivers/platform/x86/intel/intel_speed_select_if/isst_if_mbox_msr.c renamed from drivers/platform/x86/intel_speed_select_if/isst_if_mbox_msr.c +0 -0
drivers/platform/x86/intel/intel_speed_select_if/isst_if_mbox_pci.c renamed from drivers/platform/x86/intel_speed_select_if/isst_if_mbox_pci.c +0 -0
drivers/platform/x86/intel/intel_speed_select_if/isst_if_mmio.c renamed from drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c +0 -0
Signature · 1 line
2.31.1
PATCH 15/20 Move Intel turbo max 3 driver to intel/ directory to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 10 ----------
drivers/platform/x86/Makefile | 1 -
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 3 ++-
drivers/platform/x86/intel/turbo_max_3/Kconfig | 14 ++++++++++++++
drivers/platform/x86/intel/turbo_max_3/Makefile | 6 ++++++
.../{ => intel/turbo_max_3}/intel_turbo_max_3.c | 0
7 files changed, 23 insertions(+), 12 deletions(-)
create mode 100644 drivers/platform/x86/intel/turbo_max_3/Kconfig
create mode 100644 drivers/platform/x86/intel/turbo_max_3/Makefile
rename drivers/platform/x86/{ => intel/turbo_max_3}/intel_turbo_max_3.c (100%)drivers/platform/x86/Kconfig +0 -10
@@ -1028,16 +1028,6 @@ config INTEL_IMR -config INTEL_TURBO_MAX_3 - bool "Intel Turbo Boost Max Technology 3.0 enumeration driver" - depends on X86_64 && SCHED_MC_PRIO - help - This driver reads maximum performance ratio of each CPU and set up - the scheduler priority metrics. In this way scheduler can prefer - CPU with higher performance to schedule tasks. - This driver is only required when the system is not using Hardware - P-States (HWP). In HWP mode, priority can be read from ACPI tables. - config INTEL_UNCORE_FREQ_CONTROL tristate "Intel Uncore frequency control driver" depends on X86_64
drivers/platform/x86/Makefile +0 -1
@@ -115,7 +115,6 @@ obj-$(CONFIG_WIRELESS_HOTKEY) += wireless-hotkey.o # Intel uncore drivers -obj-$(CONFIG_INTEL_TURBO_MAX_3) += intel_turbo_max_3.o obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore-frequency.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -33,6 +33,7 @@ source "drivers/platform/x86/intel/ips/Kconfig" source "drivers/platform/x86/intel/rst/Kconfig" source "drivers/platform/x86/intel/smartconnect/Kconfig" source "drivers/platform/x86/intel/intel_speed_select_if/Kconfig" +source "drivers/platform/x86/intel/turbo_max_3/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +2 -1
@@ -33,4 +33,5 @@ obj-$(CONFIG_INTEL_TELEMETRY) += telemetry/ obj-$(CONFIG_INTEL_IPS) += ips/ obj-$(CONFIG_INTEL_RST) += rst/ obj-$(CONFIG_INTEL_SMARTCONNECT) += smartconnect/ -obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) += intel_speed_select_if/ +obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) += intel_speed_select_if/ +obj-$(CONFIG_INTEL_TURBO_MAX_3) += turbo_max_3/
drivers/platform/x86/intel/turbo_max_3/Kconfig new file +14 -0
@@ -0,0 +1,14 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_TURBO_MAX_3 + bool "Intel Turbo Boost Max Technology 3.0 enumeration driver" + depends on X86_64 && SCHED_MC_PRIO + help + This driver reads maximum performance ratio of each CPU and set up + the scheduler priority metrics. In this way scheduler can prefer + CPU with higher performance to schedule tasks. + This driver is only required when the system is not using Hardware + P-States (HWP). In HWP mode, priority can be read from ACPI tables.
drivers/platform/x86/intel/turbo_max_3/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_TURBO_MAX_3) += intel_turbo_max_3.o
drivers/platform/x86/intel/turbo_max_3/intel_turbo_max_3.c renamed from drivers/platform/x86/intel_turbo_max_3.c +0 -0
Signature · 1 line
2.31.1
PATCH 16/20 Move Intel uncore freq driver to intel/ directory to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 13 -------------
drivers/platform/x86/Makefile | 5 -----
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 1 +
drivers/platform/x86/intel/uncore_freq/Kconfig | 15 +++++++++++++++
drivers/platform/x86/intel/uncore_freq/Makefile | 6 ++++++
.../uncore_freq}/intel-uncore-frequency.c | 0
7 files changed, 23 insertions(+), 18 deletions(-)
create mode 100644 drivers/platform/x86/intel/uncore_freq/Kconfig
create mode 100644 drivers/platform/x86/intel/uncore_freq/Makefile
rename drivers/platform/x86/{ => intel/uncore_freq}/intel-uncore-frequency.c (100%)drivers/platform/x86/Kconfig +0 -13
@@ -1026,19 +1026,6 @@ config INTEL_IMR If you are running on a Galileo/Quark say Y here. - - -config INTEL_UNCORE_FREQ_CONTROL - tristate "Intel Uncore frequency control driver" - depends on X86_64 - help - This driver allows control of uncore frequency limits on - supported server platforms. - Uncore frequency controls RING/LLC (last-level cache) clocks. - - To compile this driver as a module, choose M here: the module - will be called intel-uncore-frequency. - endif # X86_PLATFORM_DEVICES config PMC_ATOM
drivers/platform/x86/Makefile +0 -5
@@ -112,10 +112,5 @@ obj-$(CONFIG_MLX_PLATFORM) += mlx-platform.o obj-$(CONFIG_TOUCHSCREEN_DMI) += touchscreen_dmi.o obj-$(CONFIG_WIRELESS_HOTKEY) += wireless-hotkey.o -# Intel uncore drivers - - -obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore-frequency.o - obj-$(CONFIG_PMC_ATOM) += pmc_atom.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -34,6 +34,7 @@ source "drivers/platform/x86/intel/rst/Kconfig" source "drivers/platform/x86/intel/smartconnect/Kconfig" source "drivers/platform/x86/intel/intel_speed_select_if/Kconfig" source "drivers/platform/x86/intel/turbo_max_3/Kconfig" +source "drivers/platform/x86/intel/uncore_freq/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +1 -0
@@ -35,3 +35,4 @@ obj-$(CONFIG_INTEL_RST) += rst/ obj-$(CONFIG_INTEL_SMARTCONNECT) += smartconnect/ obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) += intel_speed_select_if/ obj-$(CONFIG_INTEL_TURBO_MAX_3) += turbo_max_3/ +obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += uncore_freq/
drivers/platform/x86/intel/uncore_freq/Kconfig new file +15 -0
@@ -0,0 +1,15 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_UNCORE_FREQ_CONTROL + tristate "Intel Uncore frequency control driver" + depends on X86_64 + help + This driver allows control of uncore frequency limits on + supported server platforms. + Uncore frequency controls RING/LLC (last-level cache) clocks. + + To compile this driver as a module, choose M here: the module + will be called intel-uncore-frequency.
drivers/platform/x86/intel/uncore_freq/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += intel-uncore-frequency.o
drivers/platform/x86/intel/uncore_freq/intel-uncore-frequency.c renamed from drivers/platform/x86/intel-uncore-frequency.c +0 -0
Signature · 1 line
2.31.1
PATCH 17/20 Move Intel int0002 vgpio driver to intel/ directory to inprove readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 19 ---------------
drivers/platform/x86/Makefile | 1 -
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 2 ++
drivers/platform/x86/intel/int0002/Kconfig | 23 +++++++++++++++++++
drivers/platform/x86/intel/int0002/Makefile | 6 +++++
.../{ => intel/int0002}/intel_int0002_vgpio.c | 0
7 files changed, 32 insertions(+), 20 deletions(-)
create mode 100644 drivers/platform/x86/intel/int0002/Kconfig
create mode 100644 drivers/platform/x86/intel/int0002/Makefile
rename drivers/platform/x86/{ => intel/int0002}/intel_int0002_vgpio.c (100%)drivers/platform/x86/Kconfig +0 -19
@@ -632,25 +632,6 @@ config THINKPAD_LMI source "drivers/platform/x86/intel/Kconfig" -config INTEL_INT0002_VGPIO - tristate "Intel ACPI INT0002 Virtual GPIO driver" - depends on GPIOLIB && ACPI && PM_SLEEP - select GPIOLIB_IRQCHIP - help - Some peripherals on Bay Trail and Cherry Trail platforms signal a - Power Management Event (PME) to the Power Management Controller (PMC) - to wakeup the system. When this happens software needs to explicitly - clear the PME bus 0 status bit in the GPE0a_STS register to avoid an - IRQ storm on IRQ 9. - - This is modelled in ACPI through the INT0002 ACPI device, which is - called a "Virtual GPIO controller" in ACPI because it defines the - event handler to call when the PME triggers through _AEI and _L02 - methods as would be done for a real GPIO interrupt in ACPI. - - To compile this driver as a module, choose M here: the module will - be called intel_int0002_vgpio. - config INTEL_MENLOW tristate "Thermal Management driver for Intel menlow platform" depends on ACPI_THERMAL
drivers/platform/x86/Makefile +0 -1
@@ -67,7 +67,6 @@ obj-$(CONFIG_THINKPAD_LMI) += think-lmi.o obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/ -obj-$(CONFIG_INTEL_INT0002_VGPIO) += intel_int0002_vgpio.o obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.o obj-$(CONFIG_INTEL_OAKTRAIL) += intel_oaktrail.o obj-$(CONFIG_INTEL_VBTN) += intel-vbtn.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -35,6 +35,7 @@ source "drivers/platform/x86/intel/smartconnect/Kconfig" source "drivers/platform/x86/intel/intel_speed_select_if/Kconfig" source "drivers/platform/x86/intel/turbo_max_3/Kconfig" source "drivers/platform/x86/intel/uncore_freq/Kconfig" +source "drivers/platform/x86/intel/int0002/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +2 -0
@@ -11,6 +11,7 @@ obj-$(CONFIG_INTEL_ATOMISP2_PM) += atomisp2/ obj-$(CONFIG_INTEL_HID_EVENT) += hid/ obj-$(CONFIG_INTEL_WMI_SBL_FW_UPDATE) += wmi/ obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += wmi/ +obj-$(CONFIG_INTEL_INT0002_VGPIO) += int0002/ # Intel PMIC / PMC / P-Unit devices
@@ -36,3 +37,4 @@ obj-$(CONFIG_INTEL_SMARTCONNECT) += smartconnect/ obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) += intel_speed_select_if/ obj-$(CONFIG_INTEL_TURBO_MAX_3) += turbo_max_3/ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += uncore_freq/ +
drivers/platform/x86/intel/int0002/Kconfig new file +23 -0
@@ -0,0 +1,23 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_INT0002_VGPIO + tristate "Intel ACPI INT0002 Virtual GPIO driver" + depends on GPIOLIB && ACPI && PM_SLEEP + select GPIOLIB_IRQCHIP + help + Some peripherals on Bay Trail and Cherry Trail platforms signal a + Power Management Event (PME) to the Power Management Controller (PMC) + to wakeup the system. When this happens software needs to explicitly + clear the PME bus 0 status bit in the GPE0a_STS register to avoid an + IRQ storm on IRQ 9. + + This is modelled in ACPI through the INT0002 ACPI device, which is + called a "Virtual GPIO controller" in ACPI because it defines the + event handler to call when the PME triggers through _AEI and _L02 + methods as would be done for a real GPIO interrupt in ACPI. + + To compile this driver as a module, choose M here: the module will + be called intel_int0002_vgpio.
drivers/platform/x86/intel/int0002/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_INT0002_VGPIO) += intel_int0002_vgpio.o
drivers/platform/x86/intel/int0002/intel_int0002_vgpio.c renamed from drivers/platform/x86/intel_int0002_vgpio.c +0 -0
Signature · 1 line
2.31.1
PATCH 18/20 Move Intel thermal driver for menlow platform driver to intel/ directory to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 8 --------
drivers/platform/x86/Makefile | 2 +-
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 2 ++
drivers/platform/x86/intel/menlow/Kconfig | 14 ++++++++++++++
drivers/platform/x86/intel/menlow/Makefile | 6 ++++++
.../platform/x86/{ => intel/menlow}/intel_menlow.c | 0
7 files changed, 24 insertions(+), 9 deletions(-)
create mode 100644 drivers/platform/x86/intel/menlow/Kconfig
create mode 100644 drivers/platform/x86/intel/menlow/Makefile
rename drivers/platform/x86/{ => intel/menlow}/intel_menlow.c (100%)drivers/platform/x86/Kconfig +0 -8
@@ -632,15 +632,7 @@ config THINKPAD_LMI source "drivers/platform/x86/intel/Kconfig" -config INTEL_MENLOW - tristate "Thermal Management driver for Intel menlow platform" - depends on ACPI_THERMAL - select THERMAL - help - ACPI thermal management enhancement driver on - Intel Menlow platform. - If unsure, say N. config INTEL_OAKTRAIL tristate "Intel Oaktrail Platform Extras"
drivers/platform/x86/Makefile +1 -1
@@ -67,7 +67,7 @@ obj-$(CONFIG_THINKPAD_LMI) += think-lmi.o obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/ -obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.o + obj-$(CONFIG_INTEL_OAKTRAIL) += intel_oaktrail.o obj-$(CONFIG_INTEL_VBTN) += intel-vbtn.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -36,6 +36,7 @@ source "drivers/platform/x86/intel/intel_speed_select_if/Kconfig" source "drivers/platform/x86/intel/turbo_max_3/Kconfig" source "drivers/platform/x86/intel/uncore_freq/Kconfig" source "drivers/platform/x86/intel/int0002/Kconfig" +source "drivers/platform/x86/intel/menlow/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +2 -0
@@ -12,6 +12,7 @@ obj-$(CONFIG_INTEL_HID_EVENT) += hid/ obj-$(CONFIG_INTEL_WMI_SBL_FW_UPDATE) += wmi/ obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += wmi/ obj-$(CONFIG_INTEL_INT0002_VGPIO) += int0002/ +obj-$(CONFIG_INTEL_MENLOW) += menlow/ # Intel PMIC / PMC / P-Unit devices
@@ -38,3 +39,4 @@ obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) += intel_speed_select_if/ obj-$(CONFIG_INTEL_TURBO_MAX_3) += turbo_max_3/ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += uncore_freq/ +
drivers/platform/x86/intel/menlow/Kconfig new file +14 -0
@@ -0,0 +1,14 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_MENLOW + tristate "Thermal Management driver for Intel menlow platform" + depends on ACPI_THERMAL + select THERMAL + help + ACPI thermal management enhancement driver on + Intel Menlow platform. + + If unsure, say N.
drivers/platform/x86/intel/menlow/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.o
drivers/platform/x86/intel/menlow/intel_menlow.c renamed from drivers/platform/x86/intel_menlow.c +0 -0
Signature · 1 line
2.31.1
Re: [PATCH 18/20] Move Intel thermal driver for menlow platform driver to intel/ directory to improve readability.
On 10/08/2021 11:58, Kate Hsuan wrote:
Why not move it into drivers/thermal/intel ?
Quoted 113 lines
Signed-off-by Kate Hsuan <[email protected]>--- drivers/platform/x86/Kconfig | 8 -------- drivers/platform/x86/Makefile | 2 +- drivers/platform/x86/intel/Kconfig | 1 + drivers/platform/x86/intel/Makefile | 2 ++ drivers/platform/x86/intel/menlow/Kconfig | 14 ++++++++++++++ drivers/platform/x86/intel/menlow/Makefile | 6 ++++++ .../platform/x86/{ => intel/menlow}/intel_menlow.c | 0 7 files changed, 24 insertions(+), 9 deletions(-) create mode 100644 drivers/platform/x86/intel/menlow/Kconfig create mode 100644 drivers/platform/x86/intel/menlow/Makefile rename drivers/platform/x86/{ => intel/menlow}/intel_menlow.c (100%)drivers/platform/x86/Kconfig +0
-8@@ -632,15 +632,7 @@ config THINKPAD_LMI source "drivers/platform/x86/intel/Kconfig" -config INTEL_MENLOW - tristate "Thermal Management driver for Intel menlow platform" - depends on ACPI_THERMAL - select THERMAL - help - ACPI thermal management enhancement driver on - Intel Menlow platform. - If unsure, say N. config INTEL_OAKTRAIL tristate "Intel Oaktrail Platform Extras"drivers/platform/x86/Makefile +1
-1@@ -67,7 +67,7 @@ obj-$(CONFIG_THINKPAD_LMI) += think-lmi.o obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/ -obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.o + obj-$(CONFIG_INTEL_OAKTRAIL) += intel_oaktrail.o obj-$(CONFIG_INTEL_VBTN) += intel-vbtn.odrivers/platform/x86/intel/Kconfig +1
-0@@ -36,6 +36,7 @@ source "drivers/platform/x86/intel/intel_speed_select_if/Kconfig" source "drivers/platform/x86/intel/turbo_max_3/Kconfig" source "drivers/platform/x86/intel/uncore_freq/Kconfig" source "drivers/platform/x86/intel/int0002/Kconfig" +source "drivers/platform/x86/intel/menlow/Kconfig" endif # X86_PLATFORM_DRIVERS_INTELdrivers/platform/x86/intel/Makefile +2
-0@@ -12,6 +12,7 @@ obj-$(CONFIG_INTEL_HID_EVENT) += hid/ obj-$(CONFIG_INTEL_WMI_SBL_FW_UPDATE) += wmi/ obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += wmi/ obj-$(CONFIG_INTEL_INT0002_VGPIO) += int0002/ +obj-$(CONFIG_INTEL_MENLOW) += menlow/ # Intel PMIC / PMC / P-Unit devices@@ -38,3 +39,4 @@ obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) += intel_speed_select_if/ obj-$(CONFIG_INTEL_TURBO_MAX_3) += turbo_max_3/ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += uncore_freq/ +drivers/platform/x86/intel/menlow/Kconfig new file +14
-0@@ -0,0 +1,14 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_MENLOW + tristate "Thermal Management driver for Intel menlow platform" + depends on ACPI_THERMAL + select THERMAL + help + ACPI thermal management enhancement driver on + Intel Menlow platform. + + If unsure, say N.drivers/platform/x86/intel/menlow/Makefile new file +6
-0@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.odrivers/platform/x86/intel/menlow/intel_menlow.c renamed from drivers/platform/x86/intel_menlow.c +0
-0
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Re: [PATCH 18/20] Move Intel thermal driver for menlow platform driver to intel/ directory to improve readability.
Hi,
Quoted 4 lines · Daniel Lezcano
On 10/08/2021 11:58, Kate Hsuan wrote:
Why not move it into
drivers/thermal/intel?
This cleanup is really something which Intel should have been doing itself, but they have not done that, so now Kate has stepped up to do this.
Figuring out if there is a better home for each of these drivers really falls outside of the scope of this. If Intel and specifically Sujith Thomas, the maintainer for that driver who is in the Cc, believe that drivers/thermal/intel is a better place then they can submit a patch for this themselves.
If Intel does that right away, then this patch can be dropped from Kate's patch-set. Otherwise this can be moved a second time once someone from Intel gets around to it.
Regards,
Hans
Quoted 117 lines
Quoted 115 lines
Signed-off-by Kate Hsuan <[email protected]>--- drivers/platform/x86/Kconfig | 8 -------- drivers/platform/x86/Makefile | 2 +- drivers/platform/x86/intel/Kconfig | 1 + drivers/platform/x86/intel/Makefile | 2 ++ drivers/platform/x86/intel/menlow/Kconfig | 14 ++++++++++++++ drivers/platform/x86/intel/menlow/Makefile | 6 ++++++ .../platform/x86/{ => intel/menlow}/intel_menlow.c | 0 7 files changed, 24 insertions(+), 9 deletions(-) create mode 100644 drivers/platform/x86/intel/menlow/Kconfig create mode 100644 drivers/platform/x86/intel/menlow/Makefile rename drivers/platform/x86/{ => intel/menlow}/intel_menlow.c (100%)drivers/platform/x86/Kconfig +0
-8@@ -632,15 +632,7 @@ config THINKPAD_LMI source "drivers/platform/x86/intel/Kconfig" -config INTEL_MENLOW - tristate "Thermal Management driver for Intel menlow platform" - depends on ACPI_THERMAL - select THERMAL - help - ACPI thermal management enhancement driver on - Intel Menlow platform. - If unsure, say N. config INTEL_OAKTRAIL tristate "Intel Oaktrail Platform Extras"drivers/platform/x86/Makefile +1
-1@@ -67,7 +67,7 @@ obj-$(CONFIG_THINKPAD_LMI) += think-lmi.o obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/ -obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.o + obj-$(CONFIG_INTEL_OAKTRAIL) += intel_oaktrail.o obj-$(CONFIG_INTEL_VBTN) += intel-vbtn.odrivers/platform/x86/intel/Kconfig +1
-0@@ -36,6 +36,7 @@ source "drivers/platform/x86/intel/intel_speed_select_if/Kconfig" source "drivers/platform/x86/intel/turbo_max_3/Kconfig" source "drivers/platform/x86/intel/uncore_freq/Kconfig" source "drivers/platform/x86/intel/int0002/Kconfig" +source "drivers/platform/x86/intel/menlow/Kconfig" endif # X86_PLATFORM_DRIVERS_INTELdrivers/platform/x86/intel/Makefile +2
-0@@ -12,6 +12,7 @@ obj-$(CONFIG_INTEL_HID_EVENT) += hid/ obj-$(CONFIG_INTEL_WMI_SBL_FW_UPDATE) += wmi/ obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += wmi/ obj-$(CONFIG_INTEL_INT0002_VGPIO) += int0002/ +obj-$(CONFIG_INTEL_MENLOW) += menlow/ # Intel PMIC / PMC / P-Unit devices@@ -38,3 +39,4 @@ obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) += intel_speed_select_if/ obj-$(CONFIG_INTEL_TURBO_MAX_3) += turbo_max_3/ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += uncore_freq/ +drivers/platform/x86/intel/menlow/Kconfig new file +14
-0@@ -0,0 +1,14 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_MENLOW + tristate "Thermal Management driver for Intel menlow platform" + depends on ACPI_THERMAL + select THERMAL + help + ACPI thermal management enhancement driver on + Intel Menlow platform. + + If unsure, say N.drivers/platform/x86/intel/menlow/Makefile new file +6
-0@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.odrivers/platform/x86/intel/menlow/intel_menlow.c renamed from drivers/platform/x86/intel_menlow.c +0
-0
Re: [PATCH 18/20] Move Intel thermal driver for menlow platform driver to intel/ directory to improve readability.
Quoted 18 lines · Hans de Goede
Hi,
Quoted 4 lines · Daniel Lezcano
On 10/08/2021 11:58, Kate Hsuan wrote:
Why not move it into
drivers/thermal/intel?This cleanup is really something which Intel should have been doing itself, but they have not done that, so now Kate has stepped up to do this.
Figuring out if there is a better home for each of these drivers really falls outside of the scope of this. If Intel and specifically Sujith Thomas, the maintainer for that driver who is in the Cc, believe that
drivers/thermal/intelis a better place then they can submit a patch for this themselves.
Quoted 3 lines
If Intel does that right away, then this patch can be dropped from Kate's patch-set. Otherwise this can be moved a second time once someone from Intel gets around to it.
We can move to thermal/intel. I will submit a change to do that.
Thanks,
Srinivas
Quoted 142 lines
Regards,
Hans
Quoted 133 lines
Quoted 131 lines
Signed-off-by Kate Hsuan <[email protected]>---
drivers/platform/x86/Kconfig | 8 -------- drivers/platform/x86/Makefile | 2 +- drivers/platform/x86/intel/Kconfig | 1 + drivers/platform/x86/intel/Makefile | 2 ++ drivers/platform/x86/intel/menlow/Kconfig | 14
++++++++++++++
drivers/platform/x86/intel/menlow/Makefile | 6 ++++++ .../platform/x86/{ =>intel/menlow}/intel_menlow.c| 07 files changed, 24 insertions(+), 9 deletions(-)create mode 100644
drivers/platform/x86/intel/menlow/Kconfigcreate mode 100644drivers/platform/x86/intel/menlow/Makefilerenamedrivers/platform/x86/{=>intel/menlow}/intel_menlow.c(100%)drivers/platform/x86/Kconfig +0
-0@@ -632,15 +632,7 @@ config THINKPAD_LMI
source "drivers/platform/x86/intel/Kconfig"
-configINTEL_MENLOW
- tristate "Thermal Management driver for Intel menlow platform"
- depends onACPI_THERMAL
- select THERMAL
- help
- ACPI thermal management enhancement driver on - Intel Menlow platform.
- If unsure, say N.
configINTEL_OAKTRAIL
tristate "Intel Oaktrail Platform Extras"drivers/platform/x86/Makefile +0
-0@@ -67,7 +67,7 @@ obj-$(CONFIG_THINKPAD_LMI) += think-lmi.oobj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/
drivers/platform/x86/Makefile +1
-1-obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.o +obj-$(CONFIG_INTEL_OAKTRAIL) += intel_oaktrail.o obj-$(CONFIG_INTEL_VBTN) += intel-vbtn.o
drivers/platform/x86/intel/Kconfig +0
-0@@ -36,6 +36,7 @@ source"
drivers/platform/x86/intel/intel_speed_select_if/Kconfig" source "drivers/platform/x86/intel/turbo_max_3/Kconfig" source "drivers/platform/x86/intel/uncore_freq/Kconfig" source "drivers/platform/x86/intel/int0002/Kconfig" +source "drivers/platform/x86/intel/menlow/Kconfig"
endif #X86_PLATFORM_DRIVERS_INTELdrivers/platform/x86/intel/Makefile +0
-0@@ -12,6 +12,7 @@ obj-$(CONFIG_INTEL_HID_EVENT) += hid/obj-$(CONFIG_INTEL_WMI_SBL_FW_UPDATE) += wmi/ obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += wmi/ obj-$(CONFIG_INTEL_INT0002_VGPIO) += int0002/ +obj-$(CONFIG_INTEL_MENLOW) += menlow/
# Intel PMIC / PMC / P-Unit devicesdrivers/platform/x86/intel/Makefile +0
-0@@ -38,3 +39,4 @@ obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) += intel_speed_select_if/ obj-$(CONFIG_INTEL_TURBO_MAX_3) += turbo_max_3/ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += uncore_freq/
drivers/platform/x86/intel/Makefile +1
-0+drivers/platform/x86/intel/menlow/Kconfig new file +7
-0@@ -0,0 +1,14 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_MENLOW + tristate "Thermal Management driver for Intel menlowplatform"
+ depends onACPI_THERMAL
+ select THERMAL
+ help
+ ACPI thermal management enhancement driver on + Intel Menlow platform.drivers/platform/x86/intel/menlow/Kconfig new file +2
-0+ + If unsure, say N.drivers/platform/x86/intel/menlow/Makefile new file +6
-0@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.odrivers/platform/x86/intel/menlow/intel_menlow.c renamed from drivers/platform/x86/intel_menlow.c +0
-0
Re: [PATCH 18/20] Move Intel thermal driver for menlow platform driver to intel/ directory to improve readability.
Hi,
Quoted 19 lines · Srinivas
Quoted 18 lines · Hans de Goede
Hi,
Quoted 4 lines · Daniel Lezcano
On 10/08/2021 11:58, Kate Hsuan wrote:
Why not move it into
drivers/thermal/intel?This cleanup is really something which Intel should have been doing itself, but they have not done that, so now Kate has stepped up to do this.
Figuring out if there is a better home for each of these drivers really falls outside of the scope of this. If Intel and specifically Sujith Thomas, the maintainer for that driver who is in the Cc, believe that
drivers/thermal/intelis a better place then they can submit a patch for this themselves.
Quoted 4 lines
Quoted 3 lines
If Intel does that right away, then this patch can be dropped from Kate's patch-set. Otherwise this can be moved a second time once someone from Intel gets around to it.
We can move to thermal/intel. I will submit a change to do that.
Great, I see that you've already send a patch for this, thank you.
Kate, please drop this patch from your series.
Regards,
Hans
Quoted 133 lines
Quoted 132 lines
Quoted 131 lines
Quoted 129 lines
Signed-off-by Kate Hsuan <[email protected]>---
drivers/platform/x86/Kconfig | 8 -------- drivers/platform/x86/Makefile | 2 +- drivers/platform/x86/intel/Kconfig | 1 + drivers/platform/x86/intel/Makefile | 2 ++ drivers/platform/x86/intel/menlow/Kconfig | 14
++++++++++++++
drivers/platform/x86/intel/menlow/Makefile | 6 ++++++ .../platform/x86/{ =>intel/menlow}/intel_menlow.c| 07 files changed, 24 insertions(+), 9 deletions(-)create mode 100644
drivers/platform/x86/intel/menlow/Kconfigcreate mode 100644drivers/platform/x86/intel/menlow/Makefilerenamedrivers/platform/x86/{=>intel/menlow}/intel_menlow.c(100%)drivers/platform/x86/Kconfig +0
-0@@ -632,15 +632,7 @@ config THINKPAD_LMI
source "drivers/platform/x86/intel/Kconfig"
-configINTEL_MENLOW
- tristate "Thermal Management driver for Intel menlow platform"
- depends onACPI_THERMAL
- select THERMAL
- help
- ACPI thermal management enhancement driver on - Intel Menlow platform.
- If unsure, say N.
configINTEL_OAKTRAIL
tristate "Intel Oaktrail Platform Extras"drivers/platform/x86/Makefile +0
-0@@ -67,7 +67,7 @@ obj-$(CONFIG_THINKPAD_LMI) += think-lmi.oobj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/
drivers/platform/x86/Makefile +1
-1-obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.o +obj-$(CONFIG_INTEL_OAKTRAIL) += intel_oaktrail.o obj-$(CONFIG_INTEL_VBTN) += intel-vbtn.o
drivers/platform/x86/intel/Kconfig +0
-0@@ -36,6 +36,7 @@ source"
drivers/platform/x86/intel/intel_speed_select_if/Kconfig" source "drivers/platform/x86/intel/turbo_max_3/Kconfig" source "drivers/platform/x86/intel/uncore_freq/Kconfig" source "drivers/platform/x86/intel/int0002/Kconfig" +source "drivers/platform/x86/intel/menlow/Kconfig"
endif #X86_PLATFORM_DRIVERS_INTELdrivers/platform/x86/intel/Makefile +0
-0@@ -12,6 +12,7 @@ obj-$(CONFIG_INTEL_HID_EVENT) += hid/obj-$(CONFIG_INTEL_WMI_SBL_FW_UPDATE) += wmi/ obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += wmi/ obj-$(CONFIG_INTEL_INT0002_VGPIO) += int0002/ +obj-$(CONFIG_INTEL_MENLOW) += menlow/
# Intel PMIC / PMC / P-Unit devicesdrivers/platform/x86/intel/Makefile +0
-0@@ -38,3 +39,4 @@ obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) += intel_speed_select_if/ obj-$(CONFIG_INTEL_TURBO_MAX_3) += turbo_max_3/ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += uncore_freq/
drivers/platform/x86/intel/Makefile +1
-0+drivers/platform/x86/intel/menlow/Kconfig new file +7
-0@@ -0,0 +1,14 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_MENLOW + tristate "Thermal Management driver for Intel menlowplatform"
+ depends onACPI_THERMAL
+ select THERMAL
+ help
+ ACPI thermal management enhancement driver on + Intel Menlow platform.drivers/platform/x86/intel/menlow/Kconfig new file +2
-0+ + If unsure, say N.drivers/platform/x86/intel/menlow/Makefile new file +6
-0@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.odrivers/platform/x86/intel/menlow/intel_menlow.c renamed from drivers/platform/x86/intel_menlow.c +0
-0
Re: [PATCH 18/20] Move Intel thermal driver for menlow platform driver to intel/ directory to improve readability.
Quoted 28 lines · Hans de Goede
Hi,
Quoted 19 lines · Srinivas
Quoted 18 lines · Hans de Goede
Hi,
Quoted 4 lines · Daniel Lezcano
On 10/08/2021 11:58, Kate Hsuan wrote:
Why not move it into
drivers/thermal/intel?This cleanup is really something which Intel should have been doing itself, but they have not done that, so now Kate has stepped up to do this.
Figuring out if there is a better home for each of these drivers really falls outside of the scope of this. If Intel and specifically Sujith Thomas, the maintainer for that driver who is in the Cc, believe that
drivers/thermal/intelis a better place then they can submit a patch for this themselves.Quoted 4 lines
Quoted 3 lines
If Intel does that right away, then this patch can be dropped from Kate's patch-set. Otherwise this can be moved a second time once someone from Intel gets around to it.
We can move to thermal/intel. I will submit a change to do that.
Quoted 8 lines
Great, I see that you've already send a patch for this, thank you.
Kate, please drop this patch from your series.
Regards,
Hans
Got it. I have dropped it.
--
BR,
Kate
Quoted 136 lines
Quoted 135 lines
Quoted 134 lines
Quoted 133 lines
Quoted 131 lines
Signed-off-by Kate Hsuan <[email protected]>--- drivers/platform/x86/Kconfig | 8 -------- drivers/platform/x86/Makefile | 2 +- drivers/platform/x86/intel/Kconfig | 1 + drivers/platform/x86/intel/Makefile | 2 ++ drivers/platform/x86/intel/menlow/Kconfig | 14 ++++++++++++++ drivers/platform/x86/intel/menlow/Makefile | 6 ++++++ .../platform/x86/{ => intel/menlow}/intel_menlow.c | 0 7 files changed, 24 insertions(+), 9 deletions(-) create mode 100644 drivers/platform/x86/intel/menlow/Kconfig create mode 100644 drivers/platform/x86/intel/menlow/Makefile rename drivers/platform/x86/{ => intel/menlow}/intel_menlow.c(100%)
drivers/platform/x86/Kconfig +0
-2@@ -632,15 +632,7 @@ config THINKPAD_LMI source "drivers/platform/x86/intel/Kconfig" -config INTEL_MENLOW - tristate "Thermal Management driver for Intel menlowplatform"
drivers/platform/x86/Kconfig +0
-6- depends on ACPI_THERMAL - select THERMAL - help - ACPI thermal management enhancement driver on - Intel Menlow platform. - If unsure, say N. config INTEL_OAKTRAIL tristate "Intel Oaktrail Platform Extras"drivers/platform/x86/Makefile +1
-1@@ -67,7 +67,7 @@ obj-$(CONFIG_THINKPAD_LMI) += think-lmi.o obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/ -obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.o + obj-$(CONFIG_INTEL_OAKTRAIL) += intel_oaktrail.o obj-$(CONFIG_INTEL_VBTN) += intel-vbtn.odrivers/platform/x86/intel/Kconfig +0
-0@@ -36,6 +36,7 @@ source"
drivers/platform/x86/intel/intel_speed_select_if/Kconfig"
source "drivers/platform/x86/intel/turbo_max_3/Kconfig" source "drivers/platform/x86/intel/uncore_freq/Kconfig" source "drivers/platform/x86/intel/int0002/Kconfig"drivers/platform/x86/intel/Kconfig +1
-0+source "drivers/platform/x86/intel/menlow/Kconfig" endif # X86_PLATFORM_DRIVERS_INTELdrivers/platform/x86/intel/Makefile +1
-0@@ -12,6 +12,7 @@ obj-$(CONFIG_INTEL_HID_EVENT) += hid/ obj-$(CONFIG_INTEL_WMI_SBL_FW_UPDATE) += wmi/ obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += wmi/ obj-$(CONFIG_INTEL_INT0002_VGPIO) += int0002/ +obj-$(CONFIG_INTEL_MENLOW) += menlow/ # Intel PMIC / PMC / P-Unit devices@@ -38,3 +39,4 @@ obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) +=
intel_speed_select_if/
obj-$(CONFIG_INTEL_TURBO_MAX_3) +=
turbo_max_3/
obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) +=
uncore_freq/drivers/platform/x86/intel/Makefile +1
-0+drivers/platform/x86/intel/menlow/Kconfig new file +7
-0@@ -0,0 +1,14 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_MENLOW + tristate "Thermal Management driver for Intel menlowplatform"
drivers/platform/x86/intel/menlow/Kconfig new file +7
-0+ depends on ACPI_THERMAL + select THERMAL + help + ACPI thermal management enhancement driver on + Intel Menlow platform. + + If unsure, say N.drivers/platform/x86/intel/menlow/Makefile new file +6
-0@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.odrivers/platform/x86/intel/menlow/intel_menlow.c renamed from drivers/platform/x86/intel_menlow.c +0
-0
PATCH 19/20 Move OakTrail driver to the intel/ directory to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 9 ---------
drivers/platform/x86/Makefile | 3 ---
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 2 +-
drivers/platform/x86/intel/oaktrail/Kconfig | 15 +++++++++++++++
drivers/platform/x86/intel/oaktrail/Makefile | 6 ++++++
.../x86/{ => intel/oaktrail}/intel_oaktrail.c | 0
7 files changed, 23 insertions(+), 13 deletions(-)
create mode 100644 drivers/platform/x86/intel/oaktrail/Kconfig
create mode 100644 drivers/platform/x86/intel/oaktrail/Makefile
rename drivers/platform/x86/{ => intel/oaktrail}/intel_oaktrail.c (100%)drivers/platform/x86/Kconfig +0 -9
@@ -634,15 +634,6 @@ source "drivers/platform/x86/intel/Kconfig" -config INTEL_OAKTRAIL - tristate "Intel Oaktrail Platform Extras" - depends on ACPI - depends on ACPI_VIDEO || ACPI_VIDEO = n - depends on RFKILL && BACKLIGHT_CLASS_DEVICE && ACPI - help - Intel Oaktrail platform need this driver to provide interfaces to - enable/disable the Camera, WiFi, BT etc. devices. If in doubt, say Y - here; it will only load on supported platforms. config INTEL_VBTN tristate "INTEL VIRTUAL BUTTON"
drivers/platform/x86/Makefile +0 -3
@@ -66,9 +66,6 @@ obj-$(CONFIG_THINKPAD_LMI) += think-lmi.o # Intel obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/ - - -obj-$(CONFIG_INTEL_OAKTRAIL) += intel_oaktrail.o obj-$(CONFIG_INTEL_VBTN) += intel-vbtn.o # MSI
drivers/platform/x86/intel/Kconfig +1 -0
@@ -37,6 +37,7 @@ source "drivers/platform/x86/intel/turbo_max_3/Kconfig" source "drivers/platform/x86/intel/uncore_freq/Kconfig" source "drivers/platform/x86/intel/int0002/Kconfig" source "drivers/platform/x86/intel/menlow/Kconfig" +source "drivers/platform/x86/intel/oaktrail/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +1 -1
@@ -13,7 +13,7 @@ obj-$(CONFIG_INTEL_WMI_SBL_FW_UPDATE) += wmi/ obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += wmi/ obj-$(CONFIG_INTEL_INT0002_VGPIO) += int0002/ obj-$(CONFIG_INTEL_MENLOW) += menlow/ - +obj-$(CONFIG_INTEL_OAKTRAIL) += oaktrail/ # Intel PMIC / PMC / P-Unit devices obj-$(CONFIG_INTEL_BXTWC_PMIC_TMU) += bxtwc/
drivers/platform/x86/intel/oaktrail/Kconfig new file +15 -0
@@ -0,0 +1,15 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_OAKTRAIL + tristate "Intel Oaktrail Platform Extras" + depends on ACPI + depends on ACPI_VIDEO || ACPI_VIDEO = n + depends on RFKILL && BACKLIGHT_CLASS_DEVICE && ACPI + help + Intel Oaktrail platform need this driver to provide interfaces to + enable/disable the Camera, WiFi, BT etc. devices. If in doubt, say Y + here; it will only load on supported platforms. +
drivers/platform/x86/intel/oaktrail/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_OAKTRAIL) += intel_oaktrail.o
drivers/platform/x86/intel/oaktrail/intel_oaktrail.c renamed from drivers/platform/x86/intel_oaktrail.c +0 -0
Signature · 1 line
2.31.1
PATCH 20/20 Move Intel virtual botton driver to intel/ directory to improve readability.
In reply to Kate Hsuan---
drivers/platform/x86/Kconfig | 15 ---------------
drivers/platform/x86/Makefile | 2 --
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 19 +++++++++----------
drivers/platform/x86/intel/vbtn/Kconfig | 16 ++++++++++++++++
drivers/platform/x86/intel/vbtn/Makefile | 6 ++++++
.../x86/{ => intel/vbtn}/intel-vbtn.c | 0
7 files changed, 32 insertions(+), 27 deletions(-)
create mode 100644 drivers/platform/x86/intel/vbtn/Kconfig
create mode 100644 drivers/platform/x86/intel/vbtn/Makefile
rename drivers/platform/x86/{ => intel/vbtn}/intel-vbtn.c (100%)drivers/platform/x86/Kconfig +0 -15
@@ -632,21 +632,6 @@ config THINKPAD_LMI source "drivers/platform/x86/intel/Kconfig" - - - -config INTEL_VBTN - tristate "INTEL VIRTUAL BUTTON" - depends on ACPI - depends on INPUT - select INPUT_SPARSEKMAP - help - This driver provides support for the Intel Virtual Button interface. - Some laptops require this driver for power button support. - - To compile this driver as a module, choose M here: the module will - be called intel_vbtn. - config MSI_LAPTOP tristate "MSI Laptop Extras" depends on ACPI
drivers/platform/x86/Makefile +0 -2
@@ -66,8 +66,6 @@ obj-$(CONFIG_THINKPAD_LMI) += think-lmi.o # Intel obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/ -obj-$(CONFIG_INTEL_VBTN) += intel-vbtn.o - # MSI obj-$(CONFIG_MSI_LAPTOP) += msi-laptop.o obj-$(CONFIG_MSI_WMI) += msi-wmi.o
drivers/platform/x86/intel/Kconfig +1 -0
@@ -38,6 +38,7 @@ source "drivers/platform/x86/intel/uncore_freq/Kconfig" source "drivers/platform/x86/intel/int0002/Kconfig" source "drivers/platform/x86/intel/menlow/Kconfig" source "drivers/platform/x86/intel/oaktrail/Kconfig" +source "drivers/platform/x86/intel/vbtn/Kconfig" endif # X86_PLATFORM_DRIVERS_INTEL
drivers/platform/x86/intel/Makefile +9 -10
@@ -12,8 +12,9 @@ obj-$(CONFIG_INTEL_HID_EVENT) += hid/ obj-$(CONFIG_INTEL_WMI_SBL_FW_UPDATE) += wmi/ obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += wmi/ obj-$(CONFIG_INTEL_INT0002_VGPIO) += int0002/ -obj-$(CONFIG_INTEL_MENLOW) += menlow/ +obj-$(CONFIG_INTEL_MENLOW) += menlow/ obj-$(CONFIG_INTEL_OAKTRAIL) += oaktrail/ +obj-$(CONFIG_INTEL_VBTN) += vbtn/ # Intel PMIC / PMC / P-Unit devices obj-$(CONFIG_INTEL_BXTWC_PMIC_TMU) += bxtwc/
@@ -24,19 +25,17 @@ obj-$(CONFIG_INTEL_PMT_CLASS) += pmt/ obj-$(CONFIG_INTEL_PMT_TELEMETRY) += pmt/ obj-$(CONFIG_INTEL_PMT_CRASHLOG) += pmt/ obj-$(CONFIG_INTEL_PUNIT_IPC) += punit/ -obj-$(CONFIG_INTEL_SCU_IPC) += scu/ -obj-$(CONFIG_INTEL_SCU_PCI) += scu/ +obj-$(CONFIG_INTEL_SCU_IPC) += scu/ +obj-$(CONFIG_INTEL_SCU_PCI) += scu/ obj-$(CONFIG_INTEL_SCU_PLATFORM) += scu/ -obj-$(CONFIG_INTEL_SCU_WDT) += scu/ +obj-$(CONFIG_INTEL_SCU_WDT) += scu/ obj-$(CONFIG_INTEL_SCU_IPC_UTIL) += scu/ obj-$(CONFIG_INTEL_TELEMETRY) += telemetry/ # Intel uncore drivers -obj-$(CONFIG_INTEL_IPS) += ips/ -obj-$(CONFIG_INTEL_RST) += rst/ -obj-$(CONFIG_INTEL_SMARTCONNECT) += smartconnect/ +obj-$(CONFIG_INTEL_IPS) += ips/ +obj-$(CONFIG_INTEL_RST) += rst/ +obj-$(CONFIG_INTEL_SMARTCONNECT) += smartconnect/ obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) += intel_speed_select_if/ -obj-$(CONFIG_INTEL_TURBO_MAX_3) += turbo_max_3/ +obj-$(CONFIG_INTEL_TURBO_MAX_3) += turbo_max_3/ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += uncore_freq/ - -
drivers/platform/x86/intel/vbtn/Kconfig new file +16 -0
@@ -0,0 +1,16 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +config INTEL_VBTN + tristate "INTEL VIRTUAL BUTTON" + depends on ACPI + depends on INPUT + select INPUT_SPARSEKMAP + help + This driver provides support for the Intel Virtual Button interface. + Some laptops require this driver for power button support. + + To compile this driver as a module, choose M here: the module will + be called intel_vbtn.
drivers/platform/x86/intel/vbtn/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Intel x86 Platform Specific Drivers +# + +obj-$(CONFIG_INTEL_VBTN) += intel-vbtn.o
drivers/platform/x86/intel/vbtn/intel-vbtn.c renamed from drivers/platform/x86/intel-vbtn.c +0 -0
Signature · 1 line
2.31.1
Quoted 3 lines · Kate Hsuan
All the intel platform specific drivers are moved to intel/. It makes more clear file structure to improve the readability.
Thanks for doing this!
I'll review it later on (this or next week), meanwhile can you rebase it on top of PDx86 for-next?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 8 lines · Andy Shevchenko
Quoted 3 lines · Kate Hsuan
All the intel platform specific drivers are moved to intel/. It makes more clear file structure to improve the readability.
Thanks for doing this!
I'll review it later on (this or next week), meanwhile can you rebase it on top of PDx86 for-next?
Okay, most of the basic comments were given by a few people already, I'll wait for v2.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Hi Kate,
Quoted 29 lines · Kate Hsuan
All the intel platform specific drivers are moved to intel/. It makes more clear file structure to improve the readability.
Kate Hsuan (20):
Move Intel hid of pdx86 to intel directory to improve readability. Move Intel WMI driver of pdx86 to intel/ directory to improve
readability.
Move Intel bxtwc driver of pdx86 to intel/ directory to improve
readability.
Move Intelchtdc_tidriver of pdx86 to improve readability. Move MRFLD power button driver of pdx86 to intel directory to improve
readability.
Move Intel PMC core of pdx86 to intel/ directory to improve
readability.
Move Intel PMT driver of pdx86 to intel/ to improve readability. Move Intel P-Unit of pdx86 to intel/ directory to improve readability. Move Intel SCU IPC of pdx86 to intel directory to increase
readability.
Move Intel SoC telemetry driver to intel directory to improve
readability.
Move Intel IPS driver of pdx86 to improve readability. Move Intel RST driver of pdx86 to intel directory to improve
readability.
Move Intel smartconnect driver of pdx86 to intel/ directory to improve
readability.
Move Intel SST driver to intel/ directory to improve readability. Move Intel turbo max 3 driver to intel/ directory to improve
readability.
Move Intel uncore freq driver to intel/ directory to improve
Quoted 8 lines
readability.
Move Intel int0002 vgpio driver to intel/ directory to inprove
readability.
Move Intel thermal driver for menlow platform driver to intel/
directory to improve readability.
Move OakTrail driver to the intel/ directory to improve readability. Move Intel virtual botton driver to intel/ directory to improve
readability.
Thank you for doing this. I have a couple of remarks which I would like to see addressed for version 2 of this series:
1. The commit messages are currently all one line, so basically only a Subject and they are missing a Body describing the change in more detail (as already pointed out by Mika).
2. Kernel patch subjects (the first line of the commit message) should always be prefixed with the subsystem + component which they are for, so instead of e.g.
"Move Intel hid of pdx86 to intel directory to improve readability."
you would use:
"platform/x86: intel-hid: Move to intel sub-directory to improve readability."
But that is a bit long; and normally the Subject line is just a summary while the body explains things like the why, so this should probably be shorted to:
"platform/x86: intel-hid: Move to intel sub-directory"
For the Subject, with the Body explaining what exactly is being changed and why.
3. You are using new sub-directories for all drivers which you are moving, but for drivers which are currently just 1 c-file, this means going from 1 c-file to 3 files (c-file + Kconfig + Makefile) this seems a bit too much. I believe that it would be better for the single file drivers (e.g. intel-hid.c, intel-vbtn.c) to be moved directly under drivers/platform/x86/intel and for there Kconfig and Makefile bits to be moved to the already existing Kconfig and Makefile files there.
4. As Andy already mentioned when moving a file like "intel_scu_ipc.c" to drivers/platform/x86/intel/scu then the whole path becomes:
drivers/platform/x86/intel/scu/intel_scu_ipc.c
Which is quite long / quite a lot to type and repeats intel + scu twice, so it would be better to drop the intel_scu prefix from the filenames in this case resulting in:
drivers/platform/x86/intel/scu/ipc.c
in this example's case. This requires some extrea work:
4.1 You will need to adjust private includes to the new filenames
4.2 If you simply adjust say this Makefile line:
obj-$(CONFIG_INTEL_SCU_PCI) += intel_scu_pcidrv.o
to:
obj-$(CONFIG_INTEL_SCU_PCI) += pcidrv.o
a pcidrv.ko will get build, but that is a very generic name and then we end up with module-name clashes which are not allowed.
So the Makefile needs to become a bit more complicated like this:
intel_scu_pcidrv-y := pcidrv.o
obj-$(CONFIG_INTEL_SCU_PCI) += intel_scu_pcidrv.o
See for example:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/tree/drivers/platform/x86/intel/pmt/Makefile?h=for-next
5. Some of the files which you are moving are mentioned in the MAINTAINERS file. For each file which you are moving please check if it is listed in the MAINTAINERS file, keeping wildcards in mind, so search e.g. for intel_scu for the intel_scu_* move.
And if the file is listed then update the MAINTAINERS entry to point to the new location.
Regards,
Hans
Quoted 123 lines · Hans de Goede
Hi Kate,
Quoted 29 lines · Kate Hsuan
All the intel platform specific drivers are moved to intel/. It makes more clear file structure to improve the readability.
Kate Hsuan (20):
Move Intel hid of pdx86 to intel directory to improve readability. Move Intel WMI driver of pdx86 to intel/ directory to improve
readability.
Move Intel bxtwc driver of pdx86 to intel/ directory to improve
readability.
Move Intelchtdc_tidriver of pdx86 to improve readability. Move MRFLD power button driver of pdx86 to intel directory to improve
readability.
Move Intel PMC core of pdx86 to intel/ directory to improve
readability.
Move Intel PMT driver of pdx86 to intel/ to improve readability. Move Intel P-Unit of pdx86 to intel/ directory to improve readability. Move Intel SCU IPC of pdx86 to intel directory to increase
readability.
Move Intel SoC telemetry driver to intel directory to improve
readability.
Move Intel IPS driver of pdx86 to improve readability. Move Intel RST driver of pdx86 to intel directory to improve
readability.
Move Intel smartconnect driver of pdx86 to intel/ directory to improve
readability.
Move Intel SST driver to intel/ directory to improve readability. Move Intel turbo max 3 driver to intel/ directory to improve
readability.
Move Intel uncore freq driver to intel/ directory to improveQuoted 8 lines
readability.
Move Intel int0002 vgpio driver to intel/ directory to inprove
readability.
Move Intel thermal driver for menlow platform driver to intel/
directory to improve readability.
Move OakTrail driver to the intel/ directory to improve readability. Move Intel virtual botton driver to intel/ directory to improve
readability.Thank you for doing this. I have a couple of remarks which I would like to see addressed for version 2 of this series:
1. The commit messages are currently all one line, so basically only a Subject and they are missing a Body describing the change in more detail (as already pointed out by Mika).
2. Kernel patch subjects (the first line of the commit message) should always be prefixed with the subsystem + component which they are for, so instead of e.g.
"Move Intel hid of pdx86 to intel directory to improve readability."
you would use:
"platform/x86: intel-hid: Move to intel sub-directory to improve readability."
But that is a bit long; and normally the Subject line is just a summary while the body explains things like the why, so this should probably be shorted to:
"platform/x86: intel-hid: Move to intel sub-directory"
For the Subject, with the Body explaining what exactly is being changed and why.
3. You are using new sub-directories for all drivers which you are moving, but for drivers which are currently just 1 c-file, this means going from 1 c-file to 3 files (c-file +
Kconfig+Makefile) this seems a bit too much. I believe that it would be better for the single file drivers (e.g.intel-hid.c,intel-vbtn.c) to be moved directly underdrivers/platform/x86/inteland for thereKconfigandMakefilebits to be moved to the already existingKconfigandMakefilefiles there.4. As Andy already mentioned when moving a file like "
intel_scu_ipc.c" todrivers/platform/x86/intel/scuthen the whole path becomes:
drivers/platform/x86/intel/scu/intel_scu_ipc.cWhich is quite long / quite a lot to type and repeats intel + scu twice, so it would be better to drop the
intel_scuprefix from the filenames in this case resulting in:
drivers/platform/x86/intel/scu/ipc.cin this example's case. This requires some extrea work:
4.1 You will need to adjust private includes to the new filenames
4.2 If you simply adjust say this
Makefileline:obj-$(CONFIG_INTEL_SCU_PCI) += intel_scu_pcidrv.o
to:
obj-$(CONFIG_INTEL_SCU_PCI) += pcidrv.o
a pcidrv.ko will get build, but that is a very generic name and then we end up with module-name clashes which are not allowed.
So the
Makefileneeds to become a bit more complicated like this:intel_scu_pcidrv-y := pcidrv.o
obj-$(CONFIG_INTEL_SCU_PCI) += intel_scu_pcidrv.oSee for example:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/tree/drivers/platform/x86/intel/pmt/Makefile?h=for-next5. Some of the files which you are moving are mentioned in the
MAINTAINERSfile. For each file which you are moving please check if it is listed in theMAINTAINERSfile, keeping wildcards in mind, so search e.g. forintel_scufor the intel_scu_* move.
Quoted 7 lines
And if the file is listed then update the
MAINTAINERSentry to point to the new location.Regards,
Hans
Thanks Hans. I'll do that for my v2 patches.
David E. Box
maintainerHi,
Quoted 3 lines · Kate Hsuan
All the intel platform specific drivers are moved to intel/. It makes more clear file structure to improve the readability.
A lot of subfolders for single files. Is this necessary? I'm submitting a single driver soon, unrelated to anything else. I was just going to drop it in /intel.
David
Quoted 229 lines
Kate Hsuan (20):
Move Intel hid of pdx86 to intel directory to improve readability. Move Intel WMI driver of pdx86 to intel/ directory to improve readability.
Move Intel bxtwc driver of pdx86 to intel/ directory to improve readability.
Move Intelchtdc_tidriver of pdx86 to improve readability. Move MRFLD power button driver of pdx86 to intel directory to improve
readability.
Move Intel PMC core of pdx86 to intel/ directory to improve readability.
Move Intel PMT driver of pdx86 to intel/ to improve readability. Move Intel P-Unit of pdx86 to intel/ directory to improve readability.
Move Intel SCU IPC of pdx86 to intel directory to increase readability.
Move Intel SoC telemetry driver to intel directory to improve readability.
Move Intel IPS driver of pdx86 to improve readability. Move Intel RST driver of pdx86 to intel directory to improve readability.
Move Intel smartconnect driver of pdx86 to intel/ directory to improve
readability.
Move Intel SST driver to intel/ directory to improve readability. Move Intel turbo max 3 driver to intel/ directory to improve readability.
Move Intel uncore freq driver to intel/ directory to improve readability.
Move Intel int0002 vgpio driver to intel/ directory to inprove readability.
Move Intel thermal driver for menlow platform driver to intel/ directory to improve readability.
Move OakTrail driver to the intel/ directory to improve readability.
Move Intel virtual botton driver to intel/ directory to improve readability.drivers/platform/x86/Kconfig | 297 ---------------- --
drivers/platform/x86/Makefile | 34 +- drivers/platform/x86/intel/Kconfig | 21 ++ drivers/platform/x86/intel/Makefile | 31 ++ drivers/platform/x86/intel/bxtwc/Kconfig | 15 + drivers/platform/x86/intel/bxtwc/Makefile | 6 + .../x86/{ => intel/bxtwc}/intel_bxtwc_tmu.c | 0 drivers/platform/x86/intel/chtdc_ti/Kconfig | 16 + drivers/platform/x86/intel/chtdc_ti/Makefile | 7 + .../chtdc_ti}/intel_chtdc_ti_pwrbtn.c | 0 drivers/platform/x86/intel/hid/Kconfig | 17 + drivers/platform/x86/intel/hid/Makefile | 7 + .../platform/x86/{ => intel/hid}/intel-hid.c | 0 drivers/platform/x86/intel/int0002/Kconfig | 23 ++ drivers/platform/x86/intel/int0002/Makefile | 6 + .../{ =>intel/int0002}/intel_int0002_vgpio.c| 0
.../{ => intel}/intel_speed_select_if/Kconfig | 0 .../intel_speed_select_if/Makefile | 0 .../intel_speed_select_if/isst_if_common.c | 0 .../intel_speed_select_if/isst_if_common.h | 0 .../intel_speed_select_if/isst_if_mbox_msr.c | 0 .../intel_speed_select_if/isst_if_mbox_pci.c | 0 .../intel_speed_select_if/isst_if_mmio.c | 0 drivers/platform/x86/intel/ips/Kconfig | 14 + drivers/platform/x86/intel/ips/Makefile | 6 + .../platform/x86/{ => intel/ips}/intel_ips.c | 0 .../platform/x86/{ => intel/ips}/intel_ips.h | 0 drivers/platform/x86/intel/menlow/Kconfig | 14 + drivers/platform/x86/intel/menlow/Makefile | 6 + .../x86/{ => intel/menlow}/intel_menlow.c | 0 drivers/platform/x86/intel/mrfld/Kconfig | 17 + drivers/platform/x86/intel/mrfld/Makefile | 6 + .../{ => intel/mrfld}/intel_mrfld_pwrbtn.c | 0 drivers/platform/x86/intel/oaktrail/Kconfig | 15 + drivers/platform/x86/intel/oaktrail/Makefile | 6 + .../x86/{ =>intel/oaktrail}/intel_oaktrail.c| 0 drivers/platform/x86/intel/pmc_core/Kconfig | 26 ++ drivers/platform/x86/intel/pmc_core/Makefile | 6 + .../x86/{ =>intel/pmc_core}/intel_pmc_core.c| 0 .../x86/{ =>intel/pmc_core}/intel_pmc_core.h| 0 .../pmc_core}/intel_pmc_core_pltdrv.c | 0 drivers/platform/x86/intel/pmt/Kconfig | 41 +++ drivers/platform/x86/intel/pmt/Makefile | 9 + .../x86/{ => intel/pmt}/intel_pmt_class.c | 0 .../x86/{ => intel/pmt}/intel_pmt_class.h | 0 .../x86/{ => intel/pmt}/intel_pmt_crashlog.c | 0 .../x86/{ =>intel/pmt}/intel_pmt_telemetry.c| 0 drivers/platform/x86/intel/punit/Kconfig | 10 + drivers/platform/x86/intel/punit/Makefile | 6 + .../x86/{ => intel/punit}/intel_punit_ipc.c | 0 drivers/platform/x86/intel/rst/Kconfig | 16 + drivers/platform/x86/intel/rst/Makefile | 6 + .../platform/x86/{ => intel/rst}/intel-rst.c | 0 drivers/platform/x86/intel/scu/Kconfig | 52 +++ drivers/platform/x86/intel/scu/Makefile | 11 + .../x86/{ => intel/scu}/intel_scu_ipc.c | 0 .../x86/{ => intel/scu}/intel_scu_ipcutil.c | 0 .../x86/{ => intel/scu}/intel_scu_pcidrv.c | 0 .../x86/{ => intel/scu}/intel_scu_pltdrv.c | 0 .../x86/{ => intel/scu}/intel_scu_wdt.c | 0 .../platform/x86/intel/smartconnect/Kconfig | 18 ++ .../platform/x86/intel/smartconnect/Makefile | 6 + .../smartconnect}/intel-smartconnect.c | 0 drivers/platform/x86/intel/telemetry/Kconfig | 16 +drivers/platform/x86/intel/telemetry/Makefile| 9 + .../telemetry}/intel_telemetry_core.c | 0 .../telemetry}/intel_telemetry_debugfs.c | 0 .../telemetry}/intel_telemetry_pltdrv.c | 0 .../platform/x86/intel/turbo_max_3/Kconfig | 14 + .../platform/x86/intel/turbo_max_3/Makefile | 6 + .../turbo_max_3}/intel_turbo_max_3.c | 0 .../platform/x86/intel/uncore_freq/Kconfig | 15 + .../platform/x86/intel/uncore_freq/Makefile | 6 + .../uncore_freq}/intel-uncore-frequency.c | 0 drivers/platform/x86/intel/vbtn/Kconfig | 16 + drivers/platform/x86/intel/vbtn/Makefile | 6 + .../x86/{ => intel/vbtn}/intel-vbtn.c | 0 drivers/platform/x86/intel/wmi/Kconfig | 26 ++ drivers/platform/x86/intel/wmi/Makefile | 7 + .../{ =>intel/wmi}/intel-wmi-sbl-fw-update.c| 0
.../{ => intel/wmi}/intel-wmi-thunderbolt.c | 081 files changed, 562 insertions(+), 330 deletions(-)create mode 100644
drivers/platform/x86/intel/bxtwc/Kconfigcreate mode 100644drivers/platform/x86/intel/bxtwc/Makefilerenamedrivers/platform/x86/{=>intel/bxtwc}/intel_bxtwc_tmu.c(100%)
create mode 100644drivers/platform/x86/intel/chtdc_ti/Kconfigcreate mode 100644drivers/platform/x86/intel/chtdc_ti/Makefilerenamedrivers/platform/x86/{=>intel/chtdc_ti}/intel_chtdc_ti_pwrbtn.c(100%)
create mode 100644drivers/platform/x86/intel/hid/Kconfigcreate mode 100644drivers/platform/x86/intel/hid/Makefilerenamedrivers/platform/x86/{=>intel/hid}/intel-hid.c(100%) create mode 100644drivers/platform/x86/intel/int0002/Kconfigcreate mode 100644drivers/platform/x86/intel/int0002/Makefilerenamedrivers/platform/x86/{=>intel/int0002}/intel_int0002_vgpio.c(100%)
renamedrivers/platform/x86/{=> intel}/intel_speed_select_if/Kconfig (100%)
renamedrivers/platform/x86/{=> intel}/intel_speed_select_if/Makefile (100%)
renamedrivers/platform/x86/{=>intel}/intel_speed_select_if/isst_if_common.c(100%) renamedrivers/platform/x86/{=>intel}/intel_speed_select_if/isst_if_common.h(100%) renamedrivers/platform/x86/{=>intel}/intel_speed_select_if/isst_if_mbox_msr.c(100%) renamedrivers/platform/x86/{=>intel}/intel_speed_select_if/isst_if_mbox_pci.c(100%) renamedrivers/platform/x86/{=>intel}/intel_speed_select_if/isst_if_mmio.c(100%)
create mode 100644drivers/platform/x86/intel/ips/Kconfigcreate mode 100644drivers/platform/x86/intel/ips/Makefilerenamedrivers/platform/x86/{=>intel/ips}/intel_ips.c(100%) renamedrivers/platform/x86/{=>intel/ips}/intel_ips.h(100%) create mode 100644drivers/platform/x86/intel/menlow/Kconfigcreate mode 100644drivers/platform/x86/intel/menlow/Makefilerenamedrivers/platform/x86/{=>intel/menlow}/intel_menlow.c(100%) create mode 100644drivers/platform/x86/intel/mrfld/Kconfigcreate mode 100644drivers/platform/x86/intel/mrfld/Makefilerenamedrivers/platform/x86/{=>intel/mrfld}/intel_mrfld_pwrbtn.c(100%)
create mode 100644drivers/platform/x86/intel/oaktrail/Kconfigcreate mode 100644drivers/platform/x86/intel/oaktrail/Makefilerenamedrivers/platform/x86/{=>intel/oaktrail}/intel_oaktrail.c(100%)
create mode 100644drivers/platform/x86/intel/pmc_core/Kconfigcreate mode 100644drivers/platform/x86/intel/pmc_core/Makefilerenamedrivers/platform/x86/{=>intel/pmc_core}/intel_pmc_core.c(100%)
renamedrivers/platform/x86/{=>intel/pmc_core}/intel_pmc_core.h(100%)
renamedrivers/platform/x86/{=>intel/pmc_core}/intel_pmc_core_pltdrv.c(100%)
create mode 100644drivers/platform/x86/intel/pmt/Kconfigcreate mode 100644drivers/platform/x86/intel/pmt/Makefilerenamedrivers/platform/x86/{=>intel/pmt}/intel_pmt_class.c(100%) renamedrivers/platform/x86/{=>intel/pmt}/intel_pmt_class.h(100%) renamedrivers/platform/x86/{=>intel/pmt}/intel_pmt_crashlog.c(100%)
renamedrivers/platform/x86/{=>intel/pmt}/intel_pmt_telemetry.c(100%)
create mode 100644drivers/platform/x86/intel/punit/Kconfigcreate mode 100644drivers/platform/x86/intel/punit/Makefilerenamedrivers/platform/x86/{=>intel/punit}/intel_punit_ipc.c(100%)
create mode 100644drivers/platform/x86/intel/rst/Kconfigcreate mode 100644drivers/platform/x86/intel/rst/Makefilerenamedrivers/platform/x86/{=>intel/rst}/intel-rst.c(100%) create mode 100644drivers/platform/x86/intel/scu/Kconfigcreate mode 100644drivers/platform/x86/intel/scu/Makefilerenamedrivers/platform/x86/{=>intel/scu}/intel_scu_ipc.c(100%) renamedrivers/platform/x86/{=>intel/scu}/intel_scu_ipcutil.c(100%)
renamedrivers/platform/x86/{=>intel/scu}/intel_scu_pcidrv.c(100%)
renamedrivers/platform/x86/{=>intel/scu}/intel_scu_pltdrv.c(100%)
renamedrivers/platform/x86/{=>intel/scu}/intel_scu_wdt.c(100%) create mode 100644drivers/platform/x86/intel/smartconnect/Kconfigcreate mode 100644drivers/platform/x86/intel/smartconnect/Makefilerenamedrivers/platform/x86/{=> intel/smartconnect}/intel-smartconnect.c(100%)
create mode 100644drivers/platform/x86/intel/telemetry/Kconfigcreate mode 100644drivers/platform/x86/intel/telemetry/Makefilerenamedrivers/platform/x86/{=>intel/telemetry}/intel_telemetry_core.c(100%)
renamedrivers/platform/x86/{=>intel/telemetry}/intel_telemetry_debugfs.c(100%)
renamedrivers/platform/x86/{=>intel/telemetry}/intel_telemetry_pltdrv.c(100%)
create mode 100644drivers/platform/x86/intel/turbo_max_3/Kconfigcreate mode 100644drivers/platform/x86/intel/turbo_max_3/Makefilerenamedrivers/platform/x86/{=>intel/turbo_max_3}/intel_turbo_max_3.c(100%)
create mode 100644drivers/platform/x86/intel/uncore_freq/Kconfigcreate mode 100644drivers/platform/x86/intel/uncore_freq/Makefilerenamedrivers/platform/x86/{=> intel/uncore_freq}/intel-uncore-frequency.c(100%)
create mode 100644drivers/platform/x86/intel/vbtn/Kconfigcreate mode 100644drivers/platform/x86/intel/vbtn/Makefilerenamedrivers/platform/x86/{=>intel/vbtn}/intel-vbtn.c(100%) create mode 100644drivers/platform/x86/intel/wmi/Kconfigcreate mode 100644drivers/platform/x86/intel/wmi/Makefilerenamedrivers/platform/x86/{=> intel/wmi}/intel-wmi-sbl-fw-update.c(100%)
renamedrivers/platform/x86/{=>intel/wmi}/intel-wmi-thunderbolt.c(100%)
Quoted 11 lines · David E. Box
Hi,
Quoted 3 lines · Kate Hsuan
All the intel platform specific drivers are moved to intel/. It makes more clear file structure to improve the readability.
A lot of subfolders for single files. Is this necessary? I'm submitting a single driver soon, unrelated to anything else. I was just going to drop it in /intel.
Ugh, surely not necessary. Not even desirable IMO.
Thanks for bringing that up.
Quoted 232 lines
Quoted 230 lines
Kate Hsuan (20):
Move Intel hid of pdx86 to intel directory to improve readability. Move Intel WMI driver of pdx86 to intel/ directory to improve readability.
Move Intel bxtwc driver of pdx86 to intel/ directory to improve readability.
Move Intelchtdc_tidriver of pdx86 to improve readability. Move MRFLD power button driver of pdx86 to intel directory to
improve
readability.
Move Intel PMC core of pdx86 to intel/ directory to improve readability.
Move Intel PMT driver of pdx86 to intel/ to improve readability. Move Intel P-Unit of pdx86 to intel/ directory to improve
readability.
Move Intel SCU IPC of pdx86 to intel directory to increase readability.
Move Intel SoC telemetry driver to intel directory to improve readability.
Move Intel IPS driver of pdx86 to improve readability. Move Intel RST driver of pdx86 to intel directory to improve readability.
Move Intel smartconnect driver of pdx86 to intel/ directory to
improve
readability.
Move Intel SST driver to intel/ directory to improve readability. Move Intel turbo max 3 driver to intel/ directory to improve readability.
Move Intel uncore freq driver to intel/ directory to improve readability.
Move Intel int0002 vgpio driver to intel/ directory to inprove readability.
Move Intel thermal driver for menlow platform driver to intel/ directory to improve readability.
Move OakTrail driver to the intel/ directory to improve
readability.
Move Intel virtual botton driver to intel/ directory to improve readability.drivers/platform/x86/Kconfig | 297 ---------------- -- drivers/platform/x86/Makefile | 34 +- drivers/platform/x86/intel/Kconfig | 21 ++ drivers/platform/x86/intel/Makefile | 31 ++ drivers/platform/x86/intel/bxtwc/Kconfig | 15 + drivers/platform/x86/intel/bxtwc/Makefile | 6 + .../x86/{ => intel/bxtwc}/intel_bxtwc_tmu.c | 0 drivers/platform/x86/intel/chtdc_ti/Kconfig | 16 + drivers/platform/x86/intel/chtdc_ti/Makefile | 7 + .../chtdc_ti}/intel_chtdc_ti_pwrbtn.c | 0 drivers/platform/x86/intel/hid/Kconfig | 17 + drivers/platform/x86/intel/hid/Makefile | 7 + .../platform/x86/{ => intel/hid}/intel-hid.c | 0 drivers/platform/x86/intel/int0002/Kconfig | 23 ++ drivers/platform/x86/intel/int0002/Makefile | 6 + .../{ => intel/int0002}/intel_int0002_vgpio.c | 0 .../{ => intel}/intel_speed_select_if/Kconfig | 0 .../intel_speed_select_if/Makefile | 0 .../intel_speed_select_if/isst_if_common.c | 0 .../intel_speed_select_if/isst_if_common.h | 0 .../intel_speed_select_if/isst_if_mbox_msr.c | 0 .../intel_speed_select_if/isst_if_mbox_pci.c | 0 .../intel_speed_select_if/isst_if_mmio.c | 0 drivers/platform/x86/intel/ips/Kconfig | 14 + drivers/platform/x86/intel/ips/Makefile | 6 + .../platform/x86/{ => intel/ips}/intel_ips.c | 0 .../platform/x86/{ => intel/ips}/intel_ips.h | 0 drivers/platform/x86/intel/menlow/Kconfig | 14 + drivers/platform/x86/intel/menlow/Makefile | 6 + .../x86/{ => intel/menlow}/intel_menlow.c | 0 drivers/platform/x86/intel/mrfld/Kconfig | 17 + drivers/platform/x86/intel/mrfld/Makefile | 6 + .../{ => intel/mrfld}/intel_mrfld_pwrbtn.c | 0 drivers/platform/x86/intel/oaktrail/Kconfig | 15 + drivers/platform/x86/intel/oaktrail/Makefile | 6 + .../x86/{ => intel/oaktrail}/intel_oaktrail.c | 0 drivers/platform/x86/intel/pmc_core/Kconfig | 26 ++ drivers/platform/x86/intel/pmc_core/Makefile | 6 + .../x86/{ => intel/pmc_core}/intel_pmc_core.c | 0 .../x86/{ => intel/pmc_core}/intel_pmc_core.h | 0 .../pmc_core}/intel_pmc_core_pltdrv.c | 0 drivers/platform/x86/intel/pmt/Kconfig | 41 +++ drivers/platform/x86/intel/pmt/Makefile | 9 + .../x86/{ => intel/pmt}/intel_pmt_class.c | 0 .../x86/{ => intel/pmt}/intel_pmt_class.h | 0 .../x86/{ => intel/pmt}/intel_pmt_crashlog.c | 0 .../x86/{ => intel/pmt}/intel_pmt_telemetry.c | 0 drivers/platform/x86/intel/punit/Kconfig | 10 + drivers/platform/x86/intel/punit/Makefile | 6 + .../x86/{ => intel/punit}/intel_punit_ipc.c | 0 drivers/platform/x86/intel/rst/Kconfig | 16 + drivers/platform/x86/intel/rst/Makefile | 6 + .../platform/x86/{ => intel/rst}/intel-rst.c | 0 drivers/platform/x86/intel/scu/Kconfig | 52 +++ drivers/platform/x86/intel/scu/Makefile | 11 + .../x86/{ => intel/scu}/intel_scu_ipc.c | 0 .../x86/{ => intel/scu}/intel_scu_ipcutil.c | 0 .../x86/{ => intel/scu}/intel_scu_pcidrv.c | 0 .../x86/{ => intel/scu}/intel_scu_pltdrv.c | 0 .../x86/{ => intel/scu}/intel_scu_wdt.c | 0 .../platform/x86/intel/smartconnect/Kconfig | 18 ++ .../platform/x86/intel/smartconnect/Makefile | 6 + .../smartconnect}/intel-smartconnect.c | 0 drivers/platform/x86/intel/telemetry/Kconfig | 16 + drivers/platform/x86/intel/telemetry/Makefile | 9 + .../telemetry}/intel_telemetry_core.c | 0 .../telemetry}/intel_telemetry_debugfs.c | 0 .../telemetry}/intel_telemetry_pltdrv.c | 0 .../platform/x86/intel/turbo_max_3/Kconfig | 14 + .../platform/x86/intel/turbo_max_3/Makefile | 6 + .../turbo_max_3}/intel_turbo_max_3.c | 0 .../platform/x86/intel/uncore_freq/Kconfig | 15 + .../platform/x86/intel/uncore_freq/Makefile | 6 + .../uncore_freq}/intel-uncore-frequency.c | 0 drivers/platform/x86/intel/vbtn/Kconfig | 16 + drivers/platform/x86/intel/vbtn/Makefile | 6 + .../x86/{ => intel/vbtn}/intel-vbtn.c | 0 drivers/platform/x86/intel/wmi/Kconfig | 26 ++ drivers/platform/x86/intel/wmi/Makefile | 7 + .../{ => intel/wmi}/intel-wmi-sbl-fw-update.c | 0 .../{ => intel/wmi}/intel-wmi-thunderbolt.c | 0 81 files changed, 562 insertions(+), 330 deletions(-)create mode 100644
drivers/platform/x86/intel/bxtwc/Kconfigcreate mode 100644drivers/platform/x86/intel/bxtwc/Makefilerenamedrivers/platform/x86/{=>intel/bxtwc}/intel_bxtwc_tmu.c
(100%)
create mode 100644drivers/platform/x86/intel/chtdc_ti/Kconfigcreate mode 100644drivers/platform/x86/intel/chtdc_ti/Makefilerenamedrivers/platform/x86/{=>intel/chtdc_ti}/intel_chtdc_ti_pwrbtn.c(100%)
create mode 100644drivers/platform/x86/intel/hid/Kconfigcreate mode 100644drivers/platform/x86/intel/hid/Makefilerenamedrivers/platform/x86/{=>intel/hid}/intel-hid.c(100%) create mode 100644drivers/platform/x86/intel/int0002/Kconfigcreate mode 100644drivers/platform/x86/intel/int0002/Makefilerenamedrivers/platform/x86/{=>intel/int0002}/intel_int0002_vgpio.c(100%)
renamedrivers/platform/x86/{=>
intel}/intel_speed_select_if/Kconfig (100%)
renamedrivers/platform/x86/{=>
intel}/intel_speed_select_if/Makefile (100%)
renamedrivers/platform/x86/{=>intel}/intel_speed_select_if/isst_if_common.c(100%)
renamedrivers/platform/x86/{=>intel}/intel_speed_select_if/isst_if_common.h(100%)
renamedrivers/platform/x86/{=>intel}/intel_speed_select_if/isst_if_mbox_msr.c(100%)
renamedrivers/platform/x86/{=>intel}/intel_speed_select_if/isst_if_mbox_pci.c(100%)
renamedrivers/platform/x86/{=>intel}/intel_speed_select_if/isst_if_mmio.c(100%)
create mode 100644drivers/platform/x86/intel/ips/Kconfigcreate mode 100644drivers/platform/x86/intel/ips/Makefilerenamedrivers/platform/x86/{=>intel/ips}/intel_ips.c(100%) renamedrivers/platform/x86/{=>intel/ips}/intel_ips.h(100%) create mode 100644drivers/platform/x86/intel/menlow/Kconfigcreate mode 100644drivers/platform/x86/intel/menlow/Makefilerenamedrivers/platform/x86/{=>intel/menlow}/intel_menlow.c(100%) create mode 100644drivers/platform/x86/intel/mrfld/Kconfigcreate mode 100644drivers/platform/x86/intel/mrfld/Makefilerenamedrivers/platform/x86/{=>intel/mrfld}/intel_mrfld_pwrbtn.c
(100%)
create mode 100644drivers/platform/x86/intel/oaktrail/Kconfigcreate mode 100644drivers/platform/x86/intel/oaktrail/Makefilerenamedrivers/platform/x86/{=>intel/oaktrail}/intel_oaktrail.c
(100%)
create mode 100644drivers/platform/x86/intel/pmc_core/Kconfigcreate mode 100644drivers/platform/x86/intel/pmc_core/Makefilerenamedrivers/platform/x86/{=>intel/pmc_core}/intel_pmc_core.c
(100%)
renamedrivers/platform/x86/{=>intel/pmc_core}/intel_pmc_core.h
(100%)
renamedrivers/platform/x86/{=>intel/pmc_core}/intel_pmc_core_pltdrv.c(100%)
create mode 100644drivers/platform/x86/intel/pmt/Kconfigcreate mode 100644drivers/platform/x86/intel/pmt/Makefilerenamedrivers/platform/x86/{=>intel/pmt}/intel_pmt_class.c(100%) renamedrivers/platform/x86/{=>intel/pmt}/intel_pmt_class.h(100%) renamedrivers/platform/x86/{=>intel/pmt}/intel_pmt_crashlog.c
(100%)
renamedrivers/platform/x86/{=>intel/pmt}/intel_pmt_telemetry.c
(100%)
create mode 100644drivers/platform/x86/intel/punit/Kconfigcreate mode 100644drivers/platform/x86/intel/punit/Makefilerenamedrivers/platform/x86/{=>intel/punit}/intel_punit_ipc.c
(100%)
create mode 100644drivers/platform/x86/intel/rst/Kconfigcreate mode 100644drivers/platform/x86/intel/rst/Makefilerenamedrivers/platform/x86/{=>intel/rst}/intel-rst.c(100%) create mode 100644drivers/platform/x86/intel/scu/Kconfigcreate mode 100644drivers/platform/x86/intel/scu/Makefilerenamedrivers/platform/x86/{=>intel/scu}/intel_scu_ipc.c(100%) renamedrivers/platform/x86/{=>intel/scu}/intel_scu_ipcutil.c
(100%)
renamedrivers/platform/x86/{=>intel/scu}/intel_scu_pcidrv.c
(100%)
renamedrivers/platform/x86/{=>intel/scu}/intel_scu_pltdrv.c
(100%)
renamedrivers/platform/x86/{=>intel/scu}/intel_scu_wdt.c(100%) create mode 100644drivers/platform/x86/intel/smartconnect/Kconfigcreate mode 100644drivers/platform/x86/intel/smartconnect/Makefilerenamedrivers/platform/x86/{=> intel/smartconnect}/intel-smartconnect.c(100%)
create mode 100644drivers/platform/x86/intel/telemetry/Kconfigcreate mode 100644drivers/platform/x86/intel/telemetry/Makefilerenamedrivers/platform/x86/{=>intel/telemetry}/intel_telemetry_core.c(100%)
renamedrivers/platform/x86/{=>intel/telemetry}/intel_telemetry_debugfs.c(100%)
renamedrivers/platform/x86/{=>intel/telemetry}/intel_telemetry_pltdrv.c(100%)
create mode 100644drivers/platform/x86/intel/turbo_max_3/Kconfigcreate mode 100644drivers/platform/x86/intel/turbo_max_3/Makefilerenamedrivers/platform/x86/{=>intel/turbo_max_3}/intel_turbo_max_3.c(100%)
create mode 100644drivers/platform/x86/intel/uncore_freq/Kconfigcreate mode 100644drivers/platform/x86/intel/uncore_freq/Makefilerenamedrivers/platform/x86/{=> intel/uncore_freq}/intel-uncore-frequency.c(100%)
create mode 100644drivers/platform/x86/intel/vbtn/Kconfigcreate mode 100644drivers/platform/x86/intel/vbtn/Makefilerenamedrivers/platform/x86/{=>intel/vbtn}/intel-vbtn.c(100%) create mode 100644drivers/platform/x86/intel/wmi/Kconfigcreate mode 100644drivers/platform/x86/intel/wmi/Makefilerenamedrivers/platform/x86/{=> intel/wmi}/intel-wmi-sbl-fw-update.c(100%)
renamedrivers/platform/x86/{=>intel/wmi}/intel-wmi-thunderbolt.c
(100%)
Signature · 3 lines
~Randy Reported-by: Randy Dunlap <[email protected]> https://people.kernel.org/tglx/notes-about-netiquette