Skip to contentSkip to conversation

opus-tools: update to 0.2 and fix license

PATCH Superseded Michael Opdenacker 2 participants 6 messages Aug 10, 2021 – Aug 12, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 opus-tools: update to 0.2 and fix license

The license in version 0.1.8 was already BSD-2-Clause and GPLv2 (for the "opusinfo" command).

The license checksum change is due to trivial changes on the license text ("https" instead of "http" and whitespace changes).

This new version now DEPENDs on "libopusenc" and "opusfile" too.

---
 .../opus-tools/opus-tools_0.1.8.bb                | 15 ---------------
 .../opus-tools/opus-tools_0.2.bb                  | 15 +++++++++++++++
 2 files changed, 15 insertions(+), 15 deletions(-)
 delete mode 100644 meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
 create mode 100644 meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb
meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb deleted +0 -15
deleted file mode 100644
index a84f2bf07..000000000
@@ -1,15 +0,0 @@
-SUMMARY = "Opus Audio Tools"
-HOMEPAGE = "http://www.opus-codec.org/"
-
-LICENSE = "BSD-2-Clause"
-LIC_FILES_CHKSUM = "file://COPYING;md5=843a066da9f1facfcc6ea6f616ffecb1"
-
-SRC_URI = "http://downloads.xiph.org/releases/opus/opus-tools-${PV}.tar.gz"
-SRC_URI[md5sum] = "b424790eda9357a4df394e2d7ca19eac"
-SRC_URI[sha256sum] = "e4e188579ea1c4e4d5066460d4a7214a7eafe3539e9a4466fdc98af41ba4a2f6"
-
-S = "${WORKDIR}/opus-tools-${PV}"
-
-DEPENDS = "libopus flac"
-
-inherit autotools pkgconfig
meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb new file +15 -0
new file mode 100644
index 000000000..b5e6ed947
@@ -0,0 +1,15 @@
+SUMMARY = "Opus Audio Tools"
+HOMEPAGE = "http://www.opus-codec.org/"
+
+LICENSE = "BSD-2-Clause & GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=79f6fc2a6239fbe5f6e52f20ac76698c"
+
+SRC_URI = "http://downloads.xiph.org/releases/opus/opus-tools-${PV}.tar.gz"
+SRC_URI[md5sum] = "ff2d0536e960cabbfb8ca7c8c1759b6c"
+SRC_URI[sha256sum] = "b4e56cb00d3e509acfba9a9b627ffd8273b876b4e2408642259f6da28fa0ff86"
+
+S = "${WORKDIR}/opus-tools-${PV}"
+
+DEPENDS = "libopus libopusenc flac opusfile"
+
+inherit autotools pkgconfig
Signature · 1 line
2.25.1
#1 lore raw
Quoted 9 lines · Michael Opdenacker

The license in version 0.1.8 was already BSD-2-Clause and GPLv2 (for the "opusinfo" command).

The license checksum change is due to trivial changes on the license text ("https" instead of "http" and whitespace changes).

This new version now DEPENDs on "libopusenc" and "opusfile" too.

Thanks for this patch, it brings up a YP compatibility issue to front see
https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1455

I think it would be better to move this recipe to meta-multimedia which should fix it.

Quoted 56 lines
---
 .../opus-tools/opus-tools_0.1.8.bb                | 15 ---------------
 .../opus-tools/opus-tools_0.2.bb                  | 15 +++++++++++++++
 2 files changed, 15 insertions(+), 15 deletions(-)
 delete mode 100644 meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
 create mode 100644 meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb
meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb deleted +0 -15
deleted file mode 100644
index a84f2bf07..000000000
@@ -1,15 +0,0 @@
-SUMMARY = "Opus Audio Tools"
-HOMEPAGE = "http://www.opus-codec.org/"
-
-LICENSE = "BSD-2-Clause"
-LIC_FILES_CHKSUM = "file://COPYING;md5=843a066da9f1facfcc6ea6f616ffecb1"
-
-SRC_URI = "http://downloads.xiph.org/releases/opus/opus-tools-${PV}.tar.gz"
-SRC_URI[md5sum] = "b424790eda9357a4df394e2d7ca19eac"
-SRC_URI[sha256sum] = "e4e188579ea1c4e4d5066460d4a7214a7eafe3539e9a4466fdc98af41ba4a2f6"
-
-S = "${WORKDIR}/opus-tools-${PV}"
-
-DEPENDS = "libopus flac"
-
-inherit autotools pkgconfig
meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb new file +15 -1
new file mode 100644
index 000000000..b5e6ed947
@@ -0,0 +1,15 @@
+SUMMARY = "Opus Audio Tools"
+HOMEPAGE = "http://www.opus-codec.org/"
+
+LICENSE = "BSD-2-Clause & GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=79f6fc2a6239fbe5f6e52f20ac76698c"
+
+SRC_URI = "http://downloads.xiph.org/releases/opus/opus-tools-${PV}.tar.gz"
+SRC_URI[md5sum] = "ff2d0536e960cabbfb8ca7c8c1759b6c"
+SRC_URI[sha256sum] = "b4e56cb00d3e509acfba9a9b627ffd8273b876b4e2408642259f6da28fa0ff86"
+
+S = "${WORKDIR}/opus-tools-${PV}"
+
+DEPENDS = "libopus libopusenc flac opusfile"
+
+inherit autotools pkgconfig
--

2.25.1

#2 lore raw

Hi Khem,

Thanks for the review and checking the test report!

Quoted 8 lines · Khem Raj
Quoted 6 lines · Michael Opdenacker

The license in version 0.1.8 was already BSD-2-Clause and GPLv2 (for the "opusinfo" command).

The license checksum change is due to trivial changes on the license text ("https" instead of "http" and whitespace changes).

Quoted 7 lines
Quoted 2 lines

This new version now DEPENDs on "libopusenc" and "opusfile" too.

Thanks for this patch, it brings up a YP compatibility issue to front see
https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1455

I think it would be better to move this recipe to meta-multimedia which should fix it.

I'll be happy to.
However, what's really the difference between meta-oe/recipes-multimedia and meta-multimedia/recipes-multimedia/? Why two different directories in the same repository?

Thanks again,
Michael.

Signature · 3 lines
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw
Quoted 19 lines · Michael Opdenacker

Hi Khem,

Thanks for the review and checking the test report!

Quoted 13 lines · Khem Raj
Quoted 8 lines · Michael Opdenacker

The license in version 0.1.8 was already BSD-2-Clause and GPLv2 (for the "opusinfo" command).

The license checksum change is due to trivial changes on the license text ("https" instead of "http" and whitespace changes).

This new version now DEPENDs on "libopusenc" and "opusfile" too.

Thanks for this patch, it brings up a YP compatibility issue to front see
https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1455

Quoted 8 lines
Quoted 2 lines

I think it would be better to move this recipe to meta-multimedia which should fix it.

I'll be happy to.
However, what's really the difference between meta-oe/recipes-multimedia and meta-multimedia/recipes-multimedia/? Why two different directories in the same repository?

these are two different layers, someone may not use meta-multimedia if its not in bblayers.conf
and thusly not see the dir under meta-multimedia, so tools/packages which are media related
but more or less generic go into meta-oe/recipe-multimedia, which this upgrade now depends
on packages in meta-multimedia so its better to put it in meta-multimedia now

Quoted 9 lines

Thanks again,
Michael.

--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#4 lore raw

Hi Khem,

Quoted 7 lines · Khem Raj
Quoted 5 lines · Michael Opdenacker

I'll be happy to.
However, what's really the difference between meta-oe/recipes-multimedia and meta-multimedia/recipes-multimedia/? Why two different directories in the same repository?

Quoted 7 lines

these are two different layers, someone may not use meta-multimedia if its not in bblayers.conf
and thusly not see the dir under meta-multimedia, so tools/packages which are media related
but more or less generic go into meta-oe/recipe-multimedia, which this upgrade now depends
on packages in meta-multimedia so its better to put it in meta-multimedia now

Thank you for the clarification. Now I understand that "meta-oe" is rather for generic packages (outside of oe-core, of course), and the other layers are for more specific purposes.

Cheers,
Michael.

Signature · 3 lines
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#5 lore raw

PATCH v2 1/1 opus-tools: update to 0.2, move to meta-multimedia and fix license

In reply to Khem Raj

The license in version 0.1.8 was already BSD-2-Clause and GPLv2 (for the "opusinfo" command).

The license checksum change is due to trivial changes on the license text ("https" instead of "http" and whitespace changes).

This new version now DEPENDs on "libopusenc" and "opusfile" too, but this required to move the recipe to meta-multimedia instead.

---
 .../opus-tools/opus-tools_0.2.bb                  | 15 +++++++++++++++
 .../packagegroups/packagegroup-meta-multimedia.bb |  1 +
 .../packagegroups/packagegroup-meta-oe.bb         |  1 -
 .../opus-tools/opus-tools_0.1.8.bb                | 15 ---------------
 4 files changed, 16 insertions(+), 16 deletions(-)
 create mode 100644 meta-multimedia/recipes-multimedia/opus-tools/opus-tools_0.2.bb
 delete mode 100644 meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
meta-multimedia/recipes-multimedia/opus-tools/opus-tools_0.2.bb new file +15 -0
new file mode 100644
index 000000000..b5e6ed947
@@ -0,0 +1,15 @@
+SUMMARY = "Opus Audio Tools"
+HOMEPAGE = "http://www.opus-codec.org/"
+
+LICENSE = "BSD-2-Clause & GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=79f6fc2a6239fbe5f6e52f20ac76698c"
+
+SRC_URI = "http://downloads.xiph.org/releases/opus/opus-tools-${PV}.tar.gz"
+SRC_URI[md5sum] = "ff2d0536e960cabbfb8ca7c8c1759b6c"
+SRC_URI[sha256sum] = "b4e56cb00d3e509acfba9a9b627ffd8273b876b4e2408642259f6da28fa0ff86"
+
+S = "${WORKDIR}/opus-tools-${PV}"
+
+DEPENDS = "libopus libopusenc flac opusfile"
+
+inherit autotools pkgconfig
meta-multimedia/recipes-multimedia/packagegroups/packagegroup-meta-multimedia.bb +1 -0
index 9e0c319c3..5522731a2 100644
@@ -66,6 +66,7 @@ RDEPENDS:packagegroup-meta-multimedia = "\
     mycroft \
     openal-soft \
     opusfile \
+    opus-tools \
     libdvdcss \
     ${@bb.utils.contains("LICENSE_FLAGS_WHITELIST", "commercial", bb.utils.contains("DISTRO_FEATURES", "x11", "vlc", "", d), "", d)} \
     ${@bb.utils.contains("LICENSE_FLAGS_WHITELIST", "commercial", "sox streamripper", "", d)} \
meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb +0 -1
index 47ee3099a..b03525de3 100644
@@ -668,7 +668,6 @@ RDEPENDS:packagegroup-meta-oe-multimedia ="\
     live555-examples \
     live555-mediaserver \
     libmikmod \
-    opus-tools \
     libmodplug \
     sound-theme-freedesktop \
     yavta \
meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb deleted +0 -15
deleted file mode 100644
index a84f2bf07..000000000
@@ -1,15 +0,0 @@
-SUMMARY = "Opus Audio Tools"
-HOMEPAGE = "http://www.opus-codec.org/"
-
-LICENSE = "BSD-2-Clause"
-LIC_FILES_CHKSUM = "file://COPYING;md5=843a066da9f1facfcc6ea6f616ffecb1"
-
-SRC_URI = "http://downloads.xiph.org/releases/opus/opus-tools-${PV}.tar.gz"
-SRC_URI[md5sum] = "b424790eda9357a4df394e2d7ca19eac"
-SRC_URI[sha256sum] = "e4e188579ea1c4e4d5066460d4a7214a7eafe3539e9a4466fdc98af41ba4a2f6"
-
-S = "${WORKDIR}/opus-tools-${PV}"
-
-DEPENDS = "libopus flac"
-
-inherit autotools pkgconfig
Signature · 1 line
2.25.1