Skip to contentSkip to conversation

rasdaemon: ras-mc-ctl: Fix script to parse dimm sizes

PATCH New Naveen Krishna Chatradhi 1 participant 1 message Aug 10, 2021 EDAC-core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rasdaemon: ras-mc-ctl: Fix script to parse dimm sizes

From: Muralidhara M K <[email protected]>

This patch removes trailing spaces at the end of a line from file location and fixes --layout option to parse dimm nodes to get the size from ras-mc-ctl.

Issue is reported https://github.com/mchehab/rasdaemon/issues/43
Where '> ras-mc-ctl --layout' reports all 0s

With this change the layout prints the correct dimm sizes

Quoted 1 line

sudo ras-mc-ctl --layout

          +-----------------------------------------------+
          |                      mc0                      |
          |  csrow0   |  csrow1   |  csrow2   |  csrow3   |

----------+-----------------------------------------------+
...
channel7: | 16384 MB | 0 MB | 0 MB | 0 MB |
channel6: | 16384 MB | 0 MB | 0 MB | 0 MB |
...
----------+-----------------------------------------------+

---
 util/ras-mc-ctl.in | 2 ++
 1 file changed, 2 insertions(+)
util/ras-mc-ctl.in +2 -0
index 1e3aeb7..b22dd60 100755
@@ -246,6 +246,7 @@ sub parse_dimm_nodes
     if (($file =~ /max_location$/)) {
         open IN, $file;
         my $location = <IN>;
+        $location =~ s/\s+$//;
         close IN;
         my @temp = split(/ /, $location);
 
@@ -288,6 +289,7 @@ sub parse_dimm_nodes
 
         open IN, $file;
         my $location = <IN>;
+        $location =~ s/\s+$//;
         close IN;
 
         my @pos;
Signature · 1 line
2.26.2