net: hso: drop unused function argument
Subsystems (5)
PATCH 1/1 net: hso: drop unused function argument
_hso_serial_set_termios() doesn't use it's second argument, so it can be dropped.
Fixes ac9720c37e87 ("tty: Fix the HSO termios handling a bit")
Signed-off-by Pavel Skripkin <[email protected]>
--- drivers/net/usb/hso.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/net/usb/hso.c +3 -4
@@ -1079,8 +1079,7 @@ static void hso_init_termios(struct ktermios *termios)tty_termios_encode_baud_rate (termios,115200 ,115200 ); } -static void _hso_serial_set_termios (struct tty_struct *tty, -struct ktermios *old) +static void _hso_serial_set_termios (struct tty_struct *tty) {struct hso_serial *serial = tty->driver_data;
@@ -1262,7 +1261,7 @@ static int hso_serial_open(struct tty_struct *tty, struct file *filp)if (serial->port.count ==1 ) { serial->rx_state =RX_IDLE ;/* Force default termio settings */ -_hso_serial_set_termios (tty,NULL ); +_hso_serial_set_termios (tty);tasklet_setup (&serial->unthrottle_tasklet, hso_unthrottle_tasklet); result =hso_start_serial_device (serial->parent,GFP_KERNEL );
@@ -1394,7 +1393,7 @@ static void hso_serial_set_termios(struct tty_struct *tty, struct ktermios *old)/* the actual setup */ spin_lock_irqsave (&serial->serial_lock, flags);if (serial->port.count) -_hso_serial_set_termios (tty, old); +_hso_serial_set_termios (tty);else tty->termios = *old;spin_unlock_irqrestore (&serial->serial_lock, flags);
Signature · 1 line
2.32.0
Jakub Kicinski
maintainerQuoted 4 lines · On Wed, 11 Aug 2021 20:13:21 +0300 Pavel Skripkin wrote:
_hso_serial_set_termios()doesn't use it's second argument, so it can be dropped.Fixes ac9720c37e87 ("tty: Fix the HSO termios handling a bit")
This one is not a bug so no fixes tag needed :) applied, thanks