eal/windows: expose symbol rte_version
PATCH 1/1 eal/windows: expose symbol rte_version
When OVS inits, it calls rte_version to get the DPDK's version. The patch fixes the error below by exposing rte_version symbol. libopenvswitch.a(dpdk.c.obj) : error LNK2019: unresolved external symbol rte_version referenced in function dpdk_init
--- lib/eal/version.map | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/eal/version.map +1 -1
@@ -198,7 +198,7 @@ DPDK_21 { rte_uuid_is_null; # WINDOWS_NO_EXPORT rte_uuid_parse; # WINDOWS_NO_EXPORT rte_uuid_unparse; # WINDOWS_NO_EXPORT - rte_version; # WINDOWS_NO_EXPORT + rte_version; rte_vfio_clear_group; # WINDOWS_NO_EXPORT rte_vfio_container_create; # WINDOWS_NO_EXPORT rte_vfio_container_destroy; # WINDOWS_NO_EXPORT
Signature · 1 line
2.32.0.windows.2
2021-08-05 17:48 (UTC+0000), William Tu:
Quoted 4 lines
When OVS inits, it calls
rte_versionto get the DPDK's version. The patch fixes the error below by exposingrte_versionsymbol.libopenvswitch.a(dpdk.c.obj): error LNK2019: unresolved external symbolrte_versionreferenced in functiondpdk_init
Quoted 1 line
Signed-off-by William Tu <[email protected]>
Quoted 9 lines
--- lib/eal/version.map | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/eal/version.map +0
-0
lib/eal/version.map DPDK_21 { · line 204
Quoted 8 lines
lib/eal/version.map +1
-1@@ -198,7 +198,7 @@ DPDK_21 { rte_uuid_is_null; # WINDOWS_NO_EXPORT rte_uuid_parse; # WINDOWS_NO_EXPORT rte_uuid_unparse; # WINDOWS_NO_EXPORT - rte_version; # WINDOWS_NO_EXPORT + rte_version; rte_vfio_clear_group; # WINDOWS_NO_EXPORT rte_vfio_container_create; # WINDOWS_NO_EXPORT rte_vfio_container_destroy; # WINDOWS_NO_EXPORT
I can see many functions not exported on Windows for no reason. This includes the rest of the version API, but it's experimental, so it's better to have this standalone patch for backporting (since the patch it fixes is backported).
I'm going to restore other exports in a bulk patchset.
Thomas Monjalon
Applied11/08/2021 23:55, Dmitry Kozlyuk:
Quoted 6 lines
2021-08-05 17:48 (UTC+0000), William Tu:
Quoted 4 lines
When OVS inits, it calls
rte_versionto get the DPDK's version. The patch fixes the error below by exposingrte_versionsymbol.libopenvswitch.a(dpdk.c.obj): error LNK2019: unresolved external symbolrte_versionreferenced in functiondpdk_init
Quoted 7 lines
Fixes 5b637a848195 ("eal: fix querying DPDK version at runtime")Quoted 1 line
Signed-off-by William Tu <[email protected]>Acked-by Dmitry Kozlyuk <[email protected]>
Applied, thanks.
Note: do not hesitate to ping when a patch is forgotten so long.