Skip to contentSkip to conversation

rockchip: rk33xx: Drop ROCKCHIP_USB2_PHY on boards without it

PATCH In review Peter Robinson 2 participants 2 messages Aug 12, 2021 – Oct 15, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rockchip: rk33xx: Drop ROCKCHIP_USB2_PHY on boards without it

The 64 bit rk33xx chips don't have the ROCKCHIP_USB2_PHY IP so drop the configs as they were likely copied over from other boards during enablement.

---
 configs/lion-rk3368_defconfig             | 1 -
 configs/nanopc-t4-rk3399_defconfig        | 1 -
 configs/roc-pc-mezzanine-rk3399_defconfig | 1 -
 configs/roc-pc-rk3399_defconfig           | 1 -
 configs/rock-pi-n10-rk3399pro_defconfig   | 1 -
 5 files changed, 5 deletions(-)
configs/lion-rk3368_defconfig +0 -1
index 5f7d101814..90a2878e50 100644
@@ -94,7 +94,6 @@ CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
 CONFIG_USB_DWC2=y
-CONFIG_ROCKCHIP_USB2_PHY=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_DWC2_OTG=y
 CONFIG_SPL_TINY_MEMSET=y
configs/nanopc-t4-rk3399_defconfig +0 -1
index a94f428def..62833c386b 100644
@@ -51,7 +51,6 @@ CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
 CONFIG_USB_DWC3=y
-CONFIG_ROCKCHIP_USB2_PHY=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_USB_HOST_ETHER=y
 CONFIG_USB_ETHER_ASIX=y
configs/roc-pc-mezzanine-rk3399_defconfig +0 -1
index 8d0f57021b..6aa47490c1 100644
@@ -69,7 +69,6 @@ CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GENERIC=y
-CONFIG_ROCKCHIP_USB2_PHY=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_USB_HOST_ETHER=y
 CONFIG_USB_ETHER_ASIX=y
configs/roc-pc-rk3399_defconfig +0 -1
index 4e5c90439d..b03ee3664f 100644
@@ -66,7 +66,6 @@ CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GENERIC=y
-CONFIG_ROCKCHIP_USB2_PHY=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_USB_HOST_ETHER=y
 CONFIG_USB_ETHER_ASIX=y
configs/rock-pi-n10-rk3399pro_defconfig +0 -1
index e5df6779de..17442a0d84 100644
@@ -60,7 +60,6 @@ CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GENERIC=y
-CONFIG_ROCKCHIP_USB2_PHY=y
 CONFIG_USB_KEYBOARD=y
 # CONFIG_USB_KEYBOARD_FN_KEYS is not set
 CONFIG_USB_GADGET=y
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw

Thanks,
- Kever

Quoted 77 lines · Peter Robinson <[email protected]> 于2021年8月12日周四 下午5:11写道:

The 64 bit rk33xx chips don't have the ROCKCHIP_USB2_PHY IP so drop the configs as they were likely copied over from other boards during enablement.

---
 configs/lion-rk3368_defconfig             | 1 -
 configs/nanopc-t4-rk3399_defconfig        | 1 -
 configs/roc-pc-mezzanine-rk3399_defconfig | 1 -
 configs/roc-pc-rk3399_defconfig           | 1 -
 configs/rock-pi-n10-rk3399pro_defconfig   | 1 -
 5 files changed, 5 deletions(-)
configs/lion-rk3368_defconfig +0 -1
index 5f7d101814..90a2878e50 100644
@@ -94,7 +94,6 @@ CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
 CONFIG_USB_DWC2=y
-CONFIG_ROCKCHIP_USB2_PHY=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_DWC2_OTG=y
 CONFIG_SPL_TINY_MEMSET=y
configs/nanopc-t4-rk3399_defconfig +0 -1
index a94f428def..62833c386b 100644
@@ -51,7 +51,6 @@ CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
 CONFIG_USB_DWC3=y
-CONFIG_ROCKCHIP_USB2_PHY=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_USB_HOST_ETHER=y
 CONFIG_USB_ETHER_ASIX=y
configs/roc-pc-mezzanine-rk3399_defconfig +0 -1
index 8d0f57021b..6aa47490c1 100644
@@ -69,7 +69,6 @@ CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GENERIC=y
-CONFIG_ROCKCHIP_USB2_PHY=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_USB_HOST_ETHER=y
 CONFIG_USB_ETHER_ASIX=y
configs/roc-pc-rk3399_defconfig +0 -1
index 4e5c90439d..b03ee3664f 100644
@@ -66,7 +66,6 @@ CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GENERIC=y
-CONFIG_ROCKCHIP_USB2_PHY=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_USB_HOST_ETHER=y
 CONFIG_USB_ETHER_ASIX=y
configs/rock-pi-n10-rk3399pro_defconfig +0 -2
index e5df6779de..17442a0d84 100644
@@ -60,7 +60,6 @@ CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GENERIC=y
-CONFIG_ROCKCHIP_USB2_PHY=y
 CONFIG_USB_KEYBOARD=y
 # CONFIG_USB_KEYBOARD_FN_KEYS is not set
 CONFIG_USB_GADGET=y
--

2.31.1