Utils: Change sprintf to snprintf
PATCH 1/1 Utils: Change sprintf to snprintf
Using sprintf can cause segmentation fault by exceeding the size of buffer array.
Signed-off-by Mateusz Kusiak <[email protected]>
--- util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
util.c +2 -2
@@ -947,12 +947,12 @@ dev_t devnm2devid(char *devnm)/* First look in /sys/block/$DEVNM/dev for %d:%d * If that fails, try parsing out a number */ -char path[100 ]; +char path[PATH_MAX ];char *ep;int fd;int mjr,mnr; -sprintf (path,"/sys/block/%s/dev" , devnm); +snprintf (path,sizeof (path),"/sys/block/%s/dev" , devnm); fd =open (path,O_RDONLY );if (fd >=0 ) {char buf[20 ];
Signature · 1 line
2.26.2
Jes Sorensen
AppliedQuoted 6 lines · Mateusz Kusiak
Using sprintf can cause segmentation fault by exceeding the size of buffer array.
Signed-off-by Mateusz Kusiak <[email protected]>--- util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks!
Jes