perf test: Do not compare overheads in the zstd comp test
Subsystems (2)
Namhyung Kim
maintainerPATCH 1/1 perf test: Do not compare overheads in the zstd comp test
The overhead can vary on each run so it'd make the test failed sometimes. Also order of hist entry can change.
Use perf report -F option to omit the overhead field and sort the result alphabetically.
--- tools/perf/tests/shell/record+zstd_comp_decomp.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/tests/shell/record+zstd_comp_decomp.sh +2 -2
@@ -25,8 +25,8 @@ check_compressed_stats() { check_compressed_output() { $perf_tool inject -i $trace_file -o $trace_file.decomp && - $perf_tool report -i $trace_file --stdio | head -n -3 > $trace_file.comp.output && - $perf_tool report -i $trace_file.decomp --stdio | head -n -3 > $trace_file.decomp.output && + $perf_tool report -i $trace_file --stdio -F comm,dso,sym | head -n -3 > $trace_file.comp.output && + $perf_tool report -i $trace_file.decomp --stdio -F comm,dso,sym | head -n -3 > $trace_file.decomp.output && diff $trace_file.comp.output $trace_file.decomp.output }
Signature · 1 line
2.33.0.rc1.237.g0d66db33f3-goog
Quoted 8 lines · Namhyung Kim
The overhead can vary on each run so it'd make the test failed sometimes. Also order of hist entry can change.
Use perf report -F option to omit the overhead field and sort the result alphabetically.
Signed-off-by Namhyung Kim <[email protected]>
Thanks,
Ian
Quoted 22 lines
--- tools/perf/tests/shell/record+zstd_comp_decomp.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/perf/tests/shell/record+zstd_comp_decomp.sh +2
-3@@ -25,8 +25,8 @@ check_compressed_stats() { check_compressed_output() { $perf_tool inject -i $trace_file -o $trace_file.decomp && - $perf_tool report -i $trace_file --stdio | head -n -3 > $trace_file.comp.output && - $perf_tool report -i $trace_file.decomp --stdio | head -n -3 > $trace_file.decomp.output && + $perf_tool report -i $trace_file --stdio -F comm,dso,sym | head -n -3 > $trace_file.comp.output && + $perf_tool report -i $trace_file.decomp --stdio -F comm,dso,sym | head -n -3 > $trace_file.decomp.output && diff $trace_file.comp.output $trace_file.decomp.output } --2.33.0.rc1.237.g0d66db33f3-goog
Em Thu, Aug 12, 2021 at 05:09:20PM -0700, Ian Rogers escreveu:
Quoted 11 lines · Namhyung Kim
Quoted 8 lines
The overhead can vary on each run so it'd make the test failed sometimes. Also order of hist entry can change.
Use perf report -F option to omit the overhead field and sort the result alphabetically.
Signed-off-by Namhyung Kim <[email protected]>Acked-by Ian Rogers <[email protected]>
Thanks, applied.
- Arnaldo
Quoted 25 lines
Thanks,
IanQuoted 22 lines
--- tools/perf/tests/shell/record+zstd_comp_decomp.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/perf/tests/shell/record+zstd_comp_decomp.sh +2
-3@@ -25,8 +25,8 @@ check_compressed_stats() { check_compressed_output() { $perf_tool inject -i $trace_file -o $trace_file.decomp && - $perf_tool report -i $trace_file --stdio | head -n -3 > $trace_file.comp.output && - $perf_tool report -i $trace_file.decomp --stdio | head -n -3 > $trace_file.decomp.output && + $perf_tool report -i $trace_file --stdio -F comm,dso,sym | head -n -3 > $trace_file.comp.output && + $perf_tool report -i $trace_file.decomp --stdio -F comm,dso,sym | head -n -3 > $trace_file.decomp.output && diff $trace_file.comp.output $trace_file.decomp.output } --2.33.0.rc1.237.g0d66db33f3-goog
Signature · 1 line
- Arnaldo