Skip to contentSkip to conversation

fbtft: fb_st7789v: added reset on init_display()

PATCH In review Oliver Graute 2 participants 5 messages Aug 13, 2021 – Feb 10, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fbtft: fb_st7789v: added reset on init_display()

staging: fbtft: fb_st7789v: reset display before initialization

In rare cases the display is flipped or mirrored. This was observed more often in a low temperature environment. A clean reset on init_display() should help to get registers in a sane state.

---
 drivers/staging/fbtft/fb_st7789v.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/staging/fbtft/fb_st7789v.c +2 -0
index 3a280cc1892c..0a2dbed9ffc7 100644
@@ -82,6 +82,8 @@ enum st7789v_command {
 {
 	int rc;
 
+	par->fbtftops.reset(par);
+
 	rc = init_tearing_effect_line(par);
 	if (rc)
 		return rc;
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 1 line · Oliver Graute

staging: fbtft: fb_st7789v: reset display before initialization

What is this line here, and why is this not your subject line instead?

Quoted 6 lines

In rare cases the display is flipped or mirrored. This was observed more often in a low temperature environment. A clean reset on init_display() should help to get registers in a sane state.

What commit does this fix?

thanks,

greg k-h

#2 lore raw
Quoted 4 lines · Greg KH
Quoted 1 line · Oliver Graute

staging: fbtft: fb_st7789v: reset display before initialization

What is this line here, and why is this not your subject line instead?

I'll put the line as subject instead.

Quoted 7 lines
Quoted 5 lines

In rare cases the display is flipped or mirrored. This was observed more often in a low temperature environment. A clean reset on init_display() should help to get registers in a sane state.

What commit does this fix?

this is a fix for a rare behavior of the fb_st7789v display. Not a bugfix for a specific commit.

Best regards,

Oliver

maintainer
#3 lore raw
Quoted 12 lines · Oliver Graute
Quoted 4 lines · Greg KH
Quoted 1 line · Oliver Graute

staging: fbtft: fb_st7789v: reset display before initialization

What is this line here, and why is this not your subject line instead?

I'll put the line as subject instead.

Quoted 4 lines
Quoted 4 lines

In rare cases the display is flipped or mirrored. This was observed more often in a low temperature environment. A clean reset on init_display() should help to get registers in a sane state.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

What commit does this fix?

this is a fix for a rare behavior of the fb_st7789v display. Not a bugfix for a specific commit.

So if it has always been broken, list the commit where the code was added to the kernel, as this should be backported to the stable kernels, right?

thanks,

greg k-h

#4 lore raw
Quoted 15 lines · Greg KH
Quoted 14 lines · Oliver Graute
Quoted 4 lines · Greg KH
Quoted 1 line · Oliver Graute

staging: fbtft: fb_st7789v: reset display before initialization

What is this line here, and why is this not your subject line instead?

I'll put the line as subject instead.

Quoted 6 lines
Quoted 5 lines

In rare cases the display is flipped or mirrored. This was observed more often in a low temperature environment. A clean reset on init_display() should help to get registers in a sane state.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

What commit does this fix?

this is a fix for a rare behavior of the fb_st7789v display. Not a bugfix for a specific commit.

So if it has always been broken, list the commit where the code was added to the kernel, as this should be backported to the stable kernels, right?

ok thx, will list the commit and add [email protected] to cc

thx,

Oliver