x86/kdump: fix wrong judge about crash_size var
PATCH 1/1 x86/kdump: fix wrong judge about crash_size var
The type of crash_size is unsigned long long, so
it can not be less than 0, so there fix it.
Signed-off-by Xin Hao <[email protected]>
--- arch/x86/kernel/setup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/setup.c +2 -2
@@ -472,11 +472,11 @@ static void __init reserve_crashkernel(void)/* crashkernel=XM */ ret =parse_crashkernel (boot_command_line, total_mem, &crash_size, &crash_base); -if (ret !=0 || crash_size <=0 ) { +if (ret !=0 || !crash_size) {/* crashkernel=X,high */ ret =parse_crashkernel_high (boot_command_line, total_mem, &crash_size, &crash_base); -if (ret !=0 || crash_size <=0 ) +if (ret !=0 || !crash_size)return ; high = true; }
--
2.31.0
Hi, everyone:
Why nobody review this patch?
Quoted 28 lines · Xin Hao
The type of
crash_sizeis unsigned long long, so
it can not be less than 0, so there fix it.Signed-off-by Xin Hao <[email protected]>--- arch/x86/kernel/setup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/x86/kernel/setup.c +2
-3@@ -472,11 +472,11 @@ static void __init reserve_crashkernel(void)/* crashkernel=XM */ ret =parse_crashkernel (boot_command_line, total_mem, &crash_size, &crash_base); -if (ret !=0 || crash_size <=0 ) { +if (ret !=0 || !crash_size) {/* crashkernel=X,high */ ret =parse_crashkernel_high (boot_command_line, total_mem, &crash_size, &crash_base); -if (ret !=0 || crash_size <=0 ) +if (ret !=0 || !crash_size)return ; high = true; } --2.31.0
Signature · 2 lines
Best Regards! Xin Hao