Skip to contentSkip to conversation

arm: mvebu: espressobin: Enable also SATA support via PCIe

PATCH In review Pali Rohár 2 participants 9 messages Aug 13, 2021 – Sep 1, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 arm: mvebu: espressobin: Enable also SATA support via PCIe

Espressobin has one on-board SATA port which is connected directly to CPU.

More SATA disks can be connected via mPCIe add-in card with PCIe-SATA controller.

So enable required SATA AHCI PCIe drivers in defconfig file.

---
 configs/mvebu_espressobin-88f3720_defconfig | 2 ++
 1 file changed, 2 insertions(+)
configs/mvebu_espressobin-88f3720_defconfig +2 -0
index c8ae0cf6109a..4003a25346ce 100644
@@ -30,6 +30,7 @@ CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_MTD=y
 CONFIG_CMD_PCI=y
+CONFIG_CMD_SATA=y
 CONFIG_CMD_SPI=y
 CONFIG_CMD_USB=y
 CONFIG_CMD_WDT=y
@@ -46,6 +47,7 @@ CONFIG_ENV_OVERWRITE=y
 CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_AHCI_PCI=y
 CONFIG_AHCI_MVEBU=y
 CONFIG_CLK=y
 CONFIG_CLK_MVEBU=y
Signature · 1 line
2.20.1
#1 lore raw

PATCH 2/3 arm: mvebu: turris_mox: Enable SATA support

SATA disks could be connected via mPCIe add-in card with PCIe-SATA controller into Mox-B or Mox-G module.

---
 configs/turris_mox_defconfig | 6 ++++++
 1 file changed, 6 insertions(+)
configs/turris_mox_defconfig +6 -0
index c19b8379c32a..fc5e1fc3766f 100644
@@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
 CONFIG_DEFAULT_DEVICE_TREE="armada-3720-turris-mox"
 CONFIG_DEBUG_UART_BASE=0xd0012000
 CONFIG_DEBUG_UART=y
+CONFIG_AHCI=y
 CONFIG_OF_BOARD_FIXUP=y
 CONFIG_DISTRO_DEFAULTS=y
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
@@ -32,6 +33,7 @@ CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_MTD=y
 CONFIG_CMD_PCI=y
+CONFIG_CMD_SATA=y
 CONFIG_CMD_SPI=y
 CONFIG_CMD_USB=y
 CONFIG_CMD_WDT=y
@@ -47,6 +49,8 @@ CONFIG_MAC_PARTITION=y
 CONFIG_ENV_OVERWRITE=y
 CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
+CONFIG_SCSI_AHCI=y
+CONFIG_AHCI_PCI=y
 CONFIG_BUTTON=y
 CONFIG_BUTTON_GPIO=y
 CONFIG_CLK=y
@@ -81,6 +85,8 @@ CONFIG_PINCTRL_ARMADA_37XX=y
 CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_DM_RTC=y
 CONFIG_RTC_DS1307=y
+CONFIG_SCSI=y
+CONFIG_DM_SCSI=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_DEBUG_UART_ANNOUNCE=y
 CONFIG_MVEBU_A3700_UART=y
Signature · 1 line
2.20.1
Reviewed-by on v1 2/3
#2 lore raw

Re: [PATCH 2/3] arm: mvebu: turris_mox: Enable SATA support

Quoted 4 lines · Pali Rohár

SATA disks could be connected via mPCIe add-in card with PCIe-SATA controller into Mox-B or Mox-G module.

Thanks,
Stefan

Quoted 35 lines
---
  configs/turris_mox_defconfig | 6 ++++++
  1 file changed, 6 insertions(+)
configs/turris_mox_defconfig +4 -0
index c19b8379c32a..fc5e1fc3766f 100644
@@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
  CONFIG_DEFAULT_DEVICE_TREE="armada-3720-turris-mox"
  CONFIG_DEBUG_UART_BASE=0xd0012000
  CONFIG_DEBUG_UART=y
+CONFIG_AHCI=y
  CONFIG_OF_BOARD_FIXUP=y
  CONFIG_DISTRO_DEFAULTS=y
  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
@@ -32,6 +33,7 @@ CONFIG_CMD_I2C=y
  CONFIG_CMD_MMC=y
  CONFIG_CMD_MTD=y
  CONFIG_CMD_PCI=y
+CONFIG_CMD_SATA=y
  CONFIG_CMD_SPI=y
  CONFIG_CMD_USB=y
  CONFIG_CMD_WDT=y
@@ -47,6 +49,8 @@ CONFIG_MAC_PARTITION=y
  CONFIG_ENV_OVERWRITE=y
  CONFIG_ENV_IS_IN_SPI_FLASH=y
  CONFIG_SYS_RELOC_GD_ENV_ADDR=y
+CONFIG_SCSI_AHCI=y
+CONFIG_AHCI_PCI=y
  CONFIG_BUTTON=y
  CONFIG_BUTTON_GPIO=y
  CONFIG_CLK=y

configs/turris_mox_defconfig CONFIG_PINCTRL_ARMADA_37XX=y · line 92

Quoted 8 lines
configs/turris_mox_defconfig +2 -0
@@ -81,6 +85,8 @@ CONFIG_PINCTRL_ARMADA_37XX=y
  CONFIG_DM_REGULATOR_FIXED=y
  CONFIG_DM_RTC=y
  CONFIG_RTC_DS1307=y
+CONFIG_SCSI=y
+CONFIG_DM_SCSI=y
  CONFIG_DEBUG_UART_SHIFT=2
  CONFIG_DEBUG_UART_ANNOUNCE=y
  CONFIG_MVEBU_A3700_UART=y

Viele Grüße,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#3 lore raw

Re: [PATCH 2/3] arm: mvebu: turris_mox: Enable SATA support

In reply to Pali Rohár
Quoted 4 lines · Pali Rohár

SATA disks could be connected via mPCIe add-in card with PCIe-SATA controller into Mox-B or Mox-G module.

Applied to u-boot-marvell/master

Thanks,
Stefan

Quoted 35 lines
---
  configs/turris_mox_defconfig | 6 ++++++
  1 file changed, 6 insertions(+)
configs/turris_mox_defconfig +4 -0
index c19b8379c32a..fc5e1fc3766f 100644
@@ -12,6 +12,7 @@ CONFIG_DM_GPIO=y
  CONFIG_DEFAULT_DEVICE_TREE="armada-3720-turris-mox"
  CONFIG_DEBUG_UART_BASE=0xd0012000
  CONFIG_DEBUG_UART=y
+CONFIG_AHCI=y
  CONFIG_OF_BOARD_FIXUP=y
  CONFIG_DISTRO_DEFAULTS=y
  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
@@ -32,6 +33,7 @@ CONFIG_CMD_I2C=y
  CONFIG_CMD_MMC=y
  CONFIG_CMD_MTD=y
  CONFIG_CMD_PCI=y
+CONFIG_CMD_SATA=y
  CONFIG_CMD_SPI=y
  CONFIG_CMD_USB=y
  CONFIG_CMD_WDT=y
@@ -47,6 +49,8 @@ CONFIG_MAC_PARTITION=y
  CONFIG_ENV_OVERWRITE=y
  CONFIG_ENV_IS_IN_SPI_FLASH=y
  CONFIG_SYS_RELOC_GD_ENV_ADDR=y
+CONFIG_SCSI_AHCI=y
+CONFIG_AHCI_PCI=y
  CONFIG_BUTTON=y
  CONFIG_BUTTON_GPIO=y
  CONFIG_CLK=y

configs/turris_mox_defconfig CONFIG_PINCTRL_ARMADA_37XX=y · line 92

Quoted 8 lines
configs/turris_mox_defconfig +2 -0
@@ -81,6 +85,8 @@ CONFIG_PINCTRL_ARMADA_37XX=y
  CONFIG_DM_REGULATOR_FIXED=y
  CONFIG_DM_RTC=y
  CONFIG_RTC_DS1307=y
+CONFIG_SCSI=y
+CONFIG_DM_SCSI=y
  CONFIG_DEBUG_UART_SHIFT=2
  CONFIG_DEBUG_UART_ANNOUNCE=y
  CONFIG_MVEBU_A3700_UART=y

Viele Grüße,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#4 lore raw

PATCH 3/3 arm: mvebu: turris_omnia: Enable NVMe support

In reply to Pali Rohár

PCIe-based NVMe SSD disks in M.2 2230/2242/2260 form-factor can be connected to Turris Omnia mPCIe slot via passive M.2 <--> mPCIe adapter.

So enable PCIe NVMe drivers.

---
 configs/turris_omnia_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/turris_omnia_defconfig +1 -0
index cd443ceb300f..2acc4ada4123 100644
@@ -77,6 +77,7 @@ CONFIG_PHY_MARVELL=y
 CONFIG_PHY_GIGE=y
 CONFIG_MVNETA=y
 CONFIG_MII=y
+CONFIG_NVME=y
 CONFIG_PCI=y
 CONFIG_PCI_MVEBU=y
 CONFIG_DM_RTC=y
Signature · 1 line
2.20.1
Reviewed-by on v1 3/3
#5 lore raw

Re: [PATCH 3/3] arm: mvebu: turris_omnia: Enable NVMe support

Quoted 6 lines · Pali Rohár

PCIe-based NVMe SSD disks in M.2 2230/2242/2260 form-factor can be connected to Turris Omnia mPCIe slot via passive M.2 <--> mPCIe adapter.

So enable PCIe NVMe drivers.

Thanks,
Stefan

Quoted 10 lines
---
  configs/turris_omnia_defconfig | 1 +
  1 file changed, 1 insertion(+)
configs/turris_omnia_defconfig +0 -0
index cd443ceb300f..2acc4ada4123 100644

configs/turris_omnia_defconfig CONFIG_PHY_MARVELL=y · line 83

Quoted 7 lines
configs/turris_omnia_defconfig +1 -0
@@ -77,6 +77,7 @@ CONFIG_PHY_MARVELL=y
  CONFIG_PHY_GIGE=y
  CONFIG_MVNETA=y
  CONFIG_MII=y
+CONFIG_NVME=y
  CONFIG_PCI=y
  CONFIG_PCI_MVEBU=y
  CONFIG_DM_RTC=y

Viele Grüße,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#6 lore raw

Re: [PATCH 3/3] arm: mvebu: turris_omnia: Enable NVMe support

In reply to Pali Rohár
Quoted 6 lines · Pali Rohár

PCIe-based NVMe SSD disks in M.2 2230/2242/2260 form-factor can be connected to Turris Omnia mPCIe slot via passive M.2 <--> mPCIe adapter.

So enable PCIe NVMe drivers.

Applied to u-boot-marvell/master

Thanks,
Stefan

Quoted 10 lines
---
  configs/turris_omnia_defconfig | 1 +
  1 file changed, 1 insertion(+)
configs/turris_omnia_defconfig +0 -0
index cd443ceb300f..2acc4ada4123 100644

configs/turris_omnia_defconfig CONFIG_PHY_MARVELL=y · line 83

Quoted 7 lines
configs/turris_omnia_defconfig +1 -0
@@ -77,6 +77,7 @@ CONFIG_PHY_MARVELL=y
  CONFIG_PHY_GIGE=y
  CONFIG_MVNETA=y
  CONFIG_MII=y
+CONFIG_NVME=y
  CONFIG_PCI=y
  CONFIG_PCI_MVEBU=y
  CONFIG_DM_RTC=y

Viele Grüße,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
Reviewed-by on v1 1/3
#7 lore raw
In reply to Pali Rohár
Quoted 8 lines · Pali Rohár

Espressobin has one on-board SATA port which is connected directly to CPU.

More SATA disks can be connected via mPCIe add-in card with PCIe-SATA controller.

So enable required SATA AHCI PCIe drivers in defconfig file.

Thanks,
Stefan

Quoted 18 lines
---
  configs/mvebu_espressobin-88f3720_defconfig | 2 ++
  1 file changed, 2 insertions(+)
configs/mvebu_espressobin-88f3720_defconfig +1 -0
index c8ae0cf6109a..4003a25346ce 100644
@@ -30,6 +30,7 @@ CONFIG_CMD_I2C=y
  CONFIG_CMD_MMC=y
  CONFIG_CMD_MTD=y
  CONFIG_CMD_PCI=y
+CONFIG_CMD_SATA=y
  CONFIG_CMD_SPI=y
  CONFIG_CMD_USB=y
  CONFIG_CMD_WDT=y

configs/mvebu_espressobin-88f3720_defconfig CONFIG_ENV_OVERWRITE=y · line 53

Quoted 7 lines
configs/mvebu_espressobin-88f3720_defconfig +1 -0
@@ -46,6 +47,7 @@ CONFIG_ENV_OVERWRITE=y
  CONFIG_ENV_IS_IN_SPI_FLASH=y
  CONFIG_SYS_RELOC_GD_ENV_ADDR=y
  CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_AHCI_PCI=y
  CONFIG_AHCI_MVEBU=y
  CONFIG_CLK=y
  CONFIG_CLK_MVEBU=y

Viele Grüße,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#8 lore raw
In reply to Pali Rohár
Quoted 8 lines · Pali Rohár

Espressobin has one on-board SATA port which is connected directly to CPU.

More SATA disks can be connected via mPCIe add-in card with PCIe-SATA controller.

So enable required SATA AHCI PCIe drivers in defconfig file.

Applied to u-boot-marvell/master

Thanks,
Stefan

Quoted 18 lines
---
  configs/mvebu_espressobin-88f3720_defconfig | 2 ++
  1 file changed, 2 insertions(+)
configs/mvebu_espressobin-88f3720_defconfig +1 -0
index c8ae0cf6109a..4003a25346ce 100644
@@ -30,6 +30,7 @@ CONFIG_CMD_I2C=y
  CONFIG_CMD_MMC=y
  CONFIG_CMD_MTD=y
  CONFIG_CMD_PCI=y
+CONFIG_CMD_SATA=y
  CONFIG_CMD_SPI=y
  CONFIG_CMD_USB=y
  CONFIG_CMD_WDT=y

configs/mvebu_espressobin-88f3720_defconfig CONFIG_ENV_OVERWRITE=y · line 53

Quoted 7 lines
configs/mvebu_espressobin-88f3720_defconfig +1 -0
@@ -46,6 +47,7 @@ CONFIG_ENV_OVERWRITE=y
  CONFIG_ENV_IS_IN_SPI_FLASH=y
  CONFIG_SYS_RELOC_GD_ENV_ADDR=y
  CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_AHCI_PCI=y
  CONFIG_AHCI_MVEBU=y
  CONFIG_CLK=y
  CONFIG_CLK_MVEBU=y

Viele Grüße,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]