Skip to contentSkip to conversation

serial: a37xx: Remove CONFIG_DEBUG_UART_SHIFT options

PATCH In review Pali Rohár 2 participants 3 messages Aug 13, 2021 – Sep 1, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 serial: a37xx: Remove CONFIG_DEBUG_UART_SHIFT options

Armada 37xx serial driver does not use CONFIG_DEBUG_UART_SHIFT.

So do not define any bogus value for CONFIG_DEBUG_UART_SHIFT option in any Armada 37xx defconfig file.

---
 configs/mvebu_db-88f3720_defconfig          | 1 -
 configs/mvebu_espressobin-88f3720_defconfig | 1 -
 configs/turris_mox_defconfig                | 1 -
 configs/uDPU_defconfig                      | 1 -
 4 files changed, 4 deletions(-)
configs/mvebu_db-88f3720_defconfig +0 -1
index bc92fdb8ee8c..eb50afc0f381 100644
@@ -63,7 +63,6 @@ CONFIG_PHY=y
 CONFIG_MVEBU_COMPHY_SUPPORT=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_ARMADA_37XX=y
-CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_DEBUG_UART_ANNOUNCE=y
 CONFIG_MVEBU_A3700_UART=y
 CONFIG_MVEBU_A3700_SPI=y
configs/mvebu_espressobin-88f3720_defconfig +0 -1
index 4003a25346ce..9641c02d9317 100644
@@ -79,7 +79,6 @@ CONFIG_MVEBU_COMPHY_SUPPORT=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_ARMADA_37XX=y
 CONFIG_DM_REGULATOR_GPIO=y
-CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_DEBUG_UART_ANNOUNCE=y
 CONFIG_MVEBU_A3700_UART=y
 CONFIG_MVEBU_A3700_SPI=y
configs/turris_mox_defconfig +0 -1
index fc5e1fc3766f..40f975ead314 100644
@@ -87,7 +87,6 @@ CONFIG_DM_RTC=y
 CONFIG_RTC_DS1307=y
 CONFIG_SCSI=y
 CONFIG_DM_SCSI=y
-CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_DEBUG_UART_ANNOUNCE=y
 CONFIG_MVEBU_A3700_UART=y
 CONFIG_MVEBU_A3700_SPI=y
configs/uDPU_defconfig +0 -1
index 3e6bb32cb88b..1ea3aad5ff2a 100644
@@ -79,7 +79,6 @@ CONFIG_PINCTRL=y
 CONFIG_PINCTRL_ARMADA_37XX=y
 CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_DM_REGULATOR_GPIO=y
-CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_DEBUG_UART_ANNOUNCE=y
 CONFIG_MVEBU_A3700_UART=y
 CONFIG_MVEBU_A3700_SPI=y
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Pali Rohár

Armada 37xx serial driver does not use CONFIG_DEBUG_UART_SHIFT.

So do not define any bogus value for CONFIG_DEBUG_UART_SHIFT option in any Armada 37xx defconfig file.

Thanks,
Stefan

Quoted 49 lines
---
  configs/mvebu_db-88f3720_defconfig          | 1 -
  configs/mvebu_espressobin-88f3720_defconfig | 1 -
  configs/turris_mox_defconfig                | 1 -
  configs/uDPU_defconfig                      | 1 -
  4 files changed, 4 deletions(-)
configs/mvebu_db-88f3720_defconfig +0 -1
index bc92fdb8ee8c..eb50afc0f381 100644
@@ -63,7 +63,6 @@ CONFIG_PHY=y
  CONFIG_MVEBU_COMPHY_SUPPORT=y
  CONFIG_PINCTRL=y
  CONFIG_PINCTRL_ARMADA_37XX=y
-CONFIG_DEBUG_UART_SHIFT=2
  CONFIG_DEBUG_UART_ANNOUNCE=y
  CONFIG_MVEBU_A3700_UART=y
  CONFIG_MVEBU_A3700_SPI=y
configs/mvebu_espressobin-88f3720_defconfig +0 -1
index 4003a25346ce..9641c02d9317 100644
@@ -79,7 +79,6 @@ CONFIG_MVEBU_COMPHY_SUPPORT=y
  CONFIG_PINCTRL=y
  CONFIG_PINCTRL_ARMADA_37XX=y
  CONFIG_DM_REGULATOR_GPIO=y
-CONFIG_DEBUG_UART_SHIFT=2
  CONFIG_DEBUG_UART_ANNOUNCE=y
  CONFIG_MVEBU_A3700_UART=y
  CONFIG_MVEBU_A3700_SPI=y
configs/turris_mox_defconfig +0 -1
index fc5e1fc3766f..40f975ead314 100644
@@ -87,7 +87,6 @@ CONFIG_DM_RTC=y
  CONFIG_RTC_DS1307=y
  CONFIG_SCSI=y
  CONFIG_DM_SCSI=y
-CONFIG_DEBUG_UART_SHIFT=2
  CONFIG_DEBUG_UART_ANNOUNCE=y
  CONFIG_MVEBU_A3700_UART=y
  CONFIG_MVEBU_A3700_SPI=y
configs/uDPU_defconfig +0 -0
index 3e6bb32cb88b..1ea3aad5ff2a 100644

configs/uDPU_defconfig CONFIG_PINCTRL=y · line 84

Quoted 7 lines
configs/uDPU_defconfig +0 -1
@@ -79,7 +79,6 @@ CONFIG_PINCTRL=y
  CONFIG_PINCTRL_ARMADA_37XX=y
  CONFIG_DM_REGULATOR_FIXED=y
  CONFIG_DM_REGULATOR_GPIO=y
-CONFIG_DEBUG_UART_SHIFT=2
  CONFIG_DEBUG_UART_ANNOUNCE=y
  CONFIG_MVEBU_A3700_UART=y
  CONFIG_MVEBU_A3700_SPI=y

Viele Grüße,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#2 lore raw
In reply to Pali Rohár
Quoted 6 lines · Pali Rohár

Armada 37xx serial driver does not use CONFIG_DEBUG_UART_SHIFT.

So do not define any bogus value for CONFIG_DEBUG_UART_SHIFT option in any Armada 37xx defconfig file.

Applied to u-boot-marvell/master

Thanks,
Stefan

Quoted 49 lines
---
  configs/mvebu_db-88f3720_defconfig          | 1 -
  configs/mvebu_espressobin-88f3720_defconfig | 1 -
  configs/turris_mox_defconfig                | 1 -
  configs/uDPU_defconfig                      | 1 -
  4 files changed, 4 deletions(-)
configs/mvebu_db-88f3720_defconfig +0 -1
index bc92fdb8ee8c..eb50afc0f381 100644
@@ -63,7 +63,6 @@ CONFIG_PHY=y
  CONFIG_MVEBU_COMPHY_SUPPORT=y
  CONFIG_PINCTRL=y
  CONFIG_PINCTRL_ARMADA_37XX=y
-CONFIG_DEBUG_UART_SHIFT=2
  CONFIG_DEBUG_UART_ANNOUNCE=y
  CONFIG_MVEBU_A3700_UART=y
  CONFIG_MVEBU_A3700_SPI=y
configs/mvebu_espressobin-88f3720_defconfig +0 -1
index 4003a25346ce..9641c02d9317 100644
@@ -79,7 +79,6 @@ CONFIG_MVEBU_COMPHY_SUPPORT=y
  CONFIG_PINCTRL=y
  CONFIG_PINCTRL_ARMADA_37XX=y
  CONFIG_DM_REGULATOR_GPIO=y
-CONFIG_DEBUG_UART_SHIFT=2
  CONFIG_DEBUG_UART_ANNOUNCE=y
  CONFIG_MVEBU_A3700_UART=y
  CONFIG_MVEBU_A3700_SPI=y
configs/turris_mox_defconfig +0 -1
index fc5e1fc3766f..40f975ead314 100644
@@ -87,7 +87,6 @@ CONFIG_DM_RTC=y
  CONFIG_RTC_DS1307=y
  CONFIG_SCSI=y
  CONFIG_DM_SCSI=y
-CONFIG_DEBUG_UART_SHIFT=2
  CONFIG_DEBUG_UART_ANNOUNCE=y
  CONFIG_MVEBU_A3700_UART=y
  CONFIG_MVEBU_A3700_SPI=y
configs/uDPU_defconfig +0 -0
index 3e6bb32cb88b..1ea3aad5ff2a 100644

configs/uDPU_defconfig CONFIG_PINCTRL=y · line 84

Quoted 7 lines
configs/uDPU_defconfig +0 -1
@@ -79,7 +79,6 @@ CONFIG_PINCTRL=y
  CONFIG_PINCTRL_ARMADA_37XX=y
  CONFIG_DM_REGULATOR_FIXED=y
  CONFIG_DM_REGULATOR_GPIO=y
-CONFIG_DEBUG_UART_SHIFT=2
  CONFIG_DEBUG_UART_ANNOUNCE=y
  CONFIG_MVEBU_A3700_UART=y
  CONFIG_MVEBU_A3700_SPI=y

Viele Grüße,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]