dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and use in DRM
Subsystems (9)
Jim Cromie
maintainerv5 cover dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and use in DRM
hi Jason, Greg, Daniel, dri-everyone,
drm_debug_enabled() is called a lot (by drm-debug api) to do unlikely bit-tests to selectively enable debug printing; this is a good job for DYNAMIC_DEBUG, IFF it is built with JUMP_LABEL.
This patchset enables the use of dynamic-debug to avoid those drm_debug_enabled() overheads, if CONFIG_DRM_USE_DYNAMIC_DEBUG=y.
v5: much rework
- based on Daniel Vetter's feedback, not RFC anymore. (except last one)
- move POC bit_map callback code into dynamic_debug add .data to struct kernel_param
add DEFINE_DYNAMIC_DEBUG_CATEGORIES :
a declarative interface for bits => control-queries this is all new functionality.
- use DEFINE_DYNAMIC_DEBUG_CATEGORIES in i915, amdgpu adds selectivity/control to existing categorizations
- DRM_USE_DYNAMIC_DEBUG
replace DRM_UT_<CAT> (an enum)
with DRM_CAT_<CAT> (a prefix string, cpp-prepended to format)
_UT_ still present, drm_debug_enabled() still used todo:
change __drm_debug param-var to read DDD_CATEGORIES's param-var might suffice to keep parallel schemes coherent.
- RFC add tracer func as syslog alternate test_dynamic_debug.ko: uses tracer for observability, does selftest has some misuse risk; calling pr_debug recursively.
v4: (brown-bagger, various fixes after snips)
v3: fixes missed SOB, && on BOL, commit-log tweaks
v2: https://lore.kernel.org/lkml/[email protected]/
v1: https://lore.kernel.org/lkml/[email protected]/
Doing so creates many new pr_debug callsites, otherwise i915 has ~120 prdbgs, and drm has just 1;
bash-5.1# modprobe i915
dyndbg: 8 debug prints in module video
dyndbg: 305 debug prints in module drm
dyndbg: 207 debug prints in module drm_kms_helper
dyndbg: 2 debug prints in module ttm
dyndbg: 1720 debug prints in module i915
On amdgpu, enabling it adds ~3200 prdbgs, currently at 56 bytes each. So CONFIG_DRM_USE_DYNAMIC_DEBUG=y affects resource requirements. Im working on a diet-plan.
Im running this patchset bare-metal on an i7/i915 laptop & an r9/amdgpu desktop (both as loadable modules). I booted the amdgpu box with:
BOOT_IMAGE=(hd2,gpt2)/vmlinuz-5.14.0-rc4-d7a-00009-g5db471cba844 \
root=UUID=mumble ro \
rootflags=subvol=root00 rhgb \
dynamic_debug.verbose=3 main.dyndbg=+p \
amdgpu.debug=1 amdgpu.test=1 \
"amdgpu.dyndbg=format ^[ +p"That last line enables ~1700 prdbg callsites with a format like '[DML' etc at boot, and amdgpu.test=1 triggers 90 seconds of tests, yielding ~76k prdbgs in 409 seconds, before I turned them off with:
echo module amdgpu -p > /proc/dynamic_debug/control
Its worth noting, this changes the dyndbg-state underneath settings applied with echo > parameters/debug; the latter is qualitatively writeonly, maybe a param_get should return "NA" "-1"
this merged cleanly, on top of
commit d65ef4634e5c795a6a4df1d198992c70e9692fb3 (drm-tip/drm-tip)
Jim Cromie (9):
drm/print: fixup spelling in a comment
moduleparam: add data member to struct kernel_param
dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks i915/gvt: remove spaces in pr_debug "gvt: core:" etc prefixes i915/gvt: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to create "gvt:core:"
etc categories
amdgpu: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to control categorized
pr_debugs
drm_print: add choice to use dynamic debug in drm-debug
amdgpu_ucode: reduce number of pr_debug calls
dyndbg: RFC add tracer facility RFC
drivers/gpu/drm/Kconfig | 13 + drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 293 ++++++++++-------- .../gpu/drm/amd/display/dc/core/dc_debug.c | 44 ++- drivers/gpu/drm/drm_print.c | 49 ++- drivers/gpu/drm/i915/gvt/Makefile | 4 + drivers/gpu/drm/i915/gvt/debug.h | 18 +- drivers/gpu/drm/i915/i915_params.c | 35 +++ include/drm/drm_print.h | 143 +++++++-- include/linux/dynamic_debug.h | 82 ++++- include/linux/moduleparam.h | 11 +- lib/Kconfig.debug | 10 + lib/Makefile | 1 + lib/dynamic_debug.c | 171 ++++++++-- lib/test_dynamic_debug.c | 247 +++++++++++++++ 14 files changed, 901 insertions(+), 220 deletions(-) create mode 100644 lib/test_dynamic_debug.c
Signature · 1 line
2.31.1
Jim Cromie
maintainerPATCH v5 1/9 drm/print: fixup spelling in a comment
s/prink/printk/ - no functional changes
--- include/drm/drm_print.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/drm/drm_print.h +1 -1
@@ -327,7 +327,7 @@ static inline bool drm_debug_enabled(enum drm_debug_category category)/* * struct device based logging * -* Prefer drm_device based logging over device or prink based logging. +* Prefer drm_device based logging over device or printk based logging. */ __printf (3 ,4 )
Signature · 1 line
2.31.1
Jim Cromie
maintainerPATCH v5 2/9 moduleparam: add data member to struct kernel_param
In reply to Jim CromieAdd a const void* data member to the struct, to allow attaching private data that will be used soon by a setter method (via kp->data) to perform more elaborate actions.
To attach the data at compile time, add new macros:
module_param_cbd() derives from module_param_cb(), adding data param, and latter is redefined to use former.
It calls __module_param_call_wdata(), which accepts a new data param and inits .data with it. Re-define __module_param_call() to use it.
Use of this new data member will be rare, it might be worth redoing this as a separate/sub-type to de-bloat the base case.
---
v4+:
. const void* data - <[email protected]>
--- include/linux/moduleparam.h | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
include/linux/moduleparam.h +9 -2
@@ -78,6 +78,7 @@ struct kernel_param {const struct kparam_string *str;const struct kparam_array *arr; }; +const void *data; };extern const struct kernel_param __start___param[], __stop___param[];
@@ -175,6 +176,9 @@ struct kparam_array#define module_param_cb (name, ops, arg, perm) \ __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0) +#define module_param_cbd (name, ops, arg, perm, data) \ + __module_param_call_wdata(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0, data) +#define module_param_cb_unsafe (name, ops, arg, perm) \ __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, \ KERNEL_PARAM_FL_UNSAFE)
@@ -284,14 +288,17 @@ struct kparam_array/* This is the fundamental function for registering boot/module parameters. */ -#define __module_param_call (prefix, name, ops, arg, perm, level, flags) \ +#define __module_param_call (prefix, name, ops, arg, perm, level, flags) \ + __module_param_call_wdata(prefix, name, ops, arg, perm, level, flags, NULL) + +#define __module_param_call_wdata (prefix, name, ops, arg, perm, level, flags, data) \/* Default value instead of permissions? */ \ static const char __param_str_##name[] = prefix #name; \ static struct kernel_param __moduleparam_const __param_##name \ __used __section("__param") \ __aligned(__alignof__(struct kernel_param)) \ = { __param_str_##name, THIS_MODULE, ops, \ - VERIFY_OCTAL_PERMISSIONS(perm), level, flags, { arg } } + VERIFY_OCTAL_PERMISSIONS(perm), level, flags, { arg }, data }/* Obsolete - use module_param_cb() */ #define module_param_call (name, _set, _get, arg, perm) \
Signature · 1 line
2.31.1
Re: [PATCH v5 2/9] moduleparam: add data member to struct kernel_param
Quoted 14 lines · Jim Cromie
Add a const void* data member to the struct, to allow attaching private data that will be used soon by a setter method (via
kp->data) to perform more elaborate actions.To attach the data at compile time, add new macros:
module_param_cbd()derives frommodule_param_cb(), adding data param, and latter is redefined to use former.It calls
__module_param_call_wdata(), which accepts a new data param and inits .data with it. Re-define__module_param_call()to use it.Use of this new data member will be rare, it might be worth redoing this as a separate/sub-type to de-bloat the base case.
...
include/linux/moduleparam.h struct kparam_array · line 180
Quoted 2 lines
include/linux/moduleparam.h +2
-0+#define module_param_cbd (name, ops, arg, perm, data) \ + __module_param_call_wdata(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0, data)
Cryptic name. Moreover, inconsistent with the rest. What about module_param_cb_data() ?
include/linux/moduleparam.h struct kparam_array · line 184
Quoted 3 lines
#define
module_param_cb_unsafe(name, ops, arg, perm)\include/linux/moduleparam.h +0
-0__module_param_call (MODULE_PARAM_PREFIX , name, ops, arg, perm,-1 , \KERNEL_PARAM_FL_UNSAFE )
(above left for the above comment)
...
Quoted 1 line
+#define
__module_param_call_wdata(prefix, name, ops, arg, perm, level, flags, data)\
Similar __module_param_call_with_data()
Signature · 2 lines
With Best Regards, Andy Shevchenko
[email protected]
maintainerRe: [PATCH v5 2/9] moduleparam: add data member to struct kernel_param
Quoted 33 lines · Andy Shevchenko
Quoted 14 lines · Jim Cromie
Add a const void* data member to the struct, to allow attaching private data that will be used soon by a setter method (via
kp->data) to perform more elaborate actions.To attach the data at compile time, add new macros:
module_param_cbd()derives frommodule_param_cb(), adding data param, and latter is redefined to use former.It calls
__module_param_call_wdata(), which accepts a new data param and inits .data with it. Re-define__module_param_call()to use it.Use of this new data member will be rare, it might be worth redoing this as a separate/sub-type to de-bloat the base case.
...
include/linux/moduleparam.h struct kparam_array · line 180
Quoted 2 lines
include/linux/moduleparam.h +2
-0+#define module_param_cbd (name, ops, arg, perm, data) \ + __module_param_call_wdata(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0, data)Cryptic name. Moreover, inconsistent with the rest. What about
module_param_cb_data()?Quoted 3 lines
#define module_param_cb_unsafe(name, ops, arg, perm) \ __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, \ KERNEL_PARAM_FL_UNSAFE)(above left for the above comment)
...
Quoted 9 lines
Quoted 1 line
+#define
__module_param_call_wdata(prefix, name, ops, arg, perm, level, flags, data)\Similar
__module_param_call_with_data()--
With Best Regards,
Andy Shevchenko
yes to all renames, revised.
thanks
Jim Cromie
maintainerPATCH v5 3/9 dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks
In reply to Jim CromieDEFINE_DYNAMIC_DEBUG_CATEGORIES(name, var, bitmap_desc, @bit_descs) allows users to define a drm.debug style (bitmap) sysfs interface, and to specify the desired mapping from bits[0-N] to the format-prefix'd pr_debug()s to be controlled.
DEFINE_DYNAMIC_DEBUG_CATEGORIES(debug_gvt, __gvt_debug,
"i915/gvt bitmap desc",
/**
* search-prefixes, passed to dd-exec_queries
* defines bits 0-N in order.
* leading ^ is tacitly inserted (by callback currently)
* trailing space used here excludes subcats.
* helper macro needs more work
* macro to autogen ++$i, 0x%x$i ?
*/
_DD_cat_("gvt:cmd: "),
_DD_cat_("gvt:core: "),
_DD_cat_("gvt:dpy: "),
_DD_cat_("gvt:el: "),
_DD_cat_("gvt:irq: "),
_DD_cat_("gvt:mm: "),
_DD_cat_("gvt:mmio: "),
_DD_cat_("gvt:render: "),
_DD_cat_("gvt:sched: "));dynamic_debug.c: add 3 new elements:
- int param_set_dyndbg()
- int param_get_dyndbg()
- struct kernel_param_ops param_ops_dyndbg
Following the model of kernel/params.c STANDARD_PARAM_DEFS, All 3 are non-static and exported.
dynamic_debug.h:
Add DEFINE_DYNAMIC_DEBUG_CATEGORIES() described above, and a do-nothing stub.
Note that it also calls MODULE_PARM_DESC for the user, but expects the user to catenate all the bit-descriptions together (as is done in drm.debug), and in the following uses in amdgpu, i915.
This in the hope that someone can offer an auto-incrementing label-generating macro, producing "\tbit-4 0x10\t" etc, and can show how to apply it to __VA_ARGS__.
Also extern the struct kernel_param param_ops_dyndbg symbol, as is done in moduleparams.h for all the STANDARD params.
USAGE NOTES:
Using dyndbg to query on "format ^$prefix" requires that the prefix be present in the compiled-in format string; where run-time prefixing is used, that format would be "%s...", which is not usefully selectable.
Adding structural query terms (func,file,lineno) could help (module is already done), but DEFINE_DYNAMIC_DEBUG_CATEGORIES can't do that now, adding it needs a better reason imo.
Dyndbg is completely agnostic wrt the categorization scheme used, to play well with any prefix convention already in use. Ad-hoc categories and sub-categories are implicitly allowed, author discipline and review is expected.
Here are some examples:
"1","2","3" 2 doesnt imply 1.
otherwize, sorta like printk levels
"1:","2:","3:" are better, avoiding [1-9]\d+ ambiguity
"hi:","mid:","low:" are reasonable, and imply independence
"todo:","rfc:" might be handy
"A:".."Z:" uhm, yeah
Hierarchical classes/categories are natural:
"drm:<CAT>:" is used in later commit
"drm:<CAT>:<SUB>:" is a natural extension.
"drm:atomic:fail:" has been proposed, sounds directly useful
Some properties of a hierarchical category deserve explication:
Trailing spaces matter !
With 1..3-space ("drm: ", "drm:atomic: ", "drm:atomic:fail: "), the ":" doesnt terminate the search-space, the trailing space does. So a "drm:" search specification will match all DRM categories & subcategories, and will not be useful in an interface where all categories are controlled together. That said, "drm:atomic:" & "drm:atomic: " are different, and both are useful in cases.
Ad-Hoc sub-categories:
These have a caveat wrt wrapper macros adding prefixes like "drm:atomic: "; the trailing space in the prefix means that drm_dbg("fail: ...") renders as "drm:atomic: fail: ", which obviously isn't ideal wrt clear and simple bitmaps.
A possible solution is to have a FOO_() version of every FOO() macro which (anti-mnemonically) elides the trailing space, which is normally inserted by a modified FOO(). Doing this would enforce a policy decision that "debug categories will be space terminated", with an pressure-relief valve.
Summarizing:
- "drm:kms: " & "drm:kms:" are different
- "drm:kms" also different - includes drm:kms2:
- "drm:kms:\t" also different
- "drm:kms:*" doesnt work, no wildcard on format atm.
Order matters in DEFINE_DYNAMIC_DEBUG_CATEGORIES(... @bit_descs)
@bit_descs (array) position determines the bit mapping to the prefix, so to keep a stable map, new categories or 3rd level categories must be added to the end.
Since bits are/will-stay applied 0-N, the later bits can countermand the earlier ones, but its tricky - consider;
DD_CATs(... "drm:atomic:", ""drm:atomic:fail:" ) // misleading
The 1st search-term is misleading, because it includes (modifies) subcategories, but then 2nd overrides it. So don't do that.
There is still plenty of bikeshedding to do.
---
v4+:
. rename to DEFINE_DYNAMIC_DEBUG_CATEGORIES from DEFINE_DYNDBG_BITMAP . in query, replace hardcoded "i915" w kp->mod->name
. static inline the stubs
. const *str in structs, const array. -Emil
. dyndbg: add do-nothing DEFINE_DYNAMIC_DEBUG_CATEGORIES if !DD_CORE . call MOD_PARM_DESC(name, "$desc") for users
. simplify callback, remove bit-change detection
. config errs reported by <[email protected]>
ddh-helpers
--- include/linux/dynamic_debug.h | 50 ++++++++++++++++++++++++++++ lib/dynamic_debug.c | 62 ++++++++++++++++++++++++++++++++++- 2 files changed, 111 insertions(+), 1 deletion(-)
include/linux/dynamic_debug.h +50 -0
@@ -52,6 +52,7 @@ struct _ddebug { } __attribute__((aligned(8))); +struct kernel_param ;#if defined(CONFIG_DYNAMIC_DEBUG_CORE )
@@ -181,6 +182,9 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor, KERN_DEBUG, prefix_str, prefix_type, \ rowsize, groupsize, buf, len, ascii) +int param_set_dyndbg (const char *instr,const struct kernel_param *kp); +int param_get_dyndbg (char *buffer,const struct kernel_param *kp); +#else /* !CONFIG_DYNAMIC_DEBUG_CORE */ #include <linux/string.h>
@@ -227,6 +231,52 @@ static inline int dynamic_debug_exec_queries(const char *query, const char *modnreturn 0 ; } +static inline int param_set_dyndbg (const char *instr,const struct kernel_param *kp) +{return 0 ; } +static inline int param_get_dyndbg (char *buffer,const struct kernel_param *kp) +{return 0 ; } +#endif /* !CONFIG_DYNAMIC_DEBUG_CORE */ +struct dyndbg_bitdesc { +/* bitpos is inferred from index in containing array */ +const char *prefix; +const char *help; +}; + +#if defined(CONFIG_DYNAMIC_DEBUG ) || \ + (defined(CONFIG_DYNAMIC_DEBUG_CORE ) && defined(DYNAMIC_DEBUG_MODULE )) +/** +* DEFINE_DYNAMIC_DEBUG_CATEGORIES() - define debug categories, bitmap, sysfs-knob +* @fsname: parameter basename under /sys +* @var: C-identifier holding state +* @_desc: string summarizing the controls provided +* @...: list of struct dyndbg_bitdesc initializations +* +* Defines /sys/modules/$modname/parameters/@fsname, and @bit_descs, +* which maps bits 0-N to categories of pr_debugs to be controlled. +* This is effectively write only, because controlled callsites can be +* further modified via >control. +* +* Also calls MODULE_PARM_DESC(fsname, _desc), with the intent to +* generate the bit_legend and apply it to the given bit_descs +*/ +#define DEFINE_DYNAMIC_DEBUG_CATEGORIES (fsname, var, _desc, ...) \ + MODULE_PARM_DESC(fsname, _desc); \ + static struct dyndbg_bitdesc const dyndbg_cats_##fsname[] = \ + { __VA_ARGS__, { NULL, NULL } }; \ + module_param_cbd(fsname, ¶m_ops_dyndbg, &var, 0644, \ + &dyndbg_cats_##fsname); + +#define _DD_cat_ (pfx) { .prefix = pfx, .help = "help for " pfx } +#define _DD_cat_help_ (pfx) "\t " pfx "\t- help for " pfx "\n" + +extern const struct kernel_param_ops param_ops_dyndbg; +#else +#define DEFINE_DYNAMIC_DEBUG_CATEGORIES (fsname, var, bitmap_desc, ...) \ + MODULE_PARM_DESC(fsname, "auto: " bitmap_desc); +#define _DD_cat_ (pfx) +#define _DD_cat_help_ (pfx) +#endif +#endif
lib/dynamic_debug.c +61 -1
71 lines not on this page · raw message
Signature · 1 line
2.31.1
Re: [PATCH v5 3/9] dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks
Quoted 138 lines · Jim Cromie
DEFINE_DYNAMIC_DEBUG_CATEGORIES(name, var, bitmap_desc, @bit_descs)allows users to define a drm.debug style (bitmap) sysfs interface, and to specify the desired mapping from bits[0-N] to the format-prefix'd pr_debug()s to be controlled.DEFINE_DYNAMIC_DEBUG_CATEGORIES(debug_gvt,
__gvt_debug,"i915/gvt bitmap desc", /** * search-prefixes, passed to dd-exec_queries * defines bits 0-N in order. * leading ^ is tacitly inserted (by callback currently) * trailing space used here excludes subcats. * helper macro needs more work * macro to autogen ++$i, 0x%x$i ? */ _DD_cat_("gvt:cmd: "), _DD_cat_("gvt:core: "), _DD_cat_("gvt:dpy: "), _DD_cat_("gvt:el: "), _DD_cat_("gvt:irq: "), _DD_cat_("gvt:mm: "), _DD_cat_("gvt:mmio: "), _DD_cat_("gvt:render: "), _DD_cat_("gvt:sched: "));
dynamic_debug.c: add 3 new elements:- int
param_set_dyndbg()
- intparam_get_dyndbg()
- structkernel_param_opsparam_ops_dyndbgFollowing the model of
kernel/params.cSTANDARD_PARAM_DEFS, All 3 are non-static and exported.
dynamic_debug.h:Add
DEFINE_DYNAMIC_DEBUG_CATEGORIES()described above, and a do-nothing stub.Note that it also calls
MODULE_PARM_DESCfor the user, but expects the user to catenate all the bit-descriptions together (as is done in drm.debug), and in the following uses in amdgpu, i915.This in the hope that someone can offer an auto-incrementing label-generating macro, producing "\tbit-4 0x10\t" etc, and can show how to apply it to
__VA_ARGS__.Also extern the struct
kernel_paramparam_ops_dyndbgsymbol, as is done inmoduleparams.hfor all the STANDARD params.USAGE NOTES:
Using dyndbg to query on "format ^$prefix" requires that the prefix be present in the compiled-in format string; where run-time prefixing is used, that format would be "%s...", which is not usefully selectable.
Adding structural query terms (func,file,lineno) could help (module is already done), but
DEFINE_DYNAMIC_DEBUG_CATEGORIEScan't do that now, adding it needs a better reason imo.Dyndbg is completely agnostic wrt the categorization scheme used, to play well with any prefix convention already in use. Ad-hoc categories and sub-categories are implicitly allowed, author discipline and review is expected.
Here are some examples:
"1","2","3" 2 doesnt imply 1.
otherwize, sorta like printk levels
"1:","2:","3:" are better, avoiding [1-9]\d+ ambiguity
"hi:","mid:","low:" are reasonable, and imply independence
"todo:","rfc:" might be handy
"A:".."Z:" uhm, yeahHierarchical classes/categories are natural:
"drm:<CAT>:" is used in later commit
"drm:<CAT>:<SUB>:" is a natural extension.
"drm:atomic:fail:" has been proposed, sounds directly usefulSome properties of a hierarchical category deserve explication:
Trailing spaces matter !
With 1..3-space ("drm: ", "drm:atomic: ", "drm:atomic:fail: "), the ":" doesnt terminate the search-space, the trailing space does. So a "drm:" search specification will match all DRM categories & subcategories, and will not be useful in an interface where all categories are controlled together. That said, "drm:atomic:" & "drm:atomic: " are different, and both are useful in cases.
Ad-Hoc sub-categories:
These have a caveat wrt wrapper macros adding prefixes like "drm:atomic: "; the trailing space in the prefix means that
drm_dbg("fail: ...")renders as "drm:atomic: fail: ", which obviously isn't ideal wrt clear and simple bitmaps.A possible solution is to have a
FOO_()version of everyFOO()macro which (anti-mnemonically) elides the trailing space, which is normally inserted by a modifiedFOO(). Doing this would enforce a policy decision that "debug categories will be space terminated", with an pressure-relief valve.Summarizing:
- "drm:kms: " & "drm:kms:" are different
- "drm:kms" also different - includes drm:kms2:
- "drm:kms:\t" also different
- "drm:kms:*" doesnt work, no wildcard on format atm.Order matters in DEFINE_DYNAMIC_DEBUG_CATEGORIES(... @bit_descs)
@bit_descs (array) position determines the bit mapping to the prefix, so to keep a stable map, new categories or 3rd level categories must be added to the end.
Since bits are/will-stay applied 0-N, the later bits can countermand the earlier ones, but its tricky - consider;
DD_CATs(... "drm:atomic:", ""drm:atomic:fail:" ) // misleadingThe 1st search-term is misleading, because it includes (modifies) subcategories, but then 2nd overrides it. So don't do that.
There is still plenty of bikeshedding to do.
---
v4+:. rename to
DEFINE_DYNAMIC_DEBUG_CATEGORIESfromDEFINE_DYNDBG_BITMAP. in query, replace hardcoded "i915" wkp->mod->name
. static inline the stubs
. const *str in structs, const array. -Emil
. dyndbg: add do-nothingDEFINE_DYNAMIC_DEBUG_CATEGORIESif !DD_CORE . callMOD_PARM_DESC(name, "$desc")for users
. simplify callback, remove bit-change detection
. config errs reported by <[email protected]>
Quoted 3 lines
ddh-helpers
Signed-off-by Jim Cromie <[email protected]>
So, it is signed or not? I didn't get (perhaps due to misplaced changlog?).
...
Quoted 3 lines
} __attribute__((aligned(8)));
Do we need two blank lines here?
Quoted 1 line
+struct
kernel_param;
...
lib/dynamic_debug.c early_initcall(dynamic_debug_init); · line 1173
Quoted 6 lines
lib/dynamic_debug.c +6
-0+int param_set_dyndbg (const char *instr,const struct kernel_param *kp) +{ +unsigned long inbits; +int rc, i, chgct =0 , totct =0 ; +char query[OUR_QUERY_SIZE ]; +struct dyndbg_bitdesc *bitmap = (struct dyndbg_bitdesc *) kp->data;
So you need space after ')' ?
lib/dynamic_debug.c early_initcall(dynamic_debug_init); · line 1178
Quoted 5 lines
lib/dynamic_debug.c +4
-0+ rc =kstrtoul (instr,0 , &inbits); +if (rc) { +pr_err ("set_dyndbg: failed\n" ); +return -EINVAL ;
Why not to return rc?
lib/dynamic_debug.c early_initcall(dynamic_debug_init); · line 1182
Quoted 4 lines
lib/dynamic_debug.c +4
-0+ } +vpr_info ("set_dyndbg: input 0x%lx\n" , inbits); + +for (i =0 ; !!bitmap[i].prefix; i++) {
Hmm... Why not simply
for (bitmap = ...; bitmap->prefix; bitmap++) {?
Quoted 1 line
+
Redundant blank line.
lib/dynamic_debug.c early_initcall(dynamic_debug_init); · line 1185
Quoted 2 lines
lib/dynamic_debug.c +2
-0+sprintf (query,"format '^%s' %cp" , bitmap[i].prefix, +test_bit (i, &inbits) ?'+' :'-' );
snprintf() ?
Quoted 9 lines
lib/dynamic_debug.c +9
-0+ + chgct =dynamic_debug_exec_queries (query, kp->mod->name); + +v2pr_info ("bit-%d: %d changes by '%s'\n" , i, chgct, query); + totct += chgct; + } +vpr_info ("total changes: %d\n" , totct); +return 0 ; +}
...
lib/dynamic_debug.c early_initcall(dynamic_debug_init); · line 1207
Quoted 2 lines
lib/dynamic_debug.c +2
-0+return scnprintf (buffer,PAGE_SIZE ,"%u\n" , + *((unsigned int *)kp->arg));
One line.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v5 3/9] dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks
Quoted 9 lines · Andy Shevchenko
lib/dynamic_debug.c early_initcall(dynamic_debug_init); · line 1173
Quoted 6 lines · Jim Cromie
lib/dynamic_debug.c +6
-0+int param_set_dyndbg (const char *instr,const struct kernel_param *kp) +{ +unsigned long inbits; +int rc, i, chgct =0 , totct =0 ; +char query[OUR_QUERY_SIZE ]; +struct dyndbg_bitdesc *bitmap = (struct dyndbg_bitdesc *) kp->data;So you need space after ')' ?
More importantly, if ->data is of type 'void *', it is bad style to cast the pointer at all. I can't tell what type 'data' has; if it is added to kernel_param as part of this series, I wasn't cc'd on the patch that did that.
[email protected]
maintainerRe: [PATCH v5 3/9] dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks
In reply to Andy ShevchenkoQuoted 15 lines
Quoted 15 lines
There is still plenty of bikeshedding to do.
---
v4+:. rename to
DEFINE_DYNAMIC_DEBUG_CATEGORIESfromDEFINE_DYNDBG_BITMAP. in query, replace hardcoded "i915" wkp->mod->name
. static inline the stubs
. const *str in structs, const array. -Emil
. dyndbg: add do-nothingDEFINE_DYNAMIC_DEBUG_CATEGORIESif !DD_CORE . callMOD_PARM_DESC(name, "$desc")for users
. simplify callback, remove bit-change detection
. config errs reported by <[email protected]>
Quoted 6 lines
Quoted 3 lines
ddh-helpers
Signed-off-by Jim Cromie <[email protected]>So, it is signed or not? I didn't get (perhaps due to misplaced changlog?).
It might be my --- snip, and reliance on format-patch -s
would it work if I used -- 2char snip ?
Quoted 71 lines
...
Quoted 3 lines
} __attribute__((aligned(8)));
Do we need two blank lines here?
Quoted 1 line
+struct
kernel_param;...
lib/dynamic_debug.c early_initcall(dynamic_debug_init); · line 1173
Quoted 6 lines
lib/dynamic_debug.c +6
-0+int param_set_dyndbg (const char *instr,const struct kernel_param *kp) +{ +unsigned long inbits; +int rc, i, chgct =0 , totct =0 ; +char query[OUR_QUERY_SIZE ]; +struct dyndbg_bitdesc *bitmap = (struct dyndbg_bitdesc *) kp->data;So you need space after ')' ?
lib/dynamic_debug.c early_initcall(dynamic_debug_init); · line 1178
Quoted 5 lines
lib/dynamic_debug.c +4
-0+ rc =kstrtoul (instr,0 , &inbits); +if (rc) { +pr_err ("set_dyndbg: failed\n" ); +return -EINVAL ;Why not to return rc?
lib/dynamic_debug.c early_initcall(dynamic_debug_init); · line 1182
Quoted 4 lines
lib/dynamic_debug.c +4
-0+ } +vpr_info ("set_dyndbg: input 0x%lx\n" , inbits); + +for (i =0 ; !!bitmap[i].prefix; i++) {Hmm... Why not simply
for (bitmap = ...; bitmap->prefix; bitmap++) {?
Quoted 1 line
+
Redundant blank line.
lib/dynamic_debug.c early_initcall(dynamic_debug_init); · line 1185
Quoted 2 lines
lib/dynamic_debug.c +2
-0+sprintf (query,"format '^%s' %cp" , bitmap[i].prefix, +test_bit (i, &inbits) ?'+' :'-' );
snprintf()?Quoted 9 lines
lib/dynamic_debug.c +9
-0+ + chgct =dynamic_debug_exec_queries (query, kp->mod->name); + +v2pr_info ("bit-%d: %d changes by '%s'\n" , i, chgct, query); + totct += chgct; + } +vpr_info ("total changes: %d\n" , totct); +return 0 ; +}...
lib/dynamic_debug.c early_initcall(dynamic_debug_init); · line 1207
Quoted 2 lines
lib/dynamic_debug.c +2
-0+return scnprintf (buffer,PAGE_SIZE ,"%u\n" , + *((unsigned int *)kp->arg));One line.
--
With Best Regards,
Andy Shevchenko
Re: [PATCH v5 3/9] dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks
Quoted 16 lines · On Fri, Aug 13, 2021 at 8:54 PM <[email protected]> wrote:
Quoted 16 lines
Quoted 15 lines
There is still plenty of bikeshedding to do.
---
v4+:. rename to
DEFINE_DYNAMIC_DEBUG_CATEGORIESfromDEFINE_DYNDBG_BITMAP. in query, replace hardcoded "i915" wkp->mod->name
. static inline the stubs
. const *str in structs, const array. -Emil
. dyndbg: add do-nothingDEFINE_DYNAMIC_DEBUG_CATEGORIESif !DD_CORE . callMOD_PARM_DESC(name, "$desc")for users
. simplify callback, remove bit-change detection
. config errs reported by <[email protected]>ddh-helpers
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Jim Cromie <[email protected]>So, it is signed or not? I didn't get (perhaps due to misplaced changlog?).
It might be my --- snip, and reliance on format-patch -s
would it work if I used -- 2char snip ?
The right thing to do is to have
SoB ...
'--- ' line
Changelog is _here_
Signature · 2 lines
With Best Regards, Andy Shevchenko
Jim Cromie
maintainerPATCH v5 4/9 i915/gvt: remove spaces in pr_debug "gvt: core:" etc prefixes
In reply to Jim CromieTaking embedded spaces out of existing prefixes makes them better class-prefixes; simplifying the nested quoting needed otherwise:
$> echo "format '^gvt: core:' +p" >control
Dropping the internal spaces means any trailing space in a query will more clearly terminate the prefix being searched for.
Consider a generic drm-debug example:
# turn off ATOMIC reports echo format "^drm:atomic: " -p > control
# turn off all ATOMIC:* reports, including any sub-categories echo format "^drm:atomic:" -p > control
# turn on ATOMIC:FAIL: reports echo format "^drm:atomic:fail: " +p > control
Removing embedded spaces in the class-prefixes simplifies the corresponding match-prefix. This means that "quoted" match-prefixes are only needed when the trailing space is desired, in order to exclude explicitly sub-categorized pr-debugs; in this example, "drm:atomic:fail:".
RFC: maybe the prefix catenation should paste in the " " class-prefix terminator explicitly. A pr_debug_() flavor could exclude the " ", allowing ad-hoc sub-categorization by appending for example, "fail:" to "drm:atomic:".
--- drivers/gpu/drm/i915/gvt/debug.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/gvt/debug.h +9 -9
@@ -36,30 +36,30 @@ do { \ } while (0) #define gvt_dbg_core(fmt, args...) \ - pr_debug("gvt: core: "fmt, ##args) + pr_debug("gvt:core: "fmt, ##args) #define gvt_dbg_irq(fmt, args...) \ - pr_debug("gvt: irq: "fmt, ##args) + pr_debug("gvt:irq: "fmt, ##args) #define gvt_dbg_mm(fmt, args...) \ - pr_debug("gvt: mm: "fmt, ##args) + pr_debug("gvt:mm: "fmt, ##args) #define gvt_dbg_mmio(fmt, args...) \ - pr_debug("gvt: mmio: "fmt, ##args) + pr_debug("gvt:mmio: "fmt, ##args) #define gvt_dbg_dpy(fmt, args...) \ - pr_debug("gvt: dpy: "fmt, ##args) + pr_debug("gvt:dpy: "fmt, ##args) #define gvt_dbg_el(fmt, args...) \ - pr_debug("gvt: el: "fmt, ##args) + pr_debug("gvt:el: "fmt, ##args) #define gvt_dbg_sched(fmt, args...) \ - pr_debug("gvt: sched: "fmt, ##args) + pr_debug("gvt:sched: "fmt, ##args) #define gvt_dbg_render(fmt, args...) \ - pr_debug("gvt: render: "fmt, ##args) + pr_debug("gvt:render: "fmt, ##args) #define gvt_dbg_cmd(fmt, args...) \ - pr_debug("gvt: cmd: "fmt, ##args) + pr_debug("gvt:cmd: "fmt, ##args)#endif
Signature · 1 line
2.31.1
Jim Cromie
maintainerPATCH v5 5/9 i915/gvt: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to create "gvt:core:" etc categories
In reply to Jim CromieThe gvt component of this driver has ~120 pr_debugs, in 9 categories quite similar to those in DRM. Following the interface model of drm.debug, add a parameter to map bits to these categorizations.
DEFINE_DYNAMIC_DEBUG_CATEGORIES(debug_gvt, __gvt_debug,
"dyndbg bitmap desc",
{ "gvt:cmd: ", "command processing" },
{ "gvt:core: ", "core help" },
{ "gvt:dpy: ", "display help" },
{ "gvt:el: ", "help" },
{ "gvt:irq: ", "help" },
{ "gvt:mm: ", "help" },
{ "gvt:mmio: ", "help" },
{ "gvt:render: ", "help" },
{ "gvt:sched: " "help" });The actual patch has a few details different, cmd_help() macro emits the initialization construct.
if CONFIG_DRM_USE_DYNAMIC_DEBUG, then -DDYNAMIC_DEBUG_MODULE is added cflags, by gvt/Makefile.
---
v4+:
. static decl of vector of bit->class descriptors - Emil.V . relocate gvt-makefile chunk from elsewhere
--- drivers/gpu/drm/i915/gvt/Makefile | 4 ++++ drivers/gpu/drm/i915/i915_params.c | 35 ++++++++++++++++++++++++++++++ 2 files changed, 39 insertions(+)
drivers/gpu/drm/i915/gvt/Makefile +4 -0
@@ -7,3 +7,7 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \ ccflags-y += -I $(srctree)/$(src) -I $(srctree)/$(src)/$(GVT_DIR)/ i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) + +#ifdef CONFIG_DRM_USE_DYNAMIC_DEBUG +ccflags-y += -DDYNAMIC_DEBUG_MODULE +#endif
drivers/gpu/drm/i915/i915_params.c +35 -0
@@ -265,3 +265,38 @@ void i915_params_free(struct i915_params *params)I915_PARAMS_FOR_EACH (FREE );#undef FREE } + +#ifdef DRM_USE_DYNAMIC_DEBUG +/* todo: needs DYNAMIC_DEBUG_MODULE in some cases */ + +unsigned long __gvt_debug; +EXPORT_SYMBOL (__gvt_debug); + +#define _help (key) "\t \"" key "\"\t: help for " key "\n" + +#define I915_GVT_CATEGORIES (name) \ + " Enable debug output via /sys/module/i915/parameters/" #name \ + ", where each bit enables a debug category.\n" \ + _help("gvt:cmd:") \ + _help("gvt:core:") \ + _help("gvt:dpy:") \ + _help("gvt:el:") \ + _help("gvt:irq:") \ + _help("gvt:mm:") \ + _help("gvt:mmio:") \ + _help("gvt:render:") \ + _help("gvt:sched:") + +DEFINE_DYNAMIC_DEBUG_CATEGORIES (debug_gvt, __gvt_debug, +I915_GVT_CATEGORIES (debug_gvt), +_DD_cat_ ("gvt:cmd:" ), +_DD_cat_ ("gvt:core:" ), +_DD_cat_ ("gvt:dpy:" ), +_DD_cat_ ("gvt:el:" ), +_DD_cat_ ("gvt:irq:" ), +_DD_cat_ ("gvt:mm:" ), +_DD_cat_ ("gvt:mmio:" ), +_DD_cat_ ("gvt:render:" ), +_DD_cat_ ("gvt:sched:" )); + +#endif
Signature · 1 line
2.31.1
Jim Cromie
maintainerPATCH v5 6/9 amdgpu: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to control categorized pr_debugs
In reply to Jim Cromielogger_types.h defines many DC_LOG_*() categorized debug wrappers. Most of these use DRM debug API, so are controllable using drm.debug, but others use bare pr_debug("$prefix: .."), each with a different class-prefix matching "^\[\w+\]:"
Use DEFINE_DYNAMIC_DEBUG_CATEGORIES to create a /sys debug_dc parameter, modinfos, and to specify a map from bits -> categorized pr_debugs to be controlled.
--- .../gpu/drm/amd/display/dc/core/dc_debug.c | 44 ++++++++++++++++++- 1 file changed, 43 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/core/dc_debug.c +43 -1
@@ -36,8 +36,50 @@#include "resource.h" -#define DC_LOGGER_INIT (logger) +#ifdef DRM_USE_DYNAMIC_DEBUG +/* define a drm.debug style dyndbg pr-debug control point */ +#include <linux/dynamic_debug.h> + +unsigned long __debug_dc; +EXPORT_SYMBOL (__debug_dc); + +#define _help_ (key) "\t " key "\t- help for " key "\n" + +/* Id like to do these inside DEFINE_DYNAMIC_DEBUG_CATEGORIES, if possible */ +#define DC_DYNDBG_BITMAP_DESC (name) \ + "Control pr_debugs via /sys/module/amdgpu/parameters/" #name \ + ", where each bit controls a debug category.\n" \ + _help_("[SURFACE]:") \ + _help_("[CURSOR]:") \ + _help_("[PFLIP]:") \ + _help_("[VBLANK]:") \ + _help_("[HW_LINK_TRAINING]:") \ + _help_("[HW_AUDIO]:") \ + _help_("[SCALER]:") \ + _help_("[BIOS]:") \ + _help_("[BANDWIDTH_CALCS]:") \ + _help_("[DML]:") \ + _help_("[IF_TRACE]:") \ + _help_("[GAMMA]:") \ + _help_("[SMU_MSG]:") + +DEFINE_DYNAMIC_DEBUG_CATEGORIES (debug_dc, __debug_dc, +DC_DYNDBG_BITMAP_DESC (debug_dc), +_DD_cat_ ("[CURSOR]:" ), +_DD_cat_ ("[PFLIP]:" ), +_DD_cat_ ("[VBLANK]:" ), +_DD_cat_ ("[HW_LINK_TRAINING]:" ), +_DD_cat_ ("[HW_AUDIO]:" ), +_DD_cat_ ("[SCALER]:" ), +_DD_cat_ ("[BIOS]:" ), +_DD_cat_ ("[BANDWIDTH_CALCS]:" ), +_DD_cat_ ("[DML]:" ), +_DD_cat_ ("[IF_TRACE]:" ), +_DD_cat_ ("[GAMMA]:" ), +_DD_cat_ ("[SMU_MSG]:" )); +#endif +#define DC_LOGGER_INIT (logger)#define SURFACE_TRACE (...) do {\ if (dc->debug.surface_trace) \
Signature · 1 line
2.31.1
Jim Cromie
maintainerPATCH v5 7/9 drm_print: add choice to use dynamic debug in drm-debug
In reply to Jim Cromiedrm's debug system writes 10 distinct categories of messages to syslog using a small API[1]: drm_dbg*(10 names), DRM_DEBUG*(8 names), DRM_DEV_DEBUG*(3 names). There are thousands of these callsites, each categorized by their authors.
These callsites can be enabled at runtime by their category, each controlled by a bit in drm.debug (/sys/modules/drm/parameter/debug). In the current "basic" implementation, drm_debug_enabled() tests these bits in __drm_debug each time an API[1] call is executed; while cheap individually, the costs accumulate.
This patch uses dynamic-debug with jump-label to patch enabled calls onto their respective NOOP slots, avoiding all runtime bit-checks of __drm_debug.
Dynamic debug has no concept of category, but we can emulate one by replacing enum categories with a set of prefix-strings; "drm:core:", "drm:kms:" "drm:driver:" etc, and prepend them (at compile time) to the given formats.
Then we can use:
echo module drm format "^drm:core: " +p > control
to enable the whole category with one query.
This conversion yields ~2100 new callsites on my i7/i915 laptop:
dyndbg: 195 debug prints in module drm_kms_helper
dyndbg: 298 debug prints in module drm
dyndbg: 1630 debug prints in module i915
CONFIG_DRM_USE_DYNAMIC_DEBUG enables this, and is available if CONFIG_DYNAMIC_DEBUG or CONFIG_DYNAMIC_DEBUG_CORE is chosen, and if CONFIG_JUMP_LABEL is enabled; this because its required to get the promised optimizations.
The "basic" -> "dyndbg" switchover is layered into the macro scheme
A. use DEFINE_DYNAMIC_DEBUG_CATEGORIES(debug, __drm_debug,
"DRM debug category-per-bit control",
{ "drm:core:", "enable CORE debug messages" }, { "drm:kms:", "enable KMS debug messages" }, ...);
B. A "classy" version of DRM_UT_<CATs> map, named DRM_DBG_CAT_<CATs>
DRM_DBG_CLASS_<CATs> was proposed, I had agreed, but reconsidered; CATEGORY is already DRM's term-of-art, and adding a near-synonym 'CLASS' only adds ambiguity.
"basic": DRM_DBG_CAT_<CATs> <=== DRM_UT_<CATs>. Identity map.
"dyndbg":
#define DRM_DBG_CAT_KMS "drm:kms: "
#define DRM_DBG_CAT_PRIME "drm:prime: "
#define DRM_DBG_CAT_ATOMIC "drm:atomic: " DRM_UT_* are preserved, since theyre used elsewhere.
We can probably reduce its use further, but thats a separate thing.
C. drm_dev_dbg() & drm_debug() are interposed with macros
basic: forward to renamed fn, with args preserved
enabled: redirect to pr_debug, dev_dbg, with CATEGORY # format
this is where drm_debug_enabled() is avoided. prefix is prepended at compile-time, no category at runtime.
D. API[1] uses DRM_DBG_CAT_<CAT>s
these already use (C), now they use (B) too,
to get the correct token type for "basic" and "dyndbg" configs.
NOTES:
Code Review is expected to catch lack of correspondence between bit=>prefix definitions (the selector) and the prefixes used in the API[1] layer above pr_debug()
I've coded the search-prefixes/categories with a trailing space, which excludes any sub-categories added later. This convention protects any "drm:atomic:fail:" callsites from getting stomped on by echo 0 > debug. Other categories could differ, but we need some default.
Dyndbg requires that the prefix be in the compiled-in format string; run-time prefixing evades callsite selection by category.
pr_debug("%s: ...", __func__, ...) // not idealWith "lineno X" in a query, its possible to enable single callsites, but it is tedious, and useless in a category context.
Unfortunately __func__ is not a macro, and cannot be catenated at preprocess/compile time.
pr_debug("Entry: ...") // +fml gives useful log-info
pr_debug("Exit: ...") // hard to catch them allBut "func foo" added to query-command would work, should it be useful enough to justify extending the declarative interface.
---
v4+:
. use DEFINE_DYNAMIC_DEBUG_CATEGORIES in drm_print.c . s/DRM_DBG_CLASS_/DRM_DBG_CAT_/ - dont need another term . default=y in KBuild entry - per @DanVet
. move some commit-log prose to dyndbg commit
. add-prototyes to (param_get/set)_dyndbg
. more wrinkles found by <[email protected]>
. relocate ratelimit chunk from elsewhere
. add kernel doc
--- drivers/gpu/drm/Kconfig | 13 ++++ drivers/gpu/drm/drm_print.c | 49 +++++++++---- include/drm/drm_print.h | 141 ++++++++++++++++++++++++++++-------- 3 files changed, 159 insertions(+), 44 deletions(-)
drivers/gpu/drm/Kconfig +13 -0
@@ -57,6 +57,19 @@ config DRM_DEBUG_MM If in doubt, say "N". +config DRM_USE_DYNAMIC_DEBUG + bool "use dynamic debug to implement drm.debug" + default y + depends on DRM + depends on DYNAMIC_DEBUG || DYNAMIC_DEBUG_CORE + depends on JUMP_LABEL + help + The "basic" drm.debug facility does a lot of unlikely + bit-field tests at runtime; while cheap individually, the + cost accumulates. DYNAMIC_DEBUG patches pr_debug()s in/out + of the running kernel, so avoids those bit-test overheads, + and is therefore recommended. + config DRM_DEBUG_SELFTEST tristate "kselftests for DRM" depends on DRM
drivers/gpu/drm/drm_print.c +35 -14
81 lines not on this page · raw message
include/drm/drm_print.h +111 -30
229 lines not on this page · raw message
Signature · 1 line
2.31.1
Jim Cromie
maintainerPATCH v5 8/9 amdgpu_ucode: reduce number of pr_debug calls
In reply to Jim CromieThere are blocks of DRM_DEBUG calls, consolidate their args into single calls. With dynamic-debug in use, each callsite consumes 56 bytes of ro callsite data, and this patch removes about 65 calls, so it saves ~3.5kb.
no functional changes.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 293 ++++++++++++---------- 1 file changed, 158 insertions(+), 135 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c +158 -135
@@ -30,17 +30,26 @@static void amdgpu_ucode_print_common_hdr (const struct common_firmware_header *hdr) { -DRM_DEBUG ("size_bytes: %u\n" ,le32_to_cpu (hdr->size_bytes)); -DRM_DEBUG ("header_size_bytes: %u\n" ,le32_to_cpu (hdr->header_size_bytes)); -DRM_DEBUG ("header_version_major: %u\n" ,le16_to_cpu (hdr->header_version_major)); -DRM_DEBUG ("header_version_minor: %u\n" ,le16_to_cpu (hdr->header_version_minor)); -DRM_DEBUG ("ip_version_major: %u\n" ,le16_to_cpu (hdr->ip_version_major)); -DRM_DEBUG ("ip_version_minor: %u\n" ,le16_to_cpu (hdr->ip_version_minor)); -DRM_DEBUG ("ucode_version: 0x%08x\n" ,le32_to_cpu (hdr->ucode_version)); -DRM_DEBUG ("ucode_size_bytes: %u\n" ,le32_to_cpu (hdr->ucode_size_bytes)); -DRM_DEBUG ("ucode_array_offset_bytes: %u\n" , -le32_to_cpu (hdr->ucode_array_offset_bytes)); -DRM_DEBUG ("crc32: 0x%08x\n" ,le32_to_cpu (hdr->crc32)); +DRM_DEBUG ("size_bytes: %u\n" +"header_size_bytes: %u\n" +"header_version_major: %u\n" +"header_version_minor: %u\n" +"ip_version_major: %u\n" +"ip_version_minor: %u\n" +"ucode_version: 0x%08x\n" +"ucode_size_bytes: %u\n" +"ucode_array_offset_bytes: %u\n" +"crc32: 0x%08x\n" , +le32_to_cpu (hdr->size_bytes), +le32_to_cpu (hdr->header_size_bytes), +le16_to_cpu (hdr->header_version_major), +le16_to_cpu (hdr->header_version_minor), +le16_to_cpu (hdr->ip_version_major), +le16_to_cpu (hdr->ip_version_minor), +le32_to_cpu (hdr->ucode_version), +le32_to_cpu (hdr->ucode_size_bytes), +le32_to_cpu (hdr->ucode_array_offset_bytes), +le32_to_cpu (hdr->crc32)); }void amdgpu_ucode_print_mc_hdr (const struct common_firmware_header *hdr)
@@ -55,9 +64,9 @@ void amdgpu_ucode_print_mc_hdr(const struct common_firmware_header *hdr)const struct mc_firmware_header_v1_0 *mc_hdr = container_of(hdr, struct mc_firmware_header_v1_0, header); -DRM_DEBUG ("io_debug_size_bytes: %u\n" , -le32_to_cpu (mc_hdr->io_debug_size_bytes)); -DRM_DEBUG ("io_debug_array_offset_bytes: %u\n" , +DRM_DEBUG ("io_debug_size_bytes: %u\n" +"io_debug_array_offset_bytes: %u\n" , +le32_to_cpu (mc_hdr->io_debug_size_bytes),le32_to_cpu (mc_hdr->io_debug_array_offset_bytes)); }else {DRM_ERROR ("Unknown MC ucode version: %u.%u\n" , version_major, version_minor);
@@ -82,13 +91,17 @@ void amdgpu_ucode_print_smc_hdr(const struct common_firmware_header *hdr)switch (version_minor) {case 0 : v2_0_hdr = container_of(hdr, struct smc_firmware_header_v2_0, v1_0.header); -DRM_DEBUG ("ppt_offset_bytes: %u\n" ,le32_to_cpu (v2_0_hdr->ppt_offset_bytes)); -DRM_DEBUG ("ppt_size_bytes: %u\n" ,le32_to_cpu (v2_0_hdr->ppt_size_bytes)); +DRM_DEBUG ("ppt_offset_bytes: %u\n" +"ppt_size_bytes: %u\n" , +le32_to_cpu (v2_0_hdr->ppt_offset_bytes), +le32_to_cpu (v2_0_hdr->ppt_size_bytes));break ;case 1 : v2_1_hdr = container_of(hdr, struct smc_firmware_header_v2_1, v1_0.header); -DRM_DEBUG ("pptable_count: %u\n" ,le32_to_cpu (v2_1_hdr->pptable_count)); -DRM_DEBUG ("pptable_entry_offset: %u\n" ,le32_to_cpu (v2_1_hdr->pptable_entry_offset)); +DRM_DEBUG ("pptable_count: %u\n" +"pptable_entry_offset: %u\n" , +le32_to_cpu (v2_1_hdr->pptable_count), +le32_to_cpu (v2_1_hdr->pptable_entry_offset));break ;default :break ;
@@ -111,10 +124,12 @@ void amdgpu_ucode_print_gfx_hdr(const struct common_firmware_header *hdr)const struct gfx_firmware_header_v1_0 *gfx_hdr = container_of(hdr, struct gfx_firmware_header_v1_0, header); -DRM_DEBUG ("ucode_feature_version: %u\n" , -le32_to_cpu (gfx_hdr->ucode_feature_version)); -DRM_DEBUG ("jt_offset: %u\n" ,le32_to_cpu (gfx_hdr->jt_offset)); -DRM_DEBUG ("jt_size: %u\n" ,le32_to_cpu (gfx_hdr->jt_size)); +DRM_DEBUG ("ucode_feature_version: %u\n" +"jt_offset: %u\n" +"jt_size: %u\n" , +le32_to_cpu (gfx_hdr->ucode_feature_version), +le32_to_cpu (gfx_hdr->jt_offset), +le32_to_cpu (gfx_hdr->jt_size)); }else {DRM_ERROR ("Unknown GFX ucode version: %u.%u\n" , version_major, version_minor); }
@@ -132,82 +147,88 @@ void amdgpu_ucode_print_rlc_hdr(const struct common_firmware_header *hdr)const struct rlc_firmware_header_v1_0 *rlc_hdr = container_of(hdr, struct rlc_firmware_header_v1_0, header); -DRM_DEBUG ("ucode_feature_version: %u\n" , -le32_to_cpu (rlc_hdr->ucode_feature_version)); -DRM_DEBUG ("save_and_restore_offset: %u\n" , -le32_to_cpu (rlc_hdr->save_and_restore_offset)); -DRM_DEBUG ("clear_state_descriptor_offset: %u\n" , -le32_to_cpu (rlc_hdr->clear_state_descriptor_offset)); -DRM_DEBUG ("avail_scratch_ram_locations: %u\n" , -le32_to_cpu (rlc_hdr->avail_scratch_ram_locations)); -DRM_DEBUG ("master_pkt_description_offset: %u\n" , +DRM_DEBUG ("ucode_feature_version: %u\n" +"save_and_restore_offset: %u\n" +"clear_state_descriptor_offset: %u\n" +"avail_scratch_ram_locations: %u\n" +"master_pkt_description_offset: %u\n" , +le32_to_cpu (rlc_hdr->ucode_feature_version), +le32_to_cpu (rlc_hdr->save_and_restore_offset), +le32_to_cpu (rlc_hdr->clear_state_descriptor_offset), +le32_to_cpu (rlc_hdr->avail_scratch_ram_locations),le32_to_cpu (rlc_hdr->master_pkt_description_offset)); + }else if (version_major ==2 ) {const struct rlc_firmware_header_v2_0 *rlc_hdr = container_of(hdr, struct rlc_firmware_header_v2_0, header); -DRM_DEBUG ("ucode_feature_version: %u\n" , -le32_to_cpu (rlc_hdr->ucode_feature_version)); -DRM_DEBUG ("jt_offset: %u\n" ,le32_to_cpu (rlc_hdr->jt_offset)); -DRM_DEBUG ("jt_size: %u\n" ,le32_to_cpu (rlc_hdr->jt_size)); -DRM_DEBUG ("save_and_restore_offset: %u\n" , -le32_to_cpu (rlc_hdr->save_and_restore_offset)); -DRM_DEBUG ("clear_state_descriptor_offset: %u\n" , -le32_to_cpu (rlc_hdr->clear_state_descriptor_offset)); -DRM_DEBUG ("avail_scratch_ram_locations: %u\n" , -le32_to_cpu (rlc_hdr->avail_scratch_ram_locations)); -DRM_DEBUG ("reg_restore_list_size: %u\n" , -le32_to_cpu (rlc_hdr->reg_restore_list_size)); -DRM_DEBUG ("reg_list_format_start: %u\n" , -le32_to_cpu (rlc_hdr->reg_list_format_start)); -DRM_DEBUG ("reg_list_format_separate_start: %u\n" , +DRM_DEBUG ("ucode_feature_version: %u\n" +"jt_offset: %u\n" +"jt_size: %u\n" +"save_and_restore_offset: %u\n" +"clear_state_descriptor_offset: %u\n" +"avail_scratch_ram_locations: %u\n" +"reg_restore_list_size: %u\n" +"reg_list_format_start: %u\n" +"reg_list_format_separate_start: %u\n" , +le32_to_cpu (rlc_hdr->ucode_feature_version), +le32_to_cpu (rlc_hdr->jt_offset), +le32_to_cpu (rlc_hdr->jt_size), +le32_to_cpu (rlc_hdr->save_and_restore_offset), +le32_to_cpu (rlc_hdr->clear_state_descriptor_offset), +le32_to_cpu (rlc_hdr->avail_scratch_ram_locations), +le32_to_cpu (rlc_hdr->reg_restore_list_size), +le32_to_cpu (rlc_hdr->reg_list_format_start),le32_to_cpu (rlc_hdr->reg_list_format_separate_start)); -DRM_DEBUG ("starting_offsets_start: %u\n" , -le32_to_cpu (rlc_hdr->starting_offsets_start)); -DRM_DEBUG ("reg_list_format_size_bytes: %u\n" , -le32_to_cpu (rlc_hdr->reg_list_format_size_bytes)); -DRM_DEBUG ("reg_list_format_array_offset_bytes: %u\n" , -le32_to_cpu (rlc_hdr->reg_list_format_array_offset_bytes)); -DRM_DEBUG ("reg_list_size_bytes: %u\n" , -le32_to_cpu (rlc_hdr->reg_list_size_bytes)); -DRM_DEBUG ("reg_list_array_offset_bytes: %u\n" , -le32_to_cpu (rlc_hdr->reg_list_array_offset_bytes)); -DRM_DEBUG ("reg_list_format_separate_size_bytes: %u\n" , -le32_to_cpu (rlc_hdr->reg_list_format_separate_size_bytes)); -DRM_DEBUG ("reg_list_format_separate_array_offset_bytes: %u\n" , -le32_to_cpu (rlc_hdr->reg_list_format_separate_array_offset_bytes)); -DRM_DEBUG ("reg_list_separate_size_bytes: %u\n" , -le32_to_cpu (rlc_hdr->reg_list_separate_size_bytes)); -DRM_DEBUG ("reg_list_separate_array_offset_bytes: %u\n" , + +DRM_DEBUG ("starting_offsets_start: %u\n" +"reg_list_format_size_bytes: %u\n" +"reg_list_format_array_offset_bytes: %u\n" +"reg_list_size_bytes: %u\n" +"reg_list_array_offset_bytes: %u\n" +"reg_list_format_separate_size_bytes: %u\n" +"reg_list_format_separate_array_offset_bytes: %u\n" +"reg_list_separate_size_bytes: %u\n" +"reg_list_separate_array_offset_bytes: %u\n" , +le32_to_cpu (rlc_hdr->starting_offsets_start), +le32_to_cpu (rlc_hdr->reg_list_format_size_bytes), +le32_to_cpu (rlc_hdr->reg_list_format_array_offset_bytes), +le32_to_cpu (rlc_hdr->reg_list_size_bytes), +le32_to_cpu (rlc_hdr->reg_list_array_offset_bytes), +le32_to_cpu (rlc_hdr->reg_list_format_separate_size_bytes), +le32_to_cpu (rlc_hdr->reg_list_format_separate_array_offset_bytes), +le32_to_cpu (rlc_hdr->reg_list_separate_size_bytes),le32_to_cpu (rlc_hdr->reg_list_separate_array_offset_bytes)); +if (version_minor ==1 ) {const struct rlc_firmware_header_v2_1 *v2_1 = container_of(rlc_hdr, struct rlc_firmware_header_v2_1, v2_0); -DRM_DEBUG ("reg_list_format_direct_reg_list_length: %u\n" , -le32_to_cpu (v2_1->reg_list_format_direct_reg_list_length)); -DRM_DEBUG ("save_restore_list_cntl_ucode_ver: %u\n" , -le32_to_cpu (v2_1->save_restore_list_cntl_ucode_ver)); -DRM_DEBUG ("save_restore_list_cntl_feature_ver: %u\n" , -le32_to_cpu (v2_1->save_restore_list_cntl_feature_ver)); -DRM_DEBUG ("save_restore_list_cntl_size_bytes %u\n" , -le32_to_cpu (v2_1->save_restore_list_cntl_size_bytes)); -DRM_DEBUG ("save_restore_list_cntl_offset_bytes: %u\n" , -le32_to_cpu (v2_1->save_restore_list_cntl_offset_bytes)); -DRM_DEBUG ("save_restore_list_gpm_ucode_ver: %u\n" , -le32_to_cpu (v2_1->save_restore_list_gpm_ucode_ver)); -DRM_DEBUG ("save_restore_list_gpm_feature_ver: %u\n" , -le32_to_cpu (v2_1->save_restore_list_gpm_feature_ver)); -DRM_DEBUG ("save_restore_list_gpm_size_bytes %u\n" , -le32_to_cpu (v2_1->save_restore_list_gpm_size_bytes)); -DRM_DEBUG ("save_restore_list_gpm_offset_bytes: %u\n" , -le32_to_cpu (v2_1->save_restore_list_gpm_offset_bytes)); -DRM_DEBUG ("save_restore_list_srm_ucode_ver: %u\n" , -le32_to_cpu (v2_1->save_restore_list_srm_ucode_ver)); -DRM_DEBUG ("save_restore_list_srm_feature_ver: %u\n" , -le32_to_cpu (v2_1->save_restore_list_srm_feature_ver)); -DRM_DEBUG ("save_restore_list_srm_size_bytes %u\n" , -le32_to_cpu (v2_1->save_restore_list_srm_size_bytes)); -DRM_DEBUG ("save_restore_list_srm_offset_bytes: %u\n" , + +DRM_DEBUG ("reg_list_format_direct_reg_list_length: %u\n" +"save_restore_list_cntl_ucode_ver: %u\n" +"save_restore_list_cntl_feature_ver: %u\n" +"save_restore_list_cntl_size_bytes %u\n" +"save_restore_list_cntl_offset_bytes: %u\n" +"save_restore_list_gpm_ucode_ver: %u\n" +"save_restore_list_gpm_feature_ver: %u\n" +"save_restore_list_gpm_size_bytes %u\n" +"save_restore_list_gpm_offset_bytes: %u\n" +"save_restore_list_srm_ucode_ver: %u\n" +"save_restore_list_srm_feature_ver: %u\n" +"save_restore_list_srm_size_bytes %u\n" +"save_restore_list_srm_offset_bytes: %u\n" , +le32_to_cpu (v2_1->reg_list_format_direct_reg_list_length), +le32_to_cpu (v2_1->save_restore_list_cntl_ucode_ver), +le32_to_cpu (v2_1->save_restore_list_cntl_feature_ver), +le32_to_cpu (v2_1->save_restore_list_cntl_size_bytes), +le32_to_cpu (v2_1->save_restore_list_cntl_offset_bytes), +le32_to_cpu (v2_1->save_restore_list_gpm_ucode_ver), +le32_to_cpu (v2_1->save_restore_list_gpm_feature_ver), +le32_to_cpu (v2_1->save_restore_list_gpm_size_bytes), +le32_to_cpu (v2_1->save_restore_list_gpm_offset_bytes), +le32_to_cpu (v2_1->save_restore_list_srm_ucode_ver), +le32_to_cpu (v2_1->save_restore_list_srm_feature_ver), +le32_to_cpu (v2_1->save_restore_list_srm_size_bytes),le32_to_cpu (v2_1->save_restore_list_srm_offset_bytes)); } }else {
@@ -227,12 +248,14 @@ void amdgpu_ucode_print_sdma_hdr(const struct common_firmware_header *hdr)const struct sdma_firmware_header_v1_0 *sdma_hdr = container_of(hdr, struct sdma_firmware_header_v1_0, header); -DRM_DEBUG ("ucode_feature_version: %u\n" , -le32_to_cpu (sdma_hdr->ucode_feature_version)); -DRM_DEBUG ("ucode_change_version: %u\n" , -le32_to_cpu (sdma_hdr->ucode_change_version)); -DRM_DEBUG ("jt_offset: %u\n" ,le32_to_cpu (sdma_hdr->jt_offset)); -DRM_DEBUG ("jt_size: %u\n" ,le32_to_cpu (sdma_hdr->jt_size)); +DRM_DEBUG ("ucode_feature_version: %u\n" +"ucode_change_version: %u\n" +"jt_offset: %u\n" +"jt_size: %u\n" , +le32_to_cpu (sdma_hdr->ucode_feature_version), +le32_to_cpu (sdma_hdr->ucode_change_version), +le32_to_cpu (sdma_hdr->jt_offset), +le32_to_cpu (sdma_hdr->jt_size));if (version_minor >=1 ) {const struct sdma_firmware_header_v1_1 *sdma_v1_1_hdr = container_of(sdma_hdr, struct sdma_firmware_header_v1_1, v1_0);
@@ -256,36 +279,36 @@ void amdgpu_ucode_print_psp_hdr(const struct common_firmware_header *hdr)const struct psp_firmware_header_v1_0 *psp_hdr = container_of(hdr, struct psp_firmware_header_v1_0, header); -DRM_DEBUG ("ucode_feature_version: %u\n" , -le32_to_cpu (psp_hdr->sos.fw_version)); -DRM_DEBUG ("sos_offset_bytes: %u\n" , -le32_to_cpu (psp_hdr->sos.offset_bytes)); -DRM_DEBUG ("sos_size_bytes: %u\n" , +DRM_DEBUG ("ucode_feature_version: %u\n" +"sos_offset_bytes: %u\n" +"sos_size_bytes: %u\n" , +le32_to_cpu (psp_hdr->sos.fw_version), +le32_to_cpu (psp_hdr->sos.offset_bytes),le32_to_cpu (psp_hdr->sos.size_bytes));if (version_minor ==1 ) {const struct psp_firmware_header_v1_1 *psp_hdr_v1_1 = container_of(psp_hdr, struct psp_firmware_header_v1_1, v1_0); -DRM_DEBUG ("toc_header_version: %u\n" , -le32_to_cpu (psp_hdr_v1_1->toc.fw_version)); -DRM_DEBUG ("toc_offset_bytes: %u\n" , -le32_to_cpu (psp_hdr_v1_1->toc.offset_bytes)); -DRM_DEBUG ("toc_size_bytes: %u\n" , -le32_to_cpu (psp_hdr_v1_1->toc.size_bytes)); -DRM_DEBUG ("kdb_header_version: %u\n" , -le32_to_cpu (psp_hdr_v1_1->kdb.fw_version)); -DRM_DEBUG ("kdb_offset_bytes: %u\n" , -le32_to_cpu (psp_hdr_v1_1->kdb.offset_bytes)); -DRM_DEBUG ("kdb_size_bytes: %u\n" , +DRM_DEBUG ("toc_header_version: %u\n" +"toc_offset_bytes: %u\n" +"toc_size_bytes: %u\n" +"kdb_header_version: %u\n" +"kdb_offset_bytes: %u\n" +"kdb_size_bytes: %u\n" , +le32_to_cpu (psp_hdr_v1_1->toc.fw_version), +le32_to_cpu (psp_hdr_v1_1->toc.offset_bytes), +le32_to_cpu (psp_hdr_v1_1->toc.size_bytes), +le32_to_cpu (psp_hdr_v1_1->kdb.fw_version), +le32_to_cpu (psp_hdr_v1_1->kdb.offset_bytes),le32_to_cpu (psp_hdr_v1_1->kdb.size_bytes)); }if (version_minor ==2 ) {const struct psp_firmware_header_v1_2 *psp_hdr_v1_2 = container_of(psp_hdr, struct psp_firmware_header_v1_2, v1_0); -DRM_DEBUG ("kdb_header_version: %u\n" , -le32_to_cpu (psp_hdr_v1_2->kdb.fw_version)); -DRM_DEBUG ("kdb_offset_bytes: %u\n" , -le32_to_cpu (psp_hdr_v1_2->kdb.offset_bytes)); -DRM_DEBUG ("kdb_size_bytes: %u\n" , +DRM_DEBUG ("kdb_header_version: %u\n" +"kdb_offset_bytes: %u\n" +"kdb_size_bytes: %u\n" , +le32_to_cpu (psp_hdr_v1_2->kdb.fw_version), +le32_to_cpu (psp_hdr_v1_2->kdb.offset_bytes),le32_to_cpu (psp_hdr_v1_2->kdb.size_bytes)); }if (version_minor ==3 ) {
@@ -293,23 +316,23 @@ void amdgpu_ucode_print_psp_hdr(const struct common_firmware_header *hdr) container_of(psp_hdr, struct psp_firmware_header_v1_1, v1_0);const struct psp_firmware_header_v1_3 *psp_hdr_v1_3 = container_of(psp_hdr_v1_1, struct psp_firmware_header_v1_3, v1_1); -DRM_DEBUG ("toc_header_version: %u\n" , -le32_to_cpu (psp_hdr_v1_3->v1_1.toc.fw_version)); -DRM_DEBUG ("toc_offset_bytes: %u\n" , -le32_to_cpu (psp_hdr_v1_3->v1_1.toc.offset_bytes)); -DRM_DEBUG ("toc_size_bytes: %u\n" , -le32_to_cpu (psp_hdr_v1_3->v1_1.toc.size_bytes)); -DRM_DEBUG ("kdb_header_version: %u\n" , -le32_to_cpu (psp_hdr_v1_3->v1_1.kdb.fw_version)); -DRM_DEBUG ("kdb_offset_bytes: %u\n" , -le32_to_cpu (psp_hdr_v1_3->v1_1.kdb.offset_bytes)); -DRM_DEBUG ("kdb_size_bytes: %u\n" , -le32_to_cpu (psp_hdr_v1_3->v1_1.kdb.size_bytes)); -DRM_DEBUG ("spl_header_version: %u\n" , -le32_to_cpu (psp_hdr_v1_3->spl.fw_version)); -DRM_DEBUG ("spl_offset_bytes: %u\n" , -le32_to_cpu (psp_hdr_v1_3->spl.offset_bytes)); -DRM_DEBUG ("spl_size_bytes: %u\n" , +DRM_DEBUG ("toc_header_version: %u\n" +"toc_offset_bytes: %u\n" +"toc_size_bytes: %u\n" +"kdb_header_version: %u\n" +"kdb_offset_bytes: %u\n" +"kdb_size_bytes: %u\n" +"spl_header_version: %u\n" +"spl_offset_bytes: %u\n" +"spl_size_bytes: %u\n" , +le32_to_cpu (psp_hdr_v1_3->v1_1.toc.fw_version), +le32_to_cpu (psp_hdr_v1_3->v1_1.toc.offset_bytes), +le32_to_cpu (psp_hdr_v1_3->v1_1.toc.size_bytes), +le32_to_cpu (psp_hdr_v1_3->v1_1.kdb.fw_version), +le32_to_cpu (psp_hdr_v1_3->v1_1.kdb.offset_bytes), +le32_to_cpu (psp_hdr_v1_3->v1_1.kdb.size_bytes), +le32_to_cpu (psp_hdr_v1_3->spl.fw_version), +le32_to_cpu (psp_hdr_v1_3->spl.offset_bytes),le32_to_cpu (psp_hdr_v1_3->spl.size_bytes)); } }else {
@@ -330,9 +353,9 @@ void amdgpu_ucode_print_gpu_info_hdr(const struct common_firmware_header *hdr)const struct gpu_info_firmware_header_v1_0 *gpu_info_hdr = container_of(hdr, struct gpu_info_firmware_header_v1_0, header); -DRM_DEBUG ("version_major: %u\n" , -le16_to_cpu (gpu_info_hdr->version_major)); -DRM_DEBUG ("version_minor: %u\n" , +DRM_DEBUG ("version_major: %u\n" +"version_minor: %u\n" , +le16_to_cpu (gpu_info_hdr->version_major),le16_to_cpu (gpu_info_hdr->version_minor)); }else {DRM_ERROR ("Unknown gpu_info ucode version: %u.%u\n" , version_major, version_minor);
Signature · 1 line
2.31.1
Jim Cromie
maintainerPATCH v5 9/9 dyndbg: RFC add tracer facility RFC
In reply to Jim CromieSean Paul [email protected] proposed, in
https://patchwork.freedesktop.org/series/78133/
drm/trace: Mirror DRM debug logs to tracefs
That patchset's goal is to be able to duplicate the debug stream to a tracing destination, by splitting drm_debug_enabled() into syslog & trace flavors, and enabling them separately. That clashes rather deeply with this patchset's goal; to avoid drm_debug_enabled() using dyndbg.
Instead, this puts the print-to-trace decision in dyndbg, after the is-it-enabled test (which is a noop), so it has near zero additional cost (other than memory increase); the print-to-trace test is only done on enabled callsites.
The basic elements:
- add a new struct _ddebug member: (*tracer)(char *format, ...)
- add a new T flag to enable tracer
- adjust the static-key-enable/disable condition for (p|T)
- if (p) before printk, since T enables too.
- if (T) call tracer if its true
= int dynamic_debug_register_tracer(query, modname, tracer); = int dynamic_debug_unregister_tracer(query, modname, cookie);
This new interface lets clients set/unset a tracer function on each callsite matching the query, for example: "drm:atomic:fail:".
Clients are expected to unregister the same callsites they register (a cookie), allowing protection of each client's dyndbg-state setup against overwrites by others.
Intended Behavior: (things are in flux, RFC)
- register sets empty slot, doesnt overwrite
the query selects callsites, and sets +T (grammar requires +-action)
- register allows same-tracer over-set wo warn
2nd register can then enable superset, subset, disjoint set
- unregister clears slot if it matches cookie/tracer query selects set, -T (as tested) tolerates over-clears
- dd-exec-queries(+/-T) can modify the enablements not sure its needed, but it falls out..
The code is currently in-line in ddebug_change(), to be moved to separate fn, rc determines flow, may also veto/alter changes by altering flag-settings - tbd.
TBD: Im not sure what happens when exec-queries(+T) hits a site wo a tracer (silence I think. maybe not ideal).
internal call-chain gets a tracer param:
New arg:
public: dynamic_debug_exec_queries
ro-string copy moved ...
1 ddebug_exec_queries tracer=NULL
... to here
2 ddebug_exec_query tracer=NULL
call-chain gets (re)used: with !NULL
public: dynamic_debug_register_tracer tracer=client's
w ro-string
1 ddebug_exec_queries tracer
...
SELFTEST: test_dynamic_debug.ko:
Uses the tracer facility to do a selftest:
- A custom tracer counts the number of calls (of T-enabled pr_debugs),
- do_debugging(x) calls a set of categorized pr_debugs x times
- test registers the tracer on the function,
then iteratively:
manipulates dyndbg states via query-cmds
runs do_debugging()
counts enabled callsite executions
reports mismatches
- modprobe test_dynamic_debug use_bad_tracer=1
attaches a bad/recursive tracer
Bad Things Happen.
has thrown me interesting panics.
NOTES:
This needs more work. RFC.
ERRORS (or WARNINGS):
It should be an error to +T a callsite which has no aux_print set (ie already registered with a query that selected that callsite). This tacitly enforces registration.
Then +T,-T can toggle those aux_print callsites (or subsets of them) to tailor the debug-stream for the purpose. Controlling flow is the best work limiter.
---
v4+: (this patch sent after (on top of) v4)
. fix "too many arguments to function", and name the args:
int (*aux_print)(const char *fmt, char *prefix, char *label, void *);
prefix : is a slot for dynamic_emit_prefix, or for custom buffer insert label : for builtin-caller used by drm-trace-print
void* : vaf, add type constraint later.
. fix printk (to syslog) needs if (+p), since +T also enables . add prototypes for un/register_aux_print
. change iface names: s/aux_print/tracer/
. also s/trace_print/tracer/
. struct va_format *vaf - tighten further ?
--- include/linux/dynamic_debug.h | 32 ++++- lib/Kconfig.debug | 10 ++ lib/Makefile | 1 + lib/dynamic_debug.c | 109 +++++++++++---- lib/test_dynamic_debug.c | 247 ++++++++++++++++++++++++++++++++++ 5 files changed, 372 insertions(+), 27 deletions(-) create mode 100644 lib/test_dynamic_debug.c
include/linux/dynamic_debug.h +31 -1
@@ -20,6 +20,7 @@ struct _ddebug {const char *function;const char *filename;const char *format; +int (*tracer)(const char *fmt,char *prefix,char *label,struct va_format *vaf); unsigned int lineno:18;/* * The flags field controls the behaviour at the callsite.
@@ -27,7 +28,11 @@ struct _ddebug {* writes commands to <debugfs>/dynamic_debug/control */ #define _DPRINTK_FLAGS_NONE 0 -#define _DPRINTK_FLAGS_PRINT (1<<0)/* printk() a message using the format */ +#define _DPRINTK_FLAGS_PRINT (1<<0)/* printk() a message */ +#define _DPRINTK_FLAGS_PRINT_TRACE (1<<5)/* call (*tracer) */ + +#define _DPRINTK_ENABLED (_DPRINTK_FLAGS_PRINT | _DPRINTK_FLAGS_PRINT_TRACE) +#define _DPRINTK_FLAGS_INCL_MODNAME (1<<1)#define _DPRINTK_FLAGS_INCL_FUNCNAME (1<<2)#define _DPRINTK_FLAGS_INCL_LINENO (1<<3)
@@ -279,4 +284,29 @@ extern const struct kernel_param_ops param_ops_dyndbg;#define _DD_cat_help_ (pfx)#endif +/** +* dynamic_debug_register_tracer - register a "printer" function +* @query: query-command string to select callsites getting the function +* @tracer: &vprintf-ish accepting 3 char* ptrs & a vaf +* +* Attach a printer function to callsites selected by query. +* If another printer is already attached, warn and skip, applying the +* rest of the query. This protects existing setups, while allowing +* maximal coexistence of (mostly) non-competing listeners. RFC. +*/ +int dynamic_debug_register_tracer (const char *query,const char *mod, +int (*tracer) (const char *fmt,char *prefix,char *label,struct va_format *vaf)); +/** +* dynamic_debug_unregister_tracer - unregister your "printer" function +* @query: query-command string to select callsites to reset +* @cookie: reserved to validate unregisters against pirates +* +* Detach this printer function (@cookie) from callsites selected by +* the query, when @cookie == callsite. This protects existing +* setups, while allowing maximal coexistence of (mostly) +* non-competing listeners. RFC. +*/ +int dynamic_debug_unregister_tracer (const char *query,const char *mod, +int (*cookie) (const char *fmt,char *prefix,char *label,struct va_format *vaf)); +#endif
lib/Kconfig.debug +10 -0
@@ -2486,6 +2486,16 @@ config TEST_STATIC_KEYS If unsure, say N. +config TEST_DYNAMIC_DEBUG + tristate "Test DYNAMIC_DEBUG" + depends on m + depends on DYNAMIC_DEBUG + help + Test the print_aux registration with a counting fn, + then test expected counts during the execution. + + If unsure, say N. + config TEST_KMOD tristate "kmod stress tester" depends on m
lib/Makefile +1 -0
@@ -82,6 +82,7 @@ obj-$(CONFIG_TEST_SORT) += test_sort.o obj-$(CONFIG_TEST_USER_COPY) += test_user_copy.o obj-$(CONFIG_TEST_STATIC_KEYS) += test_static_keys.o obj-$(CONFIG_TEST_STATIC_KEYS) += test_static_key_base.o +obj-$(CONFIG_TEST_DYNAMIC_DEBUG) += test_dynamic_debug.o obj-$(CONFIG_TEST_PRINTF) += test_printf.o obj-$(CONFIG_TEST_SCANF) += test_scanf.o obj-$(CONFIG_TEST_BITMAP) += test_bitmap.o
lib/dynamic_debug.c +83 -26
196 lines not on this page · raw message
lib/test_dynamic_debug.c new file +247 -0
247 lines not on this page · raw message
Signature · 1 line
2.31.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and use in DRM
In reply to Jim Cromie== Series Details ==
== Series Details ==
Series: dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and use in DRM
URL : https://patchwork.freedesktop.org/series/93683/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 9735d1bd2f6a moduleparam: add data member to struct kernel_param -:62: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 0 warnings, 0 checks, 35 lines checked918363f529da dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks
-:42: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #42:
Add DEFINE_DYNAMIC_DEBUG_CATEGORIES() described above, and a do-nothing stub.
-:72: WARNING:TYPO_SPELLING: 'doesnt' may be misspelled - perhaps 'doesn't'? #72:
"1","2","3" 2 doesnt imply 1.
^^^^^^
-:90: WARNING:TYPO_SPELLING: 'doesnt' may be misspelled - perhaps 'doesn't'? #90:
":" doesnt terminate the search-space, the trailing space does.
^^^^^^
-:114: WARNING:TYPO_SPELLING: 'doesnt' may be misspelled - perhaps 'doesn't'? #114:
- "drm:kms:*" doesnt work, no wildcard on format atm.
^^^^^^
-:188: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fsname' - possible side-effects? #188: FILE: include/linux/dynamic_debug.h:264:
+#define DEFINE_DYNAMIC_DEBUG_CATEGORIES(fsname, var, _desc, ...) \
+ MODULE_PARM_DESC(fsname, _desc); \
+ static struct dyndbg_bitdesc const dyndbg_cats_##fsname[] = \
+ { __VA_ARGS__, { NULL, NULL } }; \
+ module_param_cbd(fsname, ¶m_ops_dyndbg, &var, 0644, \
+ &dyndbg_cats_##fsname);
-:188: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'var' may be better as '(var)' to avoid precedence issues #188: FILE: include/linux/dynamic_debug.h:264:
+#define DEFINE_DYNAMIC_DEBUG_CATEGORIES(fsname, var, _desc, ...) \
+ MODULE_PARM_DESC(fsname, _desc); \
+ static struct dyndbg_bitdesc const dyndbg_cats_##fsname[] = \
+ { __VA_ARGS__, { NULL, NULL } }; \
+ module_param_cbd(fsname, ¶m_ops_dyndbg, &var, 0644, \
+ &dyndbg_cats_##fsname);
-:188: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #188: FILE: include/linux/dynamic_debug.h:264:
+#define DEFINE_DYNAMIC_DEBUG_CATEGORIES(fsname, var, _desc, ...) \
+ MODULE_PARM_DESC(fsname, _desc); \
+ static struct dyndbg_bitdesc const dyndbg_cats_##fsname[] = \
+ { __VA_ARGS__, { NULL, NULL } }; \
+ module_param_cbd(fsname, ¶m_ops_dyndbg, &var, 0644, \
+ &dyndbg_cats_##fsname);
-:190: WARNING:STATIC_CONST: Move const after static - use 'static const struct dyndbg_bitdesc' #190: FILE: include/linux/dynamic_debug.h:266:
+ static struct dyndbg_bitdesc const dyndbg_cats_##fsname[] = \
-:195: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pfx' - possible side-effects? #195: FILE: include/linux/dynamic_debug.h:271:
+#define _DD_cat_(pfx) { .prefix = pfx, .help = "help for " pfx }
-:196: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pfx' - possible side-effects? #196: FILE: include/linux/dynamic_debug.h:272:
+#define _DD_cat_help_(pfx) "\t " pfx "\t- help for " pfx "\n"
-:200: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #200: FILE: include/linux/dynamic_debug.h:276:
+#define DEFINE_DYNAMIC_DEBUG_CATEGORIES(fsname, var, bitmap_desc, ...) \
+ MODULE_PARM_DESC(fsname, "auto: " bitmap_desc);
-:240: CHECK:SPACING: No space is necessary after a cast #240: FILE: lib/dynamic_debug.c:1173:
+ struct dyndbg_bitdesc *bitmap = (struct dyndbg_bitdesc *) kp->data;
-:250: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #250: FILE: lib/dynamic_debug.c:1183:
+ for (i = 0; !!bitmap[i].prefix; i++) {
+
-:282: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #282: FILE: lib/dynamic_debug.c:1215:
+};
+/* support DEFINE_DYNAMIC_DEBUG_CATEGORIES users */
-:283: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 7 warnings, 7 checks, 139 lines checked52fe10f828c0 i915/gvt: remove spaces in pr_debug "gvt: core:" etc prefixes -:47: CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #47: FILE: drivers/gpu/drm/i915/gvt/debug.h:39:
+ pr_debug("gvt:core: "fmt, ##args)
-:51: CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #51: FILE: drivers/gpu/drm/i915/gvt/debug.h:42:
+ pr_debug("gvt:irq: "fmt, ##args)
-:55: CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #55: FILE: drivers/gpu/drm/i915/gvt/debug.h:45:
+ pr_debug("gvt:mm: "fmt, ##args)
-:59: CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #59: FILE: drivers/gpu/drm/i915/gvt/debug.h:48:
+ pr_debug("gvt:mmio: "fmt, ##args)
-:63: CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #63: FILE: drivers/gpu/drm/i915/gvt/debug.h:51:
+ pr_debug("gvt:dpy: "fmt, ##args)
-:67: CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #67: FILE: drivers/gpu/drm/i915/gvt/debug.h:54:
+ pr_debug("gvt:el: "fmt, ##args)
-:71: CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #71: FILE: drivers/gpu/drm/i915/gvt/debug.h:57:
+ pr_debug("gvt:sched: "fmt, ##args)
-:75: CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #75: FILE: drivers/gpu/drm/i915/gvt/debug.h:60:
+ pr_debug("gvt:render: "fmt, ##args)
-:79: CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #79: FILE: drivers/gpu/drm/i915/gvt/debug.h:63:
+ pr_debug("gvt:cmd: "fmt, ##args)
total: 0 errors, 0 warnings, 9 checks, 39 lines checkedd1de5f57f0f1 i915/gvt: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to create "gvt:core:" etc categories -:56: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'key' - possible side-effects? #56: FILE: drivers/gpu/drm/i915/i915_params.c:275:
+#define _help(key) "\t \"" key "\"\t: help for " key "\n"
-:83: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 0 warnings, 1 checks, 45 lines checkedcc4308e46704 amdgpu: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to control categorized pr_debugs -:34: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'key' - possible side-effects? #34: FILE: drivers/gpu/drm/amd/display/dc/core/dc_debug.c:46:
+#define _help_(key) "\t " key "\t- help for " key "\n"
-:55: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #55: FILE: drivers/gpu/drm/amd/display/dc/core/dc_debug.c:67:
+DEFINE_DYNAMIC_DEBUG_CATEGORIES(debug_dc, __debug_dc,
+ DC_DYNDBG_BITMAP_DESC(debug_dc),
total: 0 errors, 0 warnings, 2 checks, 51 lines checked 8ded13656ce8 drm_print: add choice to use dynamic debug in drm-debug -:167: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #167: FILE: drivers/gpu/drm/drm_print.c:61:
+DEFINE_DYNAMIC_DEBUG_CATEGORIES(debug, __drm_debug,
+ DRM_DEBUG_DESC,
-:416: CHECK:LINE_SPACING: Please don't use multiple blank lines #416: FILE: include/drm/drm_print.h:582:
+
-:460: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 0 warnings, 2 checks, 329 lines checked 089e2b7e8515 amdgpu_ucode: reduce number of pr_debug calls f36b9555c312 dyndbg: RFC add tracer facility RFC
-:41: WARNING:TYPO_SPELLING: 'doesnt' may be misspelled - perhaps 'doesn't'? #41:
- register sets empty slot, doesnt overwrite
^^^^^^
-:126: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #126: FILE: include/linux/dynamic_debug.h:31:
+#define _DPRINTK_FLAGS_PRINT (1<<0) /* printk() a message */
^
-:127: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #127: FILE: include/linux/dynamic_debug.h:32:
+#define _DPRINTK_FLAGS_PRINT_TRACE (1<<5) /* call (*tracer) */
^
-:149: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #149: FILE: include/linux/dynamic_debug.h:298:
+int dynamic_debug_register_tracer(const char *query, const char *mod,
+ int (*tracer) (const char *fmt, char *prefix, char *label, struct va_format *vaf));
-:149: WARNING:SPACING: Unnecessary space before function pointer arguments #149: FILE: include/linux/dynamic_debug.h:298:
+ int (*tracer) (const char *fmt, char *prefix, char *label, struct va_format *vaf));
-:161: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #161: FILE: include/linux/dynamic_debug.h:310:
+int dynamic_debug_unregister_tracer(const char *query, const char *mod,
+ int (*cookie) (const char *fmt, char *prefix, char *label, struct va_format *vaf));
-:161: WARNING:SPACING: Unnecessary space before function pointer arguments #161: FILE: include/linux/dynamic_debug.h:310:
+ int (*cookie) (const char *fmt, char *prefix, char *label, struct va_format *vaf));
-:172: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully #172: FILE: lib/Kconfig.debug:2489:
+config TEST_DYNAMIC_DEBUG
-:226: CHECK:BRACES: braces {} should be used on all arms of this statement #226: FILE: lib/dynamic_debug.c:213:
+ if (!tracer)
[...]
+ else {
[...]
-:228: CHECK:BRACES: Unbalanced braces around else statement #228: FILE: lib/dynamic_debug.c:215:
+ else {
-:230: CHECK:BRACES: braces {} should be used on all arms of this statement #230: FILE: lib/dynamic_debug.c:217:
+ if (!dp->tracer) {
[...]
+ else if (tracer == dp->tracer)
[...]
+ else
[...]
-:234: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #234: FILE: lib/dynamic_debug.c:221:
+ }
+ else if (tracer == dp->tracer)
-:240: CHECK:BRACES: braces {} should be used on all arms of this statement #240: FILE: lib/dynamic_debug.c:227:
+ if (!tracer)
[...]
+ else {
[...]
-:242: CHECK:BRACES: Unbalanced braces around else statement #242: FILE: lib/dynamic_debug.c:229:
+ else {
-:244: CHECK:BRACES: braces {} should be used on all arms of this statement #244: FILE: lib/dynamic_debug.c:231:
+ if (!dp->tracer)
[...]
+ else if (dp->tracer == tracer) {
[...]
+ else
[...]
-:251: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #251: FILE: lib/dynamic_debug.c:238:
+ }
+ else
-:258: CHECK:BRACES: braces {} should be used on all arms of this statement #258: FILE: lib/dynamic_debug.c:243:
+ if (dp->flags & _DPRINTK_ENABLED) {
[...]
- } else if (modifiers->flags & _DPRINTK_FLAGS_PRINT)
[...]
-:353: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... #353: FILE: lib/dynamic_debug.c:675:
+ printk(KERN_DEBUG "%s%pV", buf, &vaf);
-:356: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #356: FILE: lib/dynamic_debug.c:678:
+ if (descriptor->flags & _DPRINTK_FLAGS_PRINT_TRACE) {
+
-:361: WARNING:TYPO_SPELLING: 'shouldnt' may be misspelled - perhaps 'shouldn't'? #361: FILE: lib/dynamic_debug.c:683:
+ /* else shouldnt matter, but maybe for consistency */
^^^^^^^^
-:399: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #399: FILE: lib/dynamic_debug.c:1262:
+int dynamic_debug_register_tracer(const char *query, const char *mod,
+ int (*tracer) (const char *fmt, char *prefix, char *label, struct va_format *vaf))
-:399: WARNING:SPACING: Unnecessary space before function pointer arguments #399: FILE: lib/dynamic_debug.c:1262:
+ int (*tracer) (const char *fmt, char *prefix, char *label, struct va_format *vaf))
-:406: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #406: FILE: lib/dynamic_debug.c:1269:
+int dynamic_debug_unregister_tracer(const char *query, const char *mod,
+ int (*tracer) (const char *fmt, char *prefix, char *label, struct va_format *vaf))
-:406: WARNING:SPACING: Unnecessary space before function pointer arguments #406: FILE: lib/dynamic_debug.c:1269:
+ int (*tracer) (const char *fmt, char *prefix, char *label, struct va_format *vaf))
-:412: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #412:
new file mode 100644
-:438: ERROR:INITIALISED_STATIC: do not initialise statics to 0 #438: FILE: lib/test_dynamic_debug.c:22:
+static int trace_ct = 0;
-:439: ERROR:INITIALISED_STATIC: do not initialise statics to 0 #439: FILE: lib/test_dynamic_debug.c:23:
+static int test_ct = 0;
-:440: ERROR:INITIALISED_STATIC: do not initialise statics to 0 #440: FILE: lib/test_dynamic_debug.c:24:
+static int errors = 0;
-:441: ERROR:INITIALISED_STATIC: do not initialise statics to 0 #441: FILE: lib/test_dynamic_debug.c:25:
+static int verbose = 0;
-:443: CHECK:LINE_SPACING: Please don't use multiple blank lines #443: FILE: lib/test_dynamic_debug.c:27:
+
+
-:478: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'expect_count', this function's name, in a string #478: FILE: lib/test_dynamic_debug.c:62:
+ pr_err("expect_count: want %d, got %d: %s\n", want, trace_ct, story);
-:494: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'do_debugging', this function's name, in a string #494: FILE: lib/test_dynamic_debug.c:78:
+ pr_info(" do_debugging %d time(s)\n", reps);
-:546: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #546: FILE: lib/test_dynamic_debug.c:130:
+struct exec_test exec_tests[] = {
+
-:608: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #608: FILE: lib/test_dynamic_debug.c:192:
+struct register_test register_tests[] = {
+
-:635: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #635: FILE: lib/test_dynamic_debug.c:219:
+ match_count = dynamic_debug_unregister_tracer(
-:643: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #643: FILE: lib/test_dynamic_debug.c:227:
+ match_count = dynamic_debug_unregister_tracer(
-:663: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 7 errors, 11 warnings, 19 checks, 514 lines checked
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and use in DRM
In reply to Jim Cromie== Series Details ==
== Series Details ==
Series: dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and use in DRM
URL : https://patchwork.freedesktop.org/series/93683/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10482 -> Patchwork_20820
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/index.html
Known issues
------------
Here are the changes found in Patchwork_20820 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-tgl-1115g4: NOTRUN -> [SKIP][1] ([fdo#109315])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/fi-tgl-1115g4/igt@amdgpu/[email protected]
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][2] ([fdo#109271]) +29 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/fi-bdw-5557u/igt@amdgpu/[email protected]
* igt@amdgpu/amd_cs_nop@nop-gfx0:
- fi-tgl-1115g4: NOTRUN -> [SKIP][3] ([fdo#109315] / [i915#2575]) +16 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/fi-tgl-1115g4/igt@amdgpu/[email protected]
* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][4] ([i915#3718])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/fi-bdw-5557u/igt@[email protected]
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-1115g4: NOTRUN -> [FAIL][5] ([i915#1888])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/fi-tgl-1115g4/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-tgl-1115g4: NOTRUN -> [SKIP][6] ([i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/fi-tgl-1115g4/igt@[email protected]
* igt@i915_pm_backlight@basic-brightness:
- fi-tgl-1115g4: NOTRUN -> [SKIP][7] ([i915#1155])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/fi-tgl-1115g4/igt@[email protected]
* igt@i915_pm_rpm@basic-rte:
- fi-tgl-1115g4: NOTRUN -> [FAIL][8] ([i915#579])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/fi-tgl-1115g4/igt@[email protected]
- fi-bdw-5557u: NOTRUN -> [FAIL][9] ([i915#579])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/fi-bdw-5557u/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-tgl-1115g4: NOTRUN -> [SKIP][10] ([i915#579]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/fi-tgl-1115g4/igt@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-tgl-1115g4: NOTRUN -> [SKIP][11] ([fdo#111827]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/fi-tgl-1115g4/igt@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/fi-bdw-5557u/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-1115g4: NOTRUN -> [SKIP][13] ([fdo#109285])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/fi-tgl-1115g4/igt@[email protected]
* igt@kms_psr@primary_mmap_gtt:
- fi-tgl-1115g4: NOTRUN -> [SKIP][14] ([i915#1072]) +3 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html
* igt@prime_vgem@basic-userptr:
- fi-tgl-1115g4: NOTRUN -> [SKIP][15] ([i915#3301])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/fi-tgl-1115g4/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- {fi-hsw-gt1}: [DMESG-WARN][16] ([i915#3303]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/fi-hsw-gt1/igt@i915_selftest@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/fi-hsw-gt1/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3718]: https://gitlab.freedesktop.org/drm/intel/issues/3718
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
Participating hosts (35 -> 34)
------------------------------
Additional (2): fi-tgl-1115g4 fi-bdw-5557u
Missing (3): fi-bdw-samus fi-bsw-cyan bat-jsl-1
Build changes
-------------
* Linux: CI_DRM_10482 -> Patchwork_20820
CI-20190529: 20190529
CI_DRM_10482: 772cc2d9bb24a9f750e3a88c6b2172873830e095 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6175: c91f99c74b966f635d7e2eb898bf0f78383d281b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20820: f36b9555c31206ec867480b1aa71d4d87457d0d9 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f36b9555c312 dyndbg: RFC add tracer facility RFC089e2b7e8515 amdgpu_ucode: reduce number of pr_debug calls8ded13656ce8 drm_print: add choice to use dynamic debug in drm-debug cc4308e46704 amdgpu: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to control categorized pr_debugs d1de5f57f0f1 i915/gvt: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to create "gvt:core:" etc categories 52fe10f828c0 i915/gvt: remove spaces in pr_debug "gvt: core:" etc prefixes 918363f529da dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks 9735d1bd2f6a moduleparam: add data member to struct kernel_param
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and use in DRM
In reply to Jim Cromie== Series Details ==
== Series Details ==
Series: dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and use in DRM
URL : https://patchwork.freedesktop.org/series/93683/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10482_full -> Patchwork_20820_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_20820_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_20820_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20820_full:
### Piglit changes ###
#### Possible regressions ####
* [email protected]@execution@tex-miplevel-selection texturelod 1dshadow (NEW):
- pig-snb-2600: NOTRUN -> [FAIL][1]
[1]: None
New tests
---------
New tests have been introduced between CI_DRM_10482_full and Patchwork_20820_full:
### New Piglit tests (1) ###
* [email protected]@execution@tex-miplevel-selection texturelod 1dshadow:
- Statuses : 1 fail(s)
- Exec time: [6.38] s
Known issues
------------
Here are the changes found in Patchwork_20820_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][2] -> [SKIP][3] ([i915#658])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-iclb2/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-iclb7/igt@[email protected]
* igt@gem_ctx_persistence@legacy-engines-queued:
- shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +7 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-snb7/igt@[email protected]
* igt@gem_eio@in-flight-immediate:
- shard-skl: [PASS][5] -> [TIMEOUT][6] ([i915#3063])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl9/igt@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-apl: [PASS][7] -> [SKIP][8] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-apl7/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-apl7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][9] -> [FAIL][10] ([i915#2842]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-tglb7/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][11] ([i915#2842]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-iclb4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][12] -> [FAIL][13] ([i915#2842]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-kbl4/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-kbl7/igt@gem_exec_fair@[email protected]
* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-glk: [PASS][14] -> [FAIL][15] ([i915#1888] / [i915#307])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-glk4/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-glk3/igt@[email protected]
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [PASS][16] -> [FAIL][17] ([i915#644])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-glk3/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-glk7/igt@[email protected]
* igt@gem_userptr_blits@input-checking:
- shard-snb: NOTRUN -> [DMESG-WARN][18] ([i915#3002])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-snb5/igt@[email protected]
* igt@gen7_exec_parse@basic-offset:
- shard-tglb: NOTRUN -> [SKIP][19] ([fdo#109289])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@[email protected]
* igt@i915_pm_rpm@pc8-residency:
- shard-tglb: NOTRUN -> [SKIP][20] ([i915#579])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@[email protected]
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-tglb: NOTRUN -> [SKIP][21] ([i915#1769])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@[email protected]
* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: [PASS][22] -> [DMESG-WARN][23] ([i915#118] / [i915#95]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-glk3/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-glk7/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-tglb: [PASS][24] -> [FAIL][25] ([i915#3722])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-tglb1/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb3/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-addfb-size-overflow:
- shard-tglb: NOTRUN -> [SKIP][26] ([fdo#111615]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb1/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3777]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-apl6/igt@[email protected]
* igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3886]) +5 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-apl8/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][29] ([i915#3689] / [i915#3886])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#3886])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-kbl6/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-bad-pixel-format-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][31] ([i915#3689])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@kms_ccs@pipe-c-bad-pixel-format-yf_tiled_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3886])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl3/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs:
- shard-snb: NOTRUN -> [SKIP][33] ([fdo#109271]) +571 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-snb5/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs.html
* igt@kms_chamelium@hdmi-hpd-fast:
- shard-snb: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +27 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-snb5/igt@[email protected]
* igt@kms_chamelium@vga-edid-read:
- shard-apl: NOTRUN -> [SKIP][35] ([fdo#109271] / [fdo#111827]) +12 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-apl8/igt@[email protected]
* igt@kms_chamelium@vga-hpd-fast:
- shard-skl: NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl3/igt@[email protected]
* igt@kms_color_chamelium@pipe-a-ctm-0-75:
- shard-kbl: NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +4 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-kbl3/igt@[email protected]
* igt@kms_color_chamelium@pipe-d-ctm-blue-to-red:
- shard-tglb: NOTRUN -> [SKIP][38] ([fdo#109284] / [fdo#111827]) +3 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@[email protected]
* igt@kms_content_protection@legacy:
- shard-apl: NOTRUN -> [TIMEOUT][39] ([i915#1319])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-apl1/igt@[email protected]
* igt@kms_content_protection@uevent:
- shard-tglb: NOTRUN -> [SKIP][40] ([fdo#111828])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb1/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-32x32-sliding:
- shard-tglb: NOTRUN -> [SKIP][41] ([i915#3319])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-max-size-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][42] ([i915#3359]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: NOTRUN -> [DMESG-WARN][43] ([i915#180]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-apl2/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-512x512-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#109279] / [i915#3359])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [PASS][45] -> [FAIL][46] ([i915#2346])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl3/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl10/igt@[email protected]
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-skl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#533])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl3/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][48] -> [FAIL][49] ([i915#79])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl4/igt@kms_flip@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl4/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite:
- shard-skl: NOTRUN -> [SKIP][50] ([fdo#109271]) +24 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][51] -> [DMESG-WARN][52] ([i915#180]) +4 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-kbl4/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-kbl4/igt@[email protected]
- shard-apl: [PASS][53] -> [DMESG-WARN][54] ([i915#180]) +3 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-apl2/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-apl2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-shrfb-plflip-blt:
- shard-tglb: NOTRUN -> [SKIP][55] ([fdo#111825]) +10 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-shrfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render:
- shard-skl: [PASS][56] -> [DMESG-WARN][57] ([i915#1982])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][58] ([fdo#108145] / [i915#265]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-apl8/igt@[email protected]
- shard-skl: NOTRUN -> [FAIL][59] ([fdo#108145] / [i915#265])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl7/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][60] ([fdo#108145] / [i915#265]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-kbl3/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][61] -> [FAIL][62] ([fdo#108145] / [i915#265]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl4/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl9/igt@[email protected]
* igt@kms_plane_multiple@atomic-pipe-d-tiling-x:
- shard-kbl: NOTRUN -> [SKIP][63] ([fdo#109271]) +62 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-kbl3/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area-0:
- shard-tglb: NOTRUN -> [SKIP][64] ([i915#2920])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#658]) +3 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-apl8/igt@[email protected]
* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][66] -> [SKIP][67] ([fdo#109642] / [fdo#111068] / [i915#658])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-iclb2/igt@kms_psr2_su@page_flip.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-iclb7/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-tglb: NOTRUN -> [FAIL][68] ([i915#132] / [i915#3467])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][69] -> [SKIP][70] ([fdo#109441])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-iclb7/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-skl: [PASS][71] -> [INCOMPLETE][72] ([i915#198])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl6/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl8/igt@[email protected]
* igt@kms_vblank@pipe-d-wait-forked-hang:
- shard-apl: NOTRUN -> [SKIP][73] ([fdo#109271]) +181 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-apl2/igt@[email protected]
* igt@kms_vrr@flip-suspend:
- shard-tglb: NOTRUN -> [SKIP][74] ([fdo#109502])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@[email protected]
* igt@kms_writeback@writeback-check-output:
- shard-skl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#2437])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl3/igt@[email protected]
* igt@perf_pmu@rc6-runtime-pm:
- shard-tglb: NOTRUN -> [SKIP][76] ([fdo#111719])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@[email protected]
* igt@prime_nv_test@nv_write_i915_gtt_mmap_read:
- shard-tglb: NOTRUN -> [SKIP][77] ([fdo#109291])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb1/igt@prime_nv_test@nv_write_i915_gtt_mmap_read.html
* igt@prime_vgem@fence-read-hang:
- shard-tglb: NOTRUN -> [SKIP][78] ([fdo#109295])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@[email protected]
* igt@runner@aborted:
- shard-snb: NOTRUN -> [FAIL][79] ([i915#3002])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-snb5/igt@[email protected]
* igt@sysfs_clients@create:
- shard-kbl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#2994])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-kbl6/igt@[email protected]
* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#2994]) +3 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-apl6/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_persistence@smoketest:
- shard-tglb: [FAIL][82] ([i915#2896]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-tglb2/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb7/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][84] ([i915#2842]) -> [PASS][85] +3 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-tglb5/igt@gem_exec_fair@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [FAIL][86] ([i915#2842]) -> [PASS][87] +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-glk8/igt@gem_exec_fair@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-glk5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-kbl: [FAIL][88] ([i915#2842]) -> [PASS][89] +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-kbl3/igt@gem_exec_fair@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-kbl7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-iclb: [FAIL][90] ([i915#2842]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-iclb6/igt@gem_exec_fair@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-iclb4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][92] ([i915#2849]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-iclb4/igt@gem_exec_fair@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-iclb3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [DMESG-WARN][94] ([i915#180]) -> [PASS][95] +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-kbl1/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-kbl3/igt@[email protected]
* igt@gem_softpin@allocator-evict@rcs0:
- shard-glk: [DMESG-WARN][96] ([i915#118] / [i915#95]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-glk9/igt@gem_softpin@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-glk9/igt@gem_softpin@[email protected]
* igt@gem_spin_batch@spin-each:
- shard-skl: [FAIL][98] ([i915#2898]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl3/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl8/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [DMESG-WARN][100] ([i915#1436] / [i915#716]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl8/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl3/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-skl: [FAIL][102] ([i915#454]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl1/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl7/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [INCOMPLETE][104] ([i915#2828]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-kbl2/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-kbl6/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-128x42-sliding:
- shard-skl: [FAIL][106] ([i915#3444]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl10/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl8/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-skl: [FAIL][108] ([i915#2346]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl7/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl9/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [FAIL][110] ([i915#79]) -> [PASS][111] +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl4/igt@kms_flip@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl4/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [FAIL][112] ([i915#2122]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl3/igt@kms_flip@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl5/igt@kms_flip@[email protected]
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][114] ([i915#1188]) -> [PASS][115] +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl4/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl9/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][116] ([fdo#108145] / [i915#265]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl4/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl4/igt@[email protected]
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][118] ([fdo#109441]) -> [PASS][119] +1 similar issue
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_cpu.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_vblank@pipe-c-wait-forked-hang:
- shard-tglb: [INCOMPLETE][120] -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-tglb7/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb5/igt@[email protected]
* igt@perf@blocking:
- shard-skl: [FAIL][122] ([i915#1542]) -> [PASS][123] +1 similar issue
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl6/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl3/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-glk: [FAIL][124] ([i915#1542]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-glk8/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-glk5/igt@[email protected]
#### Warnings ####
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [FAIL][126] ([i915#2842]) -> [FAIL][127] ([i915#2852])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-iclb2/igt@gem_exec_fair@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-iclb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-tglb: [SKIP][128] ([i915#2848]) -> [FAIL][129] ([i915#2842])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-tglb6/igt@gem_exec_fair@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-tglb1/igt@gem_exec_fair@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][130] ([i915#658]) -> [SKIP][131] ([i915#588])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-iclb8/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-iclb2/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][132] ([i915#2684]) -> [WARN][133] ([i915#1804] / [i915#2684]) +1 similar issue
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-iclb1/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-iclb7/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: [FAIL][134] -> [FAIL][135] ([i915#3722])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-skl10/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-skl8/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-iclb: [SKIP][136] ([i915#2920]) -> [SKIP][137] ([i915#658]) +2 similar issues
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-iclb2/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-iclb7/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-iclb: [SKIP][138] ([i915#658]) -> [SKIP][139] ([i915#2920])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-iclb8/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/shard-iclb2/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144]) ([i915#180] / [i915#2505] / [i915#3002] / [i915#3363]) -> ([FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151]) ([fdo#109271] / [i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-kbl1/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10482/shard-kbl6/igt@[email protected]
[
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20820/index.html