Skip to contentSkip to conversation

Fix client-pending-auth help message in management interface

PATCH In review [email protected]... 3 participants 3 messages Aug 14, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix client-pending-auth help message in management interface

From: Selva Nair <[email protected]...>

- Add the missing timeout value that is required (not optional)
- Split the long line
- Also make the AUTH_PENDING state message format in management-notes.txt more precise.

---
 doc/management-notes.txt | 2 +-
 src/openvpn/manage.c     | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
doc/management-notes.txt +1 -1
index c2034429..5b920fa5 100644
@@ -658,7 +658,7 @@ implementations the name IV_SSO is kept in lieu of a better name.
 The management interface of the client receives notification of
 pending auth via
 
->STATE:datetime,AUTH_PENDING,[timeout number]
+>STATE:datetime,AUTH_PENDING,[timeout number],,,,,
 
 If {EXTRA} is present the client is informed using INFOMSG
 notification as
src/openvpn/manage.c +2 -2
index 86584c4b..f86c87f2 100644
@@ -104,8 +104,8 @@ man_help(void)
     msg(M_CLIENT, "client-auth-nt CID KID : Authenticate client-id/key-id CID/KID");
     msg(M_CLIENT, "client-deny CID KID R [CR] : Deny auth client-id/key-id CID/KID with log reason");
     msg(M_CLIENT, "                             text R and optional client reason text CR");
-    msg(M_CLIENT, "client-pending-auth CID MSG : Instruct OpenVPN to send AUTH_PENDING and INFO_PRE msg"
-        "                          to the client and wait for a final client-auth/client-deny");
+    msg(M_CLIENT, "client-pending-auth CID MSG timeout : Instruct OpenVPN to send AUTH_PENDING and INFO_PRE msg");
+    msg(M_CLIENT, "                                      to the client and wait for a final client-auth/client-deny");
     msg(M_CLIENT, "client-kill CID [M]    : Kill client instance CID with message M (def=RESTART)");
     msg(M_CLIENT, "env-filter [level]     : Set env-var filter level");
 #ifdef MANAGEMENT_PF
Signature · 1 line
2.20.1
Acked-by on v1 1/1
#1 lore raw

Am 14.08.21 um 06:48 schrieb [email protected]...:

Quoted 32 lines

From: Selva Nair <[email protected]...>

- Add the missing timeout value that is required (not optional)
- Split the long line
- Also make the AUTH_PENDING state message format in management-notes.txt more precise.

---
 doc/management-notes.txt | 2 +-
 src/openvpn/manage.c     | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
doc/management-notes.txt +1 -1
index c2034429..5b920fa5 100644
@@ -658,7 +658,7 @@ implementations the name IV_SSO is kept in lieu of a better name.
 The management interface of the client receives notification of
 pending auth via
 
->STATE:datetime,AUTH_PENDING,[timeout number]
+>STATE:datetime,AUTH_PENDING,[timeout number],,,,,
 
 If {EXTRA} is present the client is informed using INFOMSG
 notification as
src/openvpn/manage.c +0 -0
index 86584c4b..f86c87f2 100644

src/openvpn/manage.c man_help(void) · line 111

Quoted 10 lines
src/openvpn/manage.c +2 -2
@@ -104,8 +104,8 @@ man_help(void)
     msg(M_CLIENT, "client-auth-nt CID KID : Authenticate client-id/key-id CID/KID");
     msg(M_CLIENT, "client-deny CID KID R [CR] : Deny auth client-id/key-id CID/KID with log reason");
     msg(M_CLIENT, "                             text R and optional client reason text CR");
-    msg(M_CLIENT, "client-pending-auth CID MSG : Instruct OpenVPN to send AUTH_PENDING and INFO_PRE msg"
-        "                          to the client and wait for a final client-auth/client-deny");
+    msg(M_CLIENT, "client-pending-auth CID MSG timeout : Instruct OpenVPN to send AUTH_PENDING and INFO_PRE msg");
+    msg(M_CLIENT, "                                      to the client and wait for a final client-auth/client-deny");
     msg(M_CLIENT, "client-kill CID [M]    : Kill client instance CID with message M (def=RESTART)");
     msg(M_CLIENT, "env-filter [level]     : Set env-var filter level");
 #ifdef MANAGEMENT_PF
#2 lore raw
In reply to [email protected]...

Thanks.

Your patch has been applied to the master branch.

commit 8b3ea9ea573adbf58b645943bd2d5bb20bc1b1a3

Author: Selva Nair
Date:   Sat Aug 14 00:48:34 2021 -0400
     Fix client-pending-auth help message in management interface

     Signed-off-by: Selva Nair <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg22739.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering