Skip to contentSkip to conversation

media: rc: clean the freed urb pointer to avoid double free

PATCH New Nil Yi 1 participant 1 message Aug 14, 2021

Subsystems (3)
lore
Share & tools
lore

Nil Yi

author
#0 lore raw

PATCH 1/1 media: rc: clean the freed urb pointer to avoid double free

After freed rx_urb, we should set the second interface urb to NULL, otherwise a double free would happen when the driver is removed from the first interface.

---
 drivers/media/rc/imon.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/media/rc/imon.c +2 -0
index 2ca4e86c7..54da6f600 100644
@@ -2358,8 +2358,10 @@ static struct imon_context *imon_init_intf1(struct usb_interface *intf,
 touch_setup_failed:
 find_endpoint_failed:
 	usb_put_dev(ictx->usbdev_intf1);
+	ictx->usbdev_intf1 = NULL;
 	mutex_unlock(&ictx->lock);
 	usb_free_urb(rx_urb);
+	ictx->rx_urb_intf1 = NULL;
 rx_urb_alloc_failed:
 	dev_err(ictx->dev, "unable to initialize intf1, err %d\n", ret);
 
Signature · 1 line
2.17.1