Skip to contentSkip to conversation

HID: sony: Fix more ShanWan clone gamepads to not rumble when plugged in.

PATCH In review Ulrich Spörlein 2 participants 2 messages Aug 14, 2021 – Aug 20, 2021 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: sony: Fix more ShanWan clone gamepads to not rumble when plugged in.

The device string on these can differ, apparently, including typos. I've bought 2 of these in 2012 and googling shows many folks out there with that broken spelling in their dmesg.

---
 drivers/hid/hid-sony.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
hid/hid-sony.c +2 -1
index b3722c51ec78..a2fef59063a6 100644
@@ -2974,7 +2974,8 @@ static int sony_probe(struct hid_device *hdev, const struct hid_device_id *id)
 	if (!strcmp(hdev->name, "FutureMax Dance Mat"))
 		quirks |= FUTUREMAX_DANCE_MAT;
 
-	if (!strcmp(hdev->name, "SHANWAN PS3 GamePad"))
+	if (!strcmp(hdev->name, "SHANWAN PS3 GamePad") ||
+	    !strcmp(hdev->name, "ShanWan PS(R) Ga`epad"))
 		quirks |= SHANWAN_GAMEPAD;
 
 	sc = devm_kzalloc(&hdev->dev, sizeof(*sc), GFP_KERNEL);
Signature · 1 line
2.32.0
#1 lore raw
Quoted 3 lines · Ulrich Spörlein

The device string on these can differ, apparently, including typos. I've bought 2 of these in 2012 and googling shows many folks out there with that broken spelling in their dmesg.

Those aftermarket producers can be funny sometimes :) Applied, thanks.

Signature · 2 lines
Jiri Kosina
SUSE Labs