Skip to contentSkip to conversation

support reading NPA/SSO PF function

PATCH In review Tomasz Duszynski 2 participants 5 messages Aug 15, 2021 – Sep 28, 2021

lore
Share & tools
lore
#0 lore raw

cover support reading NPA/SSO PF function

This series adds support for retrieving NPA/SSO PF function which is then used by a baseband PSM job scheduler block to access NPA/SSO.

While at it also push out some device removal fix.

Tomasz Duszynski (3):
raw/cnxk_bphy: fix device lookup common/cnxk: support reading NPA/SSO PF function raw/cnxk_bphy: support reading NPA/SSO PF function

 drivers/common/cnxk/roc_bphy.c       | 12 +++++++
 drivers/common/cnxk/roc_bphy.h       |  2 ++
 drivers/common/cnxk/version.map      |  2 ++
 drivers/raw/cnxk_bphy/cnxk_bphy.c    | 19 +++++++++--
 drivers/raw/cnxk_bphy/rte_pmd_bphy.h | 50 ++++++++++++++++++++++++++++
 5 files changed, 83 insertions(+), 2 deletions(-)

--
2.25.1

#1 lore raw

PATCH 1/3 raw/cnxk_bphy: fix device lookup

Name needs to be prepared before the lookup otherwise PMD will not be released.

Fixes 24d9c5d59d5d ("raw/cnxk_bphy: add baseband PHY skeleton driver")
---
 drivers/raw/cnxk_bphy/cnxk_bphy.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/raw/cnxk_bphy/cnxk_bphy.c +1 -2
index 9cb3f8d332..8a0d2224c0 100644
@@ -306,14 +306,13 @@ bphy_rawdev_remove(struct rte_pci_device *pci_dev)
 		return -EINVAL;
 	}
 
+	bphy_rawdev_get_name(name, pci_dev);
 	rawdev = rte_rawdev_pmd_get_named_dev(name);
 	if (rawdev == NULL) {
 		plt_err("invalid device name (%s)", name);
 		return -EINVAL;
 	}
 
-	bphy_rawdev_get_name(name, pci_dev);
-
 	return rte_rawdev_pmd_release(rawdev);
 }
 
Signature · 1 line
2.25.1
#2 lore raw

Re: [dpdk-dev] [PATCH 1/3] raw/cnxk_bphy: fix device lookup

Quoted 8 lines · Tomasz Duszynski

Name needs to be prepared before the lookup otherwise PMD will not be released.

Fixes 24d9c5d59d5d ("raw/cnxk_bphy: add baseband PHY skeleton driver")

Series applied to dpdk-next-net-mrvl/for-next-net. Thanks.

Quoted 27 lines
---
 drivers/raw/cnxk_bphy/cnxk_bphy.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/raw/cnxk_bphy/cnxk_bphy.c +1 -3
index 9cb3f8d332..8a0d2224c0 100644
@@ -306,14 +306,13 @@ bphy_rawdev_remove(struct rte_pci_device *pci_dev)
                return -EINVAL;
        }
 
+       bphy_rawdev_get_name(name, pci_dev);
        rawdev = rte_rawdev_pmd_get_named_dev(name);
        if (rawdev == NULL) {
                plt_err("invalid device name (%s)", name);
                return -EINVAL;
        }
 
-       bphy_rawdev_get_name(name, pci_dev);
-
        return rte_rawdev_pmd_release(rawdev);
 }
 
--

2.25.1

#3 lore raw

PATCH 2/3 common/cnxk: support reading NPA/SSO PF function

In reply to Tomasz Duszynski

Add support for reading NPA/SSO pf_func which will be used by a PSM to access NPA/SSO. PSM is a hardware block capable of dispatching jobs to different blocks within a baseband module.

---
 drivers/common/cnxk/roc_bphy.c  | 12 ++++++++++++
 drivers/common/cnxk/roc_bphy.h  |  2 ++
 drivers/common/cnxk/version.map |  2 ++
 3 files changed, 16 insertions(+)
drivers/common/cnxk/roc_bphy.c +12 -0
index 77606d6465..12234c5dcc 100644
@@ -38,3 +38,15 @@ roc_bphy_dev_fini(struct roc_bphy *roc_bphy)
 
 	return 0;
 }
+
+uint16_t
+roc_bphy_npa_pf_func_get(void)
+{
+	return idev_npa_pffunc_get();
+}
+
+uint16_t
+roc_bphy_sso_pf_func_get(void)
+{
+	return idev_sso_pffunc_get();
+}
drivers/common/cnxk/roc_bphy.h +2 -0
index 0579c6c443..0032829c8d 100644
@@ -13,5 +13,7 @@ struct roc_bphy {
 
 int __roc_api roc_bphy_dev_init(struct roc_bphy *roc_bphy);
 int __roc_api roc_bphy_dev_fini(struct roc_bphy *roc_bphy);
+__roc_api uint16_t roc_bphy_npa_pf_func_get(void);
+__roc_api uint16_t roc_bphy_sso_pf_func_get(void);
 
 #endif /* _ROC_BPHY_ */
drivers/common/cnxk/version.map +2 -0
index 2cbcc4b93a..bcbeaf5e7e 100644
@@ -46,6 +46,8 @@ INTERNAL {
 	roc_bphy_irq_handler_set;
 	roc_bphy_irq_stack_get;
 	roc_bphy_irq_stack_remove;
+	roc_bphy_npa_pf_func_get;
+	roc_bphy_sso_pf_func_get;
 	roc_clk_freq_get;
 	roc_cpt_afs_print;
 	roc_cpt_dev_clear;
Signature · 1 line
2.25.1
#4 lore raw

PATCH 3/3 raw/cnxk_bphy: support reading NPA/SSO PF function

In reply to Tomasz Duszynski

Add support for reading NPA/SSO pf_func which will be used by a PSM to access NPA/SSO. PSM is a hardware block capable of dispatching jobs to different blocks within a baseband module.

---
 drivers/raw/cnxk_bphy/cnxk_bphy.c    | 16 +++++++++
 drivers/raw/cnxk_bphy/rte_pmd_bphy.h | 50 ++++++++++++++++++++++++++++
 2 files changed, 66 insertions(+)
drivers/raw/cnxk_bphy/cnxk_bphy.c +16 -0
index 8a0d2224c0..8e7b714ba1 100644
@@ -67,6 +67,14 @@ bphy_rawdev_selftest(uint16_t dev_id)
 		goto err_desc;
 	}
 
+	ret = rte_pmd_bphy_npa_pf_func_get(dev_id);
+	if (ret == 0)
+		plt_warn("NPA pf_func is invalid");
+
+	ret = rte_pmd_bphy_sso_pf_func_get(dev_id);
+	if (ret == 0)
+		plt_warn("SSO pf_func is invalid");
+
 	ret = rte_pmd_bphy_intr_init(dev_id);
 	if (ret) {
 		plt_err("intr init failed");
@@ -190,6 +198,14 @@ cnxk_bphy_irq_enqueue_bufs(struct rte_rawdev *dev,
 	case CNXK_BPHY_IRQ_MSG_TYPE_MEM_GET:
 		bphy_dev->queues[queue].rsp = &bphy_dev->mem;
 		break;
+	case CNXK_BPHY_MSG_TYPE_NPA_PF_FUNC:
+		bphy_dev->queues[queue].rsp =
+			(void *)(size_t)roc_bphy_npa_pf_func_get();
+		break;
+	case CNXK_BPHY_MSG_TYPE_SSO_PF_FUNC:
+		bphy_dev->queues[queue].rsp =
+			(void *)(size_t)roc_bphy_sso_pf_func_get();
+		break;
 	default:
 		ret = -EINVAL;
 	}
drivers/raw/cnxk_bphy/rte_pmd_bphy.h +50 -0

60 lines not on this page · raw message

Signature · 1 line
2.25.1