Skip to contentSkip to conversation

tracepoint: Fix the comment style

PATCH In review zhaoxiao 2 participants 2 messages Aug 16, 2021 Tracing

lore
Share & tools
lore

zhaoxiao

author
#0 lore raw

PATCH 1/1 tracepoint: Fix the comment style

Fix function name in tracepoint.c kernel-doc comment to remove a warning found by clang_w1.

kernel/tracepoint.c:589: warning: expecting prototype for register_tracepoint_notifier(). Prototype was for register_tracepoint_module_notifier() instead kernel/tracepoint.c:613: warning: expecting prototype for unregister_tracepoint_notifier(). Prototype was for unregister_tracepoint_module_notifier() instead

---
 kernel/tracepoint.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/tracepoint.c +2 -2
index efd14c79fab4..64ea283f2f86 100644
@@ -577,7 +577,7 @@ bool trace_module_has_bad_taint(struct module *mod)
 static BLOCKING_NOTIFIER_HEAD(tracepoint_notify_list);
 
 /**
- * register_tracepoint_notifier - register tracepoint coming/going notifier
+ * register_tracepoint_module_notifier - register tracepoint coming/going notifier
  * @nb: notifier block
  *
  * Notifiers registered with this function are called on module
@@ -603,7 +603,7 @@ int register_tracepoint_module_notifier(struct notifier_block *nb)
 EXPORT_SYMBOL_GPL(register_tracepoint_module_notifier);
 
 /**
- * unregister_tracepoint_notifier - unregister tracepoint coming/going notifier
+ * unregister_tracepoint_module_notifier - unregister tracepoint coming/going notifier
  * @nb: notifier block
  *
  * The notifier block callback should expect a "struct tp_module" data
Signature · 1 line
2.20.1
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · ----- On Aug 16, 2021, at 1:24 AM, zhaoxiao [email protected] wrote:

Fix function name in tracepoint.c kernel-doc comment to remove a warning found by clang_w1.

kernel/tracepoint.c:589: warning: expecting prototype for register_tracepoint_notifier(). Prototype was for register_tracepoint_module_notifier() instead kernel/tracepoint.c:613: warning: expecting prototype for unregister_tracepoint_notifier(). Prototype was for unregister_tracepoint_module_notifier() instead

Thanks!

Quoted 33 lines

---
kernel/tracepoint.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
kernel/tracepoint.c +1 -1
index efd14c79fab4..64ea283f2f86 100644
@@ -577,7 +577,7 @@ bool trace_module_has_bad_taint(struct module *mod)
 static BLOCKING_NOTIFIER_HEAD(tracepoint_notify_list);
 
 /**
- * register_tracepoint_notifier - register tracepoint coming/going notifier
+ * register_tracepoint_module_notifier - register tracepoint coming/going

notifier
* @nb: notifier block
*
* Notifiers registered with this function are called on module

kernel/tracepoint.c +1 -1
@@ -603,7 +603,7 @@ int register_tracepoint_module_notifier(struct
 notifier_block *nb)
 EXPORT_SYMBOL_GPL(register_tracepoint_module_notifier);
 
 /**
- * unregister_tracepoint_notifier - unregister tracepoint coming/going notifier
+ * unregister_tracepoint_module_notifier - unregister tracepoint coming/going

notifier
* @nb: notifier block
*
* The notifier block callback should expect a "struct tp_module" data
--
2.20.1

Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com