drm/fb: Fix randconfig builds
Subsystems (2)
PATCH v2 1/1 drm/fb: Fix randconfig builds
From: Jackie Liu <[email protected]>
When CONFIG_DRM_FBDEV_EMULATION is compiled to y and CONFIG_FB is m, the compilation will fail. we need make that dependency explicit.
--- drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/Kconfig +1 -1
@@ -98,7 +98,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM - depends on FB + depends on FB && FB != m select DRM_KMS_HELPER select FB_CFB_FILLRECT select FB_CFB_COPYAREA
Signature · 1 line
2.25.1
Quoted 8 lines · Jackie Liu
From: Jackie Liu <[email protected]>
When
CONFIG_DRM_FBDEV_EMULATIONis compiled to y andCONFIG_FBis m, the compilation will fail. we need make that dependency explicit.Fixes f611b1e7624c ("drm: Avoid circular dependencies for CONFIG_FB")Reported-by k2ci <[email protected]>Signed-off-by Jackie Liu <[email protected]>
Why do you send this while the discussion is still ongoing?
Now this *requires* FB=y even if it *could* be FB=m when DRM_KMS_HELPER=m.
BR,
Jani.
Quoted 17 lines
--- drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/Kconfig +1
-1@@ -98,7 +98,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM - depends on FB + depends on FB && FB != m select DRM_KMS_HELPER select FB_CFB_FILLRECT select FB_CFB_COPYAREA
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Quoted 6 lines · Jani Nikula
Quoted 5 lines · Jackie Liu
From: Jackie Liu <[email protected]>
When
CONFIG_DRM_FBDEV_EMULATIONis compiled to y andCONFIG_FBis m, the compilation will fail. we need make that dependency explicit.
Quoted 8 lines
Quoted 3 lines
Fixes f611b1e7624c ("drm: Avoid circular dependencies for CONFIG_FB")Reported-by k2ci <[email protected]>Signed-off-by Jackie Liu <[email protected]>Why do you send this while the discussion is still ongoing?
Now this *requires* FB=y even if it *could* be FB=m when DRM_KMS_HELPER=m.
Yes, You are right.
BR, Jackie
Quoted 22 lines
BR,
Jani.Quoted 17 lines
--- drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/Kconfig +1
-1@@ -98,7 +98,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM - depends on FB + depends on FB && FB != m select DRM_KMS_HELPER select FB_CFB_FILLRECT select FB_CFB_COPYAREA