net/iavf: remove redundant default RSS field for IP fragment packets
PATCH 1/2 net/iavf: remove redundant default RSS field for IP fragment packets
This patch removes redundant default RSS field for IP fragment packets, only src MAC address and dst MAC address are needed.
--- drivers/net/iavf/iavf_hash.c | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-)
drivers/net/iavf/iavf_hash.c +2 -24
@@ -624,34 +624,12 @@ iavf_rss_hash_set(struct iavf_adapter *ad, uint64_t rss_hf, bool add) }if (rss_hf Ð_RSS_FRAG_IPV4 ) { -struct virtchnl_proto_hdrs hdr = { - .tunnel_level =TUNNEL_LEVEL_OUTER , - .count =3 , - .proto_hdr = { - proto_hdr_eth, - proto_hdr_ipv4, - { -VIRTCHNL_PROTO_HDR_IPV4_FRAG , -FIELD_SELECTOR (VIRTCHNL_PROTO_HDR_IPV4_FRAG_PKID ), - {BUFF_NOUSED }, - }, - }, - }; - rss_cfg.proto_hdrs = hdr; + rss_cfg.proto_hdrs = outer_ipv4_tmplt;iavf_add_del_rss_cfg (ad, &rss_cfg, add); }if (rss_hf Ð_RSS_FRAG_IPV6 ) { -struct virtchnl_proto_hdrs hdr = { - .tunnel_level =TUNNEL_LEVEL_OUTER , - .count =3 , - .proto_hdr = { - proto_hdr_eth, - proto_hdr_ipv6, - proto_hdr_ipv6_frag, - }, - }; - rss_cfg.proto_hdrs = hdr; + rss_cfg.proto_hdrs = outer_ipv6_tmplt;iavf_add_del_rss_cfg (ad, &rss_cfg, add); }
Signature · 1 line
2.25.1
Quoted 3 lines · Wenjun Wu
This patch removes redundant default RSS field for IP fragment packets, only src MAC address and dst MAC address are needed.
Hi Wenjun,
The impact is not clear, from the description I take this as code refactoring without any impact but can you please clarify this in the commit log?
Also patch title it too long, can we update as following:
net/iavf: fix default RSS field for IP fragment packets
If so can you please put the Fixes tag? This way patch can be backported too.
Quoted 47 lines
Signed-off-by Wenjun Wu <[email protected]>--- drivers/net/iavf/iavf_hash.c | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-)drivers/net/iavf/iavf_hash.c +2
-24@@ -624,34 +624,12 @@ iavf_rss_hash_set(struct iavf_adapter *ad, uint64_t rss_hf, bool add) }if (rss_hf Ð_RSS_FRAG_IPV4 ) { -struct virtchnl_proto_hdrs hdr = { - .tunnel_level =TUNNEL_LEVEL_OUTER , - .count =3 , - .proto_hdr = { - proto_hdr_eth, - proto_hdr_ipv4, - { -VIRTCHNL_PROTO_HDR_IPV4_FRAG , -FIELD_SELECTOR (VIRTCHNL_PROTO_HDR_IPV4_FRAG_PKID ), - {BUFF_NOUSED }, - }, - }, - }; - rss_cfg.proto_hdrs = hdr; + rss_cfg.proto_hdrs = outer_ipv4_tmplt;iavf_add_del_rss_cfg (ad, &rss_cfg, add); }if (rss_hf Ð_RSS_FRAG_IPV6 ) { -struct virtchnl_proto_hdrs hdr = { - .tunnel_level =TUNNEL_LEVEL_OUTER , - .count =3 , - .proto_hdr = { - proto_hdr_eth, - proto_hdr_ipv6, - proto_hdr_ipv6_frag, - }, - }; - rss_cfg.proto_hdrs = hdr; + rss_cfg.proto_hdrs = outer_ipv6_tmplt;iavf_add_del_rss_cfg (ad, &rss_cfg, add); }
Hi Ferruh,
This patch removes support of IPID for both IPv4 and IPv6 fragment packets, because it is not expected in default RSS. The impact is that IPID will not be used to calculate the hash value in default RSS for IP fragment packet. I will rework commit log and send v2 patch later.
Quoted 74 lines
-----Original Message-----
From: Yigit, Ferruh <[email protected]>
Sent: Friday, August 13, 2021 7:59 PM
To: Wu, Wenjun1 <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: Re: [dpdk-dev] [PATCH v1 1/2] net/iavf: remove redundant default RSS field for IP fragment packetsQuoted 3 lines · Wenjun Wu
This patch removes redundant default RSS field for IP fragment packets, only src MAC address and dst MAC address are needed.
Hi Wenjun,
The impact is not clear, from the description I take this as code refactoring without any impact but can you please clarify this in the commit log?
Also patch title it too long, can we update as following:
net/iavf: fix default RSS field for IP fragment packetsIf so can you please put the Fixes tag? This way patch can be backported too.
drivers/net/iavf/iavf_hash.c iavf_rss_hash_set(struct iavf_adapter *ad,
Quoted 10 lines
Signed-off-by Wenjun Wu <[email protected]>--- drivers/net/iavf/iavf_hash.c | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-)(quoted diff) +0
-0
b/drivers/net/iavf/iavf_hash.cindex2b03dad858..eba55ecea5100644drivers/net/iavf/iavf_hash.c +0
-0@@ -624,34 +624,12 @@ iavf_rss_hash_set(struct iavf_adapter *ad,
uint64_trss_hf, bool add)drivers/net/iavf/iavf_hash.c iavf_rss_hash_set(struct iavf_adapter *ad, uint64_t rss_hf, bool add)
Quoted 12 lines
drivers/net/iavf/iavf_hash.c +0
-9}if (rss_hf Ð_RSS_FRAG_IPV4 ) { -struct virtchnl_proto_hdrs hdr = { - .tunnel_level =TUNNEL_LEVEL_OUTER , - .count =3 , - .proto_hdr = { - proto_hdr_eth, - proto_hdr_ipv4, - { -VIRTCHNL_PROTO_HDR_IPV4_FRAG , -
FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_FRAG_PKID),Quoted 25 lines
drivers/net/iavf/iavf_hash.c +2
-15- {BUFF_NOUSED}, - }, - }, - }; - rss_cfg.proto_hdrs = hdr; + rss_cfg.proto_hdrs = outer_ipv4_tmplt;iavf_add_del_rss_cfg (ad, &rss_cfg, add); }if (rss_hf Ð_RSS_FRAG_IPV6 ) { -struct virtchnl_proto_hdrs hdr = { - .tunnel_level =TUNNEL_LEVEL_OUTER , - .count =3 , - .proto_hdr = { - proto_hdr_eth, - proto_hdr_ipv6, - proto_hdr_ipv6_frag, - }, - }; - rss_cfg.proto_hdrs = hdr; + rss_cfg.proto_hdrs = outer_ipv6_tmplt;iavf_add_del_rss_cfg (ad, &rss_cfg, add); }
PATCH v2 1/2 net/iavf: fix default RSS field for IP fragment packets
In reply to Wenjun WuPreviously IP ID field is supported in default RSS for IP fragment packets. Actually it is not expected.
This patch removes redundant default RSS field for IP fragment packets. The default RSS only needs to support the src and dst IP fields.
--- drivers/net/iavf/iavf_hash.c | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-)
drivers/net/iavf/iavf_hash.c +2 -24
@@ -624,34 +624,12 @@ iavf_rss_hash_set(struct iavf_adapter *ad, uint64_t rss_hf, bool add) }if (rss_hf Ð_RSS_FRAG_IPV4 ) { -struct virtchnl_proto_hdrs hdr = { - .tunnel_level =TUNNEL_LEVEL_OUTER , - .count =3 , - .proto_hdr = { - proto_hdr_eth, - proto_hdr_ipv4, - { -VIRTCHNL_PROTO_HDR_IPV4_FRAG , -FIELD_SELECTOR (VIRTCHNL_PROTO_HDR_IPV4_FRAG_PKID ), - {BUFF_NOUSED }, - }, - }, - }; - rss_cfg.proto_hdrs = hdr; + rss_cfg.proto_hdrs = outer_ipv4_tmplt;iavf_add_del_rss_cfg (ad, &rss_cfg, add); }if (rss_hf Ð_RSS_FRAG_IPV6 ) { -struct virtchnl_proto_hdrs hdr = { - .tunnel_level =TUNNEL_LEVEL_OUTER , - .count =3 , - .proto_hdr = { - proto_hdr_eth, - proto_hdr_ipv6, - proto_hdr_ipv6_frag, - }, - }; - rss_cfg.proto_hdrs = hdr; + rss_cfg.proto_hdrs = outer_ipv6_tmplt;iavf_add_del_rss_cfg (ad, &rss_cfg, add); }
Signature · 1 line
2.25.1
v3 cover fix default RSS field for IP fragment packets
This patch set removes redundant default RSS field for both IPv4 and IPv6 fragment packets. Only src and dst address are needed.
v3:
* Rework commit log
v2:
* Rework commit log
Wenjun Wu (2):
net/iavf: fix default RSS field for IP fragment packets net/ice: fix default RSS field for IP fragment packets
drivers/net/iavf/iavf_hash.c | 26 ++------------------------ drivers/net/ice/ice_ethdev.c | 4 ++-- 2 files changed, 4 insertions(+), 26 deletions(-)
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v3 0/2] fix default RSS field for IP fragment packets
Quoted 21 lines
-----Original Message-----
From: Wu, Wenjun1 <[email protected]>
Sent: Tuesday, August 17, 2021 4:43 PM
To: [email protected]; Zhang, Qi Z <[email protected]>
Cc: Wu, Wenjun1 <[email protected]>
Subject: [PATCH v3 0/2] fix default RSS field for IP fragment packetsThis patch set removes redundant default RSS field for both IPv4 and IPv6 fragment packets. Only src and dst address are needed.
v3:
* Rework commit log
v2:
* Rework commit logWenjun Wu (2):
net/iavf: fix default RSS field for IP fragment packets net/ice: fix default RSS field for IP fragment packets
Quoted 6 lines
drivers/net/iavf/iavf_hash.c | 26 ++------------------------ drivers/net/ice/ice_ethdev.c | 4 ++-- 2 files changed, 4 insertions(+), 26 deletions(-)--
2.25.1
Applied to dpdk-next-net-intel.
Thanks
Qi
PATCH v3 1/2 net/iavf: fix default RSS field for IP fragment packets
In reply to Wenjun WuPreviously, hash value is calculated by src IP address, dst IP address and IP ID. However, default RSS field only needs src and dst IP address.
This patch removes IP ID from default RSS field for IP fragment packets to improve default RSS configuration.
--- drivers/net/iavf/iavf_hash.c | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-)
drivers/net/iavf/iavf_hash.c +2 -24
@@ -624,34 +624,12 @@ iavf_rss_hash_set(struct iavf_adapter *ad, uint64_t rss_hf, bool add) }if (rss_hf Ð_RSS_FRAG_IPV4 ) { -struct virtchnl_proto_hdrs hdr = { - .tunnel_level =TUNNEL_LEVEL_OUTER , - .count =3 , - .proto_hdr = { - proto_hdr_eth, - proto_hdr_ipv4, - { -VIRTCHNL_PROTO_HDR_IPV4_FRAG , -FIELD_SELECTOR (VIRTCHNL_PROTO_HDR_IPV4_FRAG_PKID ), - {BUFF_NOUSED }, - }, - }, - }; - rss_cfg.proto_hdrs = hdr; + rss_cfg.proto_hdrs = outer_ipv4_tmplt;iavf_add_del_rss_cfg (ad, &rss_cfg, add); }if (rss_hf Ð_RSS_FRAG_IPV6 ) { -struct virtchnl_proto_hdrs hdr = { - .tunnel_level =TUNNEL_LEVEL_OUTER , - .count =3 , - .proto_hdr = { - proto_hdr_eth, - proto_hdr_ipv6, - proto_hdr_ipv6_frag, - }, - }; - rss_cfg.proto_hdrs = hdr; + rss_cfg.proto_hdrs = outer_ipv6_tmplt;iavf_add_del_rss_cfg (ad, &rss_cfg, add); }
Signature · 1 line
2.25.1