Skip to contentSkip to conversation

remove pointless constructor

PATCH New Rosen Penev 1 participant 1 message Aug 17, 2021 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove pointless constructor

The members can be initialized directly, allowing to remove the onstructor.

---
 utils/v4l2-compliance/v4l2-test-buffers.cpp | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
utils/v4l2-compliance/v4l2-test-buffers.cpp +2 -4
index a005fde61..2f01ed8f3 100644
@@ -2453,8 +2453,6 @@ int testRequests(struct node *node, bool test_streaming)
 class BlockingThread
 {
 public:
-	BlockingThread() : done(false), running(false) {}
-
 	virtual ~BlockingThread()
 	{
 		stop();
@@ -2497,7 +2495,7 @@ public:
 		running = false;
 	}
 
-	std::atomic<bool> done;
+	std::atomic<bool> done{};
 
 private:
 	static void *startRoutine(void *arg)
@@ -2516,7 +2514,7 @@ private:
 	virtual void run() = 0;
 
 	pthread_t thread;
-	std::atomic<bool> running;
+	std::atomic<bool> running{};
 };
 
 class DqbufThread : public BlockingThread
Signature · 1 line
2.31.1