media: usb: tm6000:clear the freed pointer
PATCH 1/1 media: usb: tm6000:clear the freed pointer
After free the ir->int_urb, the pointer need to
be set to NULL.
Signed-off-by Nil Yi <[email protected]>
--- drivers/media/usb/tm6000/tm6000-input.c | 1 + 1 file changed, 1 insertion(+)
drivers/media/usb/tm6000/tm6000-input.c +1 -0
@@ -346,6 +346,7 @@ static int __tm6000_ir_int_start(struct rc_dev *rc) ir->int_urb->transfer_buffer =kzalloc (size,GFP_ATOMIC );if (!ir->int_urb->transfer_buffer) {usb_free_urb (ir->int_urb); + ir->int_urb =NULL ;return err; }dprintk (1 ,"int interval: %d\n" , dev->int_in.endp->desc.bInterval);
Signature · 1 line
2.17.1
Quoted 2 lines · Nil Yi
After free the
ir->int_urb, the pointer need to
be set to NULL.
Again, in the commit message please explain what code path will lead to 😱.
Thanks,
Sean
Quoted 21 lines
Signed-off-by Nil Yi <[email protected]>--- drivers/media/usb/tm6000/tm6000-input.c | 1 + 1 file changed, 1 insertion(+)drivers/media/usb/tm6000/tm6000-input.c +1
-0@@ -346,6 +346,7 @@ static int __tm6000_ir_int_start(struct rc_dev *rc) ir->int_urb->transfer_buffer =kzalloc (size,GFP_ATOMIC );if (!ir->int_urb->transfer_buffer) {usb_free_urb (ir->int_urb); + ir->int_urb =NULL ;return err; }dprintk (1 ,"int interval: %d\n" , dev->int_in.endp->desc.bInterval);Signature · 1 line
2.17.1