qapi/machine.json: Remove zero value reference from SMPConfiguration documentation
PATCH 1/1 qapi/machine.json: Remove zero value reference from SMPConfiguration documentation
Commit 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse") introduced documentation stating that a zero input value for an SMP parameter indicates that its value should be automatically configured. This is indeed how things work today, but we'd like to change that. Avoid documenting behaviors we want to leave undefined for the time being, giving us freedom to change it later.
--- qapi/machine.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
qapi/machine.json +1 -1
@@ -1288,7 +1288,7 @@ ## # @SMPConfiguration: # -# Schema for CPU topology configuration. "0" or a missing value lets +# Schema for CPU topology configuration. A missing value lets # QEMU figure out a suitable value based on the ones that are provided. # # @cpus: number of virtual CPUs in the virtual machine
Signature · 1 line
2.31.1
Quoted 18 lines · Andrew Jones
Commit
1e63fe685804("machine: pass QAPI struct tomc->smp_parse") introduced documentation stating that a zero input value for an SMP parameter indicates that its value should be automatically configured. This is indeed how things work today, but we'd like to change that. Avoid documenting behaviors we want to leave undefined for the time being, giving us freedom to change it later.Fixes 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")Signed-off-by Andrew Jones <[email protected]>--- qapi/machine.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)qapi/machine.json +0
-0
qapi/machine.json line 1294
Quoted 8 lines
qapi/machine.json +1
-1@@ -1288,7 +1288,7 @@ ## # @SMPConfiguration: # -# Schema for CPU topology configuration. "0" or a missing value lets +# Schema for CPU topology configuration. A missing value lets # QEMU figure out a suitable value based on the ones that are provided. # # @cpus: number of virtual CPUs in the virtual machine
.
Quoted 19 lines · Andrew Jones
Commit
1e63fe685804("machine: pass QAPI struct tomc->smp_parse") introduced documentation stating that a zero input value for an SMP parameter indicates that its value should be automatically configured. This is indeed how things work today, but we'd like to change that. Avoid documenting behaviors we want to leave undefined for the time being, giving us freedom to change it later.Fixes 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")Signed-off-by Andrew Jones <[email protected]>--- qapi/machine.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)qapi/machine.json +0
-0
qapi/machine.json line 1294
Quoted 8 lines
qapi/machine.json +1
-1@@ -1288,7 +1288,7 @@ ## # @SMPConfiguration: # -# Schema for CPU topology configuration. "0" or a missing value lets +# Schema for CPU topology configuration. A missing value lets # QEMU figure out a suitable value based on the ones that are provided. # # @cpus: number of virtual CPUs in the virtual machine
Quoted 7 lines · Andrew Jones
Commit
1e63fe685804("machine: pass QAPI struct tomc->smp_parse") introduced documentation stating that a zero input value for an SMP parameter indicates that its value should be automatically configured. This is indeed how things work today, but we'd like to change that. Avoid documenting behaviors we want to leave undefined for the time being, giving us freedom to change it later.
Quoted 5 lines
Fixes 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")Signed-off-by Andrew Jones <[email protected]>--- qapi/machine.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 19 lines · Andrew Jones
Commit
1e63fe685804("machine: pass QAPI struct tomc->smp_parse") introduced documentation stating that a zero input value for an SMP parameter indicates that its value should be automatically configured. This is indeed how things work today, but we'd like to change that. Avoid documenting behaviors we want to leave undefined for the time being, giving us freedom to change it later.Fixes 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")Signed-off-by Andrew Jones <[email protected]>--- qapi/machine.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)qapi/machine.json +0
-0
qapi/machine.json line 1294
Quoted 8 lines
qapi/machine.json +1
-1@@ -1288,7 +1288,7 @@ ## # @SMPConfiguration: # -# Schema for CPU topology configuration. "0" or a missing value lets +# Schema for CPU topology configuration. A missing value lets # QEMU figure out a suitable value based on the ones that are provided. # # @cpus: number of virtual CPUs in the virtual machine
Peter Maydell
AppliedQuoted 8 lines · Andrew Jones
Commit
1e63fe685804("machine: pass QAPI struct tomc->smp_parse") introduced documentation stating that a zero input value for an SMP parameter indicates that its value should be automatically configured. This is indeed how things work today, but we'd like to change that. Avoid documenting behaviors we want to leave undefined for the time being, giving us freedom to change it later.
Quoted 5 lines
Fixes 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")Signed-off-by Andrew Jones <[email protected]>--- qapi/machine.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1
for any user-visible changes.
-- PMM