Skip to contentSkip to conversation

input/gscps2: Prefer strscpy over strlcpy

PATCH New Len Baker 1 participant 1 message Aug 17, 2021

Subsystems (3)
lore
Share & tools
lore

Len Baker

author
#0 lore raw

PATCH 1/1 input/gscps2: Prefer strscpy over strlcpy

strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated. The safe replacement is strscpy().

This is a previous step in the path to remove the strlcpy() function entirely from the kernel [1].

[1] https://github.com/KSPP/linux/issues/89

---
 drivers/input/serio/gscps2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/serio/gscps2.c +1 -1
index 2f9775de3c5b..cae74d0edb09 100644
@@ -357,7 +357,7 @@ static int __init gscps2_probe(struct parisc_device *dev)
 
 	snprintf(serio->name, sizeof(serio->name), "gsc-ps2-%s",
 		 (ps2port->id == GSC_ID_KEYBOARD) ? "keyboard" : "mouse");
-	strlcpy(serio->phys, dev_name(&dev->dev), sizeof(serio->phys));
+	strscpy(serio->phys, dev_name(&dev->dev), sizeof(serio->phys));
 	serio->id.type		= SERIO_8042;
 	serio->write		= gscps2_write;
 	serio->open		= gscps2_open;

--
2.25.1