ideapad-laptop: Fix Legion 5 Fn lock LED
PATCH 1/1 ideapad-laptop: Fix Legion 5 Fn lock LED
This patch fixes the bug 212671.
Althrough the Fn lock (Fn + Esc) works on Legion 5 (R7000P), its LED light does not change with the state. This modification sets the Fn lock state to its current value on receiving the wmi event 8FC0DE0C-B4E4-43FD-B0F3-8871711C1294 to update the LED state.
---
Another possible approach is to call ideapad_input_report(priv, value) to send a keycode and let the user handle the LED by echoing the current value of /sys/bus/platform/drivers/ideapad_acpi/VPC2004:00/fn_lock back into itself. But the problem with this approach is Fn+F9 and Fn+Esc trigger the same WMI GUID and event value and I have no idea how to distinguish them.
drivers/platform/x86/ideapad-laptop.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/platform/x86/ideapad-laptop.c +10 -0
@@ -41,6 +41,7 @@static const char *const ideapad_wmi_fnesc_events[] = {"26CAB2E5-5CF1-46AE-AAC3-4A12B6BA50E6" ,/* Yoga 3 */ "56322276-8493-4CE8-A783-98C991274F5E" ,/* Yoga 700 */ +"8FC0DE0C-B4E4-43FD-B0F3-8871711C1294" ,/* Legion 5 */ };#endif
@@ -1464,6 +1465,15 @@ static void ideapad_wmi_notify(u32 value, void *context)case 128 :ideapad_input_report (priv, value);break ; +case 208 : +unsigned long result; + +if (!eval_hals (priv->adev->handle, &result)) { +bool state =test_bit (HALS_FNLOCK_STATE_BIT , &result); + +exec_sals (priv->adev->handle, state ?SALS_FNLOCK_ON :SALS_FNLOCK_OFF ); + } +break ;default :dev_info (&priv->platform_device->dev,"Unknown WMI event: %u\n" , value);
Signature · 1 line
2.32.0
Hi,
Quoted 7 lines · Meng Dong
This patch fixes the bug 212671.
Althrough the Fn lock (Fn + Esc) works on Legion 5 (R7000P), its LED light does not change with the state. This modification sets the Fn lock state to its current value on receiving the wmi event 8FC0DE0C-B4E4-43FD-B0F3-8871711C1294 to update the LED state.Signed-off-by Meng Dong <[email protected]>
Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.
Regards,
Hans
Quoted 40 lines
---
Another possible approach is to callideapad_input_report(priv, value)to send a keycode and let the user handle the LED by echoing the current value of /sys/bus/platform/drivers/ideapad_acpi/VPC2004:00/fn_lock back into itself. But the problem with this approach is Fn+F9 and Fn+Esc trigger the same WMI GUID and event value and I have no idea how to distinguish them.drivers/platform/x86/ideapad-laptop.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/platform/x86/ideapad-laptop.c +10
-0@@ -41,6 +41,7 @@static const char *const ideapad_wmi_fnesc_events[] = {"26CAB2E5-5CF1-46AE-AAC3-4A12B6BA50E6" ,/* Yoga 3 */ "56322276-8493-4CE8-A783-98C991274F5E" ,/* Yoga 700 */ +"8FC0DE0C-B4E4-43FD-B0F3-8871711C1294" ,/* Legion 5 */ };#endif @@ -1464,6 +1465,15 @@ static void ideapad_wmi_notify(u32 value, void *context)case 128 :ideapad_input_report (priv, value);break ; +case 208 : +unsigned long result; + +if (!eval_hals (priv->adev->handle, &result)) { +bool state =test_bit (HALS_FNLOCK_STATE_BIT , &result); + +exec_sals (priv->adev->handle, state ?SALS_FNLOCK_ON :SALS_FNLOCK_OFF ); + } +break ;default :dev_info (&priv->platform_device->dev,"Unknown WMI event: %u\n" , value);