Skip to contentSkip to conversation

Kconfig symbol clean-up on usb

PATCH In review Lukas Bulwahn 2 participants 5 messages Aug 18, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover Kconfig symbol clean-up on usb

Dear Greg,

The script ./scripts/checkkconfigsymbols.py warns on invalid references to Kconfig symbols (often, minor typos, name confusions or outdated references).

This patch series addresses all issues reported by ./scripts/checkkconfigsymbols.py in ./drivers/usb/ for Kconfig and Makefile files. Issues in the Kconfig and Makefile files indicate some shortcomings in the overall build definitions, and often are true actionable issues to address.

These issues can be identified and filtered by:

./scripts/checkkconfigsymbols.py | grep -E "drivers/usb/.*(Kconfig|Makefile)" -B 1 -A 1

After applying this patch series on linux-next (next-20210816), the command above yields just one further issues to address:

ARCH_VERSAL
Referencing files: drivers/usb/dwc3/Kconfig

For this remaining issue, I already contacted Manish Narani, the contributor of ./drivers/usb/dwc3/, to clarify the intent of that config dependency.

Please pick this patch series into your usb-next tree.

Best regards,

Lukas

Lukas Bulwahn (3):
usb: host: remove dead EHCI support for on-chip PMC MSP71xx USB
controller
usb: host: remove line for obsolete config USB_HWA_HCD
usb: remove reference to deleted config STB03xxx

 drivers/usb/Kconfig            |   2 +-
 drivers/usb/Makefile           |   1 -
 drivers/usb/host/Kconfig       |   9 -
 drivers/usb/host/ehci-hcd.c    |   5 -
 drivers/usb/host/ehci-pmcmsp.c | 328 ---------------------------------
 5 files changed, 1 insertion(+), 344 deletions(-)
 delete mode 100644 drivers/usb/host/ehci-pmcmsp.c
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/3 usb: host: remove dead EHCI support for on-chip PMC MSP71xx USB controller

Commit 1b00767fd8e1 ("MIPS: Remove PMC MSP71xx platform") deletes ./arch/mips/pmcs-msp71xx/Kconfig, including its config MSP_HAS_USB.

Hence, since then, the corresponding EHCI support for on-chip PMC MSP71xx USB controller is dead code. Remove this dead driver.

---
 drivers/usb/host/Kconfig       |   9 -
 drivers/usb/host/ehci-hcd.c    |   5 -
 drivers/usb/host/ehci-pmcmsp.c | 328 ---------------------------------
 3 files changed, 342 deletions(-)
 delete mode 100644 drivers/usb/host/ehci-pmcmsp.c
drivers/usb/host/Kconfig +0 -9
index df9428f1dc5e..c4736d1d020c 100644
@@ -187,15 +187,6 @@ config USB_EHCI_PCI
 	depends on USB_PCI
 	default y
 
-config USB_EHCI_HCD_PMC_MSP
-	tristate "EHCI support for on-chip PMC MSP71xx USB controller"
-	depends on MSP_HAS_USB
-	select USB_EHCI_BIG_ENDIAN_DESC
-	select USB_EHCI_BIG_ENDIAN_MMIO
-	help
-		Enables support for the onchip USB controller on the PMC_MSP7100 Family SoC's.
-		If unsure, say N.
-
 config XPS_USB_HCD_XILINX
 	bool "Use Xilinx usb host EHCI controller core"
 	depends on (PPC32 || MICROBLAZE)
drivers/usb/host/ehci-hcd.c +0 -5
index 10b0365f3439..6bdc6d6bf74d 100644
@@ -1296,11 +1296,6 @@ MODULE_LICENSE ("GPL");
 #define XILINX_OF_PLATFORM_DRIVER	ehci_hcd_xilinx_of_driver
 #endif
 
-#ifdef CONFIG_USB_EHCI_HCD_PMC_MSP
-#include "ehci-pmcmsp.c"
-#define	PLATFORM_DRIVER		ehci_hcd_msp_driver
-#endif
-
 #ifdef CONFIG_SPARC_LEON
 #include "ehci-grlib.c"
 #define PLATFORM_DRIVER		ehci_grlib_driver
drivers/usb/host/ehci-pmcmsp.c deleted +0 -328

328 lines not on this page · raw message

Signature · 1 line
2.26.2
maintainer Acked-by on v1 1/3
#2 lore raw

Re: [PATCH 1/3] usb: host: remove dead EHCI support for on-chip PMC MSP71xx USB controller

Quoted 8 lines · Lukas Bulwahn

Commit 1b00767fd8e1 ("MIPS: Remove PMC MSP71xx platform") deletes ./arch/mips/pmcs-msp71xx/Kconfig, including its config MSP_HAS_USB.

Hence, since then, the corresponding EHCI support for on-chip PMC MSP71xx USB controller is dead code. Remove this dead driver.

---

#3 lore raw

PATCH 2/3 usb: host: remove line for obsolete config USB_HWA_HCD

In reply to Lukas Bulwahn

Commit 71ed79b0e4be ("USB: Move wusbcore and UWB to staging as it is obsolete") misses to adjust some part in ./drivers/usb/host/Makefile.

Hence, ./scripts/checkkconfigsymbols.py warns:

USB_HWA_HCD
Referencing files: drivers/usb/Makefile

Remove the missing piece of this code removal.

---
 drivers/usb/Makefile | 1 -
 1 file changed, 1 deletion(-)
drivers/usb/Makefile +0 -1
index 3e2cc95b7b0b..643edf5fe18c 100644
@@ -31,7 +31,6 @@ obj-$(CONFIG_USB_SL811_HCD)	+= host/
 obj-$(CONFIG_USB_ISP1362_HCD)	+= host/
 obj-$(CONFIG_USB_U132_HCD)	+= host/
 obj-$(CONFIG_USB_R8A66597_HCD)	+= host/
-obj-$(CONFIG_USB_HWA_HCD)	+= host/
 obj-$(CONFIG_USB_FSL_USB2)	+= host/
 obj-$(CONFIG_USB_FOTG210_HCD)	+= host/
 obj-$(CONFIG_USB_MAX3421_HCD)	+= host/
Signature · 1 line
2.26.2
#4 lore raw

PATCH 3/3 usb: remove reference to deleted config STB03xxx

In reply to Lukas Bulwahn

Commit 7583b63c343c ("powerpc/40x: Remove STB03xxx") removes the config STB03xxx, but left a reference in ./drivers/usb/Kconfig behind.

Hence, ./scripts/checkkconfigsymbols.py warns:

STB03xxx
Referencing files: drivers/usb/Kconfig

Remove this reference to the deleted config.

---
 drivers/usb/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/Kconfig +1 -1
index 26475b409b53..578a439e71b5 100644
@@ -11,7 +11,7 @@ config USB_OHCI_BIG_ENDIAN_MMIO
 
 config USB_OHCI_LITTLE_ENDIAN
 	bool
-	default n if STB03xxx || PPC_MPC52xx
+	default n if PPC_MPC52xx
 	default y
 
 config USB_EHCI_BIG_ENDIAN_MMIO
Signature · 1 line
2.26.2