i40e: 16BYTE_RX_DESC build broken on FreeBSD-13
https://bugs.dpdk.org/show_bug.cgi?id=788
Bug ID: 788
Summary: i40e: 16BYTE_RX_DESC build broken on FreeBSD-13
Product: DPDK
Version: 21.08
Hardware: x86
OS: FreeBSD
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: [email protected]
Reporter: [email protected]Target Milestone: ---
Hello,
I just tried compiling DPDK 21.08 and found my configuration no longer builds on FreeBSD-13.0. With version 21.05, I defined RTE_LIBRTE_I40E_16BYTE_RX_DESC in rte_config.h as described in section "Use 16 Bytes RX Descriptor Size" of the current i40e PMD documentation. I also defined a similar variable RTE_LIBRTE_ICE_16BYTE_RX_DESC in rte_config.h for the ice PMD.
This morning I brought in version 21.08 and watched it compile on FreeBSD-12.2 (clang version 10.0.1) running on an 'Intel(R) Xeon(R) CPU E5-2637 v3'. Then I tried building it on FreeBSD-13.0 (clang version 11.0.1) on a 'AMD Ryzen Threadripper 3990X 64-Core Processor' but the build died with a number of compilation errors related to avx512f features enabled in functions compiled without support for avx512f.
Below I have an edited build log from the FreeBSD-12.2 system that works followed by the log from the FreeBSD-13.0 system that fails. Looking at the 12.2 log, there is a warning “Binutils error with AVX512 assembly, disabling AVX512 support” that might be hiding this issue? Neither system has hardware support for AVX-512 but it appears that the compiler does. Thank you for your help!
*** FreeBSD-12.2 build that works ***
The Meson build system
Version: 0.58.1
Build type: native build
Program cat found: YES (/bin/cat)
Project name: DPDK
Project version: 21.08.0
C compiler for the host machine: cc (clang 10.0.1 "FreeBSD clang version 10.0.1 ([email protected]:llvm/llvm-project.git llvmorg-10.0.1-0-gef32c611aa2)") C linker for the host machine: cc ld.lld 10.0.1
Host machine cpu family: x86_64
Host machine cpu: x86_64
Compiler for C supports arguments -mno-avx512f: YES config/x86/meson.build:9: WARNING: Binutils error with AVX512 assembly, disabling AVX512 support
Compiler for C supports arguments -mavx512f: YES
Checking if "AVX512 checking" compiles: YES
Fetching value of define "__SSE4_2__" : 1
Fetching value of define "__AES__" : 1
Fetching value of define "__AVX__" : 1
Fetching value of define "__AVX2__" : 1
Fetching value of define "__AVX512BW__" :
Fetching value of define "__AVX512CD__" :
Fetching value of define "__AVX512DQ__" :
Fetching value of define "__AVX512F__" :
Fetching value of define "__AVX512VL__" :
Fetching value of define "__PCLMUL__" : 1
Fetching value of define "__RDRND__" : 1
Fetching value of define "__RDSEED__" :
Fetching value of define "__VPCLMULQDQ__" :
Compiler for C supports arguments -mpclmul: YES
Compiler for C supports arguments -maes: YES
*** FreeBSD-13.0 system that does not build ***
The Meson build system
Version: 0.58.1
Build type: native build
Program cat found: YES (/bin/cat)
Project name: DPDK
Project version: 21.08.0
C compiler for the host machine: cc (clang 11.0.1 "FreeBSD clang version 11.0.1 ([email protected]:llvm/llvm-project.git llvmorg-11.0.1-0-g43ff75f2c3fe)") C linker for the host machine: cc ld.lld 11.0.1
Host machine cpu family: x86_64
Host machine cpu: x86_64
Compiler for C supports arguments -mavx512f: YES
Checking if "AVX512 checking" compiles: YES
Fetching value of define "__SSE4_2__" : 1
Fetching value of define "__AES__" : 1
Fetching value of define "__AVX__" : 1
Fetching value of define "__AVX2__" : 1
Fetching value of define "__AVX512BW__" :
Fetching value of define "__AVX512CD__" :
Fetching value of define "__AVX512DQ__" :
Fetching value of define "__AVX512F__" :
Fetching value of define "__AVX512VL__" :
Fetching value of define "__PCLMUL__" : 1
Fetching value of define "__RDRND__" : 1
Fetching value of define "__RDSEED__" : 1
Fetching value of define "__VPCLMULQDQ__" :
Compiler for C supports arguments -mpclmul: YES Compiler for C supports arguments -maes: YES Compiler for C supports arguments -mavx512f: YES (cached) Compiler for C supports arguments -mavx512bw: YES Compiler for C supports arguments -mavx512dq: YES Compiler for C supports arguments -mavx512vl: YES Compiler for C supports arguments -mvpclmulqdq: YES Compiler for C supports arguments -mavx2: YES Compiler for C supports arguments -mavx: YES
Compiler for C supports arguments -mavx512f -mavx512vl -mavx512cd -mavx512bw:
YES
Compiler for C supports arguments -mavx512f -mavx512dq: YES
FAILED: drivers/libtmp_rte_net_i40e.a.p/net_i40e_i40e_rxtx_vec_avx2.c.o cc -Idrivers/libtmp_rte_net_i40e.a.p -Idrivers -I../drivers -Idrivers/net/i40e -I../drivers/net/i40e -Idrivers/net/i40e/base -I../drivers/net/i40e/base -Ilib/ethdev -I../lib/ethdev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/freebsd/include -I../lib/eal/freebsd/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/bsd -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -Ilib/hash -I../lib/hash -Ilib/rcu -I../lib/rcu -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3 -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-missing-field-initializers -D_GNU_SOURCE -D__BSD_VISIBLE -fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -DPF_DRIVER -DVF_DRIVER -DINTEGRATED_VF -DX722_A0_SUPPORT -DCC_AVX2_SUPPORT -DCC_AVX512_SUPPORT -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.i40e -MD -MQ drivers/libtmp_rte_net_i40e.a.p/net_i40e_i40e_rxtx_vec_avx2.c.o -MF drivers/libtmp_rte_net_i40e.a.p/net_i40e_i40e_rxtx_vec_avx2.c.o.d -o drivers/libtmp_rte_net_i40e.a.p/net_i40e_i40e_rxtx_vec_avx2.c.o -c ../drivers/net/i40e/i40e_rxtx_vec_avx2.c
In file included from ../drivers/net/i40e/i40e_rxtx_vec_avx2.c:13:../drivers/net/i40e/i40e_rxtx_vec_common.h:337:22: error: always_inline function '_mm512_set1_epi64' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
__m512i hdr_room = _mm512_set1_epi64(RTE_PKTMBUF_HEADROOM);
^../drivers/net/i40e/i40e_rxtx_vec_common.h:337:22: error: AVX vector return of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/i40e/i40e_rxtx_vec_common.h:385:5: error:
'__builtin_ia32_inserti64x4' needs target feature avx512f
_mm512_inserti64x4(_mm512_castsi256_si512(vaddr0_1),
^
/usr/lib/clang/11.0.1/include/avx512fintrin.h:7413:12: note: expanded from
macro '_mm512_inserti64x4'
(__m512i)__builtin_ia32_inserti64x4((__v8di)(__m512i)(A), \
^In file included from ../drivers/net/i40e/i40e_rxtx_vec_avx2.c:13:../drivers/net/i40e/i40e_rxtx_vec_common.h:385:24: error: always_inline function '_mm512_castsi256_si512' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
_mm512_inserti64x4(_mm512_castsi256_si512(vaddr0_1),
^
../drivers/net/i40e/i40e_rxtx_vec_common.h:385:24: error: AVX vector return of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/i40e/i40e_rxtx_vec_common.h:388:5: error:
'__builtin_ia32_inserti64x4' needs target feature avx512f
_mm512_inserti64x4(_mm512_castsi256_si512(vaddr4_5),
^
/usr/lib/clang/11.0.1/include/avx512fintrin.h:7413:12: note: expanded from
macro '_mm512_inserti64x4'
(__m512i)__builtin_ia32_inserti64x4((__v8di)(__m512i)(A), \
^In file included from ../drivers/net/i40e/i40e_rxtx_vec_avx2.c:13:../drivers/net/i40e/i40e_rxtx_vec_common.h:388:24: error: always_inline function '_mm512_castsi256_si512' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
_mm512_inserti64x4(_mm512_castsi256_si512(vaddr4_5),
^
../drivers/net/i40e/i40e_rxtx_vec_common.h:388:24: error: AVX vector return of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI ../drivers/net/i40e/i40e_rxtx_vec_common.h:392:18: error: always_inline function '_mm512_unpackhi_epi64' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
dma_addr0_3 = _mm512_unpackhi_epi64(vaddr0_3,
vaddr0_3);
^../drivers/net/i40e/i40e_rxtx_vec_common.h:392:18: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI ../drivers/net/i40e/i40e_rxtx_vec_common.h:393:18: error: always_inline function '_mm512_unpackhi_epi64' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
dma_addr4_7 = _mm512_unpackhi_epi64(vaddr4_7,
vaddr4_7);
^../drivers/net/i40e/i40e_rxtx_vec_common.h:393:18: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI ../drivers/net/i40e/i40e_rxtx_vec_common.h:396:18: error: always_inline function '_mm512_add_epi64' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
dma_addr0_3 = _mm512_add_epi64(dma_addr0_3, hdr_room);
^../drivers/net/i40e/i40e_rxtx_vec_common.h:396:18: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI ../drivers/net/i40e/i40e_rxtx_vec_common.h:397:18: error: always_inline function '_mm512_add_epi64' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
dma_addr4_7 = _mm512_add_epi64(dma_addr4_7, hdr_room);
^../drivers/net/i40e/i40e_rxtx_vec_common.h:397:18: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/i40e/i40e_rxtx_vec_common.h:400:4: error: always_inline function '_mm512_store_si512' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
_mm512_store_si512((__m512i *)&rxdp->read,
dma_addr0_3);
^../drivers/net/i40e/i40e_rxtx_vec_common.h:400:4: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/i40e/i40e_rxtx_vec_common.h:401:4: error: always_inline function '_mm512_store_si512' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
_mm512_store_si512((__m512i *)&(rxdp + 4)->read,
dma_addr4_7);
^fatal error: too many errors emitted, stopping now [-ferror-limit=] 20 errors generated.
[971/1893] Compiling C object drivers/libtmp_rte_net_ice.a.p/net_ice_ice_rxtx_vec_avx2.c.o
FAILED: drivers/libtmp_rte_net_ice.a.p/net_ice_ice_rxtx_vec_avx2.c.o cc -Idrivers/libtmp_rte_net_ice.a.p -Idrivers -I../drivers -Idrivers/net/ice -I../drivers/net/ice -Idrivers/net/ice/base -I../drivers/net/ice/base -Idrivers/common/iavf -I../drivers/common/iavf -Ilib/ethdev -I../lib/ethdev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/freebsd/include -I../lib/eal/freebsd/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/bsd -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -Ilib/hash -I../lib/hash -Ilib/rcu -I../lib/rcu -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3 -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-missing-field-initializers -D_GNU_SOURCE -D__BSD_VISIBLE -fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -DCC_AVX2_SUPPORT -DCC_AVX512_SUPPORT -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.ice -MD -MQ drivers/libtmp_rte_net_ice.a.p/net_ice_ice_rxtx_vec_avx2.c.o -MF drivers/libtmp_rte_net_ice.a.p/net_ice_ice_rxtx_vec_avx2.c.o.d -o drivers/libtmp_rte_net_ice.a.p/net_ice_ice_rxtx_vec_avx2.c.o -c ../drivers/net/ice/ice_rxtx_vec_avx2.c
In file included from ../drivers/net/ice/ice_rxtx_vec_avx2.c:5:../drivers/net/ice/ice_rxtx_vec_common.h:422:22: error: always_inline function '_mm512_set1_epi64' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
__m512i hdr_room = _mm512_set1_epi64(RTE_PKTMBUF_HEADROOM);
^../drivers/net/ice/ice_rxtx_vec_common.h:422:22: error: AVX vector return of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/ice/ice_rxtx_vec_common.h:470:5: error:
'__builtin_ia32_inserti64x4' needs target feature avx512f
_mm512_inserti64x4(_mm512_castsi256_si512(vaddr0_1),
^
/usr/lib/clang/11.0.1/include/avx512fintrin.h:7413:12: note: expanded from
macro '_mm512_inserti64x4'
(__m512i)__builtin_ia32_inserti64x4((__v8di)(__m512i)(A), \
^In file included from ../drivers/net/ice/ice_rxtx_vec_avx2.c:5:../drivers/net/ice/ice_rxtx_vec_common.h:470:24: error: always_inline function '_mm512_castsi256_si512' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
_mm512_inserti64x4(_mm512_castsi256_si512(vaddr0_1),
^
../drivers/net/ice/ice_rxtx_vec_common.h:470:24: error: AVX vector return of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/ice/ice_rxtx_vec_common.h:473:5: error:
'__builtin_ia32_inserti64x4' needs target feature avx512f
_mm512_inserti64x4(_mm512_castsi256_si512(vaddr4_5),
^
/usr/lib/clang/11.0.1/include/avx512fintrin.h:7413:12: note: expanded from
macro '_mm512_inserti64x4'
(__m512i)__builtin_ia32_inserti64x4((__v8di)(__m512i)(A), \
^In file included from ../drivers/net/ice/ice_rxtx_vec_avx2.c:5:../drivers/net/ice/ice_rxtx_vec_common.h:473:24: error: always_inline function '_mm512_castsi256_si512' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
_mm512_inserti64x4(_mm512_castsi256_si512(vaddr4_5),
^
../drivers/net/ice/ice_rxtx_vec_common.h:473:24: error: AVX vector return of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/ice/ice_rxtx_vec_common.h:477:18: error: always_inline function '_mm512_unpackhi_epi64' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
dma_addr0_3 = _mm512_unpackhi_epi64(vaddr0_3,
vaddr0_3);
^../drivers/net/ice/ice_rxtx_vec_common.h:477:18: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/ice/ice_rxtx_vec_common.h:478:18: error: always_inline function '_mm512_unpackhi_epi64' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
dma_addr4_7 = _mm512_unpackhi_epi64(vaddr4_7,
vaddr4_7);
^../drivers/net/ice/ice_rxtx_vec_common.h:478:18: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/ice/ice_rxtx_vec_common.h:481:18: error: always_inline function '_mm512_add_epi64' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
dma_addr0_3 = _mm512_add_epi64(dma_addr0_3, hdr_room);
^../drivers/net/ice/ice_rxtx_vec_common.h:481:18: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/ice/ice_rxtx_vec_common.h:482:18: error: always_inline function '_mm512_add_epi64' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
dma_addr4_7 = _mm512_add_epi64(dma_addr4_7, hdr_room);
^../drivers/net/ice/ice_rxtx_vec_common.h:482:18: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/ice/ice_rxtx_vec_common.h:485:4: error: always_inline function '_mm512_store_si512' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
_mm512_store_si512((__m512i *)&rxdp->read,
dma_addr0_3);
^../drivers/net/ice/ice_rxtx_vec_common.h:485:4: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/ice/ice_rxtx_vec_common.h:486:4: error: always_inline function '_mm512_store_si512' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
_mm512_store_si512((__m512i *)&(rxdp + 4)->read,
dma_addr4_7);
^fatal error: too many errors emitted, stopping now [-ferror-limit=] 20 errors generated.
[998/1893] Compiling C object drivers/libtmp_rte_net_ice.a.p/net_ice_ice_rxtx.c.o ../drivers/net/ice/ice_rxtx.c:129:60: warning: unused parameter 'rxq' [-Wunused-parameter] ice_rxd_to_pkt_fields_by_comms_aux_v1(struct ice_rx_queue *rxq,
^
../drivers/net/ice/ice_rxtx.c:171:60: warning: unused parameter 'rxq'
[-Wunused-parameter]
ice_rxd_to_pkt_fields_by_comms_aux_v2(struct ice_rx_queue *rxq,
^2 warnings generated.
[1006/1893] Compiling C object lib/librte_pipeline.a.p/pipeline_rte_table_action.c.o
ninja: build stopped: subcommand failed.
[109/890] Compiling C object drivers/libtmp_rte_net_i40e.a.p/net_i40e_i40e_rxtx_vec_avx2.c.o
FAILED: drivers/libtmp_rte_net_i40e.a.p/net_i40e_i40e_rxtx_vec_avx2.c.o cc -Idrivers/libtmp_rte_net_i40e.a.p -Idrivers -I../drivers -Idrivers/net/i40e -I../drivers/net/i40e -Idrivers/net/i40e/base -I../drivers/net/i40e/base -Ilib/ethdev -I../lib/ethdev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/freebsd/include -I../lib/eal/freebsd/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/bsd -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -Ilib/hash -I../lib/hash -Ilib/rcu -I../lib/rcu -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3 -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-missing-field-initializers -D_GNU_SOURCE -D__BSD_VISIBLE -fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -DPF_DRIVER -DVF_DRIVER -DINTEGRATED_VF -DX722_A0_SUPPORT -DCC_AVX2_SUPPORT -DCC_AVX512_SUPPORT -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.i40e -MD -MQ drivers/libtmp_rte_net_i40e.a.p/net_i40e_i40e_rxtx_vec_avx2.c.o -MF drivers/libtmp_rte_net_i40e.a.p/net_i40e_i40e_rxtx_vec_avx2.c.o.d -o drivers/libtmp_rte_net_i40e.a.p/net_i40e_i40e_rxtx_vec_avx2.c.o -c ../drivers/net/i40e/i40e_rxtx_vec_avx2.c
In file included from ../drivers/net/i40e/i40e_rxtx_vec_avx2.c:13:../drivers/net/i40e/i40e_rxtx_vec_common.h:337:22: error: always_inline function '_mm512_set1_epi64' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
__m512i hdr_room = _mm512_set1_epi64(RTE_PKTMBUF_HEADROOM);
^../drivers/net/i40e/i40e_rxtx_vec_common.h:337:22: error: AVX vector return of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/i40e/i40e_rxtx_vec_common.h:385:5: error:
'__builtin_ia32_inserti64x4' needs target feature avx512f
_mm512_inserti64x4(_mm512_castsi256_si512(vaddr0_1),
^
/usr/lib/clang/11.0.1/include/avx512fintrin.h:7413:12: note: expanded from
macro '_mm512_inserti64x4'
(__m512i)__builtin_ia32_inserti64x4((__v8di)(__m512i)(A), \
^In file included from ../drivers/net/i40e/i40e_rxtx_vec_avx2.c:13:../drivers/net/i40e/i40e_rxtx_vec_common.h:385:24: error: always_inline function '_mm512_castsi256_si512' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
_mm512_inserti64x4(_mm512_castsi256_si512(vaddr0_1),
^
../drivers/net/i40e/i40e_rxtx_vec_common.h:385:24: error: AVX vector return of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/i40e/i40e_rxtx_vec_common.h:388:5: error:
'__builtin_ia32_inserti64x4' needs target feature avx512f
_mm512_inserti64x4(_mm512_castsi256_si512(vaddr4_5),
^
/usr/lib/clang/11.0.1/include/avx512fintrin.h:7413:12: note: expanded from
macro '_mm512_inserti64x4'
(__m512i)__builtin_ia32_inserti64x4((__v8di)(__m512i)(A), \
^In file included from ../drivers/net/i40e/i40e_rxtx_vec_avx2.c:13:../drivers/net/i40e/i40e_rxtx_vec_common.h:388:24: error: always_inline function '_mm512_castsi256_si512' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
_mm512_inserti64x4(_mm512_castsi256_si512(vaddr4_5),
^
../drivers/net/i40e/i40e_rxtx_vec_common.h:388:24: error: AVX vector return of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI ../drivers/net/i40e/i40e_rxtx_vec_common.h:392:18: error: always_inline function '_mm512_unpackhi_epi64' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
dma_addr0_3 = _mm512_unpackhi_epi64(vaddr0_3,
vaddr0_3);
^../drivers/net/i40e/i40e_rxtx_vec_common.h:392:18: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI ../drivers/net/i40e/i40e_rxtx_vec_common.h:393:18: error: always_inline function '_mm512_unpackhi_epi64' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
dma_addr4_7 = _mm512_unpackhi_epi64(vaddr4_7,
vaddr4_7);
^../drivers/net/i40e/i40e_rxtx_vec_common.h:393:18: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI ../drivers/net/i40e/i40e_rxtx_vec_common.h:396:18: error: always_inline function '_mm512_add_epi64' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
dma_addr0_3 = _mm512_add_epi64(dma_addr0_3, hdr_room);
^../drivers/net/i40e/i40e_rxtx_vec_common.h:396:18: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI ../drivers/net/i40e/i40e_rxtx_vec_common.h:397:18: error: always_inline function '_mm512_add_epi64' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
dma_addr4_7 = _mm512_add_epi64(dma_addr4_7, hdr_room);
^../drivers/net/i40e/i40e_rxtx_vec_common.h:397:18: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/i40e/i40e_rxtx_vec_common.h:400:4: error: always_inline function '_mm512_store_si512' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
_mm512_store_si512((__m512i *)&rxdp->read,
dma_addr0_3);
^../drivers/net/i40e/i40e_rxtx_vec_common.h:400:4: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/i40e/i40e_rxtx_vec_common.h:401:4: error: always_inline function '_mm512_store_si512' requires target feature 'avx512f', but would be inlined into function 'i40e_rxq_rearm_common' that is compiled without support for 'avx512f'
_mm512_store_si512((__m512i *)&(rxdp + 4)->read,
dma_addr4_7);
^fatal error: too many errors emitted, stopping now [-ferror-limit=] 20 errors generated.
[119/890] Compiling C object drivers/libtmp_rte_net_ice.a.p/net_ice_ice_rxtx_vec_avx2.c.o
FAILED: drivers/libtmp_rte_net_ice.a.p/net_ice_ice_rxtx_vec_avx2.c.o cc -Idrivers/libtmp_rte_net_ice.a.p -Idrivers -I../drivers -Idrivers/net/ice -I../drivers/net/ice -Idrivers/net/ice/base -I../drivers/net/ice/base -Idrivers/common/iavf -I../drivers/common/iavf -Ilib/ethdev -I../lib/ethdev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/freebsd/include -I../lib/eal/freebsd/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/bsd -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -Ilib/hash -I../lib/hash -Ilib/rcu -I../lib/rcu -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3 -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-missing-field-initializers -D_GNU_SOURCE -D__BSD_VISIBLE -fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -DCC_AVX2_SUPPORT -DCC_AVX512_SUPPORT -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.ice -MD -MQ drivers/libtmp_rte_net_ice.a.p/net_ice_ice_rxtx_vec_avx2.c.o -MF drivers/libtmp_rte_net_ice.a.p/net_ice_ice_rxtx_vec_avx2.c.o.d -o drivers/libtmp_rte_net_ice.a.p/net_ice_ice_rxtx_vec_avx2.c.o -c ../drivers/net/ice/ice_rxtx_vec_avx2.c
In file included from ../drivers/net/ice/ice_rxtx_vec_avx2.c:5:../drivers/net/ice/ice_rxtx_vec_common.h:422:22: error: always_inline function '_mm512_set1_epi64' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
__m512i hdr_room = _mm512_set1_epi64(RTE_PKTMBUF_HEADROOM);
^../drivers/net/ice/ice_rxtx_vec_common.h:422:22: error: AVX vector return of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/ice/ice_rxtx_vec_common.h:470:5: error:
'__builtin_ia32_inserti64x4' needs target feature avx512f
_mm512_inserti64x4(_mm512_castsi256_si512(vaddr0_1),
^
/usr/lib/clang/11.0.1/include/avx512fintrin.h:7413:12: note: expanded from
macro '_mm512_inserti64x4'
(__m512i)__builtin_ia32_inserti64x4((__v8di)(__m512i)(A), \
^In file included from ../drivers/net/ice/ice_rxtx_vec_avx2.c:5:../drivers/net/ice/ice_rxtx_vec_common.h:470:24: error: always_inline function '_mm512_castsi256_si512' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
_mm512_inserti64x4(_mm512_castsi256_si512(vaddr0_1),
^
../drivers/net/ice/ice_rxtx_vec_common.h:470:24: error: AVX vector return of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/ice/ice_rxtx_vec_common.h:473:5: error:
'__builtin_ia32_inserti64x4' needs target feature avx512f
_mm512_inserti64x4(_mm512_castsi256_si512(vaddr4_5),
^
/usr/lib/clang/11.0.1/include/avx512fintrin.h:7413:12: note: expanded from
macro '_mm512_inserti64x4'
(__m512i)__builtin_ia32_inserti64x4((__v8di)(__m512i)(A), \
^In file included from ../drivers/net/ice/ice_rxtx_vec_avx2.c:5:../drivers/net/ice/ice_rxtx_vec_common.h:473:24: error: always_inline function '_mm512_castsi256_si512' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
_mm512_inserti64x4(_mm512_castsi256_si512(vaddr4_5),
^
../drivers/net/ice/ice_rxtx_vec_common.h:473:24: error: AVX vector return of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/ice/ice_rxtx_vec_common.h:477:18: error: always_inline function '_mm512_unpackhi_epi64' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
dma_addr0_3 = _mm512_unpackhi_epi64(vaddr0_3,
vaddr0_3);
^../drivers/net/ice/ice_rxtx_vec_common.h:477:18: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/ice/ice_rxtx_vec_common.h:478:18: error: always_inline function '_mm512_unpackhi_epi64' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
dma_addr4_7 = _mm512_unpackhi_epi64(vaddr4_7,
vaddr4_7);
^../drivers/net/ice/ice_rxtx_vec_common.h:478:18: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/ice/ice_rxtx_vec_common.h:481:18: error: always_inline function '_mm512_add_epi64' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
dma_addr0_3 = _mm512_add_epi64(dma_addr0_3, hdr_room);
^../drivers/net/ice/ice_rxtx_vec_common.h:481:18: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/ice/ice_rxtx_vec_common.h:482:18: error: always_inline function '_mm512_add_epi64' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
dma_addr4_7 = _mm512_add_epi64(dma_addr4_7, hdr_room);
^../drivers/net/ice/ice_rxtx_vec_common.h:482:18: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/ice/ice_rxtx_vec_common.h:485:4: error: always_inline function '_mm512_store_si512' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
_mm512_store_si512((__m512i *)&rxdp->read,
dma_addr0_3);
^../drivers/net/ice/ice_rxtx_vec_common.h:485:4: error: AVX vector argument of type '__m512i' (vector of 8 'long long' values) without 'avx512f' enabled changes the ABI../drivers/net/ice/ice_rxtx_vec_common.h:486:4: error: always_inline function '_mm512_store_si512' requires target feature 'avx512f', but would be inlined into function 'ice_rxq_rearm_common' that is compiled without support for 'avx512f'
_mm512_store_si512((__m512i *)&(rxdp + 4)->read,
dma_addr4_7);
^fatal error: too many errors emitted, stopping now [-ferror-limit=] 20 errors generated.
ninja: build stopped: subcommand failed.
Signature · 2 lines
You are receiving this mail because: You are the assignee for the bug.
PATCH 1/2 net/i40e: fix generic build on FreeBSD
The common header file for vectorization is included in multiple files, and so must use macros for the current compilation unit, rather than the compiler-capability flag set for the whole driver. With the current, incorrect, macro, the AVX512 or AVX2 flags may be set when compiling up SSE code, leading to compilation errors. Changing from "CC_AVX*_SUPPORT" to the compiler-defined "__AVX*__" macros fixes this issue.
Bugzilla ID: 788
--- drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/i40e/i40e_rxtx_vec_common.h +2 -2
@@ -268,7 +268,7 @@ i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev)#endif } -#ifdef CC_AVX2_SUPPORT +#ifdef __AVX2__ static __rte_always_inline void i40e_rxq_rearm_common(struct i40e_rx_queue *rxq, __rte_unused bool avx512) {
@@ -329,7 +329,7 @@ i40e_rxq_rearm_common(struct i40e_rx_queue *rxq, __rte_unused bool avx512) _mm_store_si128((__m128i *)&rxdp++->read, dma_addr1); } #else -#ifdef CC_AVX512_SUPPORT +#ifdef __AVX512VL__ if (avx512) { struct rte_mbuf *mb0, *mb1, *mb2, *mb3; struct rte_mbuf *mb4, *mb5, *mb6, *mb7;
Signature · 1 line
2.30.2
PATCH 2/2 net/ice: fix generic build on FreeBSD
The common header file for vectorization is included in multiple files, and so must use macros for the current compilation unit, rather than the compiler-capability flag set for the whole driver. With the current, incorrect, macro, the AVX512 or AVX2 flags may be set when compiling up SSE code, leading to compilation errors. Changing from "CC_AVX*_SUPPORT" to the compiler-defined "__AVX*__" macros fixes this issue.
Bugzilla ID: 788
--- drivers/net/ice/ice_rxtx_vec_common.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ice/ice_rxtx_vec_common.h +3 -3
@@ -194,7 +194,7 @@ _ice_tx_queue_release_mbufs_vec(struct ice_tx_queue *txq)*/ i = txq->tx_next_dd - txq->tx_rs_thresh +1 ; -#ifdef CC_AVX512_SUPPORT +#ifdef __AVX512VL__struct rte_eth_dev *dev = &rte_eth_devices[txq->vsi->adapter->pf.dev_data->port_id]; if (dev->tx_pkt_burst == ice_xmit_pkts_vec_avx512 ||
@@ -352,7 +352,7 @@ ice_tx_vec_dev_check_default(struct rte_eth_dev *dev)return result; } -#ifdef CC_AVX2_SUPPORT +#ifdef __AVX2__ static __rte_always_inline void ice_rxq_rearm_common(struct ice_rx_queue *rxq, __rte_unused bool avx512) {
@@ -414,7 +414,7 @@ ice_rxq_rearm_common(struct ice_rx_queue *rxq, __rte_unused bool avx512) _mm_store_si128((__m128i *)&rxdp++->read, dma_addr1); } #else -#ifdef CC_AVX512_SUPPORT +#ifdef __AVX512VL__ if (avx512) { struct rte_mbuf *mb0, *mb1, *mb2, *mb3; struct rte_mbuf *mb4, *mb5, *mb6, *mb7;
Signature · 1 line
2.30.2
Re: [dpdk-dev] [PATCH 2/2] net/ice: fix generic build on FreeBSD
Quoted 65 lines
-----Original Message-----
From: Richardson, Bruce <[email protected]>
Sent: Thursday, August 19, 2021 12:38 AM
To: [email protected]
Cc: [email protected]; Richardson, Bruce <[email protected]>; Lu, Wenzhuo <[email protected]>; Rong, Leyi <[email protected]>; [email protected]; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: [PATCH 2/2] net/ice: fix generic build on FreeBSDThe common header file for vectorization is included in multiple files, and so must use macros for the current compilation unit, rather than the compiler- capability flag set for the whole driver. With the current, incorrect, macro, the AVX512 or AVX2 flags may be set when compiling up SSE code, leading to compilation errors. Changing from "CC_AVX*_SUPPORT"
to the compiler-defined "__AVX*__" macros fixes this issue.Bugzilla ID: 788
Fixes a4e480de268e ("net/ice: optimize Tx by using AVX512")Fixes 20daa1c978b7 ("net/ice: fix crash in AVX512")Signed-off-by Bruce Richardson <[email protected]>--- drivers/net/ice/ice_rxtx_vec_common.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/net/ice/ice_rxtx_vec_common.h +1
-1@@ -194,7 +194,7 @@ _ice_tx_queue_release_mbufs_vec(struct ice_tx_queue*txq) */ i = txq->tx_next_dd - txq->tx_rs_thresh +1 ; -#ifdef CC_AVX512_SUPPORT +#ifdef __AVX512VL__struct rte_eth_dev *dev = &rte_eth_devices[txq->vsi->adapter- >pf.dev_data->port_id];drivers/net/ice/ice_rxtx_vec_common.h +2
-1if (dev->tx_pkt_burst == ice_xmit_pkts_vec_avx512 || @@ -352,7 +352,7 @@ ice_tx_vec_dev_check_default(struct rte_eth_dev *dev)return result; } -#ifdef CC_AVX2_SUPPORT +#ifdef __AVX2__ static __rte_always_inline void ice_rxq_rearm_common(struct ice_rx_queue *rxq, __rte_unused bool avx512){ @@ -414,7 +414,7 @@
ice_rxq_rearm_common(struct ice_rx_queue *rxq, __rte_unused bool avx512)drivers/net/ice/ice_rxtx_vec_common.h +1
-2_mm_store_si128((__m128i *)&rxdp++->read, dma_addr1); } #else -#ifdef CC_AVX512_SUPPORT +#ifdef __AVX512VL__ if (avx512) { struct rte_mbuf *mb0, *mb1, *mb2, *mb3; struct rte_mbuf *mb4, *mb5, *mb6, *mb7; --
Quoted 1 line
2.30.2
Zhang, Qi Z
AppliedRe: [dpdk-dev] [PATCH 2/2] net/ice: fix generic build on FreeBSD
Quoted 69 lines
-----Original Message-----
From: Rong, Leyi <[email protected]>
Sent: Monday, August 30, 2021 4:18 PM
To: Richardson, Bruce <[email protected]>; [email protected]
Cc: [email protected]; Lu, Wenzhuo <[email protected]>; [email protected]; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: RE: [PATCH 2/2] net/ice: fix generic build on FreeBSDQuoted 55 lines
-----Original Message-----
From: Richardson, Bruce <[email protected]>
Sent: Thursday, August 19, 2021 12:38 AM
To: [email protected]
Cc: [email protected]; Richardson, Bruce <[email protected]>; Lu, Wenzhuo <[email protected]>; Rong, Leyi <[email protected]>; [email protected]; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: [PATCH 2/2] net/ice: fix generic build on FreeBSDThe common header file for vectorization is included in multiple files, and so must use macros for the current compilation unit, rather than the compiler- capability flag set for the whole driver. With the current, incorrect, macro, the
AVX512 or AVX2 flags may be set when compiling up SSE code, leading to compilation errors. Changing from "CC_AVX*_SUPPORT"
to the compiler-defined "__AVX*__" macros fixes this issue.Bugzilla ID: 788
Fixes a4e480de268e ("net/ice: optimize Tx by using AVX512")Fixes 20daa1c978b7 ("net/ice: fix crash in AVX512")Signed-off-by Bruce Richardson <[email protected]>--- drivers/net/ice/ice_rxtx_vec_common.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/net/ice/ice_rxtx_vec_common.h +0
-0@@ -194,7 +194,7 @@ _ice_tx_queue_release_mbufs_vec(struct
ice_tx_queue
*txq)drivers/net/ice/ice_rxtx_vec_common.h +1
-1*/ i = txq->tx_next_dd - txq->tx_rs_thresh +1 ; -#ifdef CC_AVX512_SUPPORT +#ifdef __AVX512VL__ struct rte_eth_dev *dev = &rte_eth_devices[txq->vsi->adapter-Quoted 1 line
pf.dev_data->port_id];drivers/net/ice/ice_rxtx_vec_common.h +2
-1if (dev->tx_pkt_burst == ice_xmit_pkts_vec_avx512 || @@ -352,7 +352,7 @@ ice_tx_vec_dev_check_default(struct rte_eth_dev *dev)return result; } -#ifdef CC_AVX2_SUPPORT +#ifdef __AVX2__ static __rte_always_inline void ice_rxq_rearm_common(struct ice_rx_queue *rxq, __rte_unused boolQuoted 1 line
avx512) { @@ -414,7 +414,7 @@ ice_rxq_rearm_common(struct
ice_rx_queue
Quoted 13 lines
Quoted 11 lines
*rxq,
__rte_unusedbool avx512)drivers/net/ice/ice_rxtx_vec_common.h +1
-2_mm_store_si128((__m128i *)&rxdp++->read, dma_addr1); } #else -#ifdef CC_AVX512_SUPPORT +#ifdef __AVX512VL__ if (avx512) { struct rte_mbuf *mb0, *mb1, *mb2, *mb3; struct rte_mbuf *mb4, *mb5, *mb6, *mb7; --2.30.2
Acked-by Leyi Rong <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi
Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix generic build on FreeBSD
In reply to Bruce RichardsonQuoted 22 lines · Bruce Richardson
The common header file for vectorization is included in multiple files, and so must use macros for the current compilation unit, rather than the compiler-capability flag set for the whole driver. With the current, incorrect, macro, the AVX512 or AVX2 flags may be set when compiling up SSE code, leading to compilation errors. Changing from "CC_AVX*_SUPPORT" to the compiler-defined "__AVX*__" macros fixes this issue.
Bugzilla ID: 788
Signed-off-by Bruce Richardson <[email protected]>--- drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/i40e/i40e_rxtx_vec_common.h +0
-0
drivers/net/i40e/i40e_rxtx_vec_common.h i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev) · line 274
Quoted 8 lines
drivers/net/i40e/i40e_rxtx_vec_common.h +1
-1@@ -268,7 +268,7 @@ i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev)#endif } -#ifdef CC_AVX2_SUPPORT +#ifdef __AVX2__ static __rte_always_inline void i40e_rxq_rearm_common(struct i40e_rx_queue *rxq, __rte_unused bool avx512) {
On a higher-level, I'd suggest we look to remove the use of these macros and AVX code in general from this header file (and ice driver equivalent). IIRC this file was originally meant to contain only the "common" code i.e. the scalar code, to be shared among vector implementations. Having AVX code in this file can lead to these sorts of bugs and just makes the file no longer truely common. The code in question here, should probably go in a "common_avx" header, which means that we can remove the AVX2 conditions from it etc.
/Bruce
Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix generic build on FreeBSD
Quoted 26 lines · Bruce Richardson
Quoted 25 lines · Bruce Richardson
The common header file for vectorization is included in multiple files, and so must use macros for the current compilation unit, rather than the compiler-capability flag set for the whole driver. With the current, incorrect, macro, the AVX512 or AVX2 flags may be set when compiling up SSE code, leading to compilation errors. Changing from "CC_AVX*_SUPPORT" to the compiler-defined "__AVX*__" macros fixes this issue.
Bugzilla ID: 788
Signed-off-by Bruce Richardson <[email protected]>--- drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/i40e/i40e_rxtx_vec_common.h +0
-0@@ -268,7 +268,7 @@ i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev)#endif }
Quoted 15 lines
drivers/net/i40e/i40e_rxtx_vec_common.h i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev) · line 274
Quoted 5 lines
drivers/net/i40e/i40e_rxtx_vec_common.h +1
-1-#ifdef CC_AVX2_SUPPORT +#ifdef __AVX2__ static __rte_always_inline void i40e_rxq_rearm_common(struct i40e_rx_queue *rxq, __rte_unused bool avx512) {On a higher-level, I'd suggest we look to remove the use of these macros and AVX code in general from this header file (and ice driver equivalent). IIRC this file was originally meant to contain only the "common" code i.e. the scalar code, to be shared among vector implementations. Having AVX code in this file can lead to these sorts of bugs and just makes the file no longer truely common. The code in question here, should probably go in a "
common_avx" header, which means that we can remove the AVX2 conditions from it etc.
Indeed I come to this thread to make exact same comment, I think better to move avx specific code into a "common_avx" header.
Zhang, Qi Z
AppliedRe: [dpdk-dev] [PATCH 1/2] net/i40e: fix generic build on FreeBSD
In reply to Bruce RichardsonQuoted 52 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Bruce Richardson
Sent: Thursday, August 19, 2021 12:38 AM
To: [email protected]
Cc: [email protected]; Richardson, Bruce <[email protected]>; Lu, Wenzhuo <[email protected]>; [email protected]; Xing, Beilei <[email protected]>
Subject: [dpdk-dev] [PATCH 1/2] net/i40e: fix generic build on FreeBSDThe common header file for vectorization is included in multiple files, and so must use macros for the current compilation unit, rather than the compiler-capability flag set for the whole driver. With the current, incorrect, macro, the AVX512 or AVX2 flags may be set when compiling up SSE code, leading to compilation errors. Changing from "CC_AVX*_SUPPORT"
to the compiler-defined "__AVX*__" macros fixes this issue.Bugzilla ID: 788
Signed-off-by Bruce Richardson <[email protected]>--- drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/i40e/i40e_rxtx_vec_common.h +1
-1@@ -268,7 +268,7 @@ i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev)#endif } -#ifdef CC_AVX2_SUPPORT +#ifdef __AVX2__ static __rte_always_inline void i40e_rxq_rearm_common(struct i40e_rx_queue *rxq, __rte_unused boolavx512) { @@ -329,7 +329,7 @@
i40e_rxq_rearm_common(struct i40e_rx_queue *rxq, __rte_unused bool avx512)drivers/net/i40e/i40e_rxtx_vec_common.h +1
-2_mm_store_si128((__m128i *)&rxdp++->read, dma_addr1); } #else -#ifdef CC_AVX512_SUPPORT +#ifdef __AVX512VL__ if (avx512) { struct rte_mbuf *mb0, *mb1, *mb2, *mb3; struct rte_mbuf *mb4, *mb5, *mb6, *mb7; --
Quoted 1 line
2.30.2
Applied to dpdk-next-net-intel.
Thanks
Qi