parse-sublevel-option.h : Add new line and license identifier
PATCH 1/1 parse-sublevel-option.h : Add new line and license identifier
Add the new line at the end of file and add SPDX license identifier GPL-2.0, thus removing warning while running checkpatch.pl script
--- tools/perf/util/parse-sublevel-options.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
tools/perf/util/parse-sublevel-options.h +4 -1
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _PERF_PARSE_SUBLEVEL_OPTIONS_H#define _PERF_PARSE_SUBLEVEL_OPTIONS_H
@@ -8,4 +10,5 @@ struct sublevel_option {int perf_parse_sublevel_options (const char *str,struct sublevel_option *opts); -#endif +#endif +
Signature · 11 lines
2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#240): https://lists.elisa.tech/g/linux-safety/message/240 Mute This Topic: https://lists.elisa.tech/mt/84977020/5278000 Group Owner: [email protected] Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
Quoted 4 lines · Nghia Le
Add the new line at the end of file and add SPDX license identifier GPL-2.0, thus removing warning while running checkpatch.pl script
Signed-off-by Nghia Le <[email protected]>
Did you run checkpatch.pl on your own patch? What did it report?
tools/perf/util/parse-sublevel-options.h line 2
Quoted 11 lines
--- tools/perf/util/parse-sublevel-options.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)tools/perf/util/parse-sublevel-options.h +2
-0@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +
Do you understand the legal implications of adding this annotation? Are you among the authors to make this statement with sufficient confidence?
It seems awkward to just annotate one file here, probably it is much better to have one commit that adds this annotation to all files in tools/perf/ if you are sure that this is all licensed GPL-2.0.
tools/perf/util/parse-sublevel-options.h struct sublevel_option { · line 14
Quoted 11 lines
tools/perf/util/parse-sublevel-options.h +2
-1#ifndef _PERF_PARSE_SUBLEVEL_OPTIONS_H#define _PERF_PARSE_SUBLEVEL_OPTIONS_H@@ -8,4 +10,5 @@ struct sublevel_option {int perf_parse_sublevel_options (const char *str,struct sublevel_option *opts); -#endif +#endif +
Now, you are adding an empty new line to this file. Can you create a patch that ends with #endif and a newline instead? That seems much more common throughout the whole kernel tree.
Good luck, we are anxiously waiting for your patch v2.
Lukas
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#241): https://lists.elisa.tech/g/linux-safety/message/241
Mute This Topic: https://lists.elisa.tech/mt/84977020/5278000
Group Owner: [email protected]
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Quoted 9 lines · Lukas Bulwahn
Quoted 2 lines · Nghia Le
Add the new line at the end of file and add SPDX license identifier
GPL-2.0, thus removing warning while running checkpatch.pl script
Quoted 2 lines
Signed-off-by Nghia Le <[email protected]>Did you run checkpatch.pl on your own patch? What did it report?
I will add report in the PATCH v2
Quoted 17 lines
---
Review
Quoted 4 lines
tools/perf/util/parse-sublevel-options.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/tools/perf/util/parse-sublevel-options.htools/perf/util/parse-sublevel-options.h line 2
Quoted 6 lines
index
9b9efcc2aaad..bb44b5af2963100644tools/perf/util/parse-sublevel-options.h +2
-0@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +Do you understand the legal implications of adding this annotation? Are you among the authors to make this statement with sufficient confidence?
Quoted 4 lines
It seems awkward to just annotate one file here, probably it is much better to have one commit that adds this annotation to all files in
tools/perf/if you are sure that this is all licensed GPL-2.0.
Thanks for your comment. Originally, I had two reasons to add license
identifier
1. To remove the warning, I referred lots of header file in the same
folder /tools/perf/util and
and many of them have license identifier with SPDX is GPL-2.0. Then I
thought we can apply for file which
doesn't have identifier explicitly
2. I also refer the topic with long conversation while Greg K-H mentioned
about add SPDX for file without license
identifier:
https://patchwork.kernel.org/project/xfs/patch/20171107020607.GA26910@magnolia/
However, I totally agree with you that it is quite complicated in terms
of legal implication and I am not confident enough
to change it at the moment. Hence, I will keep it as original version
Quoted 8 lines
#ifndef
_PERF_PARSE_SUBLEVEL_OPTIONS_Htools/perf/util/parse-sublevel-options.h struct sublevel_option { · line 11
Quoted 5 lines
tools/perf/util/parse-sublevel-options.h +0
-0#define _PERF_PARSE_SUBLEVEL_OPTIONS_H@@ -8,4 +10,5 @@ struct sublevel_option { int perf_parse_sublevel_options(const char *str, struct sublevel_option*opts);
Quoted 1 line
Quoted 9 lines
tools/perf/util/parse-sublevel-options.h struct sublevel_option { · line 14
Quoted 4 lines
tools/perf/util/parse-sublevel-options.h +2
-1-#endif +#endif +Now, you are adding an empty new line to this file. Can you create a patch that ends with #endif and a newline instead? That seems much more common throughout the whole kernel tree.
I will update in PATCH v2
Good luck, we are anxiously waiting for your patch v2.
Quoted 3 lines
Lukas
Thank you for your detailed comments
Nghia Le
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#242): https://lists.elisa.tech/g/linux-safety/message/242
Mute This Topic: https://lists.elisa.tech/mt/84977020/5278000
Group Owner: [email protected]
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-