Skip to contentSkip to conversation

package/sentry-cli: remove package

PATCH Applied Thomas Petazzoni 3 participants 8 messages Aug 18, 2021 – Aug 19, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/sentry-cli: remove package

This package has had build failures for a very long time, and these issues have not been fixed, and it is now the number 1 build failure reason in our autobuilders. It is time to acknowledge that the package needs to be removed.

---
 DEVELOPERS                         |  1 -
 package/Config.in.host             |  1 -
 package/sentry-cli/Config.in.host  | 10 ----------
 package/sentry-cli/sentry-cli.hash |  3 ---
 package/sentry-cli/sentry-cli.mk   | 32 ------------------------------
 5 files changed, 47 deletions(-)
 delete mode 100644 package/sentry-cli/Config.in.host
 delete mode 100644 package/sentry-cli/sentry-cli.hash
 delete mode 100644 package/sentry-cli/sentry-cli.mk
DEVELOPERS +0 -1
index af97de02de..64cd29d7d1 100644
@@ -1441,7 +1441,6 @@ F:	package/python-schedule/
 F:	package/python-sentry-sdk/
 F:	package/python-websockets/
 F:	package/python-xlib/
-F:	package/sentry-cli/
 F:	package/sentry-native/
 F:	package/unclutter-xfixes/
 
package/Config.in.host +0 -1
index 8d443ea255..551352482e 100644
@@ -79,7 +79,6 @@ menu "Host utilities"
 	source "package/s6-rc/Config.in.host"
 	source "package/sam-ba/Config.in.host"
 	source "package/sdbusplus/Config.in.host"
-	source "package/sentry-cli/Config.in.host"
 	source "package/squashfs/Config.in.host"
 	source "package/sunxi-tools/Config.in.host"
 	source "package/swig/Config.in.host"
package/sentry-cli/Config.in.host deleted +0 -10
deleted file mode 100644
index 3124015367..0000000000
@@ -1,10 +0,0 @@
-config BR2_PACKAGE_HOST_SENTRY_CLI
-	bool "host sentry-cli"
-	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
-	select BR2_PACKAGE_HOST_RUSTC
-	help
-	  Official Sentry command line interface
-
-	  For managing debug information files and source maps.
-
-	  https://docs.sentry.io/cli/
package/sentry-cli/sentry-cli.hash deleted +0 -3
deleted file mode 100644
index 3b0733a276..0000000000
@@ -1,3 +0,0 @@
-# locally calculated
-sha256  5d0f7acf6a139d1c1716b9a8ff76c8bfaab09104ba663c957bb9a5dba2ffbabd  sentry-cli-1.57.0.tar.gz
-sha256  9503def7b54ceb6e3cd182fd59bc05d3a30d7eae481e65aaba4b495133c83c14  LICENSE
package/sentry-cli/sentry-cli.mk deleted +0 -32
deleted file mode 100644
index 7e53f16026..0000000000
@@ -1,32 +0,0 @@
-################################################################################
-#
-# sentry-cli
-#
-################################################################################
-
-SENTRY_CLI_VERSION = 1.57.0
-SENTRY_CLI_SITE = $(call github,getsentry,sentry-cli,$(SENTRY_CLI_VERSION))
-SENTRY_CLI_LICENSE = BSD-3-clause
-SENTRY_CLI_LICENSE_FILES = LICENSE
-
-HOST_SENTRY_CLI_DEPENDENCIES = host-rustc host-zlib
-
-HOST_SENTRY_CLI_CARGO_ENV = \
-	CARGO_HOME=$(HOST_DIR)/share/cargo \
-	RUSTFLAGS="$(addprefix -C link-args=,$(HOST_LDFLAGS))"
-
-HOST_SENTRY_CLI_CARGO_OPTS = \
-	--release \
-	--manifest-path=$(@D)/Cargo.toml
-
-define HOST_SENTRY_CLI_BUILD_CMDS
-	$(HOST_MAKE_ENV) $(HOST_SENTRY_CLI_CARGO_ENV) \
-		cargo build $(HOST_SENTRY_CLI_CARGO_OPTS)
-endef
-
-define HOST_SENTRY_CLI_INSTALL_CMDS
-	$(INSTALL) -D -m 0755 $(@D)/target/release/sentry-cli \
-		$(HOST_DIR)/bin/sentry-cli
-endef
-
-$(eval $(host-generic-package))
Signature · 6 lines
2.31.1

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
#1 lore raw

Thomas;

It seems like version 1.68.0 fixes the build failures. I have tested two different
defconfigs that are on the failure list:
- bf7361dc482d8f3f97d523b7d56eabe5bc515ae8
- 97aa03f497536462abc85011ba1c94874d18f237

And the new version doesn't produce the failures that are plaguing the autobuilders.

Instead of removing the package, I would suggest updating it to 1.68.0 instead.

Adam

Quoted 108 lines · Thomas Petazzoni

This package has had build failures for a very long time, and these issues have not been fixed, and it is now the number 1 build failure reason in our autobuilders. It is time to acknowledge that the package needs to be removed.

---
 DEVELOPERS                         |  1 -
 package/Config.in.host             |  1 -
 package/sentry-cli/Config.in.host  | 10 ----------
 package/sentry-cli/sentry-cli.hash |  3 ---
 package/sentry-cli/sentry-cli.mk   | 32 ------------------------------
 5 files changed, 47 deletions(-)
 delete mode 100644 package/sentry-cli/Config.in.host
 delete mode 100644 package/sentry-cli/sentry-cli.hash
 delete mode 100644 package/sentry-cli/sentry-cli.mk
DEVELOPERS +0 -1
index af97de02de..64cd29d7d1 100644
@@ -1441,7 +1441,6 @@ F:        package/python-schedule/
 F:     package/python-sentry-sdk/
 F:     package/python-websockets/
 F:     package/python-xlib/
-F:     package/sentry-cli/
 F:     package/sentry-native/
 F:     package/unclutter-xfixes/
 
package/Config.in.host +0 -1
index 8d443ea255..551352482e 100644
@@ -79,7 +79,6 @@ menu "Host utilities"
        source "package/s6-rc/Config.in.host"
        source "package/sam-ba/Config.in.host"
        source "package/sdbusplus/Config.in.host"
-       source "package/sentry-cli/Config.in.host"
        source "package/squashfs/Config.in.host"
        source "package/sunxi-tools/Config.in.host"
        source "package/swig/Config.in.host"
package/sentry-cli/Config.in.host deleted +0 -10
deleted file mode 100644
index 3124015367..0000000000
@@ -1,10 +0,0 @@
-config BR2_PACKAGE_HOST_SENTRY_CLI
-       bool "host sentry-cli"
-       depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
-       select BR2_PACKAGE_HOST_RUSTC
-       help
-         Official Sentry command line interface
-
-         For managing debug information files and source maps.
-
-         https://docs.sentry.io/cli/
package/sentry-cli/sentry-cli.hash deleted +0 -3
deleted file mode 100644
index 3b0733a276..0000000000
@@ -1,3 +0,0 @@
-# locally calculated
-sha256  5d0f7acf6a139d1c1716b9a8ff76c8bfaab09104ba663c957bb9a5dba2ffbabd  sentry-cli-1.57.0.tar.gz
-sha256  9503def7b54ceb6e3cd182fd59bc05d3a30d7eae481e65aaba4b495133c83c14  LICENSE
package/sentry-cli/sentry-cli.mk deleted +0 -33
deleted file mode 100644
index 7e53f16026..0000000000
@@ -1,32 +0,0 @@
-################################################################################
-#
-# sentry-cli
-#
-################################################################################
-
-SENTRY_CLI_VERSION = 1.57.0
-SENTRY_CLI_SITE = $(call github,getsentry,sentry-cli,$(SENTRY_CLI_VERSION))
-SENTRY_CLI_LICENSE = BSD-3-clause
-SENTRY_CLI_LICENSE_FILES = LICENSE
-
-HOST_SENTRY_CLI_DEPENDENCIES = host-rustc host-zlib
-
-HOST_SENTRY_CLI_CARGO_ENV = \
-       CARGO_HOME=$(HOST_DIR)/share/cargo \
-       RUSTFLAGS="$(addprefix -C link-args=,$(HOST_LDFLAGS))"
-
-HOST_SENTRY_CLI_CARGO_OPTS = \
-       --release \
-       --manifest-path=$(@D)/Cargo.toml
-
-define HOST_SENTRY_CLI_BUILD_CMDS
-       $(HOST_MAKE_ENV) $(HOST_SENTRY_CLI_CARGO_ENV) \
-               cargo build $(HOST_SENTRY_CLI_CARGO_OPTS)
-endef
-
-define HOST_SENTRY_CLI_INSTALL_CMDS
-       $(INSTALL) -D -m 0755 $(@D)/target/release/sentry-cli \
-               $(HOST_DIR)/bin/sentry-cli
-endef
-
-$(eval $(host-generic-package))
--

2.31.1

Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot

#2 lore raw

Hello Adam,

Quoted 10 lines · On Wed, 18 Aug 2021 13:36:58 -0700 Adam Duskett <[email protected]> wrote:

It seems like version 1.68.0 fixes the build failures. I have tested two different
defconfigs that are on the failure list:
- bf7361dc482d8f3f97d523b7d56eabe5bc515ae8
- 97aa03f497536462abc85011ba1c94874d18f237

And the new version doesn't produce the failures that are plaguing the autobuilders.

Instead of removing the package, I would suggest updating it to 1.68.0 instead.

Thanks for looking into this. Did you confirm that you were able to reproduce the failures *before* the version bump ?

One of the issue seems to because by the host-sentry-cli calling into Git, which would probably work with in-tree builds, but not out-of-tree builds for example. Another issue seems to be related to zlib being available on the host system or not.

So to know if the 1.68.0 update fixes the issue, we need to make sure that you were able to reproduce the failures with the current version, in the same setup as the one you tested the version bump with.

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
#3 lore raw

Hey Thomas;

Quoted 12 lines · Thomas Petazzoni

Hello Adam,

Quoted 6 lines · On Wed, 18 Aug 2021 13:36:58 -0700 Adam Duskett <[email protected]> wrote:

It seems like version 1.68.0 fixes the build failures. I have tested two different
defconfigs that are on the failure list:
- bf7361dc482d8f3f97d523b7d56eabe5bc515ae8
- 97aa03f497536462abc85011ba1c94874d18f237

Quoted 8 lines
Quoted 4 lines

And the new version doesn't produce the failures that are plaguing the autobuilders.

Instead of removing the package, I would suggest updating it to 1.68.0 instead.

Thanks for looking into this. Did you confirm that you were able to reproduce the failures *before* the version bump ?

Interestingly enough, my testing method was flawed. While I did spin up a debian 9
docker container and the exact git hash that failed, I made the mistake of running
make host-sentry-cli and not make

When calling host-sentry-cli directly, there isn't a failure, but when running just make
the failure does appear. I am not sure how to pass include paths to cargo, but it seems
like the only failure now is the missing zlib.h library if the package is bumped to 1.68, as
the git repository error is indeed resolved.

Thanks!
Adam

Quoted 9 lines

One of the issue seems to because by the host-sentry-cli calling into Git, which would probably work with in-tree builds, but not out-of-tree builds for example. Another issue seems to be related to zlib being available on the host system or not.

So to know if the 1.68.0 update fixes the issue, we need to make sure that you were able to reproduce the failures with the current version, in the same setup as the one you tested the version bump with.

Quoted 7 lines

Thanks!

Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot

#4 lore raw
Quoted 6 lines · On Thu, 19 Aug 2021 09:08:49 -0700 Adam Duskett <[email protected]> wrote:

Interestingly enough, my testing method was flawed. While I did spin up a debian 9
docker container and the exact git hash that failed, I made the mistake of running
make host-sentry-cli and not make

Quoted 7 lines

When calling host-sentry-cli directly, there isn't a failure, but when running just make
the failure does appear. I am not sure how to pass include paths to cargo, but it seems
like the only failure now is the missing zlib.h library if the package is bumped to 1.68, as
the git repository error is indeed resolved.

Including for an out-of-tree build, where the build directory is outside of any Git repository ?

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
#5 lore raw

Ugh, out of tree still fails. Yeah, I'm bad at this whole troubleshooting thing :(

Sorry for wasting your time! Remove this terrible package!

Adam

Quoted 21 lines · Thomas Petazzoni
Quoted 6 lines · On Thu, 19 Aug 2021 09:08:49 -0700 Adam Duskett <[email protected]> wrote:

Interestingly enough, my testing method was flawed. While I did spin up a debian 9
docker container and the exact git hash that failed, I made the mistake of running
make host-sentry-cli and not make

Quoted 7 lines

When calling host-sentry-cli directly, there isn't a failure, but when running just make
the failure does appear. I am not sure how to pass include paths to cargo, but it seems
like the only failure now is the missing zlib.h library if the package is bumped to 1.68, as
the git repository error is indeed resolved.

Including for an out-of-tree build, where the build directory is outside of any Git repository ?

Quoted 7 lines

Thanks!

Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot

#6 lore raw

Hello Adam,

Quoted 2 lines · On Thu, 19 Aug 2021 09:30:43 -0700 Adam Duskett <[email protected]> wrote:

Ugh, out of tree still fails. Yeah, I'm bad at this whole troubleshooting thing :(

Ah ah :-)

Quoted 1 line

Sorry for wasting your time! Remove this terrible package!

Well, I don't think it's a terrible package, but I'm not personally interested in it, and despite those zillions of failures being reported for weeks/months, nobody cared enough to fix it up.

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
#7 lore raw
In reply to Thomas Petazzoni

Thomas, All,

On 2021-08-18 22:22 +0200, Thomas Petazzoni spake thusly:

Quoted 6 lines

This package has had build failures for a very long time, and these issues have not been fixed, and it is now the number 1 build failure reason in our autobuilders. It is time to acknowledge that the package needs to be removed.

Indeed, this is a bit sad that we have to remove a package, but since noone ever fixed the issues with it, meh...

I was pondering whether it was material for master or next, but then I decided master, because we do not want a release with a known-broken, never-to-be-fixed package.

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 105 lines
---
 DEVELOPERS                         |  1 -
 package/Config.in.host             |  1 -
 package/sentry-cli/Config.in.host  | 10 ----------
 package/sentry-cli/sentry-cli.hash |  3 ---
 package/sentry-cli/sentry-cli.mk   | 32 ------------------------------
 5 files changed, 47 deletions(-)
 delete mode 100644 package/sentry-cli/Config.in.host
 delete mode 100644 package/sentry-cli/sentry-cli.hash
 delete mode 100644 package/sentry-cli/sentry-cli.mk
DEVELOPERS +0 -1
index af97de02de..64cd29d7d1 100644
@@ -1441,7 +1441,6 @@ F:	package/python-schedule/
 F:	package/python-sentry-sdk/
 F:	package/python-websockets/
 F:	package/python-xlib/
-F:	package/sentry-cli/
 F:	package/sentry-native/
 F:	package/unclutter-xfixes/
 
package/Config.in.host +0 -1
index 8d443ea255..551352482e 100644
@@ -79,7 +79,6 @@ menu "Host utilities"
 	source "package/s6-rc/Config.in.host"
 	source "package/sam-ba/Config.in.host"
 	source "package/sdbusplus/Config.in.host"
-	source "package/sentry-cli/Config.in.host"
 	source "package/squashfs/Config.in.host"
 	source "package/sunxi-tools/Config.in.host"
 	source "package/swig/Config.in.host"
package/sentry-cli/Config.in.host deleted +0 -10
deleted file mode 100644
index 3124015367..0000000000
@@ -1,10 +0,0 @@
-config BR2_PACKAGE_HOST_SENTRY_CLI
-	bool "host sentry-cli"
-	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
-	select BR2_PACKAGE_HOST_RUSTC
-	help
-	  Official Sentry command line interface
-
-	  For managing debug information files and source maps.
-
-	  https://docs.sentry.io/cli/
package/sentry-cli/sentry-cli.hash deleted +0 -3
deleted file mode 100644
index 3b0733a276..0000000000
@@ -1,3 +0,0 @@
-# locally calculated
-sha256  5d0f7acf6a139d1c1716b9a8ff76c8bfaab09104ba663c957bb9a5dba2ffbabd  sentry-cli-1.57.0.tar.gz
-sha256  9503def7b54ceb6e3cd182fd59bc05d3a30d7eae481e65aaba4b495133c83c14  LICENSE
package/sentry-cli/sentry-cli.mk deleted +0 -32
deleted file mode 100644
index 7e53f16026..0000000000
@@ -1,32 +0,0 @@
-################################################################################
-#
-# sentry-cli
-#
-################################################################################
-
-SENTRY_CLI_VERSION = 1.57.0
-SENTRY_CLI_SITE = $(call github,getsentry,sentry-cli,$(SENTRY_CLI_VERSION))
-SENTRY_CLI_LICENSE = BSD-3-clause
-SENTRY_CLI_LICENSE_FILES = LICENSE
-
-HOST_SENTRY_CLI_DEPENDENCIES = host-rustc host-zlib
-
-HOST_SENTRY_CLI_CARGO_ENV = \
-	CARGO_HOME=$(HOST_DIR)/share/cargo \
-	RUSTFLAGS="$(addprefix -C link-args=,$(HOST_LDFLAGS))"
-
-HOST_SENTRY_CLI_CARGO_OPTS = \
-	--release \
-	--manifest-path=$(@D)/Cargo.toml
-
-define HOST_SENTRY_CLI_BUILD_CMDS
-	$(HOST_MAKE_ENV) $(HOST_SENTRY_CLI_CARGO_ENV) \
-		cargo build $(HOST_SENTRY_CLI_CARGO_OPTS)
-endef
-
-define HOST_SENTRY_CLI_INSTALL_CMDS
-	$(INSTALL) -D -m 0755 $(@D)/target/release/sentry-cli \
-		$(HOST_DIR)/bin/sentry-cli
-endef
-
-$(eval $(host-generic-package))
Signature · 6 lines
2.31.1

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot