Skip to contentSkip to conversation

test/service_cores: fix wrong comment

PATCH Applied Joyce Kong 3 participants 3 messages Aug 19, 2021 – Oct 12, 2021

lore
Share & tools
lore

Joyce Kong

author
#0 lore raw

PATCH 1/1 test/service_cores: fix wrong comment

Change the inaccurate comment of 'set pass flag'
to 'clear pass flag' as the '*pass_test = 0' code
actually implements clearing.

Fixes f038a81e1c56 ("service: add unit tests")
---
 app/test/test_service_cores.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
app/test/test_service_cores.c +1 -1
index ece104054e..8659a1526c 100644
@@ -68,7 +68,7 @@ static int32_t dummy_mt_unsafe_cb(void *args)
 		rte_delay_ms(250);
 		__atomic_store_n(lock, 0, __ATOMIC_RELAXED);
 	} else {
-		/* 2nd thread will fail to take lock, so set pass flag */
+		/* 2nd thread will fail to take lock, so clear pass flag */
 		*pass_test = 0;
 	}
 
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines

-----Original Message-----
From: Joyce Kong <[email protected]>
Sent: Thursday, August 19, 2021 7:11 AM
To: [email protected]; Van Haaren, Harry <[email protected]>; [email protected]; [email protected]
Cc: [email protected]; [email protected]; [email protected]
Subject: [PATCH] test/service_cores: fix wrong comment

Change the inaccurate comment of 'set pass flag' to 'clear pass flag' as the '*pass_test = 0' code actually implements clearing.

Quoted 5 lines
Fixes f038a81e1c56 ("service: add unit tests")
#2 lore raw
Quoted 14 lines · Harry
Quoted 14 lines

-----Original Message-----
From: Joyce Kong <[email protected]>
Sent: Thursday, August 19, 2021 7:11 AM
To: [email protected]; Van Haaren, Harry <[email protected]>; [email protected]; [email protected]
Cc: [email protected]; [email protected]; [email protected]
Subject: [PATCH] test/service_cores: fix wrong comment

Change the inaccurate comment of 'set pass flag' to 'clear pass flag' as the '*pass_test = 0' code actually implements clearing.

Quoted 6 lines
Quoted 5 lines
Fixes f038a81e1c56 ("service: add unit tests")

Applied, thanks.

Signature · 1 line
David Marchand