Skip to contentSkip to conversation

Add RTC for MStar SoCs

PATCH Superseded Romain Perier 2 participants 5 messages Aug 19, 2021 – Aug 23, 2021

Subsystems (3)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Romain Perier

author maintainer
#0 lore raw

v3 cover Add RTC for MStar SoCs

This patches series adds a new driver for the RTC found in the Mstar MSC313e SoCs and newer. It adds a basic rtc driver, the corresponding devicetree bindings and its documentation.

The rtctest (from selftests) has been passed on this driver, with the following output:

$ rtctest 
TAP version 13
1..7
# Starting 7 tests from 2 test cases.
#  RUN           rtc.date_read ...
# rtctest.c:47:date_read:Current RTC date/time is 01/01/1970 00:02:03.
#            OK  rtc.date_read
ok 1 rtc.date_read
#  RUN           rtc.uie_read ...
#            OK  rtc.uie_read
ok 2 rtc.uie_read
#  RUN           rtc.uie_select ...
#            OK  rtc.uie_select
ok 3 rtc.uie_select
#  RUN           rtc.alarm_alm_set ...
# rtctest.c:136:alarm_alm_set:Alarm time now set to 00:02:12.
# rtctest.c:156:alarm_alm_set:data: 1a0
#            OK  rtc.alarm_alm_set
ok 4 rtc.alarm_alm_set
#  RUN           rtc.alarm_wkalm_set ...
# rtctest.c:192:alarm_wkalm_set:Alarm time now set to 01/01/1970 00:02:15.
#            OK  rtc.alarm_wkalm_set
ok 5 rtc.alarm_wkalm_set
#  RUN           rtc.alarm_alm_set_minute ...
# rtctest.c:238:alarm_alm_set_minute:Alarm time now set to 00:03:00.
# rtctest.c:258:alarm_alm_set_minute:data: 1a0
#            OK  rtc.alarm_alm_set_minute
ok 6 [  180.545015] random: fast init done
rtc.alarm_alm_set_minute
#  RUN           rtc.alarm_wkalm_set_minute ...
# rtctest.c:294:alarm_wkalm_set_minute:Alarm time now set to 01/01/1970 00:04:00.
#            OK  rtc.alarm_wkalm_set_minute
ok 7 rtc.alarm_wkalm_set_minute
# PASSED: 7 / 7 tests passed.
# Totals: pass:7 fail:0 xfail:0 xpass:0 skip:0 error:0

Changes since v2:
- Added dual-license header to the dt-bindings documentation
- Reordered dts entries, so the rtc device_node is before the watchdog device_node (because it has a lower address)
- Updated rtc range_max to U32_MAX
- Leave range_min to 0 (default value when it is not set at all)
- Fixed the CNT_EN_BIT logic, so .read_time will only read the time when the RTC has been previously set and has a valid state (which is not the case after a POR).

Changes since v1:
- Fixed the DT bindings documentation and fixed dt_binding_check (an include was missing)
- Added || COMPILE_TEST to kconfig
- Removed rtc_valid_tm from msc313_rtc_read_time()
- Removed the last write of the msc313_rtc_set_time() function (not required) and improved comments
- Replaced the relaxed io by normal io in msc313_rtc_interrupt()
- Added checks to be sure that the alarm fired in msc313_rtc_interrupt()
- Removed msc313_rtc_remove() (replaced by devm_add_action_or_reset)
- Removed unnecessary software reset of the IP in the probe function (the soft reset is never executed, it is a mistake from the initial refactoring)
- Switched to devm_rtc_allocate_device() and devm_rtc_register_device(), and dropped the error message related to the rtc device allocation
- Added an RTC range by setting .range_min and .range_max
- Added the "start-year" property to the DT bindings documentation

Daniel Palmer (1):
rtc: Add support for the MSTAR MSC313 RTC

Romain Perier (2):
dt-bindings: rtc: Add Mstar MSC313e RTC devicetree bindings
documentation
ARM: dts: mstar: Add rtc device node

 .../bindings/rtc/mstar,msc313-rtc.yaml        |  49 ++++
 MAINTAINERS                                   |   1 +
 arch/arm/boot/dts/mstar-v7.dtsi               |   8 +
 drivers/rtc/Kconfig                           |  10 +
 drivers/rtc/Makefile                          |   1 +
 drivers/rtc/rtc-msc313.c                      | 258 ++++++++++++++++++
 6 files changed, 327 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rtc/mstar,msc313-rtc.yaml
 create mode 100644 drivers/rtc/rtc-msc313.c
Signature · 1 line
2.30.2
author maintainer
#1 lore raw

PATCH v3 1/3 dt-bindings: rtc: Add Mstar MSC313e RTC devicetree bindings documentation

This adds the documentation for the devicetree bindings of the Mstar MSC313e RTC driver, found from MSC313e SoCs and newer.

---
 .../bindings/rtc/mstar,msc313-rtc.yaml        | 49 +++++++++++++++++++
 1 file changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rtc/mstar,msc313-rtc.yaml
Documentation/devicetree/bindings/rtc/mstar,msc313-rtc.yaml new file +49 -0
new file mode 100644
index 000000000000..114199cf4d28
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/mstar,msc313-rtc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mstar MSC313e RTC Device Tree Bindings
+
+allOf:
+  - $ref: "rtc.yaml#"
+
+maintainers:
+  - Daniel Palmer <[email protected]>
+  - Romain Perier <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - mstar,msc313-rtc
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  start-year: true
+
+  clocks:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    rtc@2400 {
+        compatible = "mstar,msc313-rtc";
+        reg = <0x2400 0x40>;
+        clocks = <&xtal_div2>;
+        interrupts-extended = <&intc_irq GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+    };
+...
Signature · 1 line
2.30.2
author maintainer
#2 lore raw

PATCH v3 2/3 rtc: Add support for the MSTAR MSC313 RTC

In reply to Romain Perier

From: Daniel Palmer <[email protected]>

This adds support for the RTC block on the Mstar MSC313e SoCs and newer.

---
 MAINTAINERS              |   1 +
 drivers/rtc/Kconfig      |  10 ++
 drivers/rtc/Makefile     |   1 +
 drivers/rtc/rtc-msc313.c | 258 +++++++++++++++++++++++++++++++++++++++
 4 files changed, 270 insertions(+)
 create mode 100644 drivers/rtc/rtc-msc313.c
MAINTAINERS +1 -0
index fd25e4ecf0b9..ebacdd5e8878 100644
@@ -2220,6 +2220,7 @@ F:	arch/arm/boot/dts/mstar-*
 F:	arch/arm/mach-mstar/
 F:	drivers/clk/mstar/
 F:	drivers/gpio/gpio-msc313.c
+F:	drivers/rtc/rtc-msc313.c
 F:	drivers/watchdog/msc313e_wdt.c
 F:	include/dt-bindings/clock/mstar-*
 F:	include/dt-bindings/gpio/msc313-gpio.h
drivers/rtc/Kconfig +10 -0
index 12153d5801ce..9ce4baab5fcf 100644
@@ -1925,4 +1925,14 @@ config RTC_DRV_WILCO_EC
 	  This can also be built as a module. If so, the module will
 	  be named "rtc_wilco_ec".
 
+config RTC_DRV_MSC313
+	tristate "MStar MSC313 RTC"
+        depends on ARCH_MSTARV7 || COMPILE_TEST
+	help
+	  If you say yes here you get support for the Mstar MSC313e On-Chip
+	  Real Time Clock.
+
+	  This driver can also be built as a module, if so, the module
+	  will be called "rtc-msc313".
+
 endif # RTC_CLASS
drivers/rtc/Makefile +1 -0
index 2dd0dd956b0e..5efda8a60cee 100644
@@ -101,6 +101,7 @@ obj-$(CONFIG_RTC_DRV_MCP795)	+= rtc-mcp795.o
 obj-$(CONFIG_RTC_DRV_MESON)	+= rtc-meson.o
 obj-$(CONFIG_RTC_DRV_MOXART)	+= rtc-moxart.o
 obj-$(CONFIG_RTC_DRV_MPC5121)	+= rtc-mpc5121.o
+obj-$(CONFIG_RTC_DRV_MSC313)	+= rtc-msc313.o
 obj-$(CONFIG_RTC_DRV_MSM6242)	+= rtc-msm6242.o
 obj-$(CONFIG_RTC_DRV_MT2712)	+= rtc-mt2712.o
 obj-$(CONFIG_RTC_DRV_MT6397)	+= rtc-mt6397.o
drivers/rtc/rtc-msc313.c new file +258 -0

258 lines not on this page · raw message

Signature · 1 line
2.30.2
#3 lore raw

Re: [PATCH v3 2/3] rtc: Add support for the MSTAR MSC313 RTC

Hi!

2021年8月20日(金) 2:03 Romain Perier <[email protected]>:

Quoted 102 lines

From: Daniel Palmer <[email protected]>

This adds support for the RTC block on the Mstar MSC313e SoCs and newer.

---
 MAINTAINERS              |   1 +
 drivers/rtc/Kconfig      |  10 ++
 drivers/rtc/Makefile     |   1 +
 drivers/rtc/rtc-msc313.c | 258 +++++++++++++++++++++++++++++++++++++++
 4 files changed, 270 insertions(+)
 create mode 100644 drivers/rtc/rtc-msc313.c
MAINTAINERS +1 -0
index fd25e4ecf0b9..ebacdd5e8878 100644
@@ -2220,6 +2220,7 @@ F:        arch/arm/boot/dts/mstar-*
 F:     arch/arm/mach-mstar/
 F:     drivers/clk/mstar/
 F:     drivers/gpio/gpio-msc313.c
+F:     drivers/rtc/rtc-msc313.c
 F:     drivers/watchdog/msc313e_wdt.c
 F:     include/dt-bindings/clock/mstar-*
 F:     include/dt-bindings/gpio/msc313-gpio.h
drivers/rtc/Kconfig +10 -0
index 12153d5801ce..9ce4baab5fcf 100644
@@ -1925,4 +1925,14 @@ config RTC_DRV_WILCO_EC
          This can also be built as a module. If so, the module will
          be named "rtc_wilco_ec".
 
+config RTC_DRV_MSC313
+       tristate "MStar MSC313 RTC"
+        depends on ARCH_MSTARV7 || COMPILE_TEST
+       help
+         If you say yes here you get support for the Mstar MSC313e On-Chip
+         Real Time Clock.
+
+         This driver can also be built as a module, if so, the module
+         will be called "rtc-msc313".
+
 endif # RTC_CLASS
drivers/rtc/Makefile +1 -0
index 2dd0dd956b0e..5efda8a60cee 100644
@@ -101,6 +101,7 @@ obj-$(CONFIG_RTC_DRV_MCP795)        += rtc-mcp795.o
 obj-$(CONFIG_RTC_DRV_MESON)    += rtc-meson.o
 obj-$(CONFIG_RTC_DRV_MOXART)   += rtc-moxart.o
 obj-$(CONFIG_RTC_DRV_MPC5121)  += rtc-mpc5121.o
+obj-$(CONFIG_RTC_DRV_MSC313)   += rtc-msc313.o
 obj-$(CONFIG_RTC_DRV_MSM6242)  += rtc-msm6242.o
 obj-$(CONFIG_RTC_DRV_MT2712)   += rtc-mt2712.o
 obj-$(CONFIG_RTC_DRV_MT6397)   += rtc-mt6397.o
drivers/rtc/rtc-msc313.c new file +37 -0
new file mode 100644
index 000000000000..8cf5d5fb298f
@@ -0,0 +1,258 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Real time clocks driver for MStar/SigmaStar ARMv7 SoCs.
+ * Based on "Real Time Clock driver for msb252x." that was contained
+ * in various MStar kernels.
+ *
+ * (C) 2019 Daniel Palmer
+ * (C) 2021 Romain Perier
+ */
+
+#include <linux/clk.h>
+#include <linux/delay.h>
+#include <linux/module.h>
+#include <linux/mod_devicetable.h>
+#include <linux/platform_device.h>
+#include <linux/rtc.h>
+
+/* Registers */
+#define REG_RTC_CTRL           0x00
+#define REG_RTC_FREQ_CW_L      0x04
+#define REG_RTC_FREQ_CW_H      0x08
+#define REG_RTC_LOAD_VAL_L     0x0C
+#define REG_RTC_LOAD_VAL_H     0x10
+#define REG_RTC_MATCH_VAL_L    0x14
+#define REG_RTC_MATCH_VAL_H    0x18
+#define REG_RTC_STATUS_INT     0x1C
+#define REG_RTC_CNT_VAL_L      0x20
+#define REG_RTC_CNT_VAL_H      0x24
+
+/* Control bits for REG_RTC_CTRL */
+#define SOFT_RSTZ_BIT          BIT(0)
+#define CNT_EN_BIT             BIT(1)
+#define WRAP_EN_BIT            BIT(2)
+#define LOAD_EN_BIT            BIT(3)
+#define READ_EN_BIT            BIT(4)
+#define INT_MASK_BIT           BIT(5)
+#define INT_FORCE_BIT          BIT(6)

drivers/rtc/rtc-msc313.c line 47

Quoted 10 lines
drivers/rtc/rtc-msc313.c new file +10 -0
+#define INT_CLEAR_BIT          BIT(7)
+
+/* Control bits for REG_RTC_STATUS_INT */
+#define RAW_INT_BIT            BIT(0)
+#define ALM_INT_BIT            BIT(1)
+
+struct msc313_rtc {
+       struct rtc_device *rtc_dev;
+       void __iomem *rtc_base;
+       struct clk *clk;

The clk variable is only used in msc313_rtc_probe(). Therefore, it is not necessary to have it in this structure.

Quoted 129 lines
drivers/rtc/rtc-msc313.c new file +129 -0
+};
+
+static int msc313_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm)
+{
+       struct msc313_rtc *priv = dev_get_drvdata(dev);
+       unsigned long seconds;
+
+       seconds = readw(priv->rtc_base + REG_RTC_MATCH_VAL_L)
+                       | (readw(priv->rtc_base + REG_RTC_MATCH_VAL_H) << 16);
+
+       rtc_time64_to_tm(seconds, &alarm->time);
+
+       if (!(readw(priv->rtc_base + REG_RTC_CTRL) & INT_MASK_BIT))
+               alarm->enabled = 1;
+
+       return 0;
+}
+
+static int msc313_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
+{
+       struct msc313_rtc *priv = dev_get_drvdata(dev);
+       u16 reg;
+
+       reg = readw(priv->rtc_base + REG_RTC_CTRL);
+       if (enabled)
+               reg &= ~INT_MASK_BIT;
+       else
+               reg |= INT_MASK_BIT;
+       writew(reg, priv->rtc_base + REG_RTC_CTRL);
+       return 0;
+}
+
+static int msc313_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm)
+{
+       struct msc313_rtc *priv = dev_get_drvdata(dev);
+       unsigned long seconds;
+
+       seconds = rtc_tm_to_time64(&alarm->time);
+       writew((seconds & 0xFFFF), priv->rtc_base + REG_RTC_MATCH_VAL_L);
+       writew((seconds >> 16) & 0xFFFF, priv->rtc_base + REG_RTC_MATCH_VAL_H);
+
+       msc313_rtc_alarm_irq_enable(dev, alarm->enabled);
+
+       return 0;
+}
+
+static bool msc313_rtc_get_enabled(struct msc313_rtc *priv)
+{
+       return readw(priv->rtc_base + REG_RTC_CTRL) & CNT_EN_BIT;
+}
+
+static void msc313_rtc_set_enabled(struct msc313_rtc *priv)
+{
+       u16 reg;
+
+       reg = readw(priv->rtc_base + REG_RTC_CTRL);
+       reg |= CNT_EN_BIT;
+       writew(reg, priv->rtc_base + REG_RTC_CTRL);
+}
+
+static int msc313_rtc_read_time(struct device *dev, struct rtc_time *tm)
+{
+       struct msc313_rtc *priv = dev_get_drvdata(dev);
+       u32 seconds;
+       u16 reg;
+
+       if (!msc313_rtc_get_enabled(priv))
+               return -EINVAL;
+
+       reg = readw(priv->rtc_base + REG_RTC_CTRL);
+       writew(reg | READ_EN_BIT, priv->rtc_base + REG_RTC_CTRL);
+
+       /* Wait for HW latch done */
+       while (readw(priv->rtc_base + REG_RTC_CTRL) & READ_EN_BIT)
+               udelay(1);
+
+       seconds = readw(priv->rtc_base + REG_RTC_CNT_VAL_L)
+                       | (readw(priv->rtc_base + REG_RTC_CNT_VAL_H) << 16);
+
+       rtc_time64_to_tm(seconds, tm);
+
+       return 0;
+}
+
+static int msc313_rtc_set_time(struct device *dev, struct rtc_time *tm)
+{
+       struct msc313_rtc *priv = dev_get_drvdata(dev);
+       unsigned long seconds;
+       u16 reg;
+
+       seconds = rtc_tm_to_time64(tm);
+       writew(seconds & 0xFFFF, priv->rtc_base + REG_RTC_LOAD_VAL_L);
+       writew((seconds >> 16) & 0xFFFF, priv->rtc_base + REG_RTC_LOAD_VAL_H);
+
+       /* Enable load for loading value into internal RTC counter */
+       reg = readw(priv->rtc_base + REG_RTC_CTRL);
+       writew(reg | LOAD_EN_BIT, priv->rtc_base + REG_RTC_CTRL);
+
+       /* Wait for HW latch done */
+       while (readw(priv->rtc_base + REG_RTC_CTRL) & LOAD_EN_BIT)
+               udelay(1);
+       msc313_rtc_set_enabled(priv);
+       return 0;
+}
+
+static const struct rtc_class_ops msc313_rtc_ops = {
+       .read_time = msc313_rtc_read_time,
+       .set_time = msc313_rtc_set_time,
+       .read_alarm = msc313_rtc_read_alarm,
+       .set_alarm = msc313_rtc_set_alarm,
+       .alarm_irq_enable = msc313_rtc_alarm_irq_enable,
+};
+
+static irqreturn_t msc313_rtc_interrupt(s32 irq, void *dev_id)
+{
+       struct msc313_rtc *priv = dev_get_drvdata(dev_id);
+       u16 reg;
+
+       reg = readw(priv->rtc_base + REG_RTC_STATUS_INT);
+       if (!(reg & ALM_INT_BIT))
+               return IRQ_NONE;
+
+       reg = readw(priv->rtc_base + REG_RTC_CTRL);
+       reg |= INT_CLEAR_BIT;
+       reg &= ~INT_FORCE_BIT;
+       writew(reg, priv->rtc_base + REG_RTC_CTRL);
+
+       rtc_update_irq(priv->rtc_dev, 1, RTC_IRQF | RTC_AF);
+

drivers/rtc/rtc-msc313.c line 186

Quoted 10 lines
drivers/rtc/rtc-msc313.c new file +10 -0
+       return IRQ_HANDLED;
+}
+
+static int msc313_rtc_probe(struct platform_device *pdev)
+{
+       struct device *dev = &pdev->dev;
+       struct msc313_rtc *priv;
+       int ret;
+       int irq;
+       unsigned long rate;

Please use reverse christmas tree ordering for local variable.

Quoted 47 lines
drivers/rtc/rtc-msc313.c new file +47 -0
+
+       priv = devm_kzalloc(&pdev->dev, sizeof(struct msc313_rtc), GFP_KERNEL);
+       if (!priv)
+               return -ENOMEM;
+
+       priv->rtc_base = devm_platform_ioremap_resource(pdev, 0);
+       if (IS_ERR(priv->rtc_base))
+               return PTR_ERR(priv->rtc_base);
+
+       irq = platform_get_irq(pdev, 0);
+       if (irq < 0)
+               return -EINVAL;
+
+       priv->rtc_dev = devm_rtc_allocate_device(dev);
+       if (IS_ERR(priv->rtc_dev))
+               return PTR_ERR(priv->rtc_dev);
+
+       priv->rtc_dev->ops = &msc313_rtc_ops;
+       priv->rtc_dev->range_max = U32_MAX;
+
+       ret = devm_request_irq(dev, irq, msc313_rtc_interrupt, IRQF_SHARED,
+                              dev_name(&pdev->dev), &pdev->dev);
+       if (ret) {
+               dev_err(dev, "Could not request IRQ\n");
+               return ret;
+       }
+
+       priv->clk = devm_clk_get(dev, NULL);
+       if (IS_ERR(priv->clk)) {
+               dev_err(dev, "No input reference clock\n");
+               return PTR_ERR(priv->clk);
+       }
+
+       ret = clk_prepare_enable(priv->clk);
+       if (ret) {
+               dev_err(dev, "Failed to enable the reference clock, %d\n", ret);
+               return ret;
+       }
+
+       ret = devm_add_action_or_reset(dev, (void (*) (void *))clk_disable_unprepare, priv->clk);
+       if (ret)
+               return ret;
+
+       rate = clk_get_rate(priv->clk);
+       writew(rate & 0xFFFF, priv->rtc_base + REG_RTC_FREQ_CW_L);
+       writew((rate >> 16) & 0xFFFF, priv->rtc_base + REG_RTC_FREQ_CW_H);
+

drivers/rtc/rtc-msc313.c line 243

Quoted 10 lines
drivers/rtc/rtc-msc313.c new file +10 -0
+       platform_set_drvdata(pdev, priv);
+
+       return devm_rtc_register_device(priv->rtc_dev);
+}
+
+static const struct of_device_id msc313_rtc_of_match_table[] = {
+       { .compatible = "mstar,msc313-rtc" },
+       { }
+};
+MODULE_DEVICE_TABLE(of, ms_rtc_of_match_table);

msc313_rtc_of_match_table ?

Quoted 16 lines
drivers/rtc/rtc-msc313.c new file +15 -1
+
+static struct platform_driver msc313_rtc_driver = {
+       .probe = msc313_rtc_probe,
+       .driver = {
+               .name = "msc313-rtc",
+               .of_match_table = msc313_rtc_of_match_table,
+       },
+};
+
+module_platform_driver(msc313_rtc_driver);
+
+MODULE_AUTHOR("Daniel Palmer <[email protected]>");
+MODULE_AUTHOR("Romain Perier <[email protected]>");
+MODULE_DESCRIPTION("MStar RTC Driver");
+MODULE_LICENSE("GPL v2");
--
Quoted 2 lines

2.30.2

Best regards,
Nobuhiro

Signature · 3 lines
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org / kernel.org}
   GPG ID: 40AD1FA6
author maintainer
#4 lore raw

PATCH v3 3/3 ARM: dts: mstar: Add rtc device node

In reply to Romain Perier

This adds the definition of the rtc device node. The RTC being able to work with the oscillator at 12Mhz for now, it shares the same xtal than the watchdog.

---
 arch/arm/boot/dts/mstar-v7.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/mstar-v7.dtsi +8 -0
index 982dba9d28eb..89ebfe4f29da 100644
@@ -110,12 +110,20 @@ reboot {
 				mask = <0x79>;
 			};
 
+			rtc@2400 {
+				compatible = "mstar,msc313-rtc";
+				reg = <0x2400 0x40>;
+				clocks = <&xtal_div2>;
+				interrupts-extended = <&intc_irq GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+			};
+
 			watchdog@6000 {
 				compatible = "mstar,msc313e-wdt";
 				reg = <0x6000 0x1f>;
 				clocks = <&xtal_div2>;
 			};
 
+
 			intc_fiq: interrupt-controller@201310 {
 				compatible = "mstar,mst-intc";
 				reg = <0x201310 0x40>;
Signature · 1 line
2.30.2