Skip to contentSkip to conversation

kselftest/arm64: mte: Fix misleading output when skipping tests

PATCH In review Mark Brown 2 participants 2 messages Aug 19, 2021 – Aug 20, 2021

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 kselftest/arm64: mte: Fix misleading output when skipping tests

When skipping the tests due to a lack of system support for MTE we currently print a message saying FAIL which makes it look like the test failed even though the test did actually report KSFT_SKIP, creating some confusion. Change the error message to say SKIP instead so things are clearer.

---
 tools/testing/selftests/arm64/mte/mte_common_util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/arm64/mte/mte_common_util.c +1 -1
index f50ac31920d1..0328a1e08f65 100644
@@ -298,7 +298,7 @@ int mte_default_setup(void)
 	int ret;
 
 	if (!(hwcaps2 & HWCAP2_MTE)) {
-		ksft_print_msg("FAIL: MTE features unavailable\n");
+		ksft_print_msg("SKIP: MTE features unavailable\n");
 		return KSFT_SKIP;
 	}
 	/* Get current mte mode */
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 5 lines · Mark Brown

When skipping the tests due to a lack of system support for MTE we currently print a message saying FAIL which makes it look like the test failed even though the test did actually report KSFT_SKIP, creating some confusion. Change the error message to say SKIP instead so things are clearer.

Applied to arm64 (for-next/kselftest), thanks!

[1/1] kselftest/arm64: mte: Fix misleading output when skipping tests

      https://git.kernel.org/arm64/c/83e5dcbece4e
Signature · 1 line
Catalin