Skip to contentSkip to conversation

package/kvm-unit-tests: disable SSP

PATCH In review Matthew Weber via buildroot 3 participants 3 messages Aug 20, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/kvm-unit-tests: disable SSP

kvm-unit-tests shouldn't use stack-protector as the test suite is building free standing binaries to test QEMU. There is no guarantee that GCC has set a spec to filter out stack protector enabling with -ffreestanding so disabling explicitly to prevent a series of build failures.

Fixes:
http://autobuild.buildroot.net/results/780/780c8c70ea7015113714cbd3841d96b08bd2f2aa/

---
 package/kvm-unit-tests/kvm-unit-tests.mk | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
package/kvm-unit-tests/kvm-unit-tests.mk +6 -7
index 2637066701..23241b453a 100644
@@ -35,15 +35,14 @@ KVM_UNIT_TESTS_CONF_OPTS =\
 # compiler. However, for x86-64, we use the host compiler, as
 # kvm-unit-tests builds 32 bit code, which Buildroot toolchains for
 # x86-64 cannot do.
-ifeq ($(BR2_x86_64),y)
-# Arch Linux adds -fstack-protector even when building with -ffreestanding, but
-# it doesn't link with the stack-protector library when -nostdlib is passed,
-# which leads to a link error. Therefore, disable it explicitly to work around
-# this bug in Arch Linux. https://bugs.archlinux.org/task/64270
-KVM_UNIT_TESTS_MAKE_OPTS += EXTRA_CFLAGS=-fno-stack-protector
-else
+ifneq ($(BR2_x86_64),y)
 KVM_UNIT_TESTS_CONF_OPTS += --cross-prefix="$(TARGET_CROSS)"
 endif
+# kvm-unit-tests shouldn't use stack-protector as the test suite is building
+# free standing binaries to test QEMU. There is no guarantee that GCC has
+# set a spec to filter out stack protector enabling with -ffreestanding so
+# disabling explicitly to prevent a series of build failures.
+KVM_UNIT_TESTS_MAKE_OPTS += EXTRA_CFLAGS=-fno-stack-protector
 
 define KVM_UNIT_TESTS_CONFIGURE_CMDS
 	cd $(@D) && ./configure $(KVM_UNIT_TESTS_CONF_OPTS)
Signature · 6 lines
2.17.1

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
#1 lore raw

Hello Matt,

Quoted 6 lines · On Fri, 20 Aug 2021 08:32:32 -0500 Matthew Weber via buildroot…

kvm-unit-tests shouldn't use stack-protector as the test suite is building free standing binaries to test QEMU. There is no guarantee that GCC has set a spec to filter out stack protector enabling with -ffreestanding so disabling explicitly to prevent a series of build failures.

Quoted 7 lines

Fixes:
http://autobuild.buildroot.net/results/780/780c8c70ea7015113714cbd3841d96b08bd2f2aa/

---
 package/kvm-unit-tests/kvm-unit-tests.mk | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

Thanks, but your patch doesn't apply to the master branch, and it makes me think we're piling up work-arounds on work-arounds.

Indeed, the passing of -fno-stack-protector in EXTRA_CFLAGS has been removed in master as of commit d183146b5c7a1a8d1a3c828bd3b6d0660d97efc0, which itself says it is no longer needed since commit 0788e921f961e36a50a94f8bb98f7eb75b312245.

However, it seems like despite 0788e921f961e36a50a94f8bb98f7eb75b312245, SSP is still being used.

Matt, Fabrice, could you review the situation and see what is the correct fix moving forward ?

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
#2 lore raw

Hello,

Quoted 28 lines · Thomas Petazzoni

Hello Matt,

Quoted 6 lines · On Fri, 20 Aug 2021 08:32:32 -0500 Matthew Weber via buildroot…

kvm-unit-tests shouldn't use stack-protector as the test suite is building free standing binaries to test QEMU. There is no guarantee that GCC has set a spec to filter out stack protector enabling with -ffreestanding so disabling explicitly to prevent a series of build failures.

Quoted 7 lines

Fixes:
http://autobuild.buildroot.net/results/780/780c8c70ea7015113714cbd3841d96b08bd2f2aa/

---
 package/kvm-unit-tests/kvm-unit-tests.mk | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

Thanks, but your patch doesn't apply to the master branch, and it makes me think we're piling up work-arounds on work-arounds.

Indeed, the passing of -fno-stack-protector in EXTRA_CFLAGS has been removed in master as of commit d183146b5c7a1a8d1a3c828bd3b6d0660d97efc0, which itself says it is no longer needed since commit 0788e921f961e36a50a94f8bb98f7eb75b312245.

Quoted 5 lines

However, it seems like despite 0788e921f961e36a50a94f8bb98f7eb75b312245, SSP is still being used.

Matt, Fabrice, could you review the situation and see what is the correct fix moving forward ?

The link on the autobuilder failure is from February 2020 and I'm not able to find a build failure due to SSP in the latest days so I assume that this patch is not needed.

Quoted 8 lines

Thanks!

Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot