grpc: remove nl2 requirement since it is optional
PATCH 1/1 grpc: remove nl2 requirement since it is optional
--- .../openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend | 3 +++ 1 file changed, 3 insertions(+)
dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend +3 -0
@@ -1,2 +1,5 @@ +# doesn't build and not required +DEPENDS:remove:mingw32 = "libnsl2" + EXTRA_OECMAKE:remove:mingw32 = "-DBUILD_SHARED_LIBS=ON" EXTRA_OECMAKE:append:mingw32 = " -DBUILD_SHARED_LIBS=OFF"
Signature · 1 line
2.17.1
Quoted 10 lines · Sinan Kaya
Signed-off-by Sinan Kaya <[email protected]>--- .../openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend | 3 +++ 1 file changed, 3 insertions(+)dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend +0
-0
dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend line 5
Quoted 5 lines
dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend +3
-0@@ -1,2 +1,5 @@ +# doesn't build and not required +DEPENDS:remove:mingw32 = "libnsl2" + EXTRA_OECMAKE:remove:mingw32 = "-DBUILD_SHARED_LIBS=ON" EXTRA_OECMAKE:append:mingw32 = " -DBUILD_SHARED_LIBS=OFF"
Should we be making that a PACKAGECONFIG which mingw32 could change?
Cheers,
Richard
Quoted 14 lines · Richard Purdie
Quoted 6 lines · Sinan Kaya
Signed-off-by Sinan Kaya <[email protected]>--- .../openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend | 3 +++ 1 file changed, 3 insertions(+)diff --git
a/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend b/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
Quoted 2 lines
index a72496d..dc0ea42 100644
---a/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
Quoted 1 line
+++
b/dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend
Quoted 9 lines
dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend line 5
Quoted 6 lines
dynamic-layers/openembedded-layers/recipes-devtools/grpc/grpc_%.bbappend +3
-0@@ -1,2 +1,5 @@ +# doesn't build and not required +DEPENDS:remove:mingw32 = "libnsl2" + EXTRA_OECMAKE:remove:mingw32 = "-DBUILD_SHARED_LIBS=ON" EXTRA_OECMAKE:append:mingw32 = " -DBUILD_SHARED_LIBS=OFF"Should we be making that a PACKAGECONFIG which mingw32 could change?
Yes, that's a good idea. Sinan, please make that change in meta-oe, then change this patch to remove it from PACKAGECONFIG
Quoted 5 lines
Cheers,
Richard
Quoted 9 lines · Joshua Watt
Quoted 2 lines
EXTRA_OECMAKE:remove:mingw32 = "-DBUILD_SHARED_LIBS=ON" EXTRA_OECMAKE:append:mingw32 = " -DBUILD_SHARED_LIBS=OFF"
Should we be making that a PACKAGECONFIG which mingw32 could change?
Yes, that's a good idea. Sinan, please make that change in meta-oe, then change this patch to remove it from PACKAGECONFIG
Patch sent with subject: [meta-oe][PATCH] grpc: make SHARED library build optional
I will wait until it gets merged to follow up here.