staging: r8188eu: Fix a resource leak in update_bcn_wps_ie
PATCH 1/1 staging: r8188eu: Fix a resource leak in update_bcn_wps_ie
The "pbackup_remainder_ie" variable is not freed when "pwps_ie_src" is null
Fixes 15865124feed ("staging: r8188eu: introduce new core dir for RTL8188eu driver")
Signed-off-by Xiangyang Zhang <[email protected]>
--- drivers/staging/r8188eu/core/rtw_ap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/r8188eu/core/rtw_ap.c +2 -1
@@ -1300,7 +1300,7 @@ static void update_bcn_wps_ie(struct adapter *padapter) pwps_ie_src = pmlmepriv->wps_beacon_ie;if (!pwps_ie_src) -return ; + goto exit; wps_ielen = (uint )pwps_ie_src[1 ];/* to get ie data len */ if ((wps_offset + wps_ielen +2 + remainder_ielen) <=MAX_IE_SZ ) {
@@ -1314,6 +1314,7 @@ static void update_bcn_wps_ie(struct adapter *padapter) pnetwork->IELength = wps_offset + (wps_ielen +2 ) + remainder_ielen; } +exit:kfree (pbackup_remainder_ie); }
Signature · 1 line
2.19.1
Quoted 23 lines · Xiangyang Zhang
The "
pbackup_remainder_ie" variable is not freed when "pwps_ie_src" is nullFixes 15865124feed ("staging: r8188eu: introduce new core dir for RTL8188eu driver")Signed-off-by Xiangyang Zhang <[email protected]>--- drivers/staging/r8188eu/core/rtw_ap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/r8188eu/core/rtw_ap.c +1
-1@@ -1300,7 +1300,7 @@ static void update_bcn_wps_ie(struct adapter *padapter) pwps_ie_src = pmlmepriv->wps_beacon_ie;if (!pwps_ie_src) -return ; + goto exit; wps_ielen = (uint )pwps_ie_src[1 ];/* to get ie data len */ if ((wps_offset + wps_ielen +2 + remainder_ielen) <=MAX_IE_SZ ) {
drivers/staging/r8188eu/core/rtw_ap.c static void update_bcn_wps_ie(struct adapter *padapter) · line 1320
Quoted 7 lines
drivers/staging/r8188eu/core/rtw_ap.c +1
-0@@ -1314,6 +1314,7 @@ static void update_bcn_wps_ie(struct adapter *padapter) pnetwork->IELength = wps_offset + (wps_ielen +2 ) + remainder_ielen; } +exit:kfree (pbackup_remainder_ie); }
Looks good to me.
Acked-by Michael Straube <[email protected]>
Thanks,
Michael