gpu: drm: amd: amdgpu: Fixed a few warnings
Subsystems (2)
PATCH 1/1 gpu: drm: amd: amdgpu: Fixed a few warnings
Fixed warnings regarding SPDX license, using "unsigned" instead of "unsigned int", wrong function parameter name for the documentation and a space between the function name and "(".
Signed-off-by Liviu Cheru <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +5 -4
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * Copyright 2009 Jerome Glisse. * All Rights Reserved.
@@ -129,7 +130,7 @@ void amdgpu_bo_placement_from_domain(struct amdgpu_bo *abo, u32 domain)u32 c =0 ;if (domain &AMDGPU_GEM_DOMAIN_VRAM ) { -unsigned visible_pfn = adev->gmc.visible_vram_size >>PAGE_SHIFT ; +unsigned int visible_pfn = adev->gmc.visible_vram_size >>PAGE_SHIFT ; places[c].fpfn =0 ; places[c].lpfn =0 ;
@@ -731,7 +732,7 @@ int amdgpu_bo_validate(struct amdgpu_bo *bo)/** * amdgpu_bo_add_to_shadow_list - add a BO to the shadow list * -* @bo: BO that will be inserted into the shadow list +* @vmbo: BO that will be inserted into the shadow list * * Insert a BO to the shadow list. */
@@ -957,7 +958,7 @@ int amdgpu_bo_pin_restricted(struct amdgpu_bo *bo, u32 domain, bo->flags |=AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED ;amdgpu_bo_placement_from_domain (bo, domain);for (i =0 ; i < bo->placement.num_placement; i++) { -unsigned fpfn, lpfn; +unsigned int fpfn, lpfn; fpfn = min_offset >>PAGE_SHIFT ; lpfn = max_offset >>PAGE_SHIFT ;
@@ -1175,7 +1176,7 @@ void amdgpu_bo_get_tiling_flags(struct amdgpu_bo *bo, u64 *tiling_flags)* Returns: * 0 for success or a negative error code on failure. */ -int amdgpu_bo_set_metadata (struct amdgpu_bo *bo,void *metadata, +int amdgpu_bo_set_metadata (struct amdgpu_bo *bo,void *metadata,uint32_t metadata_size,uint64_t flags) {struct amdgpu_bo_user *ubo;
Signature · 1 line
2.30.2
Quoted 5 lines · Liviu Cheru
Fixed warnings regarding SPDX license, using "unsigned" instead of "unsigned int", wrong function parameter name for the documentation and a space between the function name and "(".
In general, please split these up by the type of change.
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c line 1
Quoted 11 lines
Signed-off-by Liviu Cheru <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +1
-0@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later
The license is MIT not GPL. See the actual license on the file.
Quoted 13 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +1
-1/* * Copyright 2009 Jerome Glisse. * All Rights Reserved. @@ -129,7 +130,7 @@ void amdgpu_bo_placement_from_domain(struct amdgpu_bo *abo, u32 domain)u32 c =0 ;if (domain &AMDGPU_GEM_DOMAIN_VRAM ) { -unsigned visible_pfn = adev->gmc.visible_vram_size >>PAGE_SHIFT ; +unsigned int visible_pfn = adev->gmc.visible_vram_size >>PAGE_SHIFT ; places[c].fpfn =0 ; places[c].lpfn =0 ;
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c int amdgpu_bo_validate(struct amdgpu_bo *bo) · line 738
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +1
-1@@ -731,7 +732,7 @@ int amdgpu_bo_validate(struct amdgpu_bo *bo)/** * amdgpu_bo_add_to_shadow_list - add a BO to the shadow list * -* @bo: BO that will be inserted into the shadow list +* @vmbo: BO that will be inserted into the shadow list * * Insert a BO to the shadow list. */
This code has already been fixed.
Quoted 21 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +2
-3@@ -957,7 +958,7 @@ int amdgpu_bo_pin_restricted(struct amdgpu_bo *bo, u32 domain, bo->flags |=AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED ;amdgpu_bo_placement_from_domain (bo, domain);for (i =0 ; i < bo->placement.num_placement; i++) { -unsigned fpfn, lpfn; +unsigned int fpfn, lpfn; fpfn = min_offset >>PAGE_SHIFT ; lpfn = max_offset >>PAGE_SHIFT ;@@ -1175,7 +1176,7 @@ void amdgpu_bo_get_tiling_flags(struct amdgpu_bo *bo, u64 *tiling_flags)* Returns: * 0 for success or a negative error code on failure. */ -int amdgpu_bo_set_metadata (struct amdgpu_bo *bo,void *metadata, +int amdgpu_bo_set_metadata (struct amdgpu_bo *bo,void *metadata,uint32_t metadata_size,uint64_t flags) {struct amdgpu_bo_user *ubo; --2.30.2