Skip to contentSkip to conversation

Usb: Storage: usb: Changed function parameter name and removed braces

PATCH In review Niklas Lantau 2 participants 2 messages Aug 21, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Usb: Storage: usb: Changed function parameter name and removed braces

Changed parameter name from __us to much more typical data after suggestion by Joe Perches. Fixed minor coding style issue as well.

---
 drivers/usb/storage/usb.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/usb/storage/usb.c +3 -4
index 90aa9c12ffac..075c4531b96d 100644
@@ -295,9 +295,9 @@ void fill_inquiry_response(struct us_data *us, unsigned char *data,
 }
 EXPORT_SYMBOL_GPL(fill_inquiry_response);
 
-static int usb_stor_control_thread(void * __us)
+static int usb_stor_control_thread(void *data)
 {
-	struct us_data *us = (struct us_data *)__us;
+	struct us_data *us = data;
 	struct Scsi_Host *host = us_to_host(us);
 	struct scsi_cmnd *srb;
 
@@ -926,9 +926,8 @@ static unsigned int usb_stor_sg_tablesize(struct usb_interface *intf)
 {
 	struct usb_device *usb_dev = interface_to_usbdev(intf);
 
-	if (usb_dev->bus->sg_tablesize) {
+	if (usb_dev->bus->sg_tablesize)
 		return usb_dev->bus->sg_tablesize;
-	}
 	return SG_ALL;
 }
 
Signature · 1 line
2.33.0
maintainer
#1 lore raw
Quoted 2 lines · Niklas Lantau

Changed parameter name from __us to much more typical data after suggestion by Joe Perches. Fixed minor coding style issue as well.

Do not do multiple things in the same patch, this should be multiple patches.

thanks,

greg k-h