rtw88: 8822ce: set CLKREQ# signal to low during suspend
Ping-Ke Shih
maintainerPATCH 1/1 rtw88: 8822ce: set CLKREQ# signal to low during suspend
From: Chin-Yen Lee <[email protected]>
We find the power sequence of system suspend flow don't meet the criteria when using 8822CE-VR chip by rfe-type 6, because the reference clock form host is sometimes late. To avoid the behavoir, we keep CLKREQ# signal to low during suspend to make sure the reference clock arrival in time.
--- drivers/net/wireless/realtek/rtw88/pci.c | 33 ++++++++++++++++++++++++ drivers/net/wireless/realtek/rtw88/pci.h | 1 + 2 files changed, 34 insertions(+)
drivers/net/wireless/realtek/rtw88/pci.c +33 -0
@@ -1359,6 +1359,25 @@ static void rtw_pci_clkreq_set(struct rtw_dev *rtwdev, bool enable)rtw_dbi_write8 (rtwdev,RTK_PCIE_LINK_CFG , value); } +static void rtw_pci_clkreq_pad_low (struct rtw_dev *rtwdev,bool enable) +{ +u8 value; +int ret; + + ret =rtw_dbi_read8 (rtwdev,RTK_PCIE_LINK_CFG , &value); +if (ret) { +rtw_err (rtwdev,"failed to read CLKREQ_L1, ret=%d" , ret); +return ; + } + +if (enable) + value &= ~BIT_CLKREQ_N_PAD ; +else + value |=BIT_CLKREQ_N_PAD ; + +rtw_dbi_write8 (rtwdev,RTK_PCIE_LINK_CFG , value); +} +static void rtw_pci_aspm_set (struct rtw_dev *rtwdev,bool enable) {u8 value;
@@ -1500,11 +1519,25 @@ static void rtw_pci_phy_cfg(struct rtw_dev *rtwdev)static int __maybe_unused rtw_pci_suspend (struct device *dev) { +struct ieee80211_hw *hw =dev_get_drvdata (dev); +struct rtw_dev *rtwdev = hw->priv; +struct rtw_chip_info *chip = rtwdev->chip; +struct rtw_efuse *efuse = &rtwdev->efuse; + +if (chip->id ==RTW_CHIP_TYPE_8822C && efuse->rfe_option ==6 ) +rtw_pci_clkreq_pad_low (rtwdev, true);return 0 ; }static int __maybe_unused rtw_pci_resume (struct device *dev) { +struct ieee80211_hw *hw =dev_get_drvdata (dev); +struct rtw_dev *rtwdev = hw->priv; +struct rtw_chip_info *chip = rtwdev->chip; +struct rtw_efuse *efuse = &rtwdev->efuse; + +if (chip->id ==RTW_CHIP_TYPE_8822C && efuse->rfe_option ==6 ) +rtw_pci_clkreq_pad_low (rtwdev, false);return 0 ; }
drivers/net/wireless/realtek/rtw88/pci.h +1 -0
@@ -37,6 +37,7 @@#define RTK_PCIE_LINK_CFG 0x0719#define BIT_CLKREQ_SW_EN BIT(4)#define BIT_L1_SW_EN BIT(3) +#define BIT_CLKREQ_N_PAD BIT(0)#define RTK_PCIE_CLKDLY_CTRL 0x0725#define BIT_PCI_BCNQ_FLAG BIT(4)
Signature · 1 line
2.25.1
Quoted 10 lines · Ping-Ke Shih
From: Chin-Yen Lee <[email protected]>
We find the power sequence of system suspend flow don't meet the criteria when using 8822CE-VR chip by rfe-type 6, because the reference clock form host is sometimes late. To avoid the behavoir, we keep CLKREQ# signal to low during suspend to make sure the reference clock arrival in time.
Signed-off-by Chin-Yen Lee <[email protected]>Signed-off-by Ping-Ke Shih <[email protected]>
Patch applied to wireless-drivers-next.git, thanks.
8d52b46caf68 rtw88: 8822ce: set CLKREQ# signal to low during suspend
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches